26946 Commits (98d089fb9a0a52baf6fa07c723bb74c4dd9a116c)

 

All Branches   

Search

Author	SHA1	Message	Date
Matt Jordan	12809721d1	Merge "Remove unneeded uses of optional_api providers."	11 years ago
Matt Jordan	4aed0ff631	Merge "Update configure.ac/Makefile for clang"	11 years ago
Corey Farrell	981084f08c	Format Interfaces: Prevent unload except by shutdown. ... Format interfaces cannot be unregistered, so the modules that provide them need to be held open except by shutdown. ASTERISK-25054 #close Reported by: Corey Farrell Change-Id: Iadbd9675bf0d30b8fded5a739b163db3ea2db8f3	11 years ago
Matt Jordan	75c0aa6979	contrib/ast-db-manage: Add Postgres ENUM type support in auto DTMF mode update ... The upgrade script for auto DTMF mode (31cd4f4891ec) added in 88b0fa7755 failed to add ENUM support for Postgres databases. This requires a specific import from the sqlalchemy.dialects.postgresql package. This patch corrects this error, which allows for Postgres update scripts to be generated. ASTERISK-24706 Change-Id: I4742ac8efa533cd6f18e0bdd907b339a9aedf015	11 years ago
Corey Farrell	1368dae773	main/presencestate.c: Add trailing slash to test category. ... ASTERISK-25053 Reported by: Corey Farrell Change-Id: I8c0375dd0818747b2d2e1ceaea87bfbeb2daf8d4	11 years ago
Joshua Colp	ddf9dcaad7	Merge "cdr/cdr_csv.c: Add a new option to enable columns added in Asterisk 1.8"	11 years ago
Matt Jordan	25b67ed6ca	Merge "term: send proper reset sequence when black background is forced"	11 years ago
Diederik de Groot	305ce3defd	Update configure.ac/Makefile for clang ... Created autoconf/ast_check_raii.m4: contains AST_CHECK_RAII which checks compiler requirements for RAII: gcc: -fnested-functions support clang: -fblocks (and if required -lBlocksRuntime) The original check was implemented in configure.ac and now has it's own file. This function also sets C_COMPILER_FAMILY to either gcc or clang for use by makefile Created autoconf/ast_check_strsep_array_bounds.m4 (contains AST_CHECK_STRSEP_ARRAY_BOUNDS): which checks if clang is able to handle the optimized strsep & strcmp functions (linux). If not, the standard libc implementation should be used instead. Clang + the optimized macro's work with: strsep(char *, char []), but not with strsepo(char *, char *). Instead of replacing all the occurences throughout the source code, not using the optimized macro version seemed easier See 'define __strcmp_gc(s1, s2, l2) in bits/string2.h': llvm-comment: Normally, this array-bounds warning are suppressed for macros, so that unused paths like the one that accesses __s1[3] are not warned about. But if you preprocess manually, and feed the result to another instance of clang, it will warn about all the possible forks of this particular if statement. Instead of switching of this optimization, another solution would be to run the preproces- sing step with -frewrite-includes, which should preserve enough information so that clang should still be able to suppress the diag- nostic at the compile step later on. See also "https://llvm.org/bugs/show_bug.cgi?id=20144" See also "https://llvm.org/bugs/show_bug.cgi?id=11536" Makefile.rules: If C_COMPILER_FAMILY=clang then add two warning suppressions: -Wno-unused-value -Wno-parentheses-equality In an earlier review (reviewboard: 4550 and 4554), they were deemed a nuisace and less than benefitial. configure.ac: Added AST_CHECK_RAII() see earlier Added AST_CHECK_STRSEP_ARRAY_BOUNDS() see earlier Removed moved content ASTERISK-24917 Change-Id: I12ea29d3bda2254ad3908e279b7effbbac6a97cb	11 years ago
Rodrigo Ramírez Norambuena	8886b724ae	cdr/cdr_csv.c: Add a new option to enable columns added in Asterisk 1.8 ... This patch adds a new option to cdr.conf, 'newcdrcolumns', that will handle CDR columns added in Asterisk 1.8. The columns are: * peeraccount * linkedid * sequence When enabled, the columns in the database entry will be populated with the data from the CDR. ASTERISK-24976 #close Change-Id: I51a57063f4ae5e194a9d933a8df45dc8a4534f0b	11 years ago
Matt Jordan	8e1b747284	Merge "res_pjsip_dlg_options: Fix MODULEINFO section."	11 years ago
Rodrigo Ramírez Norambuena	94532b2c22	main/asterisk.c: Update Asterisk copyright year ... Change-Id: I5e75d7f7e2c096d74edd9e8735268a894f4b93ab	11 years ago
Rodrigo Ramírez Norambuena	2ed5e6a9ba	utils: Remove trailing whitespace ... Change-Id: I4644f43a6a1ca9b5130cd2a6746772b888eb4f7a	11 years ago
Corey Farrell	c3ec5da156	Remove unneeded uses of optional_api providers. ... A few cases exist where headers of optional_api provders are included but not needed. This causes unneeded calls to ast_optional_api_use. * Don't include optional_api.h from sip_api.h. * Move 'struct ast_channel_monitor' to channel.h. * Don't include monitor.h from chan_sip.c, channel.c or features.c. The move of struct ast_channel_monitor is needed since channel.c depends on it. This has no effect on users of monitor.h since channel.h is included from monitor.h. ASTERISK-25051 #close Reported by: Corey Farrell Change-Id: I53ea65a9fc9693c89f8bcfd6120649bfcfbc3478	11 years ago
Matt Jordan	2be861173a	Merge "include/asterisk/channel.h: Fix typo"	11 years ago
Matt Jordan	32eb00b70a	Merge "Astobj2: Fix initialization order of refdebug and AO2_DEBUG."	11 years ago
Corey Farrell	44bbdbe3a4	res_pjsip_dlg_options: Fix MODULEINFO section. ... Removed the extra space before "MODULEINFO" in res_pjsip_dlg_options. This extra space prevented any of the dependencies from being seen by menuselect, so building with default options would fail if PJSIP was not installed. This also makes the tool that extracts information for menuselect tolerant of multiple spaces in the future. ASTERISK-25033 #close Reported by: Peter Whisker Change-Id: Iccd54846f70c4a7a50cb5bf70b7bb5cb4bab3698	11 years ago
D Tucny	e4f0a55f7f	term: send proper reset sequence when black background is forced ... When using the force black background command-line option or configuration option an invalid reset sequence is sent following a coloured output item in the CLI, the result is that the colour is not 'turned off' and continues until the next non-default coloured text output. A reset sequence is already defined in term.c, but the ast_term_reset function doesn't use it, instead building it's own invalid sequence and returning that. This patch changes that behaviour, removing the building of a reset sequence and instead using the pre-built constant 'enddata' which is a suitable reset sequence for this purpose. ASTERISK-24896 #close Reported by: Dan Tucny Change-Id: I56323899123ae3264900389cae1f5b252aa3bf43	11 years ago
Corey Farrell	8f3cee1258	Astobj2: Fix initialization order of refdebug and AO2_DEBUG. ... This ensures that refdebug is initialized before AO2_DEBUG if both are enabled, since AO2_DEBUG allocates a container. This change also makes AO2_DEBUG initialization critical, a failure will abort Asterisk startup. This is needed since the failure would be caused by reg_containers allocation failure, and that would result in a segmentation fault by ao2_container_register later in startup. ASTERISK-25048 #close Reported by: Corey Farrell Change-Id: I9a243ea3fc5653b48b931ba6d61971cb2e530244	11 years ago
Matt Jordan	7ac28be04b	main/pbx: Improve performance of dialplan reloads with a large number of hints ... The PBX core maintains two hash tables for hints: a container of the actual hints (hints), along with a container of devices that are watching that hint (hintdevices). When a dialplan reload occurs, each hint in the hints container is destroyed; this requires a lookup in the container of devices to find the device => hint mapping object. In the current code, this performs an ao2_callback, iterating over each of the device to hint objects in the hintdevices container. For a large number of hints, this is extremely expensive: dialplan reloads with 20000 hints could take several minutes in just this phase. This patch improves the performance of this step in the dialplan reloads by caching which devices are watching a hint on the hint object itself. Since we don't want to create a circular reference, we just cache the name of the device. This allows us to perform a smarter ao2_callback on the hintdevices container during hint removal, hashing on the name of the device and returning an iterator to the matching names. The overall performance improvement is rather large, taking this step down to a number of seconds as opposed to minutes. In addition, this patch also registers the hint containers in the PBX core with the astobj2 library. This allows for reasonable debugging to hash collisions in those containers. ASTERISK-25040 #close Reported by: Matt Jordan Change-Id: Iedfc97a69d21070c50fca42275d7b3e714e59360	11 years ago
Matt Jordan	01f3d5b7d4	Merge "Prevent potential crash on blond transfer."	11 years ago
Corey Farrell	6b208d8c3b	Sample Configs: Fix syntax error in pjsip.conf ... The sample pjsip.conf has a few comment lines that are missing the semicolons at the start of the comment, causing the config to fail load. Change-Id: I776a38c916a7df7ee3e072fd0b21dbf4cc457352	11 years ago
Joshua Colp	22d9ac0a10	Merge "Build System: Fix issue with addons moduleinfo."	11 years ago
Mark Michelson	dc23204aca	Prevent potential crash on blond transfer. ... Scenario: Alice calls Bob. Bob performs a blond transfer to Carol. Carol rejects the incoming call (or some other immediate circumstance causes Carol not to answer the call) What occurs in this case is that when the bridge between Alice and Bob breaks, Alice is told to masquerade into Bob's channel that had placed the call to Carol. The actual masquerade goes down without a hitch. However, a channel fixup callback that attempts to publish dial events over Stasis has a crash. The reason for this crash is that the datastore on Bob's channel that placed the outbound call to Carol only had a bare pointer to Carol's channel. Since Carol rejected the incoming call, Carol's channel has been hung up and freed, meaning accessing her channel results in a crash. The fix here is simple. The dial fixup code has been altered to hold references to the involved channels and to drop those references when freeing data. ASTERISK-25025 #close Reported by Chet Stevens Change-Id: I54eedda207b8ec7a69263353b43abe5746aea197	11 years ago
Corey Farrell	47fa2ad10b	Build System: Fix issue with addons moduleinfo. ... The build system now scans additional sources when generating moduleinfo for menuselect. Unfortunately the extra sources for format_mp3 only exist if downloaded. Use the Makefile macro 'wildcard' to allow moduleinfo generator to ignore sources that do not exist. Change-Id: I596604713b7345ce994f32197f8f6bfd9bcf4170	11 years ago
Joshua Colp	bb6ddb3dc8	res_ari_device_states: Fix dependency on res_stasis_device_state. ... The res_ari_device_states module depends on res_stasis_device_state, not res_stasis_device_states. Change-Id: I26e02ad37f9e36bcc859867e2fad1b90452ec3de	11 years ago
Mark Michelson	4475945a24	Merge "chan_dahdi: Add the chan_dahdi.conf force_restart_unavailable_chans option."	11 years ago
Mark Michelson	11ffcf662f	Restrict functionality when ACLs are misconfigured. ... This patch has two main purposes: 1) Improve warning messages when ACLs are configured improperly. 2) Prevent misconfigured ACLs from allowing potentially unwanted traffic. To acomplish point (2) in most cases, whatever configuration object that the ACL belonged to was not allowed to load. The one exception is res_pjsip_acl. In that case, ACLs are their own configuration object. Furthermore, the module loading code has no indication that a ACL configuration had a failure. So the tactic taken here is to create an ACL that just blocks everything. ASTERISK-24969 Reported by Corey Farrell Change-Id: I2ebcb6959cefad03cea4d81401be946203fcacae	11 years ago
Richard Mudgett	03c51cf525	chan_dahdi: Add the chan_dahdi.conf force_restart_unavailable_chans option. ... Some telco switches occasionally ignore ISDN RESTART requests. The fix for ASTERISK-19608 added an escape clause for B channels in the restarting state if the telco ignores a RESTART request. If the telco fails to acknowledge the RESTART then Asterisk will assume the telco acknowledged the RESTART on the second call attempt requesting the B channel by the telco. The escape clause is good for dealing with RESTART requests in general but it does cause the next call for the restarting B channel to be rejected if the telco insists the call must go on that B channel. chan_dahdi doesn't really need to issue a RESTART request in response to receiving a cause 44 (Requested channel not available) code. Sending the RESTART in such a situation is not required (nor prohibited) by the standards. I think chan_dahdi does this for historical reasons to deal with buggy peers to get channels unstuck in a similar fashion as the chan_dahdi.conf resetinterval option. * Add the chan_dahdi.conf force_restart_unavailable_chans compatability option that when disabled will prevent chan_dahdi from trying to RESTART the channel in response to a cause 44 code. ASTERISK-25034 #close Reported by: Richard Mudgett Change-Id: Ib8b17a438799920f4a2038826ff99a1884042f65	11 years ago
Rodrigo Ramírez Norambuena	556653d937	cdr/cdr_csv.c: Refactor, function to write content of csv file. ... Create a function for write content of CDR on csv files. Before used same code for write two distinct files (account and master cdr) instead use a function for thats. Reduced to one lock when files are written. Change-Id: Idce707f4c108083252e0aeb948f421d924953e65	11 years ago
Joshua Colp	80aa9aee5d	res_pjsip_outbound_registration: Fix double unref on error return. ... When the PJSIP pjsip_regc_send function is invoked and an error status returned the caller currently decrements the reference count of the client state that it just incremented, assuming the registration callback would not have been invoked. In practice this is not correct. If the failure happens after the transaction has been set up the callback will still be invoked. This will cause the reference count to be incorrectly decremented twice, once by the registration callback and second by the caller of pjsip_regc_send. This change makes it so that whether the callback is invoked or not is known by the caller of pjsip_regc_send. Depending on this it can know whether it is responsible for decrementing the reference count of the client state or not. ASTERISK-25037 #close Reported by: Joshua Colp Change-Id: I749dc12f3a22115c49c5d7d95ff42a5fa45319de	11 years ago
Rodrigo Ramírez Norambuena	7ff3b2d479	include/asterisk/channel.h: Fix typo ... Change-Id: Ie584b85e16a94c255e60d0b1732ef9686464fef3	11 years ago
Matt Jordan	7fe923d20b	Merge "ARI: Fix missing dependencies."	11 years ago
Matt Jordan	08355350a2	Merge "res_fax: allow 2400 transmission rate according to v.27ter standard"	11 years ago
Matt Jordan	39d3e1ef6e	main/rtp_engine: Fix DTLS double-free introduced by 0b6410c4f8 ... The patch in 0b6410c4f8 did correctly fix a memory leak of the DTLS structures in the RTP engine. However, when a 'core reload' is issued, a double free of the memory pointed to by the char *'s in the DTLS configuration struct can occur, as ast_rtp_dtls_cfg_free does not set the pointers to NULL when they are freed. This patch sets those pointers to NULL, preventing a second call to ast_rtp_dtls_cfg_free from corrupting memory. ASTERISK-25022 Change-Id: I820471e6070a37e3c26f760118c86770e12f6115	11 years ago
Mark Michelson	8d547e4e88	Merge "cdr/cdr_csv.c: Add missing space after comma."	11 years ago
Kevin Harwell	5d0c182885	res_fax: allow 2400 transmission rate according to v.27ter standard ... A previous set of patches (see: ASTERISK-22790 & ASTERISK-23231) made it so a v.27 modem was not allowed to have a minimum transmission rate of 2400 bits per second. This reverts all or some of those patches since according to the v.27ter standard a rate of 2400 bits per second is also supported. One of the original patches also added 9600 bits per second support for v.27. This patch also removes that since v.27ter only supports 2400/4800 bits per second. Also, since Asterisk specifically supports v.27ter the enum was renamed to better reflect this. ASTERISK-24955 #close Reported by: Matt Jordan Change-Id: I4b9dfb6bf7eff08463ab47ee1a74224f27cae733	11 years ago
Matt Jordan	57cbb4bc8d	Merge "Astobj2: Add ao2_weakproxy_ref_object function."	11 years ago
Joshua Colp	648b22f19d	Merge "res_pjsip_outbound_registration: Don't fail on delayed processing."	11 years ago
Corey Farrell	c9c03998cc	Astobj2: Add ao2_weakproxy_ref_object function. ... This function allows code to run ao2_ref against the real object associated with a weakproxy. It is useful when all of the following conditions are true: * You have a pointer to weakproxy. * You do not have or need a pointer to the real object. * You need to ensure the real object exists and is not destroyed during a process. In this case it's wasteful to store a pointer to the real object just for the sake of releasing it later. Change-Id: I38a319b83314de75be74207a8771aab269bcca46	11 years ago
Mark Michelson	03261b9614	Merge "Git Conversion: Switch Non-C files to ASTERISK_REGISTER_FILE."	11 years ago
Mark Michelson	4f1db2070d	res_pjsip_outbound_registration: Don't fail on delayed processing. ... Odd behaviors have been observed during outbound registrations. The most common problem witnessed has been one where a request with authentication credentials cannot be created after receiving a 401 response. Other behaviors include apparently processing an incorrect SIP response. Inspecting the code led to an apparent issue with regards to how we handle transactions in outbound registration code. When a response to a REGISTER arrives, we save a pointer to the transaction and then push a task onto the registration serializer. Between the time that we save the pointer and push the task, it's possible for the transaction to be destroyed due to a timeout. It's also possible for the address to be reused by the transaction layer for a new transaction. To allow for authentication of a REGISTER request to be authenticated after the transaction has timed out, we now hold a reference to the original REGISTER request instead of the transaction. The function for creating a request with authentication has been altered to take the original request instead of the transaction where the original request was sent. ASTERISK-25020 Reported by Mark Michelson Change-Id: I756c19ab05ada5d0503175db9676acf87c686d0a	11 years ago
Joshua Colp	ed5715eb39	res_sorcery_config: Fix build issue due to syntax error. ... Change-Id: Ic8322f04e37842848ad72cf2871bd0378f67c4ac	11 years ago
Matt Jordan	48d5971a82	Merge "chan_pjsip: Creating Channel Causes Asterisk to Crash When Duplicate AOR Sections Exist in pjsip.conf"	11 years ago
Matt Jordan	d6ecbbac0a	Merge topic 'ASTERISK-25027' ... * changes: res_pjsip: Remove incorrect MODULEINFO from presence_xml.c. Git Migration: Create doc/rest-api when needed.	11 years ago
Matt Jordan	f6202f5cf0	Merge "Build System: Prevent unneeded changes to asterisk/buildopts.h."	11 years ago
Corey Farrell	f226bd6f60	ARI: Fix missing dependencies. ... ARI modules that are generated by 'make ari-stubs' are all dependent on res_ari_model. Additionally some of the same modules depend on one or more res_stasis_* modules. ASTERISK-25027 #close Reported by: Corey Farrell Change-Id: I8e07fe7e81fedacb87232f2b6f8b5f47927b4153	11 years ago
Corey Farrell	881844297a	res_pjsip: Remove incorrect MODULEINFO from presence_xml.c. ... Remove incorrect MODULEINFO block and unneeded header includes from presence_xml.c. ASTERISK-25027 Reported by: Corey Farrell Change-Id: I977c609ab9d1fe05373027c4138900f6985990eb	11 years ago
Corey Farrell	c232ff3af0	Git Migration: Create doc/rest-api when needed. ... Create the directory './doc/rest-api' at the start of 'make ari-stubs' to prevent an error when documentation is generated. The directory is also added to git ignores. ASTERISK-25027 Reported by: Corey Farrell Change-Id: Iaccc7f0138501c23aa78feaca2f3cce9e68cbc1b	11 years ago
Joshua Colp	78ff328b0b	Merge "chan_iax2: Ensure that IAX flags are 64 bits."	11 years ago
Corey Farrell	5d997ecc83	Build System: Prevent unneeded changes to asterisk/buildopts.h. ... * Add AST_DEVMODE to BUILDOPTS * Use BUILDOPTS to generate AST_BUILDOPT_SUM. * Remove loop that defined AST_MODULE_* These changes ensure that only ABI effecting options are considered for AST_BUILDOPT_SUM. This also reduces unneeded full system rebuilds caused by enabling or disabling one module that another is dependent on. ASTERISK-25028 #close Reported by: Corey Farrell Change-Id: I2c516d93df9f6aaa09ae079a8168c887a6ff93a2	11 years ago