870 Commits (97a653518dc6dbdc927521e92b51dedaffe149bc)

Author	SHA1	Message	Date
Josh Soref	9aa88723e3	funcs: Spelling fixes ... Correct typos of the following word families: effectively emitted expect anthony ASTERISK-29714 Change-Id: Ic16f9ec855bb6d14ec8e170b90af9a36b06d488a	4 years ago
Sean Bright	a4d533d132	func_talkdetect.c: Fix logical errors in silence detection. ... There are 3 separate changes here: 1. The documentation erroneously stated that the dsp_talking_threshold argument was a number of milliseconds when it is actually an energy level used by the DSP code to classify talking vs. silence. 2. Fixes a copy paste error in the argument handling code. 3. Don't erroneously switch to the talking state if we aren't actively handling a frame we've classified as talking. Patch inspired by one provided by Moritz Fain (License #6961). ASTERISK-27816 #close Change-Id: I5953fd570b98b49c41cee55bfe3b941753fb2511	4 years ago
Naveen Albert	b0027c65f9	func_vmcount: Add support for multiple mailboxes ... Allows multiple mailboxes to be specified for VMCOUNT instead of just one. ASTERISK-29661 #close Change-Id: I9108528300795fd5b607efa9d4dd7b74be031813	4 years ago
Naveen Albert	228c97d3bf	func_channel: Add CHANNEL_EXISTS function. ... Adds a function to check for the existence of a channel by name or by UNIQUEID. ASTERISK-29656 #close Change-Id: Ib464e9eb6e13dc683a846286798fecff4fd943cb	4 years ago
Naveen Albert	249fe0f37e	func_strings: Add STRBETWEEN function ... Adds the STRBETWEEN function, which can be used to insert a substring between each character in a string. For instance, this can be used to insert pauses between DTMF tones in a string of digits. ASTERISK-29627 Change-Id: Ice23009d4a8e9bb9718d2b2301d405567087d258	4 years ago
Naveen Albert	b8e2b2ed5e	func_env: Add DIRNAME and BASENAME functions ... Adds the DIRNAME and BASENAME functions, which are wrappers around the corresponding C library functions. These can be used to safely and conveniently work with file paths and names in the dialplan. ASTERISK-29628 #close Change-Id: Id3aeb907f65c0ff96b6e57751ff0cb49d61db7f3	4 years ago
Naveen Albert	11516e4b8e	func_sayfiles: Retrieve say file names ... Up until now, all of the logic used to translate arguments to the Say applications has been directly coupled to playback, preventing other modules from using this logic. This refactors code in say.c and adds a SAYFILES function that can be used to retrieve the file names that would be played. These can then be used in other applications or for other purposes. Additionally, a SayMoney application and a SayOrdinal application are added. Both SayOrdinal and SayNumber are also expanded to support integers greater than one billion. ASTERISK-29531 Change-Id: If9718c89353b8e153d84add3cc4637b79585db19	4 years ago
Naveen Albert	4bd5757123	func_math: Return integer instead of float if possible ... The MIN, MAX, and ABS functions all support float arguments, but currently return floats even if the arguments are all integers and the response is a whole number, in which case the user is likely expecting an integer. This casts the float to an integer before printing into the response buffer if possible. ASTERISK-29495 Change-Id: I902d29eacf3ecd0f8a6a5e433c97f0421d205488	4 years ago
Naveen Albert	1055660252	func_scramble: Audio scrambler function ... Adds a function to scramble audio on a channel using whole spectrum frequency inversion. This can be used as a privacy enhancement with applications like ChanSpy or other potentially sensitive audio. ASTERISK-29542 Change-Id: I01020769d91060a1f56a708eb405f87648d1a67e	4 years ago
Naveen Albert	af17973bda	func_frame_drop: New function ... Adds function to selectively drop specified frames in the TX or RX direction on a channel, including control frames. ASTERISK-29478 Change-Id: I8147c9d55d74e2e48861edba6b22f930920541ec	4 years ago
Jaco Kroon	2dbf8cd135	func_lock: Add "dialplan locks show" cli command. ... For example: arthur*CLI> dialplan locks show func_lock locks: Name Requesters Owner uls-autoref 0 (unlocked) 1 total locks listed. Obviously other potentially useful stats could be added (eg, how many times there was contention, how many times it failed etc ... but that would require keeping the stats and I'm not convinced that's worth the effort. This was useful to troubleshoot some other issues so submitting it. Change-Id: Ib875e56feb49d523300aec5f36c635ed74843a9f Signed-off-by: Jaco Kroon <jaco@uls.co.za>	4 years ago
Jaco Kroon	5d7d174e1f	func_lock: Prevent module unloading in-use module. ... The scenario where a channel still has an associated datastore we cannot unload since there is a function pointer to the destroy and fixup functions in play. Thus increase the module ref count whenever we allocate a datastore, and decrease it during destroy. In order to tighten the race that still exists in spite of this (below) add some extra failure cases to prevent allocations in these cases. Race: If module ref is zero, an LOCK or TRYLOCK is invoked (near) simultaneously on a channel that has NOT PREVIOUSLY taken a lock, and if in such a case the datastore is created *prior* to unloading being set to true (first step in module unload) then it's possible that the module will unload with the destructor being called (and segfault) post the module being unloaded. The module will however wait for such locks to release prior to unloading. If post that we can recheck the module ref before returning the we can (in theory, I think) eliminate the last of the race. This race is mostly theoretical in nature. Change-Id: I21a514a0b56755c578a687f4867eacb8b59e23cf Signed-off-by: Jaco Kroon <jaco@uls.co.za>	4 years ago
Jaco Kroon	4040095ea4	func_lock: Fix memory corruption during unload. ... AST_TRAVERSE accessess current as current = current->(field).next ... and since we free current (and ast_free poisons the memory) we either end up on a ast_mutex_lock to a non-existing lock that can never be obtained, or a segfault. Incidentally add logging in the "we have to wait for a lock to release" case, and remove an ineffective statement that sets memory that was just cleared by ast_calloc to zero. Change-Id: Id19ba3d9867b23d0e6783b97e6ecd8e62698b8c3 Signed-off-by: Jaco Kroon <jaco@uls.co.za>	4 years ago
Jaco Kroon	5008d9fee1	func_lock: Fix requesters counter in error paths. ... In two places we bail out with failure after we've already incremented the requesters counter, if this occured then it would effectively result in unload to wait indefinitely, thus preventing clean shutdown. Change-Id: I362a6c0dc424f736d4a9c733d818e72d19675283 Signed-off-by: Jaco Kroon <jaco@uls.co.za>	4 years ago
Naveen Albert	8236f2f155	func_math: Three new dialplan functions ... Introduces three new dialplan functions, MIN and MAX, which can be used to calculate the minimum or maximum of up to two numbers, and ABS, an absolute value function. ASTERISK-29431 Change-Id: I2bda9269d18f9d54833c85e48e41fce0e0ce4d8d	4 years ago
Naveen Albert	d1305af137	func_volume: Add read capability to function. ... Up until now, the VOLUME function has been write only, so that TX/RX values can be set but not read afterwards. Now, previously set TX/RX values can be read later. ASTERISK-29439 Change-Id: Ia23e92fa2e755c36e9c8e69f2940d2703ccccb5f	4 years ago
Joshua C. Colp	e42417e910	xml: Embed module information into core XML documentation. ... This change embeds the MODULEINFO block of modules into the core XML documentation. This provides a shared mechanism for use by both menuselect and Asterisk for information and a definitive source of truth. ASTERISK-29335 Change-Id: Ifbfd5c700049cf320a3e45351ac65dd89bc99d90	4 years ago
Jaco Kroon	59129bfab8	func_callerid+res_agi: Fix compile errors related to -Werror=zero-length-bounds ... Change-Id: I75152cece8a00b7523d542e5ac22796f9595692b Signed-off-by: Jaco Kroon <jaco@uls.co.za>	4 years ago
Jaco Kroon	d847f7e8f8	func_odbc: Introduce minargs config and expose ARGC in addition to ARGn. ... minargs enables enforcing of minimum count of arguments to pass to func_odbc, so if you're unconditionally using ARG1 through ARG4 then this should be set to 4. func_odbc will generate an error in this case, so for example [FOO] minargs = 4 and ODBC_FOO(a,b,c) in dialplan will now error out instead of using a potentially leaked ARG4 from Gosub(). ARGC is needed if you're using optional argument, to verify whether or not an argument has been passed, else it's possible to use a leaked ARGn from Gosub (app_stack). So now you can safely do ${IF($[${ARGC}>3]?${ARGV}:default value)} kind of thing. Change-Id: I6ca0b137d90b03f6aa9c496991f6cbf1518f6c24 Signed-off-by: Jaco Kroon <jaco@uls.co.za>	4 years ago
Jaco Kroon	32e36144c7	func_lock: fix multiple-channel-grant problems. ... Under contention it becomes possible that multiple channels will be told they successfully obtained the lock, which is a bug. Please refer ASTERISK-29217 This introduces a couple of changes. 1. Replaces requesters ao2 container with simple counter (we don't really care who is waiting for the lock, only how many). This is updated undex ->mutex to prevent memory access races. 2. Correct semantics for ast_cond_timedwait() as described in pthread_cond_broadcast(3P) is used (multiple threads can be released on a single _signal()). 3. Module unload races are taken care of and memory properly cleaned up. Change-Id: I6f68b5ec82ff25b2909daf6e4d19ca864a463e29 Signed-off-by: Jaco Kroon <jaco@uls.co.za>	4 years ago
Alexander Traud	4c79bc19d1	loader: Sync load- and build-time deps. ... In MODULEINFO, each depend has to be listed in .requires of AST_MODULE_INFO. ASTERISK-29148 Change-Id: I254dd33194ae38d2877b8021c57c2a5deb6bbcd2	5 years ago
Dovid Bender	5046e1fb06	func_curl.c: Allow user to set what return codes constitute a failure. ... Currently any response from res_curl where we get an answer from the web server, regardless of what the response is (404, 403 etc.) Asterisk currently treats it as a success. This patch allows you to set which codes should be considered as a failure by Asterisk. If say we set failurecodes=404,403 then when using curl in realtime if a server gives a 404 error Asterisk will try to failover to the next option set in extconfig.conf ASTERISK-28825 Reported by: Dovid Bender Code by: Gobinda Paul Change-Id: I94443e508343e0a3e535e51ea6e0562767639987	5 years ago
Alexander Traud	13b56c4be6	Compiler fixes for GCC with -Og ... ASTERISK-29144 Change-Id: I2a72c072083b4492a223c6f9d73d21f4f424db62	5 years ago
Sean Bright	799426cd58	func_curl.c: Prevent crash when using CURLOPT(httpheader) ... Because we use shared thread-local cURL instances, we need to ensure that the state of the cURL instance is correct before each invocation. In the case of custom headers, we were not resetting cURL's internal HTTP header pointer which could result in a crash if subsequent requests do not configure custom headers. ASTERISK-29085 #close Change-Id: I8b4ab34038156dfba613030a45f10e932d2e992d	5 years ago
Alexander Traud	ea102bd1a7	curl: Add build-time dependency. ... ASTERISK-28838 Change-Id: I34724e799e1ffaf723eb2c358abe8934dbadcd52	5 years ago
Jean Aunis	ef4255f6ed	func_volume: Accept decimal number as argument ... Allow voice volume to be multiplied or divided by a floating point number. ASTERISK-28813 Change-Id: I5b42b890ec4e1f6b0b3400cb44ff16522b021c8c	5 years ago
Sebastien Duthil	3513be1e79	func_channel: allow reading 4 fields from dialplan ... The following fields return an error when read from dialplan: - exten - context - userfield - channame ASTERISK-28796 #close Change-Id: Ieacaac629490f8710fdacc9de80ed5916c5f6ee2	5 years ago
traud	81d271f76a	func_aes: Avoid incorrect error message on load. ... In case of no OpenSSL headers, the module func_aes was built but did not load. ASTERISK-28788 Change-Id: I0b99b8468cbeb3b0eab23069cbd64062ef885ffc	5 years ago
Sean Bright	65ff4d80a1	func_odbc: Prevent snprintf() truncation warning ... For reasons that are not clear to me - this only appears for me when _not_ building in dev-mode. Change-Id: Ib45c54daaea8e0d571cb470cab1daaae2edba968	5 years ago
Sean Bright	f69da94fab	func_curl: Add 'followlocation' option to CURLOPT() ... We allow for 'maxredirs' to be set, but this value is ignored when followlocation is not enabled which, by default, it is not. ASTERISK-17491 #close Reported by: candrews Change-Id: I96a4ab0142f2fb7d2e96ff976f6cf7b2982c761a	5 years ago
Boris P. Korzun	e54299cd3e	func_odbc: acf_odbc_read() and cli_odbc_read() unicode support ... Added ast_odbc_ast_str_SQLGetData() considers SQL_DESC_OCTET_LENGTH column attribute for correct allocating the buffer. ASTERISK-28497 #close Change-Id: I50e86c8a277996f13d4a4b9b318ece0d60b279bf	5 years ago
Pascal Cadotte Michaud	2d2b28bfa4	PJSIP_CONTACT: add missing argument documentation ... add missing argument "rtt" and "status" to the documentation The change to the dtd file allow an enumlist to contain one or many configOptionToEnum or enum. This is different from the previous patch I submitted when you could have a configOptionToEnum or (a configOptionToEnum followed by one or manu enums) or (one or many enums) ASTERISK-28626 Change-Id: Ia71743ee7ec813f40297b0ddefeee7909db63b6d	5 years ago
George Joseph	4631e77078	Merge "Revert "PJSIP_CONTACT: add missing argument documentation"" into 16	5 years ago
Joshua Colp	9c29c3fb3e	Revert "PJSIP_CONTACT: add missing argument documentation" ... This reverts commit 174e6426aa. Reason for revert: Regression in XML validation. validity error : Content model of enumlist is not determinist: (configOptionToEnum | (configOptionToEnum , enum+) | enum+) As we are preparing to do releases and this is not critical I am reverting this for now until resolved. Change-Id: I2c9656fb40b2d2f56f54caa35c8be02cc92babd0	5 years ago
Friendly Automation	7620d1256c	Merge "PJSIP_CONTACT: add missing argument documentation" into 16	5 years ago
Pascal Cadotte Michaud	174e6426aa	PJSIP_CONTACT: add missing argument documentation ... add missing argument "rtt" and "status" to the documentation ASTERISK-28626 Change-Id: I8419e4c8203e411b87d93dc395acdbcf7526dedf	6 years ago
Kevin Harwell	f8e4473e16	Merge "func_curl.c: Support custom http headers" into 16	6 years ago
Sean Bright	e39ddb1cb1	func_env: Prevent FILE() from reading garbage at end-of-file ... If the last line of a file does not have a terminating EOL sequence, we potentially add garbage to the value returned from the FILE() function. There is no overflow potential here as we are reading from a buffer of a known size, we are just reading too much of it. ASTERISK-26481 #close Change-Id: I50dd4fcf416fb3c83150040a1a79a59d9eb1ae01	6 years ago
Martin Tomec	37dcdd485a	func_curl.c: Support custom http headers ... When user wants to send json data, the default Content-Type header is incorect (application/x-www-form-urlencoded). This patch allows to set any custom headers so the Content-Type header can be overriden. User can set multiple headers by multiple calls of curlopt(). This approach is not consistent with other parameters, but is more readable in dialplan than one call with multiple headers. ASTERISK-28613 Change-Id: I4dd68c3f4e25362ef941d73a3861f58348dcfbf9	6 years ago
Joshua Colp	6647be69ac	func_jitterbuffer: Add audio/video sync support. ... This change adds support to the JITTERBUFFER dialplan function for audio and video synchronization. When enabled the RTCP SR report is used to produce an NTP timestamp for both the audio and video streams. Using this information the video frames are queued until their NTP timestamp is equal to or behind the NTP timestamp of the audio. The audio jitterbuffer acts as the leader deciding when to shrink/grow the jitterbuffer when adaptive is in use. For both adaptive and fixed the video buffer follows the size of the audio jitterbuffer. ASTERISK-28533 Change-Id: I3fd75160426465e6d46bb2e198c07b9d314a4492	6 years ago
Kevin Harwell	6bb14150c4	various modules: json integer overflow ... There were still a few places in the code that could overflow when "packing" a json object with a value outside the base type integer's range. For instance: unsigned int value = INT_MAX + 1 ast_json_pack("{s: i}", value); would result in a negative number being "packed". In those situations this patch alters those values to a ast_json_int_t, which widens the value up to a long or long long. ASTERISK-28480 Change-Id: Ied530780d83e6f1772adba0e28d8938ef30c49a1	6 years ago
Joshua Colp	44254d548b	res_odbc: Add basic query logging. ... When Asterisk is connected and used with a database the response time of the database can cause problems in Asterisk if it is long. Normally the only way to see this problem would be to retrieve a backtrace from Asterisk and examine where things are blocked, or examine the database to see if there is any indication of a problem. This change adds some basic query logging to make it easier to investigate such a problem. When logging is enabled res_odbc will now keep track of the number of queries executed, as well as the query that has taken the longest time to execute. There is also an option which will cause a WARNING message to be output if a query takes longer than a configurable amount of time to execute. This makes it easier and clearer for users that their database may be experiencing a problem that could impact Asterisk. ASTERISK-28277 Change-Id: I173cf4928b10754478a6a8c27dfa96ede0f058a6	6 years ago
Joshua Colp	53d0664781	Merge "func_strings: HASHKEY - negative array index can cause corruption" into 16	7 years ago
Corey Farrell	ed7a5664b6	astobj2: Eliminate usage of legacy ao2_container_alloc routine. ... Replace usage of ao2_container_alloc with ao2_container_alloc_hash or ao2_container_alloc_list. ao2_container_alloc is now restricted to modules only and is being removed from Asterisk 17. Change-Id: I0907d78bc66efc775672df37c8faad00f2f6c088	7 years ago
Kevin Harwell	72e532136c	func_strings: HASHKEY - negative array index can cause corruption ... This patch makes it so only matching non-empty key names, and keys created by the HASH function are eligible for inclusion in the comma separated string. It also fixes a bug where it was possible to write to a negative index if the result buffer was empty. ASTERISK-28159 patches: ASTERISK-28159.diff submitted by Michael Walton (license 6502) Change-Id: I6e57fe7307dfd856271753aed5ba64c59b511487	7 years ago
Richard Mudgett	77f151d927	func_periodic_hook.c: Cleanup module resources on failure. ... * Make load_module() cleanup if it failed to setup the module. * Make unload_module() always return 0. It is silly to fail unloading if the hook function we try to unregister was not even registered. Change-Id: I280fc6e8ba2a7ee2588ca01d870eebaf74b4ffe6	7 years ago
Alexander Traud	6f47b84fbd	func_env: Compile in Solaris 11. ... Change-Id: Idc9b36720f3d29c90a35a6a1ae79a7f9e1aaf50e	7 years ago
Richard Mudgett	91c3ac19cb	Dialplan functions: Fix some channel autoservice misuse. ... * Fix off nominal paths leaving the channel in autoservice. * Remove unnecessary start/stop channel autoservice. * Fix channel locking around a channel datastore search. Change-Id: I7ff2e42388064fe3149034ecae57604040b8b540	7 years ago
Jenkins2	076ff479ac	Merge "crypto.h: Repair ./configure --with-ssl=PATH."	7 years ago
Alexander Traud	99aed78078	crypto.h: Repair ./configure --with-ssl=PATH. ... ASTERISK-27908 Change-Id: Iac49d9f82faeb8a4611c6805906bd6d650b1b1d8	7 years ago