1876 Commits (90dc0cfa85dbe55c7f34e59fb56b97f582d57db4)

Author	SHA1	Message	Date
Joshua Colp	90dc0cfa85	Merged revisions 76561 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ................ r76561 | file | 2007-07-23 11:34:21 -0300 (Mon, 23 Jul 2007) | 14 lines Merged revisions 76560 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r76560 | file | 2007-07-23 11:32:07 -0300 (Mon, 23 Jul 2007) | 6 lines (closes issue #10236) Reported by: homesick Patches: rpid_1.4_75840.patch uploaded by homesick (license 91) Accept Remote Party ID on guest calls. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76563 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	7a2772c151	Mark str2dtmfmode() as currently unused to resolve a compiler warning and ... allow building under dev mode git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76562 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	eaebbdab61	(closes issue #10271) ... Reported by: snuffy Patches: doxygen-updates.diff uploaded by snuffy (license 35) Another big batch of doxygen documentation updates git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76559 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	b1791d9349	introduce two functions, map_x_s() and map_s_x(), to map ... between integers and strings using a single translation table, and use them in a few places instead of ad-hoc routines that duplicate the table. On passing, note that REFER_CONFIRMED is never used, and add a few comments. Nothing to backport here. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76547 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	83609770c1	Remove an unused function to resolve a compiler warning ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76524 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	ed1775bd10	move "sip prunte realtime ..." and "sip set debug ... " to NEW_CLI style. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76521 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	1ee5480549	Add some documentation on the sipregistry states and the ... handling of the sip_register structures. This commit only changes comments and whitespace. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76467 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	28cde9fee3	add a bit of comments on internal functions. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76458 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	719dcef90d	rewrite "sip show {channels|subscriptions}" CLI handler ... using the new-style cli format. No functional changes, nothing to backport. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76408 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	930bf0402d	Make sip_destroy() return NULL so the caller can do things like ... foo = sip_destroy(foo); and reduce the chance of bugs due to dangling pointers. Also remove a duplicate prototype for the function. nothing to backport. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76392 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	97512a856f	add two comment blocks, one on reusing nonces, and one on the handling ... of an 'authpeer' local variable. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76390 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	db12b404fc	comment and slightly restructure handle_request() in the part that handles ... responses, so that there is a common exit point. Mark two places where probably we could return -1 instead of 0 to report an error to the caller. (change triggered by investigations on how the 'SIP_PKT_IGNORE' field was used). nothing to backport from this commit git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76371 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	88f18dc9d7	remove unused argument from handle_invite_replaces(), and also leftover ... SIP_PKT_* stuff from the previous commit. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76366 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	b7945cd78e	Cleanup of flags used in struct sip_request, moving them to ... individual variables. Apart from SIP_PKT_IGNORE which was used a zillion times, the other two are used seldom. On passing: - move the arrays to the end of struct sip_request, so a (small) buffer overflow is less likely to overwrite the other fields; - note that the 'ignore' argument to handle_invite_replaces() is not used and should be removed (will be done in a separate commit). Nothing to backport in this change. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76365 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	aa110ad3fd	move two per-packet flags to proper variables. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76349 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	e603d729a9	minor clarification on the usage of SIP_* flags. ... Also correct some items that were misclassified. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76348 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	0d5e33f2c3	document the way sipdebug works, and implement it through ... variables and not flags. NOTE: The old behaviour (preserved in this commit) is that if sipdebug is set in the config file, it can only be disabled by reloading the config. I am not sure if this is accidental or voluntary, but it is really unconvenient and I think it should be handled in the same way as other options i.e. consider requests from the config file or the cli (or the command line) to be fully equivalent and act on the same status variable. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76330 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	063edd1953	move the SIP_REALTIME flag to a field in the user/peer structure. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76314 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	1daf32e474	Add a note to document how the temporary 'pvt' should be initialized ... before using it. I am unclear on the details right now so i hope someone can comment more. The obvious (and lazy) approach would be to bzero() all of it (except for the string pool), but isn't that too much work ? Feedback wanted here... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76313 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	ed604a6df8	whoops... was setting needdestroy on the wrong dialog. ... (spotted by a diff with my own branch) git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76279 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	b11d587ab6	more two more flags to proper variables: ALREADYGONE and NEEDDESTROY. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76278 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	4ce3ee94c3	use explicit variables for things that don't need to ... be stored in ast_flags. First victim is 'SIP_NO_HISTORY' replaced by a 'do_history' field in the sip_pvt structure. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76231 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	10d1b9347c	Use ast_str_append() instead of ast_build_string() to construct ... the sdp messages. Overall the code is slightly more readable (because the string is fully described by a single pointer), and more efficient (because the length is stored explicitly so you don't need to do strlen()). (I have been using this code for almost a year now.) I wish we had infix string operators to do this sort of things! Nothing to backport from this change. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76229 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	06a3436375	We have two 'technology' descriptors for a SIP channel, so ... define and use a macro to determine whether we are pointing to one of them, so when one goes away (or a new one appears) we don't have to touch all the code. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76224 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	2286afa3af	Enhance NAT support as discussed on the -dev list, i.e.: ... + extensive documentation changes both in sip.conf.sample and in the source; + allow "externip" and "externhost" to include a port number as well; + allow "bindaddr" to have a port number (making bindport unnecessary, even though it is still present for backward compatibility); + introduce the new "stunaddr" parameter to specify an STUN server to be used from the main SIP socket; + extend the "sip show settings" output to show all the above. Internally: + change related data structures from struct in_addr to struct sockaddr_in to store the port numbers as well; + reorganize ast_sip_ouraddrfor() (should also be renamed to sip_ouraddrfor() because it is not a generic API, though it might become so if called with a socket as an additional argument, in which case it can be moved elsewhere). As mentioned in the documentation, media sessions still do not use STUN so the port numbers may still be incorrect when Asterisk is behind a NAT On passing, some of the debugging messages printing media addresses are probably using the wrong values, but this will be checked/fixed in a subsequent commit if needed. Part of the following chunk in the function that handles a "sip reload" is probably needed on previous versions as well, to avoid leaking the memory used for the "localaddr" list: @@ -17244,13 +17274,17 @@ /* Reset IP addresses */ memset(&bindaddr, 0, sizeof(bindaddr)); + memset(&stunaddr, 0, sizeof(stunaddr)); + memset(&internip, 0, sizeof(internip)); + /* Free memory for local network address mask */ + ---> ast_free_ha(localaddr); <----- memset(&localaddr, 0, sizeof(localaddr)); memset(&externip, 0, sizeof(externip)); memset(&default_prefs, 0 , sizeof(default_prefs)); git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76221 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	989b93143a	Merged revisions 76087 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ................ r76087 | file | 2007-07-20 14:20:09 -0300 (Fri, 20 Jul 2007) | 14 lines Merged revisions 76080 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r76080 | file | 2007-07-20 14:16:48 -0300 (Fri, 20 Jul 2007) | 6 lines (closes issue #10247) Reported by: fkasumovic Patches: chan_sip.patch uploaded by fkasumovic (license #101) Drop any peer realm authentication entries when reloading so multiple entries do not get added to the peer. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76091 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	66cae9269b	It is impossible for the externhost variable to not exist, it is however possible for it to be empty. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76056 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	bfc782f4e9	Don't use a field size for the last argument of printf format, ... because in this case the string is left-aligned and it is not truncated anyways. Omitting the field size prevents the generation of trailing whitespace, which makes the string fit in smaller windows. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76037 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	b2fec9ad16	Extend the 'network settings' section with indication on the ... localnet settings (requires the change in SVN 76034), and also give an indication on whether/why/how the remapping of addresses in SIP message is done or not. I think this is especially useful for debugging the configuration, as the address remapping depends on a combination of at least 3 parameters (localnet, externhost, externip) and successful DNS lookup. An example of the output of this section is below: Network Settings: --------------------------- SIP address remapping: Enabled using externhost Externhost: foo.dyndns.net Externip: 80.64.128.23:0 Externrefresh: 10 Internal IP: 12.34.56.78:5060 Localnet: 192.168.0.0/255.255.0.0 10.0.0.0/255.0.0.0 I leave to the community the judgement if the above info is a useful addition for 1.4. It is not a bugfix, but it is neither a new feature, only a useful diagnostic tool. Note that I would like to move there also the bindaddress/port information, in the usual addr:port format e.g. Bindaddress: 0.0.0.0:5060 so that network information is all in one place. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@76035 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	0e969271ae	After some study, thought, comparing, etc. I've backed out the previous universal mod to make ast_flags a 64 bit thing. Instead, I added a 64-bit version of ast_flags (ast_flags64), and 64-bit versions of the test-flag, set-flag, etc. macros, and an app_parse_options64 routine, and I use these in app_dial alone, to eliminate the 30-option limit it had grown to meet. There is room now for 32 more options and flags. I was heavily tempted to implement some of the other ideas that were presented, but this solution does not intro any new versions of dial, doesn't have a different API, has a minimal/zero impact on code outside of dial, and doesn't seriously (I hope) affect the code structure of dial. It's the best I can think of right now. My goal was NOT to rewrite dial. I leave that to a future, coordinated effort. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@75983 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	d60c5ee296	print more of the network settings (externip, externhost etc.) ... in the "sip show settings" cli output. I have put these in a separate section, probably even bindaddr and SIP port should go there. There are more things to add here e.g. localnet and so on. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@75878 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	192ac53c3f	document the use of externip, externhost and other nat-related options, ... as well as the handling of the sip socket. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@75875 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	fddd5b557c	ast_sip_ouraddrfor() never fails, so make it void ... and remove the code that would never be called. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@75874 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Luigi Rizzo	00d9a3e7a0	portability fix: use %f instead of %lf when printing double. ... The l is useless. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@75873 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	81bc1d7af5	Merge in ast_strftime branch, which changes timestamps to be accurate to the microsecond, instead of only to the second ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@75706 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	a23feea9d2	Merged revisions 75623 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r75623 | file | 2007-07-18 12:44:02 -0300 (Wed, 18 Jul 2007) | 2 lines Few more places that needs to check for onhold state. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@75624 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	d90bddfa6c	Merged revisions 75621 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r75621 | file | 2007-07-18 12:41:06 -0300 (Wed, 18 Jul 2007) | 5 lines (closes issue #10165) Reported by: elandivar It is possible for hold status to exist without call limits set, so we need to ensure update_call_counter is executed regardless. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@75622 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	5ac24b25d3	This corrects the problem with flags and %lld formats on 64-bit machines, where uint64_t is NOT acceptable for %lld, and also works on 32-bit machines. At least, with gcc. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@75585 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	4003b31fc5	Minor code tweaks. Variables were being checked wrong in some situations and didn't need to be checked in others. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@75566 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	8a7732f067	via 10206, I have added an option (e) to Dial to allow the h exten to get run on peer. Had to upgrade ast_flag stuff to 64 bits to do this. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@75400 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	6bc0a4929c	Merged revisions 74955 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r74955 | murf | 2007-07-12 14:42:08 -0600 (Thu, 12 Jul 2007) | 1 line This patch resolves 10143; thanks to irroot for the patch; looked acceptable. Let the community decide if it messes things up ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@74956 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Olle Johansson	a1b9cbcd31	Implementation of a feature that will disable "missed calls" counters on SIP phones. ... If the call is answered by another phone, other phones won't display the call as "missed". You can also add an option to the dial command so that you can have a "followme" scenario and not count the calls as "missed" when you cancel the call. Thanks to Ramon and Frank for feedback on this feature. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@74024 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	ba857cc8a9	Merged revisions 73985 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r73985 | tilghman | 2007-07-08 23:03:20 -0500 (Sun, 08 Jul 2007) | 2 lines Doxygen formatting fixes; fixes errors while 'make progdocs'. (Closes issue #10104) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@73994 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Olle Johansson	74e8ab14fc	Merged revisions 73849 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r73849 | oej | 2007-07-08 11:47:31 +0200 (Sun, 08 Jul 2007) | 2 lines While tracking down a bug, I need some more history. Dumphistory is very useful, indeed. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@73850 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	1da115c8d9	Merged revisions 73769 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ................ r73769 | russell | 2007-07-06 18:02:58 -0500 (Fri, 06 Jul 2007) | 12 lines Merged revisions 73768 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r73768 | russell | 2007-07-06 18:01:22 -0500 (Fri, 06 Jul 2007) | 4 lines If a sip_pvt struct has already registered an extension state callback, remove the old one before adding a new one. If this isn't done, Asterisk will crash. (issue #10120) ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@73771 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	a0c37d2548	Merged revisions 73679 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ................ r73679 | russell | 2007-07-06 10:57:25 -0500 (Fri, 06 Jul 2007) | 15 lines Merged revisions 73678 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r73678 | russell | 2007-07-06 10:55:41 -0500 (Fri, 06 Jul 2007) | 7 lines (closes issue #10125) Reported by: makoto Patches submitted by: makoto This fixes a crash in chan_sip that happens when the bindaddr setting is not valid on Asterisk startup, gets fixed, and then a reload gets issued. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@73680 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	134a556c9f	Merged revisions 73598 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r73598 | russell | 2007-07-05 18:59:22 -0500 (Thu, 05 Jul 2007) | 3 lines Fix a crash in chan_sip. Don't try to stop the monitor thread if it was never started. (closes issue #10124, reported by gzero, fixed by me) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@73599 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Kevin P. Fleming	cc19ba80f5	Merged revisions 73548 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ................ r73548 | kpfleming | 2007-07-05 17:20:44 -0500 (Thu, 05 Jul 2007) | 10 lines Merged revisions 73547 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r73547 | kpfleming | 2007-07-05 17:11:51 -0500 (Thu, 05 Jul 2007) | 2 lines we shouldn't allow G.723.1 endpoints to use VAD, just like we don't support it for G.729 ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@73550 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	0fc25ac3ee	Merged revisions 73467 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ................ r73467 | file | 2007-07-05 16:18:02 -0300 (Thu, 05 Jul 2007) | 10 lines Merged revisions 73466 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r73466 | file | 2007-07-05 16:15:18 -0300 (Thu, 05 Jul 2007) | 2 lines Copy language information to the dialog structure when calling a peer for situations where a PBX may be started on the dialed channel. (issue #10121 reported by clegall_proformatique) ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@73468 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jason Parker	daec10d187	Fix building with -Wdeclaration-after-statement, here too ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@72491 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago