2391 Commits (8e4768ebfb9e15732b06f42730eadf7b0488080f)

Author	SHA1	Message	Date
Leif Madsen	0f0d691f4c	Merged revisions 228897 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r228897 | lmadsen | 2009-11-09 09:38:38 -0600 (Mon, 09 Nov 2009) | 14 lines Merged revisions 228896 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r228896 | lmadsen | 2009-11-09 09:37:43 -0600 (Mon, 09 Nov 2009) | 6 lines Update WARNING message. Update a WARNING message to give a suggested fix when encountered. (closes issue #16198) Reported by: atis Tested by: atis ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@228900 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
David Vossel	d5777523dd	Merged revisions 228693 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r228693 | dvossel | 2009-11-06 16:35:44 -0600 (Fri, 06 Nov 2009) | 16 lines Merged revisions 228692 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r228692 | dvossel | 2009-11-06 16:33:27 -0600 (Fri, 06 Nov 2009) | 9 lines fixes audiohook write crash occuring in chan_spy whisper mode. After writing to the audiohook list in ast_write(), frames were being freed incorrectly. Under certain conditions this resulted in a double free crash. (closes issue #16133) Reported by: wetwired ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@228694 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Matthew Nicholson	778181794e	Merged revisions 228620 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r228620 | mnicholson | 2009-11-06 13:47:11 -0600 (Fri, 06 Nov 2009) | 15 lines Merged revisions 228378 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r228378 | mnicholson | 2009-11-06 10:26:59 -0600 (Fri, 06 Nov 2009) | 8 lines Properly handle '=' while decoding base64 messages and null terminate strings returned from BASE64_DECODE. (closes issue #15271) Reported by: chappell Patches: base64_fix.patch uploaded by chappell (license 8) Tested by: kobaz ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@228649 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Joshua Colp	7bedf3ea01	Merged revisions 228410 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r228410 | file | 2009-11-06 12:42:23 -0400 (Fri, 06 Nov 2009) | 14 lines Merged revisions 228409 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r228409 | file | 2009-11-06 12:41:20 -0400 (Fri, 06 Nov 2009) | 7 lines Fix a bug caused by a partially invalid frame (from the jitterbuffer) passing through the Asterisk core. (closes issue #15560) Reported by: jvandal (closes issue #15709) Reported by: covici ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@228413 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
David Vossel	41115458e3	Merged revisions 228339 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r228339 | dvossel | 2009-11-06 09:42:46 -0600 (Fri, 06 Nov 2009) | 12 lines Merged revisions 228338 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r228338 | dvossel | 2009-11-06 09:41:41 -0600 (Fri, 06 Nov 2009) | 5 lines fixes crash in astfd.c (closes issue #15981) Reported by: slavon ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@228340 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Jason Parker	bed759482a	Merged revisions 227372 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r227372 | qwell | 2009-11-03 13:59:46 -0600 (Tue, 03 Nov 2009) | 9 lines Fix some build issues on Solaris. (closes issue #14517) (SWP-109) Reported by: asgaroth Patches: bug_14517.diff uploaded by snuffy (license 35) Tested by: asgaroth, snuffy, dougm, qwell ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@227375 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	61716f24b5	Merged revisions 226159 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r226159 | tilghman | 2009-10-27 15:22:07 -0500 (Tue, 27 Oct 2009) | 14 lines Merged revisions 226138 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r226138 | tilghman | 2009-10-27 15:16:49 -0500 (Tue, 27 Oct 2009) | 7 lines Manager output is not always NULL-terminated, so force a NULL at the end of the filestream. (closes issue #15495) Reported by: pdf Patches: 20090916__issue15495.diff.txt uploaded by tilghman (license 14) Tested by: pdf ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@226170 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
David Vossel	12fb1e8bde	Merged revisions 225445 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r225445 | dvossel | 2009-10-22 14:55:51 -0500 (Thu, 22 Oct 2009) | 50 lines SIP TCP/TLS: move client connection setup/write into tcp helper thread, various related locking/memory fixes. What this patch fixes 1.Moves sip TCP/TLS connection setup into the TCP helper thread: Connection setup takes awhile and before this it was being done while holding the monitor lock. 2.Moves TCP/TLS writing to the TCP helper thread: Through the use of a packet queue and an alert pipe, the TCP helper thread can now be woken up to write data as well as read data. 3.Locking error: sip_xmit returned an XMIT_ERROR without giving up the tcptls_session lock. This lock has been completely removed from sip_xmit and placed in the new sip_tcptls_write() function. 4.Memory leak: When creating a tcptls_client the tls_cfg was alloced but never freed unless the tcptls_session failed to start. Now the session_args for a sip client are an ao2 object which frees the tls_cfg on destruction. 5.Pointer to stack variable: During sip_prepare_socket the creation of a client's ast_tcptls_session_args was done on the stack and stored as a pointer in the newly created tcptls_session. Depending on the events that followed, there was a slight possibility that pointer could have been accessed after the stack returned. Given the new changes, it is always accessed after the stack returns which is why I found it. Notable code changes 1.I broke tcptls.c's ast_tcptls_client_start() function into two functions. One for creating and allocating the new tcptls_session, and a separate one for starting and handling the new connection. This allowed me to create the tcptls_session, launch the helper thread, and then establish the connection within the helper thread. 2.Writes to a tcptls_session are now done within the helper thread. This is done by using an alert pipe to wake up the thread if new data needs to be sent. The thread's sip_threadinfo object contains the alert pipe as well as the packet queue. 3.Since the threadinfo object contains the alert pipe, it must now be accessed outside of the helper thread for every write (queuing of a packet). For easy lookup, I moved the threadinfo objects from a linked list to an ao2_container. (closes issue #13136) Reported by: pabelanger Tested by: dvossel, whys (closes issue #15894) Reported by: dvossel Tested by: dvossel Review: https://reviewboard.asterisk.org/r/380/ ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@225489 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	c6a9fbf2c9	Merged revisions 225360 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r225360 | tilghman | 2009-10-22 12:11:23 -0500 (Thu, 22 Oct 2009) | 11 lines Merged revisions 225105 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r225105 | tilghman | 2009-10-21 11:02:12 -0500 (Wed, 21 Oct 2009) | 4 lines Fix documentation for ast_softhangup() and correct the misuse thereof. (closes issue #16103) Reported by: majorbloodnok ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@225363 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	4afb3624ba	Merged revisions 224856 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r224856 | tilghman | 2009-10-20 17:09:07 -0500 (Tue, 20 Oct 2009) | 12 lines Merged revisions 224855 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r224855 | tilghman | 2009-10-20 17:07:11 -0500 (Tue, 20 Oct 2009) | 5 lines Pay attention to the return value of the manipulate function. While this looks like an optimization, it prevents a crash from occurring when used with certain audiohook callbacks (diagnosed with SVN trunk, backported to 1.4 to keep the source consistent across versions). ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@224859 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Joshua Colp	d5dc087718	Merged revisions 224774 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r224774 | file | 2009-10-20 14:47:34 -0300 (Tue, 20 Oct 2009) | 12 lines Merged revisions 224773 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r224773 | file | 2009-10-20 14:46:37 -0300 (Tue, 20 Oct 2009) | 5 lines Add support for relaying early media in the features attended transfer option. (closes issue #14828) Reported by: licedey ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@224777 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Kevin P. Fleming	bac1e12c9e	Merged revisions 224671 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r224671 | kpfleming | 2009-10-19 18:47:39 -0500 (Mon, 19 Oct 2009) | 14 lines Merged revisions 224670 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r224670 | kpfleming | 2009-10-19 18:44:07 -0500 (Mon, 19 Oct 2009) | 7 lines Correct timestamp calculations when RTP sample rates over 8kHz are used. While testing some endpoints that support 16kHz and 32kHz sample rates, some log messages were generated due to calc_rxstamp() computing timestamps in a way that produced odd results, so this patch sanitizes the result of the computations. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@224674 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Russell Bryant	69130fc9dc	Merged revisions 223487 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r223487 | russell | 2009-10-11 12:25:42 -0500 (Sun, 11 Oct 2009) | 17 lines Merged revisions 223485-223486 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r223485 | russell | 2009-10-11 12:22:52 -0500 (Sun, 11 Oct 2009) | 6 lines Don't use data outside of its scope. The purpose of this code was to have a hangup frame put on the list of deferred frames. However, the code that read the hangup frame was outside of the scope of where the hangup frame was declared. ........ r223486 | russell | 2009-10-11 12:25:06 -0500 (Sun, 11 Oct 2009) | 2 lines Remove some unnecessary code. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@223490 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Matthew Nicholson	032c24dc56	Merged revisions 223273 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r223273 | mnicholson | 2009-10-09 13:34:08 -0500 (Fri, 09 Oct 2009) | 14 lines Merged revisions 223225 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r223225 | mnicholson | 2009-10-09 13:20:11 -0500 (Fri, 09 Oct 2009) | 8 lines Signal timeouts by returning AST_CONTROL_RINGING when originating calls. (closes issue #15104) Reported by: nblasgen Patches: manager-timeout1.diff uploaded by mnicholson (license 96) Tested by: nblasgen, mnicholson ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@223286 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Russell Bryant	bfd8af8cc8	Merged revisions 222880 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r222880 | russell | 2009-10-08 14:52:03 -0500 (Thu, 08 Oct 2009) | 51 lines Merged revisions 222878 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r222878 | russell | 2009-10-08 14:45:47 -0500 (Thu, 08 Oct 2009) | 44 lines Make filestream frame handling safer by isolating frames before returning them. This patch is related to a number of issues on the bug tracker that show crashes related to freeing frames that came from a filestream. A number of fixes have been made over time while trying to figure out these problems, but there re still people seeing the crash. (Note that some of these bug reports include information about other problems. I am specifically addressing the filestream frame crash here.) I'm still not clear on what the exact problem is. However, what is _very_ clear is that we have seen quite a few problems over time related to unexpected behavior when we try to use embedded frames as an optimization. In some cases, this optimization doesn't really provide much due to improvements made in other areas. In this case, the patch modifies filestream handling such that the embedded frame will not be returned. ast_frisolate() is used to ensure that we end up with a completely mallocd frame. In reality, though, we will not actually have to malloc every time. For filestreams, the frame will almost always be allocated and freed in the same thread. That means that the thread local frame cache will be used. So, going this route doesn't hurt. With this patch in place, some people have reported success in not seeing the crash anymore. (SWP-150) (AST-208) (ABE-1834) (issue #15609) Reported by: aragon Patches: filestream_frisolate-1.4.diff2.txt uploaded by russell (license 2) Tested by: aragon, russell (closes issue #15817) Reported by: zerohalo Tested by: zerohalo (closes issue #15845) Reported by: marhbere Review: https://reviewboard.asterisk.org/r/386/ ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@222883 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
David Vossel	d9a817f431	Merged revisions 222873 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r222873 | dvossel | 2009-10-08 14:35:30 -0500 (Thu, 08 Oct 2009) | 6 lines fixes an ast_netsock_list memory leak. ABE-1998 Review: https://reviewboard.asterisk.org/r/395/ ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@222874 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Kevin P. Fleming	6410aa2418	Merged revisions 222176 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r222176 | kpfleming | 2009-10-05 20:24:24 -0500 (Mon, 05 Oct 2009) | 27 lines Recorded merge of revisions 222152 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r222152 | kpfleming | 2009-10-05 20:16:36 -0500 (Mon, 05 Oct 2009) | 20 lines Fix ao2_iterator API to hold references to containers being iterated. See Mantis issue for details of what prompted this change. Additional notes: This patch changes the ao2_iterator API in two ways: F_AO2I_DONTLOCK has become an enum instead of a macro, with a name that fits our naming policy; also, it is now necessary to call ao2_iterator_destroy() on any iterator that has been created. Currently this only releases the reference to the container being iterated, but in the future this could also release other resources used by the iterator, if the iterator implementation changes to use additional resources. (closes issue #15987) Reported by: kpfleming Review: https://reviewboard.asterisk.org/r/383/ ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@222187 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Kevin P. Fleming	ba54bb0506	Merged revisions 222110 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r222110 | kpfleming | 2009-10-05 14:45:00 -0500 (Mon, 05 Oct 2009) | 25 lines Allow non-compliant T.38 endpoints to be supportable via configuration option. Many T.38 endpoints incorrectly send the maximum IFP frame size they can accept as the T38FaxMaxDatagram value in their SDP, when in fact this value is supposed to be the maximum UDPTL payload size (datagram size) they can accept. If the value they supply is small enough (a commonly supplied value is '72'), T.38 UDPTL transmissions will likely fail completely because the UDPTL packets will not have enough room for a primary IFP frame and the redundancy used for error correction. If this occurs, the Asterisk UDPTL stack will emit log messages warning that data loss may occur, and that the value may need to be overridden. This patch extends the 't38pt_udptl' configuration option in sip.conf to allow the administrator to override the value supplied by the remote endpoint and supply a value that allows T.38 FAX transmissions to be successful with that endpoint. In addition, in any SIP call where the override takes effect, a debug message will be printed to that effect. This patch also removes the T38FaxMaxDatagram configuration option from udptl.conf.sample, since it has not actually had any effect for a number of releases. In addition, this patch cleans up the T.38 documentation in sip.conf.sample (which incorrectly documented that T.38 support was passthrough only). (issue #15586) Reported by: globalnetinc ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@222113 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	9a537db364	Merged revisions 221971 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r221971 | tilghman | 2009-10-02 11:59:57 -0500 (Fri, 02 Oct 2009) | 9 lines Merged revisions 221970 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r221970 | tilghman | 2009-10-02 11:58:03 -0500 (Fri, 02 Oct 2009) | 2 lines Ensure the result of the hash function is positive. Negative array offsets suck. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@221974 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	8cd1873f08	Merged revisions 221920 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r221920 | tilghman | 2009-10-01 22:04:34 -0500 (Thu, 01 Oct 2009) | 4 lines Initialize a variable that we check immediately upon startup. (closes issue #15973) Reported by: atis ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@221923 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	a1458fef36	Merged revisions 221777 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r221777 | tilghman | 2009-10-01 18:59:15 -0500 (Thu, 01 Oct 2009) | 9 lines Merged revisions 221776 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r221776 | tilghman | 2009-10-01 18:53:12 -0500 (Thu, 01 Oct 2009) | 2 lines Fix a bunch of off-by-one errors ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@221780 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Kevin P. Fleming	f820a30e22	Merged revisions 221592 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r221592 | kpfleming | 2009-10-01 11:16:09 -0500 (Thu, 01 Oct 2009) | 12 lines Remove ability to control T.38 FAX error correction from udptl.conf. chan_sip has had the ability to control T.38 FAX error correction mode on a per-peer (or global) basis for a couple of releases now, which is where it should have been all along. This patch removes the ability to configure it in udptl.conf, but issues a warning if the user tries to do, telling them to look at sip.conf.sample for how to configure it now. For any SIP peers that are T.38 enabled in sip.conf, there is already a default for FEC error correction even if the user does not specify any mode, so this change will not turn off error correction by default, it will have the same default value that has been in the udptl.conf sample file. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@221622 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Terry Wilson	9a61ba3e28	Merged revisions 221266 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r221266 | twilson | 2009-09-30 12:52:30 -0500 (Wed, 30 Sep 2009) | 32 lines Merged revisions 221086 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r221086 | twilson | 2009-09-30 09:49:11 -0500 (Wed, 30 Sep 2009) | 25 lines Change the SSRC by default when our media stream changes Be default, change SSRC when doing an audio stream changes Asterisk doesn't honor marker bit when reinvited to already-bridged RTP streams,resulting in far-end stack discarding packets with "old" timestamps that areactually part of a new stream. This patch sends AST_CONTROL_SRCUPDATE whenever there is a reinvite, unless the 'constantssrc' is set to true in sip.conf. The original issue reported to Digium support detailed the following situation: ITSP <-> Asterisk 1.4.26.2 <-> SIP-based Application Server Call comes in fromITSP, Asterisk dials the app server which sends a re-invite back toAsterisk--not to negotiate to send media directly to the ITSP, but to indicatethat it's changing the stream it's sending to Asterisk. The app servergenerates a new SSRC, sequence numbers, timestamps, and sets the marker bit on the new stream. Asterisk passes through the teimstamp of the new stream, butdoes not reset the SSRC, sequence numbers, or set the marker bit. When the timestamp on the new stream is older than the timestamp on the originalstream, the ITSP (which doesn't know there has been any change) discards the newframes because it thinks they are too old. This patch addresses this by changing the SSRC on a stream update unless constantssrc=true is set in sip.conf. Review: https://reviewboard.asterisk.org/r/374/ ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@221304 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	cfbfe5a74e	Merged revisions 221201 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r221201 | tilghman | 2009-09-30 11:56:42 -0500 (Wed, 30 Sep 2009) | 14 lines Merged revisions 221200 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r221200 | tilghman | 2009-09-30 11:55:21 -0500 (Wed, 30 Sep 2009) | 7 lines Avoid a potential NULL dereference. (closes issue #15865) Reported by: kobaz Patches: 20090915__issue15865.diff.txt uploaded by tilghman (license 14) Tested by: kobaz ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@221204 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
David Vossel	f5edb25e1c	Merged revisions 220365 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r220365 | dvossel | 2009-09-24 15:37:20 -0500 (Thu, 24 Sep 2009) | 8 lines fixes tcptls_session memory leak caused by ref count error (closes issue #15939) Reported by: dvossel Review: https://reviewboard.asterisk.org/r/375/ ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@220369 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	94740de344	Merged revisions 220289 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r220289 | tilghman | 2009-09-24 14:41:02 -0500 (Thu, 24 Sep 2009) | 13 lines Merged revisions 220288 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r220288 | tilghman | 2009-09-24 14:39:41 -0500 (Thu, 24 Sep 2009) | 6 lines Implicitly sending a progress signal breaks some applications. Call Progress() in your dialplan if you explicitly want progress to be sent. (Reverts change 216430, closes issue #15957) Reported by: Pavel Troller on the Asterisk-Dev mailing list http://lists.digium.com/pipermail/asterisk-dev/2009-September/039897.html ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@220292 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	dbecaa986b	Merged revisions 219654 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r219654 | tilghman | 2009-09-20 12:55:49 -0500 (Sun, 20 Sep 2009) | 15 lines Merged revisions 219653 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r219653 | tilghman | 2009-09-20 12:52:05 -0500 (Sun, 20 Sep 2009) | 8 lines Really stop the stream, when ast_closestream() is called. (closes issue #15129) Reported by: bmh Patches: 20090918__issue15129.diff.txt uploaded by tilghman (license 14) Review: https://reviewboard.asterisk.org/r/372/ ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@219669 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Matthew Nicholson	5eb7d1c6b1	Merged revisions 219139 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r219139 | mnicholson | 2009-09-17 10:18:01 -0500 (Thu, 17 Sep 2009) | 17 lines Merged revisions 219136 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r219136 | mnicholson | 2009-09-17 09:58:39 -0500 (Thu, 17 Sep 2009) | 10 lines Prevent a potential race condition and crash when hanging up a channel by removing the channel from the channel list before begining channel tear down. This fix may potentially cause problems with CDR backends that access the channel a CDR is associated with via the channel list. This fix makes the channel unavabile at the time when the CDR backend is invoked. This has been documented in include/asterisk/cdr.h. (closes issue #15316) Reported by: vmarrone Tested by: mnicholson Review: https://reviewboard.asterisk.org/r/362/ ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@219194 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	eb13d6330b	Merged revisions 219061 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r219061 | tilghman | 2009-09-16 18:42:12 -0500 (Wed, 16 Sep 2009) | 15 lines Merged revisions 219023 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r219023 | tilghman | 2009-09-16 18:21:53 -0500 (Wed, 16 Sep 2009) | 8 lines Properly deal with quotes in the arguments of '#exec' includes. (closes issue #15583) Reported by: pkempgen Patches: 20090726__issue15583.diff.txt uploaded by tilghman (license 14) 20090726__issue15583-1.4-4.diff.txt uploaded by pkempgen (license 169) Tested by: pkempgen ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@219063 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
David Brooks	53b7849750	Merged revisions 218868 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r218868 | dbrooks | 2009-09-16 13:06:42 -0500 (Wed, 16 Sep 2009) | 20 lines Merged revisions 218867 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r218867 | dbrooks | 2009-09-16 13:00:45 -0500 (Wed, 16 Sep 2009) | 13 lines Fixes CID pattern matching behavior to mirror that of extension pattern matching. Pattern matching for extensions uses a type of scoring system, giving values for specificity to each character in the pattern. Unfortunately, this is done character by character, in order. This does lead to some less specific patterns being first in line for matching, but it will usually get the job done. This patch merely brings CID matching to the same level as extension matching. This patch does not attempt to tackle the problem shared by extension matching. (closes issue #14708) Reported by: klaus3000 ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@218938 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Joshua Colp	49ba3d9752	Merged revisions 218295 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r218295 | file | 2009-09-14 13:16:39 -0500 (Mon, 14 Sep 2009) | 2 lines Do not attempt to add a parking extension if an error occurred while reading the configuration. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@218300 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	d392fb412c	Merged revisions 218050 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r218050 | tilghman | 2009-09-11 00:58:11 -0500 (Fri, 11 Sep 2009) | 3 lines Check the origination priority for more matches, not the current priority. Found by Pavel Troller on the -dev list. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@218055 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Olle Johansson	9e57fd58e2	Merged revisions 216438 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r216438 | oej | 2009-09-04 16:02:34 +0200 (Fre, 04 Sep 2009) | 35 lines Merged revisions 216430 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r216430 | oej | 2009-09-04 15:45:48 +0200 (Fre, 04 Sep 2009) | 27 lines Make apps send PROGRESS control frame for early media and fix too early media issue in SIP The issue at hand is that some legacy (dying) PBX systems send empty media frames on PRI links *before* any call progress. The SIP channel receives these frames and by default signals 183 Session progress and starts sending media. This will cause phones to play silence and ignore the later 180 ringing message. A bad user experience. The fix is twofold: - We discovered that asterisk apps that support early media ("noanswer") did not send any PROGRESS frame to indicate early media. Fixed. - We introduce a setting in chan_sip so that users can disable any relay of media frames before the outbound channel actually indicates any sort of call progress. In 1.4, 1.6.0 and 1.6.1, this will be disabled for backward compatibility. In later versions of Asterisk, this will be enabled. We don't assume that it will change your Asterisk phone experience - only for the better. We encourage third-party application developers to make sure that if they have applications that wants to send early media, add a PROGRESS control frame transmission to make sure that all channel drivers actually will start sending early media. This has not been the default in Asterisk previous to this patch, so if you got inspiration from our code, you need to update accordingly. Sorry for the trouble and thanks for your support. This code has been running for a few months in a large scale installation (over 250 servers with PRI and/or BRI links to old PBX systems). That's no proof that this is an excellent patch, but, well, it's tested :-) ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@216647 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	9c7b554a2b	Merged revisions 216547 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r216547 | tilghman | 2009-09-04 12:31:44 -0500 (Fri, 04 Sep 2009) | 3 lines Enable turning off the application delimiter warning with the 'dontwarn' option. Suggested on the -dev list, and implemented in an alternate way by me. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@216550 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Michiel van Baak	c099071716	Merged revisions 216506 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r216506 | mvanbaak | 2009-09-04 17:05:05 +0200 (Fri, 04 Sep 2009) | 9 lines Merged revisions 216435 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r216435 | mvanbaak | 2009-09-04 15:56:10 +0200 (Fri, 04 Sep 2009) | 2 lines make asterisk compile under devmode with DEBUG_THREADS enabled on OpenBSD ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@216509 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Michiel van Baak	1f52ecb3ed	Merged revisions 216222 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r216222 | mvanbaak | 2009-09-04 08:08:33 +0200 (Fri, 04 Sep 2009) | 3 lines make sure 'start' is always initialized. Makes asterisk compile with --enable-dev-mode ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@216225 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
David Vossel	574c8c2144	Merged revisions 215955 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r215955 | dvossel | 2009-09-03 11:31:54 -0500 (Thu, 03 Sep 2009) | 6 lines Merge code associated with AST-2009-006 (closes issue #12912) Reported by: rathaus Tested by: tilghman, russell, dvossel, dbrooks ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@216007 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Olle Johansson	c73b17515c	Fix bad reports in "sip show channelstats". ... Not directly mergeable in svn trunk, needs more tests, therefore committed directly to 1.6.2. (closes issue #15819) Reported by: klaus3000 Patches: asterisk-1.6.2-beta4-sipshowchannelstats-patch-0.2.txt uploaded by klaus3000 (license 65) Tested by: klaus3000, oej git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@215887 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Michiel van Baak	a2d71f3a34	Merged revisions 215622 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r215622 | mvanbaak | 2009-09-02 22:21:51 +0200 (Wed, 02 Sep 2009) | 4 lines - lock channel before looking for a channel variable - Init the parkings list member of struct parkinglot. Thanks Sean for the explanation why this should be here. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@215647 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	42a5345e8f	Merged revisions 215567 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r215567 | tilghman | 2009-09-02 13:37:25 -0500 (Wed, 02 Sep 2009) | 9 lines Close up to the soft open file limit (same on Linux, but varies drastically on OS X). Also, a Makefile fix for Darwin (OS X). (closes issue #14542) Reported by: jtodd Patches: 20090901__issue14542.diff.txt uploaded by tilghman (license 14) Tested by: jtodd, tilghman Change-type: bugfix ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@215570 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Kevin P. Fleming	263958f5b4	Merged revisions 215161 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r215161 | kpfleming | 2009-09-01 14:50:48 -0500 (Tue, 01 Sep 2009) | 3 lines Ensure that frame dumps of AST_CONTROL_T38_PARAMETERS frames are properly decoded. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@215165 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	99581db532	Merged revisions 214702 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r214702 | tilghman | 2009-08-28 15:14:39 -0500 (Fri, 28 Aug 2009) | 15 lines Merged revisions 214701 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r214701 | tilghman | 2009-08-28 15:13:32 -0500 (Fri, 28 Aug 2009) | 8 lines Modify comment to be a bit more accurate. We have kept this comment around long enough, that it's pretty clear that we're keeping the code, because changing the code would require a pretty fundamental architectural shift. We've also taken criticism in some quarters, because it was believed that it was referring to the code being nasty. No, the code isn't nasty, just the operation itself is rather odd. Fixed for eternity (probably not). ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@214707 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	d0ee8a5b71	Merged revisions 214514 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r214514 | tilghman | 2009-08-27 16:26:37 -0500 (Thu, 27 Aug 2009) | 7 lines Ensure that we check for the special value CONFIG_STATUS_FILEINVALID. (closes issue #15786) Reported by: a_villacis Patches: asterisk-1.6.2.0-beta4-manager-fix-crash-on-include-nonexistent-file.patch uploaded by a villacis (license 660) (Plus a few of my own, to catch the remaining places within manager.c where it could have been a problem) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@214515 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
David Vossel	112fb69d3b	Merged revisions 214195 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r214195 | dvossel | 2009-08-26 11:38:53 -0500 (Wed, 26 Aug 2009) | 25 lines Merged revisions 214194 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r214194 | dvossel | 2009-08-26 11:36:42 -0500 (Wed, 26 Aug 2009) | 19 lines ast_write() ignores ast_audiohook_write() results In ast_write(), if a channel has a list of audiohooks, those lists are written to and the resulting frame is what ast_write() should continue with. The problem was the returned audiohook frame was not being handled at all, and the original frame passed into it did not contain the mixed audio, so essentially audio was being lost. One result of this was chan_spy's whisper mode no longer worked. To complicate the issue, frames passed into ast_write may either be a single frame, or a list of frames. So, as the list of frames is processed in the audiohook_write, the returned frames had to be added to a new list. (closes issue #15660) Reported by: corruptor Tested by: dvossel ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@214196 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	9ed28f265e	Merged revisions 214071 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r214071 | tilghman | 2009-08-25 14:32:48 -0500 (Tue, 25 Aug 2009) | 17 lines Merged revisions 214068-214069 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r214068 | tilghman | 2009-08-25 14:26:50 -0500 (Tue, 25 Aug 2009) | 6 lines Fix pronunciation of German dates. (closes issue #15273) Reported by: Benjamin Kluck Patches: say_c.patch uploaded by Benjamin Kluck (license 803) ........ r214069 | tilghman | 2009-08-25 14:28:42 -0500 (Tue, 25 Aug 2009) | 2 lines I should always compile before committing... ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@214074 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	69a31d3172	Merged revisions 213971 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r213971 | tilghman | 2009-08-25 01:35:37 -0500 (Tue, 25 Aug 2009) | 14 lines Merged revisions 213970 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r213970 | tilghman | 2009-08-25 01:34:44 -0500 (Tue, 25 Aug 2009) | 7 lines Improve error message by informing user exactly which function is missing a parethesis. (closes issue #15242) Reported by: Nick_Lewis Patches: pbx.c-funcparenthesis.patch2 uploaded by dbrooks (license 790) pbx.c-funcparenthesis-1.4.diff uploaded by loloski (license 68) ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@213974 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Terry Wilson	799d82c73e	Merged revisions 213450 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r213450 | twilson | 2009-08-20 22:48:54 -0500 (Thu, 20 Aug 2009) | 2 lines Make LOAD_ORDER actually work ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@213453 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Matthew Nicholson	f5488f80ac	Merged revisions 213327 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r213327 | mnicholson | 2009-08-20 15:29:32 -0500 (Thu, 20 Aug 2009) | 7 lines Fix a crash by checking the proper pointer for validity before deferencing it. (closes issue #15751) Reported by: atis Patches: ast_bridge_call_peer_cdr.patch uploaded by atis (license 242) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@213350 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Jason Parker	8212d18e31	Merged revisions 213179 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r213179 | qwell | 2009-08-19 17:38:46 -0500 (Wed, 19 Aug 2009) | 5 lines Fix compile when certain G711 menuselect options are enabled. (closes issue #15697) Reported by: slavon ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@213182 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Russell Bryant	81ecc23e9a	Merged revisions 213046 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r213046 | russell | 2009-08-19 10:32:18 -0500 (Wed, 19 Aug 2009) | 4 lines Don't blow up on a NULL cdr. Reported in #asterisk-dev. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.2@213047 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago