4927 Commits (8d22e7e6cfebc730b1df73471b58facdfbcc89e7)

Author	SHA1	Message	Date
Corey Farrell	d4e69edbdd	Fix GCC 8 build issues. ... This fixes build warnings found by GCC 8. In some cases format truncation is intentional so the warning is just suppressed. ASTERISK-27824 #close Change-Id: I724f146cbddba8b86619d4c4a9931ee877995c84	8 years ago
Jenkins2	c2a2e2bad4	Merge "app_macro: Prevent infinite loop in find_matching_priority." into 15	8 years ago
Corey Farrell	c60c019511	app_macro: Prevent infinite loop in find_matching_priority. ... Use AST_PBX_MAX_STACK to escape if we recurse 128 times. This will prevent crash if dialplan contains an include loop. Log an error when this occurs, at most one message per call to Macro() so we avoid logger spam. ASTERISK-26570 #close Change-Id: I6c71b76998c31434391b150de055ae9a531e31da	8 years ago
Jenkins2	15c1bc6ff1	Merge "app_sendtext: Enhance SendText to support Enhanced Messaging" into 15	8 years ago
Jenkins2	4a56bf3b36	Merge ""confbridge show profile bridge" does not output "sfu" when video_mode is sfu" into 15	8 years ago
Chris-Savinovich	3543bb83bd	"confbridge show profile bridge" does not output "sfu" when video_mode is sfu ... Fixes a bug on the "confbridge show profile bridge" cli command that showed "video_mode=no video" when video_mode was set to "sfu" ASTERISK-27418 #close Change-Id: I481e3172c7f872664c7ac7809879d541c9f031e9	8 years ago
Joshua Colp	5c2120f5f5	bridge_softmix / app_confbridge: Add support for REMB combining. ... This change adds the ability for multiple REMB reports in bridge_softmix to be combined according to a configured behavior into a single report. This single report is sent back to the sender of video, which adjusts the encoding bitrate to be at or below the bitrate of the report. The available behaviors are: lowest, highest, and average. Lowest uses the lowest received bitrate. Highest uses the highest received bitrate. Average goes through the received bitrates adding them to the previous average and creates a new average. Other behaviors can be added in the future and the existing average one may be adjusted, but this provides the foundation to do so. Support for configuring which behavior to use has been added to app_confbridge. ASTERISK-27804 Change-Id: I9eafe4e7c1f72d67074a8d6acb26bfcf19322b66	8 years ago
George Joseph	50b133e133	app_sendtext: Enhance SendText to support Enhanced Messaging ... SendText now accepts new channel variables that can be used to override the To and From display names and set the Content-Type of a message. Since you can now set Content-Type, other text/* content types are now valid. Change-Id: I648b4574478119f95de09d9f08e9595831b02830	8 years ago
Joshua Colp	f2a9129d8c	Merge "app_confbridge / bridge_softmix: Add ability to configure REMB interval." into 15	8 years ago
Richard Mudgett	1790ffb390	app_agent_pool.c: Fix off nominal ref leak. ... Change-Id: Ib427ffc2c802620eaafb08b1c2a17dddd8fb8eb6	8 years ago
Joshua Colp	132fd2abdb	app_confbridge / bridge_softmix: Add ability to configure REMB interval. ... This change adds a configuration option to app_confbridge which can be used to set the interval at which we will send a combined REMB (remote estimated maximum bitrate) frame to sources of video. The bridging API has also been extended slightly to allow setting this so bridge_softmix can use it. ASTERISK-27786 Change-Id: I0e49eae60f369c86434414f3cb8278709c793c82	8 years ago
Joshua Colp	e5fe633075	Merge "BuildSystem: Remove unused dependency on libltdl." into 15	8 years ago
Jenkins2	7ce871f81d	Merge "app_dial: Enable early-media video" into 15	8 years ago
Alexander Traud	57ed69dcd4	BuildSystem: Remove unused dependency on libltdl. ... Asterisk does not need the development package of libltdl, because it does not use any symbol of -lltdl directly. Instead, it uses the runtime package via the shared library -lodbc. On the supported platforms, that shared library declares its dependency on -lltdl correctly, otherwise AST_EXT_LIB_CHECK would have failed. ASTERISK-27745 Change-Id: Icd315809b8e7978203431f3afb66240dd3a040ba	8 years ago
Florian Floimair	a316cb78b7	app_dial: Enable early-media video ... Certain applications (e.g. door-phone) require that also video is transmitted before a call is accepted. Change-Id: I9842e1dc2f6e1c2c49dc33fe615255007d2f821e	8 years ago
George Joseph	2ef947555b	app_voicemail: Fix json blob errors ... When app_voicemail calls ast_test_suite_notify with the results of a user keypress, it formats the keypress as '%c'. If the user hung up or some other error occurrs, the result of the keypress is a non printable character. This ultimately causes json_vpack_ex to think it's being passed a non utf-8 string and return an error. * Keypress results passed to ast_test_suite_notify are now checked with isprint() and a '?' is substituted if the check fails. Change-Id: I78ee188916bbac840f3d03f40201b692347ea865	8 years ago
Jenkins2	6c354cc3f3	Merge "Replace direct checks of option_debug with DEBUG_ATLEAST macro." into 15	8 years ago
Kevin Harwell	a458008a54	Merge "voicemail: Fixed wrong voicemail message count" into 15	8 years ago
Corey Farrell	852ef63964	Replace direct checks of option_debug with DEBUG_ATLEAST macro. ... Checking option_debug directly is incorrect as it ignores file/module specific debug settings. This system-wide change replaces nearly all direct checks for option_debug with the DEBUG_ATLEAST macro. Change-Id: Ic342d4799a945dbc40ac085ac142681094a4ebf0	8 years ago
Sungtae Kim	80113ec68d	voicemail: Fixed wrong voicemail message count ... Fixed wrong voicemail mailbox reference for Action: VoicemailUsersList. ASTERISK-27703 Change-Id: I99bfec14bd4ae475b0fa1fac5a7992f3e2e8d64a	8 years ago
Michael Cargile	66da3570fe	apps/app_amd.c: Fixed total time and silence calculations ... Between Asterisk 11 and Asterisk 13 there was a significant increase in the number of AST_FRAME_NULL frames being processed by app_amd.c's main loop. Each AST_FRAME_NULL frame was being counted as 100ms towards the total time and silence. This may have been accurate when app_amd.c was orginally added, but it is not in Asterisk 13. As such the total analysis time and silence calculations were way off effectively breaking app_amd.c * Additional debug messages were added * AST_FRAME_NULL are now ignored ASTERISK-27610 Change-Id: I18aca01af98f87c1e168e6ae0d85c136d1df5ea9	8 years ago
Richard Mudgett	c2684729a5	app_confbridge: ConfbridgeList event has standard channel shapshot headers. ... * Made the AMI ConfbridgeList action's ConfbridgeList events output all the standard channel snapshot headers instead of a few hand-coded channel snapshot headers. The benefit is that the CallerIDName gets disruptive characters like CR, LF, Tab, and a few others escaped. However, an empty CallerIDName is now output as "<unknown>" instead of "<no name>". ASTERISK-27651 Change-Id: Iaf7d54a9d40194c2db060bc9b4979fab6720d977	8 years ago
Richard Mudgett	a0ec3fcbaa	app_confbridge: Add the Muted header to ConfbridgeJoin AMI event. ... ASTERISK-27651 Change-Id: Idef2ca54d242d1b894efd3fc7b360bc6fd5bdc34	8 years ago
Jenkins2	da3bcd4feb	Merge "app_confbridge: Update dsp_silence_threshold and dsp_talking_threshold docs." into 15	8 years ago
Richard Mudgett	447fc8cc0a	app_confbridge: Update dsp_silence_threshold and dsp_talking_threshold docs. ... The dsp_talking_threshold does not represent time in milliseconds. It represents the average magnitude per sample in the audio packets. This is what the DSP uses to determine if a packet is silence or talking/noise. Change-Id: If6f939c100eb92a5ac6c21236559018eeaf58443	8 years ago
Alexander Traud	0126c0eeb3	app_voicemail: Avoid always true when using pointer address. ... clang 4.0 warned about this. ASTERISK-27635 Change-Id: I213f230607d7fbe97c0f5f2d60da9cbf5a2d8231	8 years ago
ghjm	d4e9985b27	app_followme: Add a prompt to be read when a call is connected ... This patch adds the ability to configure a prompt which will be read to the "winner" who pressed 1 (or the configured value) and received the call. ASTERISK-24372 #close Change-Id: I6ec1c6c883347f7d1e1f597189544993c8d65272	8 years ago
Alexander Traud	e6837e2123	app_osplookup.c: Avoid two format truncations. ... GCC 7 warned about this. ASTERISK-27578 Change-Id: I4a00458dbe9b575ef04338b6a7852272745e1552	8 years ago
Corey Farrell	7abf373139	app_confbridge: Fix NULL check in action_kick_last. ... The check for last_user == NULL needs to happen before we dereference the variable, previously it was possible for us to check flags of a NULL last_user. Change-Id: I274f737aa8af9d2d53e4a78cdd7ad57561003945	8 years ago
Alexander Traud	c33da7be98	General: Avoid implicit conversion to char when changes value to negative. ... clang 5.0 warned about this. ASTERISK-27557 Change-Id: I7cceaa88e147cbdf81a3a7beec5c1c20210fa41e	8 years ago
Sean Bright	b64c02e414	Remove as much trailing whitespace as possible. ... Change-Id: I873c1c6d00f447269bd841494459efccdd2c19c0	8 years ago
Jenkins2	18ac9fad31	Merge "app_voicemail: Fix file copy error handling." into 15	8 years ago
Jenkins2	b910a00bc1	Merge "Fix Common Typo's." into 15	8 years ago
Corey Farrell	57af855ef2	app_voicemail: Fix file copy error handling. ... Fix error where input/output file descriptors would be closed multiple times. Change-Id: Iba5140b60cb7de79e3d5d92be3c256947aa99da9	8 years ago
Corey Farrell	70cd4430a4	Fix Common Typo's. ... Fix instances of: * Retreive * Recieve * other then * different then * Repeated words ("the the", "an an", "and and", etc). * othterwise, teh ASTERISK-24198 #close Change-Id: I3809a9c113b92fd9d0d9f9bac98e9c66dc8b2d31	8 years ago
Corey Farrell	e90470700b	app_festival: Fix fd leak on connection failure. ... Change-Id: If5efaddcf735ff7d17e55c36cc1388946cee9e0f	8 years ago
Corey Farrell	a2a1425ed6	app_voicemail: Fix memory management issues. ... * mwi_sub_event_cb: mwist leaked on separate_mailbox failure. * add_email_attachment: A reference to sox_gain_tmpdir was used after the storage was out of scope. Change-Id: I6282c542ff7b82fa091177a912d11234a8b00a30	8 years ago
Joshua Colp	bac31e55bb	Merge changes from topic 'faster-aco' into 15 ... * changes: aco: Minimize use of regex. aco: Create ways to minimize use of regex.	8 years ago
Joshua Colp	9ff63ef7fa	app_transfer: Remove LOCAL from documentation. ... The Local channel has never supported app_transfer from what I can see so remove it from the documentation. ASTERISK-25649 Change-Id: Icbcfe297f6f866285a26b3e9fd5c6d00fa22e0e9	8 years ago
Corey Farrell	957709e1e8	aco: Minimize use of regex. ... Remove nearly all use of regex from ACO users. Still remaining: * app_confbridge has a legitamate use of option name regex. * ast_sorcery_object_fields_register is implemented with regex, all callers use simple prefix based regex. I haven't decided the best way to fix this in both 13/15 and master. Change-Id: Ib5ed478218d8a661ace4d2eaaea98b59a897974b	8 years ago
Ivan Poddubny	61362f247e	app_queue: Fix extension state subscriptions removed on dialplan reload ... The approach with having a single global subscription to all extension state changes has one issue: dynamically created hints don't have any watchers and are therefore garbage collected on the first dialplan reload. This change creates a state subscription for every queue member with a hint as state_interface, thus increasing the count of watches for hints, so they are not destroyed prematurely anymore. There are 2 side effects: 1. The state change callback in app_queue is not executed when there are no members referring to the extension. 2. The callback is called multiple times for the same hint if it's associated with more than one queue member. Reported by: Steven T. Wheeler ASTERISK-18411 #close Change-Id: I4956af2136ea2a7f110ac9272eae5f6e676d8f89	8 years ago
Sean Bright	f9c6f69205	utils: Add convenience function for setting fd flags ... There are many places in the code base where we ignore the return value of fcntl() when getting/setting file descriptior flags. This patch introduces a convenience function that allows setting or clearing file descriptor flags and will also log an error on failure for later analysis. Change-Id: I8b81901e1b1bd537ca632567cdb408931c6eded7	8 years ago
Sungtae Kim	30db6bb1a0	Add new object for VoicemailUserEntry ... Currently, when the app_voicemail sending VoicemailUserEntry AMI event, there's no OldMessageCount info for default. To check the OldMessageCount info, it required IMAP_STORAGE define, but this is not correct. Added OldMessageCount item as a default. ASTERISK-27456 Change-Id: I5c71521c2d1daf8b7b161e31c34d28cca6aea4c7	8 years ago
Corey Farrell	0e2385581b	Loader: Remove unneeded load_pri declarations. ... Instead of specifying AST_MODFLAG_LOAD_ORDER with load_pri AST_MODPRI_DEFAULT just use AST_MODFLAG_DEFAULT. Change-Id: I0123258eafce324249433a69df15a85cc16e509f	8 years ago
Corey Farrell	19ba25dd96	app_minivm: Fix possible uninitialized return value. ... Declare 'res' initialized to -1 to deal with earlier error paths that could cause 'res' to be returned uninitialized. Change-Id: I8ac2a5755bf4174d89ef893e924c940f702b104e	8 years ago
George Joseph	89997cc003	app_record: Don't set RECORD_STATUS chan var until file is closed ... We've been calling pbx_builtin_setvar_helper to set the RECORD_STATUS variable before actually closing the recorded file. If a client is watching VarSet events and tries to do something with the file when a RECORD_STATUS event is seen, they might attempt to do so while the file it's still open. We now delay calling pbx_builtin_setvar_helper until after we close the file. ASTERISK-27423 Change-Id: I7fe9de99953e46b4bafa2b38cf151fe8f6488254	8 years ago
Richard Mudgett	be08bb6076	Fix ast_(v)asprintf() malloc failure usage conditions. ... When (v)asprintf() fails, the state of the allocated buffer is undefined. The library had better not leave an allocated buffer as a result or no one will know to free it. The most likely way it can return failure is for an allocation failure. If the printf conversion fails then you actually have a threading problem which is much worse because another thread modified the parameter values. * Made __ast_asprintf()/__ast_vasprintf() set the returned buffer to NULL on failure. That is much more useful than either an uninitialized pointer or a pointer that has already been freed. Many uses won't have to check for failure to ensure that the buffer won't be double freed or prevent an attempt to free an uninitialized pointer. * stasis.c: Fixed memory leak in multi_object_blob_to_ami() allocated by ast_asprintf(). * ari/resource_bridges.c:ari_bridges_play_helper(): Remove assignment to the wrong thing which is now not needed even if assigning to the right thing. Change-Id: Ib5252fb8850ecf0f78ed0ee2ca0796bda7e91c23	8 years ago
Corey Farrell	9897675b35	Add missing menuselect dependencies. ... This adds menuselect dependencies for modules that use symbols of other modules. ASTERISK-27390 Change-Id: Ia2d2849f5b87a72af7324a82edc3f283eafb5385	8 years ago
Joshua Colp	4c4622ef64	Merge "Modules: Fix issues with CLI completion." into 15	8 years ago
Corey Farrell	57f5335278	Modules: Fix issues with CLI completion. ... * Stop using ast_module_helper to check if a module is loaded, use ast_module_check instead (app_confbridge and app_meetme). * Stop ast_module_helper from listing reload classes when needsreload was not requested. ASTERISK-27378 Change-Id: Iaed8c1e4fcbeb242921dbac7929a0fe75ff4b239	8 years ago