4792 Commits (85ffedabd1306822bf38ad6ad408a586d89ba0fc)

Author	SHA1	Message	Date
Joshua Colp	83dffa6088	Merge "Loader: Remove unneeded load_pri declarations." into 13	8 years ago
Corey Farrell	8971a7ff3c	Loader: Remove unneeded load_pri declarations. ... Instead of specifying AST_MODFLAG_LOAD_ORDER with load_pri AST_MODPRI_DEFAULT just use AST_MODFLAG_DEFAULT. Change-Id: I0123258eafce324249433a69df15a85cc16e509f	8 years ago
Corey Farrell	3dca4c7742	app_minivm: Fix possible uninitialized return value. ... Declare 'res' initialized to -1 to deal with earlier error paths that could cause 'res' to be returned uninitialized. Change-Id: I8ac2a5755bf4174d89ef893e924c940f702b104e	8 years ago
George Joseph	7e874eae7a	app_record: Don't set RECORD_STATUS chan var until file is closed ... We've been calling pbx_builtin_setvar_helper to set the RECORD_STATUS variable before actually closing the recorded file. If a client is watching VarSet events and tries to do something with the file when a RECORD_STATUS event is seen, they might attempt to do so while the file it's still open. We now delay calling pbx_builtin_setvar_helper until after we close the file. ASTERISK-27423 Change-Id: I7fe9de99953e46b4bafa2b38cf151fe8f6488254	8 years ago
Richard Mudgett	9013415593	Fix ast_(v)asprintf() malloc failure usage conditions. ... When (v)asprintf() fails, the state of the allocated buffer is undefined. The library had better not leave an allocated buffer as a result or no one will know to free it. The most likely way it can return failure is for an allocation failure. If the printf conversion fails then you actually have a threading problem which is much worse because another thread modified the parameter values. * Made __ast_asprintf()/__ast_vasprintf() set the returned buffer to NULL on failure. That is much more useful than either an uninitialized pointer or a pointer that has already been freed. Many uses won't have to check for failure to ensure that the buffer won't be double freed or prevent an attempt to free an uninitialized pointer. * stasis.c: Fixed memory leak in multi_object_blob_to_ami() allocated by ast_asprintf(). * ari/resource_bridges.c:ari_bridges_play_helper(): Remove assignment to the wrong thing which is now not needed even if assigning to the right thing. Change-Id: Ib5252fb8850ecf0f78ed0ee2ca0796bda7e91c23	8 years ago
Corey Farrell	7c35740ba1	Add missing menuselect dependencies. ... This adds menuselect dependencies for modules that use symbols of other modules. ASTERISK-27390 Change-Id: Ia2d2849f5b87a72af7324a82edc3f283eafb5385	8 years ago
Jenkins2	6b14200093	Merge "Modules: Fix issues with CLI completion." into 13	8 years ago
Corey Farrell	cee81b3c8b	Modules: Fix issues with CLI completion. ... * Stop using ast_module_helper to check if a module is loaded, use ast_module_check instead (app_confbridge and app_meetme). * Stop ast_module_helper from listing reload classes when needsreload was not requested. ASTERISK-27378 Change-Id: Iaed8c1e4fcbeb242921dbac7929a0fe75ff4b239	8 years ago
Igor Goncharovskiy	8436f1d35a	app_agent_spool: Fix typo in dtmf features usage desctiption ... Fix typo, that specify usage wrong option 'dtmf-features' for CHANNEL() function instead of correct 'dtmf_features' ASTERISK-27377 #close Change-Id: I15ecc829c1035b359584673e12cdb5c9291ac930	8 years ago
Richard Mudgett	2db97ee219	app_voicemail.c: Fix compiler warning with IMAP build. ... ASTERISK-27181 Change-Id: Ic4468b49860bd7f67e922baf4c9e96828c184d17	8 years ago
Richard Mudgett	b4cb0050bd	app_agent_pool.c: Fix online documentation typo. ... Change-Id: Ib0bc95fd0ec288c78c313823254d7a84ebfc4429	8 years ago
Jenkins2	4a2caab4f6	Merge "app_originate: Set ORIGINATE_STATUS correctly on failure" into 13	8 years ago
Nathan Bruning	416e35589e	app_queue.c: clear moh field in init_queue ... ASTERISK-27301 #close Change-Id: Ic31361f34e2de3b6470e68fc37205a7711082eba	8 years ago
Sean Bright	e71a65a358	app_originate: Set ORIGINATE_STATUS correctly on failure ... We were ignoring the return value from ast_pbx_outgoing_exten() and ast_pbx_outgoing_app() which could fail before setting the reason code. This resulted in failures being reported as success. ASTERISK-25266 #close Reported by: Allen Ford Change-Id: Idf16237b7e41b527d2c69c865829128686beeb3b	8 years ago
Richard Mudgett	0945f10d3b	app_queue.c: Fix announcements when announce-to-first-user not enabled. ... The previous patch for ASTERISK-27216 made it so you wouldn't get any position or periodic announcements unless you had announce-to-first-user enabled. The announce-to-first-user feature was added by ASTERISK_21782 as a result of the patch which introduced the redundant announcements that ASTERISK-27216 removes. * By noting that the makeannouncement variable is used to suppresses the first user announcement, we set its initial value to the announce-to-first-user enable setting. ASTERISK-27216 Change-Id: Ieaeb7dbea8ae7073086b775fbafe0625b000b10a	8 years ago
Jenkins2	df17e01274	Merge "app_queue: Only do announcement logic between ringing cycles" into 13	8 years ago
George Joseph	690f7f7c76	build: A few gcc 7 error fixes ... Change-Id: I7b5300fbf1af7d88d47129db13ad6dbdc9b553ec	8 years ago
StefanEng86	0adf6f3bd9	app_queue: Only do announcement logic between ringing cycles ... This patch reverts the change by patch 2263 from old reviewboard. Note that reverting that 2263-patch still preserves the behaviour that the commit log of the 2263-patch claimed to add. The reason for this is: The function wait_for_answer is only called from try_calling which in turn is only called from the main for loop in queue_exec, and earlier in that loop we already check the things that's removed by this patch. There's no need to check those things twice each loop iteration, and I think the proper place to check it is before each ringing cycle. By checking it in wait_for_answer, you allow the issue explained in the jira - that the head caller hears announcements while the agents' sip phones are actively ringing. Reported-by: Stefan Engström Tested-by: Stefan Engström ASTERISK-27216 #close Change-Id: Ic4290dc75256f9743900c6762ee1bb915f672db0	8 years ago
Jenkins2	63211cc0ff	Merge "app_waitforsilence: Cleanup & don't treat missing frames as 'noise'" into 13	8 years ago
Sean Bright	e4797b2cbd	app_waitforsilence: Cleanup & don't treat missing frames as 'noise' ... * WaitForSilence completes successfully if it receives no media in the specified timeout, but when acting as WaitForNoise that logic needs to be reversed. * Use standard argument parsing macros and add some error checking for invalid values. * The documentation indicated that the first argument to both WaitForSilence and WaitForNoise was required when it was not. Update the documentation to reflect that. * Wrap up some behavior in structs to avoid boolean checks all over the place. ASTERISK-24066 #close Reported by: M vd S Change-Id: I01d40adc5b63342bb5018a1bea2081a0aa191ef9	8 years ago
Sean Bright	5f4863d4f9	app_directory: Handle a NULL mailbox without crashing ... ASTERISK-27241 #close Reported by: David Moore Change-Id: Ibbbca85517b04c315406ebfe3b6f7e0763daedc6	8 years ago
Corey Farrell	04ee3eb774	AST-2017-006: Fix app_minivm application MinivmNotify command injection ... An admin can configure app_minivm with an externnotify program to be run when a voicemail is received. The app_minivm application MinivmNotify uses ast_safe_system() for this purpose which is vulnerable to command injection since the Caller-ID name and number values given to externnotify can come from an external untrusted source. * Add ast_safe_execvp() function. This gives modules the ability to run external commands with greater safety compared to ast_safe_system(). Specifically when some parameters are filled by untrusted sources the new function does not allow malicious input to break argument encoding. This may be of particular concern where CALLERID(name) or CALLERID(num) may be used as a parameter to a script run by ast_safe_system() which could potentially allow arbitrary command execution. * Changed app_minivm.c:run_externnotify() to use the new ast_safe_execvp() instead of ast_safe_system() to avoid command injection. * Document code injection potential from untrusted data sources for other shell commands that are under user control. ASTERISK-27103 Change-Id: I7552472247a84cde24e1358aaf64af160107aef1	8 years ago
Sean Bright	d2ace23248	confbridge: Handle user hangup during name recording ... This prevents orphaned CBAnn channels from getting stuck in the bridge. ASTERISK-26994 #close Reported by: James Terhune Change-Id: I5e43e832a9507ec3f2c59752cd900b41dab80457	8 years ago
Jenkins2	2d69137bf4	Merge "app_record: Resolve some absolute vs. relative filename bugs" into 13	8 years ago
Sean Bright	9e6efcace5	voicemail: Fix various abuses of mkstemp ... mkstemp() returns a unique filename, but appending an extension to that filename does not guarantee uniqueness. Instead, use mkdtemp() and we can put whatever extension we want on the files that we create inside the directory. In the case of app_minivm, we also now properly clean up any temporary files that we create. ASTERISK-20858 #close Reported by: Walter Doekes Change-Id: I30ad04f0e115f0b11693ff678ba5184d8b938e43	8 years ago
Sean Bright	01b5913ce0	app_record: Resolve some absolute vs. relative filename bugs ... If the Record() application is called with a relative filename that includes directories, we were not properly creating the intermediate directories and Record() would fail. Secondarily, updated the documentation for RECORDED_FILE to mention that it does not include a filename extension. Finally, rewrote the '%d' functionality to be a bit more straight forward and less noisy. ASTERISK-16777 #close Reported by: klaus3000 Change-Id: Ibc2640cba3a8c7f17d97b02f76b7608b1e7ffde2	8 years ago
Jenkins2	28857047da	Merge "app_queue: Evaluate realtime queues when running dialplan functions" into 13	8 years ago
Jenkins2	c0251ae004	Merge "app_voicemail: Honor escape digits in "greeting only" mode" into 13	8 years ago
Sean Bright	579d4593ac	app_queue: Evaluate realtime queues when running dialplan functions ... ASTERISK-19103 #close Reported by: Jim Van Meggelen Change-Id: I4bd32a9d1fcebb8ac56bff0e084d4f53e31b692b	8 years ago
Sean Bright	0af145de2d	app_voicemail: Honor escape digits in "greeting only" mode ... ASTERISK-21241 #close Reported by: Eelco Brolman Patches: Patch uploaded by Eelco Brolman (License 6442) Change-Id: Icbe39b5c82a49b46cf1d168dc17766f3d84f54fe	8 years ago
Sungtae Kim	b88c3a4209	app_queue: Fix initial hold time queue statistic ... Fixed to use correct initial value and fixed to use the correct queue info to check the first value. ASTERISK-27204 Change-Id: Ia9e36c828e566e1cc25c66f73307566e4acb8e73	8 years ago
Corey Farrell	905c4ca3dc	app_privacy: remove unused header asterisk/image.h ... Change-Id: I56ed530633a642633b18383821069e806c92ae82	8 years ago
Corey Farrell	d066758a4c	Fix compile error for old versions of GCC. ... Use -Wno-format-truncation only if supported by compiler. ASTERISK-27171 #close Change-Id: Iac0aed7a5bcaa16c21b7d62c4e4678d244c4ccb6	8 years ago
Niklas Larsson	9a09f7dd5d	app_queue: Add priority to AMI QueueStatus ... Add priority to callers in AMI QueueStatus response ASTERISK-27092 #close Change-Id: I8d1f737a72c7c38f4cfe1a4ee3ecc0a4f85bd199	8 years ago
Corey Farrell	0f49e6ee2e	Fix compiler warnings on Fedora 26 / GCC 7. ... GCC 7 has added capability to produce warnings, this fixes most of those warnings. The specific warnings are disabled in a few places: * app_voicemail.c: truncation of paths more than 4096 chars in many places. * chan_mgcp.c: callid truncated to 80 chars. * cdr.c: two userfields are combined to cdr copy, fix would break ABI. * tcptls.c: ignore use of deprecated method SSLv3_client_method(). ASTERISK-27156 #close Change-Id: I65f280e7d3cfad279d16f41823a4d6fddcbc4c88	8 years ago
Richard Mudgett	7ff9d8785d	app_voicemail.c: Allow mailbox entry on authentication retry prompt. ... The following testsuite voicemail tests were failing to re-enter the mailbox after the first login attempt. tests/apps/voicemail/authenticate_invalid_mailbox tests/apps/voicemail/authenticate_invalid_password The tests were noting the start of the vm-incorrect-mailbox prompt and immediately sending the mailbox for the next login attempt. Since the invalid message playback had to complete before the digits were recognized, the test passed for the wrong reason and added approximately 20 seconds to the test times. * Allow the vm-incorrect-mailbox prompt to get interrupted by the mailbox digits like the initial vm-login prompt so the tests are able to enter the intended mailbox. Change-Id: I1dc53fe917bfe03a4587b2c4cd24c94696a69df8	8 years ago
Holger Hans Peter Freyther	1c3e7df26e	app_playback.c: Use the timezonename parameter ... In say_date_generic the timezonename parameter is passed but never used. Fix it by passing it to the ast_localtime function. ASTERISK-27124 Change-Id: I6afa98f9163190043244b9f3ba91eb1874d1b586	8 years ago
Sergej Kasumovic	3858d99b73	app_confbridge: Make sure name recordings are always removed from the filesystem ... This commit fixes two possible scenarios: * When recording name and if during recording you hangup, file is never removed. This is due to the fact file location is nulled. * When recording name and if you hangup during thank-you prompt, file is never removed. ASTERISK-27123 #close Change-Id: I39b7271408b4b54ce880c5111a886aa8f28c2625	8 years ago
Sean Bright	194625c1de	app_voicemail: Cleanup ODBC connection handling ... The primary focus of this patch is adding a missing call to ast_odbc_release_obj(), but is also a general cleanup of the ODBC related code in app_voicemail. ASTERISK-27093 #close Change-Id: I8e285142eaeb3146b4287a928276b70db76c902b	8 years ago
Ivan Poddubny	2c43ca0ac5	app_queue: Fix returning to dialplan when a queue is empty ... The fix for ASTERISK-25665 introduced a regression. The return value of queue_exec used to be 0 in case of leavewhenempty but it was changed to -1 (returned from wait_our_turn and passed transparently by queue_exec), thus leading to hangup instead of returning back to dialplan. This commit resets the value back to 0 in this case, restoring original behavior. ASTERISK-27065 #close Reported by: Marek Cervenka Change-Id: Id9c83b75aeda463250155e88c5004be52bbca5ac	8 years ago
Alexei Gradinari	8f356192d1	app_voicemail: IMAP connection control ... A new global option "imap_poll_logout" was added to specify whether need to disconnect from the IMAP server after polling of mailboxes. ASTERISK-27068 #close Closing IMAP connection after loading mailbox from voicemail.conf ASTERISK-24052 #close Change-Id: Ib7558ba04516240a32b65f42e9be64372a0ae12a	8 years ago
Alexei Gradinari	3b6c327c51	app_voicemail: IMAP logout on reload/unload ... Closing IMAP connection on module reload or unload. ASTERISK-24052 #close Change-Id: I2a40182aa9ef249fa6865d33570430e9ada68525	8 years ago
Jenkins2	8b12ad2f61	Merge "app_voicemail: IMAP logout on MWI unsubscribe" into 13	8 years ago
Richard Mudgett	f1a209d5ac	app_voicemail.c: Fix compile error when IMAP enabled. ... Change-Id: I2703f15b4099b4210c68eccf293105d1975c1fc1	8 years ago
Alexei Gradinari	08be5e01e8	app_voicemail: IMAP logout on MWI unsubscribe ... Closing IMAP connection on MWI unsubscribe. ASTERISK-24052 #close Change-Id: I4ff964026002b2817b48c20fb4239f0a880228fd	8 years ago
Jenkins2	a76b473c49	Merge "app_confbridge: Race between removing and playing name recording while leaving" into 13	8 years ago
Joshua Colp	dc05183f4b	channel / app_meetme: Fix parentheses. ... ASTERISK-27025 Change-Id: Id736b0aa4ec6b6b0f04663d64fa8d151f81fdbed	8 years ago
Jenkins2	d4ccd3a6c0	Merge "asterisk: Audit locking of channel when manipulating flags." into 13	8 years ago
Jenkins2	bc4ef72394	Merge "app_queue: Fix members showing as being in call when not." into 13	8 years ago
Joshua Colp	6bfcb1acc7	app_queue: Fix members showing as being in call when not. ... A change was done which added an 'in_call' flag to queue members that was set to true while talking to an agent. Unfortunately in practice this does not accurately reflect whether they are talking to an agent or not. If a Local channel is involved and a transfer is performed then the app_queue application would incorrectly think the agent was still in a call with the caller. This was done to fix a race condition between an agent becoming available by device state and the checking of the last call information for the wrapup time. There was a small window where the last call information would be the previous value instead of the new one. This change goes about fixing the original issue in a different way by considering the call completed if device state is received which would make the agent available and if they are currently in a call. If this occurs the last call information is updated before the agent becomes available ensuring that old information is not present when checking if the member should be called. This also improves the transfer situation by actually updating and enforcing the wrapup time. ASTERISK-26399 ASTERISK-26400 ASTERISK-26715 ASTERISK-26975 Change-Id: Ife1cb686e3173b3a6d368601adef9aff69d4beea	8 years ago