1978 Commits (827f655dac2bc438e3fae3b1573324b8a503e024)

Author	SHA1	Message	Date
Tilghman Lesher	827f655dac	Merged revisions 166696 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r166696 | tilghman | 2008-12-23 14:47:08 -0600 (Tue, 23 Dec 2008) | 7 lines Allow semicolons and extended characters in user-specified SIP headers. (closes issue #14110) Reported by: gork Patches: 20081222__bug14110__2.diff.txt uploaded by Corydon76 (license 14) Tested by: gork, putnopvut ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@166698 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Mark Michelson	63f2d52453	Merged revisions 166569 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r166569 | mmichelson | 2008-12-23 09:17:54 -0600 (Tue, 23 Dec 2008) | 20 lines Merged revisions 166568 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r166568 | mmichelson | 2008-12-23 09:16:26 -0600 (Tue, 23 Dec 2008) | 12 lines Fix a crash resulting from a datastore with inheritance but no duplicate callback The fix for this is to simply set the newly created datastore's data pointer to NULL if it is inherited but has no duplicate callback. (closes issue #14113) Reported by: francesco_r Patches: 14113.patch uploaded by putnopvut (license 60) Tested by: francesco_r ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@166571 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	9981739dd1	Merged revisions 166533 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r166533 | tilghman | 2008-12-22 22:32:15 -0600 (Mon, 22 Dec 2008) | 11 lines Merged revisions 166509 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r166509 | tilghman | 2008-12-22 22:05:25 -0600 (Mon, 22 Dec 2008) | 4 lines Use the integer form of condition for integer comparisons. (closes issue #14127) Reported by: andrew ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@166535 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Russell Bryant	511692bc3d	Merged revisions 166342 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r166342 | russell | 2008-12-22 11:44:23 -0600 (Mon, 22 Dec 2008) | 2 lines Remove some error messages. This is the default handler that is valid to use. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@166343 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Russell Bryant	3d6899f584	Merged revisions 166317 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r166317 | russell | 2008-12-22 11:29:10 -0600 (Mon, 22 Dec 2008) | 10 lines Merged revisions 166297 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r166297 | russell | 2008-12-22 11:22:56 -0600 (Mon, 22 Dec 2008) | 2 lines Fix up timeout handling in ast_carefulwrite(). ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@166326 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Russell Bryant	3db74e5bd7	Merged revisions 166282 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r166282 | russell | 2008-12-22 11:09:36 -0600 (Mon, 22 Dec 2008) | 12 lines Introduce ast_careful_fwrite() and use in AMI to prevent partial writes. This patch introduces a function to do careful writes on a file stream which will handle timeouts and partial writes. It is currently used in AMI to address the issue that has been reported. However, there are probably a few other places where this could be used. (closes issue #13546) Reported by: srt Tested by: russell http://reviewboard.digium.com/r/104/ ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@166284 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Mark Michelson	198eedad1f	Merged revisions 166267 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r166267 | mmichelson | 2008-12-22 10:07:59 -0600 (Mon, 22 Dec 2008) | 17 lines Fix a file playback crash and explicitly initialize values in func_timeout.c A crash was brought up on the bugtracker. The first run through valgrind was full of legitimate complaints of uninitialized values in func_timeout when setting a response timeout. These were fixed but the crash persisted. A second run through showed the real problem. The reference counting used for filestreams was incorrect because there were some missing increments when a frame was read from a format module. (closes issue #14118) Reported by: blitzrage Patches: 14118v2.patch uploaded by putnopvut (license 60) Tested by: blitzrage ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@166275 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Joshua Colp	69c484879f	Merged revisions 166268 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r166268 | file | 2008-12-22 12:08:13 -0400 (Mon, 22 Dec 2008) | 7 lines Record the previous port in the temporary address structure so that the comparison does not treat the host as having changed even if it did not. This would have been uninitialized before and would have led to a baddddd port. (closes issue #13628) Reported by: pananix Patches: bug13628.patch uploaded by jpeeler (license 325) Tested by: file, blitzrage ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@166272 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Mark Michelson	732fd97b6b	Merged revisions 166162 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r166162 | mmichelson | 2008-12-19 17:45:00 -0600 (Fri, 19 Dec 2008) | 6 lines Get rid of an extra space. I don't know how this crept back in when I had already fixed it earlier ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@166164 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Mark Michelson	7ed70a7a3f	Merged revisions 166092,166095 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r166092 | mmichelson | 2008-12-19 16:26:16 -0600 (Fri, 19 Dec 2008) | 28 lines Adding a new dialplan function AUDIOHOOK_INHERIT This function is being added as a method to allow for an audiohook to move to a new channel during a channel masquerade. The most obvious use for such a facility is for MixMonitor when a transfer is performed. Prior to the addition of this functionality, if a channel running MixMonitor was transferred by another party, then the recording would stop once the transfer had completed. By using AUDIOHOOK_INHERIT, you can make MixMonitor continue recording the call even after the transfer has completed. It has also been determined that since this is seen by most as a bug fix and is not an invasive change, this functionality will also be backported to 1.4 and merged into the 1.6.0 branches, even though they are feature-frozen. (closes issue #13538) Reported by: mbit Patches: 13538.patch uploaded by putnopvut (license 60) Tested by: putnopvut Review: http://reviewboard.digium.com/r/102/ ........ r166095 | mmichelson | 2008-12-19 16:40:57 -0600 (Fri, 19 Dec 2008) | 5 lines Remove the verbatim tag from the author line I could have sworn I already did that before, though... ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@166098 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Russell Bryant	c871ef2aeb	Merged revisions 165801 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r165801 | russell | 2008-12-18 15:44:47 -0600 (Thu, 18 Dec 2008) | 19 lines Merged revisions 165796 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r165796 | russell | 2008-12-18 15:39:25 -0600 (Thu, 18 Dec 2008) | 11 lines Make ast_carefulwrite() be more careful. This patch handles some additional cases that could result in partial writes to the file description. This was done to address complaints about partial writes on AMI. (issue #13546) (more changes needed to address potential problems in 1.6) Reported by: srt Tested by: russell Review: http://reviewboard.digium.com/r/99/ ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@165804 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Russell Bryant	52f5e8fcfb	Merged revisions 165723 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r165723 | russell | 2008-12-18 13:33:42 -0600 (Thu, 18 Dec 2008) | 14 lines Remove the need for AST_PBX_KEEPALIVE with the GoSub option from Dial. This is part of an effort to completely remove AST_PBX_KEEPALIVE and other similar return codes from the source. While this usage was perfectly safe, there are others that are problematic. Since we know ahead of time that we do not want to PBX to destroy the channel, the PBX API has been changed so that information can be provided as an argument, instead, thus removing the need for the KEEPALIVE return value. Further changes to get rid of KEEPALIVE and related code is being done by murf. There is a patch up for that on review 29. Review: http://reviewboard.digium.com/r/98/ ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@165728 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Joshua Colp	e5a8f92ab1	Merged revisions 165599 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r165599 | file | 2008-12-18 13:13:32 -0400 (Thu, 18 Dec 2008) | 11 lines Merged revisions 165591 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r165591 | file | 2008-12-18 13:11:42 -0400 (Thu, 18 Dec 2008) | 4 lines Only care about a compatible codec for early bridging if we are actually bridging to another channel. If we are not we actually want to bring the audio back to us. (closes issue #13545) Reported by: davidw ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@165605 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Russell Bryant	4468cd8d49	Merged revisions 164882 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r164882 | russell | 2008-12-16 15:39:15 -0600 (Tue, 16 Dec 2008) | 17 lines Merged revisions 164881 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r164881 | russell | 2008-12-16 15:38:29 -0600 (Tue, 16 Dec 2008) | 9 lines Fix an issue where DEBUG_THREADS may erroneously report that a thread is exiting while holding a lock. If the last lock attempt was a trylock, and it failed, it will still be in the list of locks so that it can be reported. (closes issue #13219) Reported by: pj ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@164884 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Russell Bryant	43371e4cb1	Merged revisions 164807 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r164807 | russell | 2008-12-16 14:41:51 -0600 (Tue, 16 Dec 2008) | 17 lines Merged revisions 164806 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r164806 | russell | 2008-12-16 14:35:25 -0600 (Tue, 16 Dec 2008) | 9 lines Add "restart gracefully" to the AMI blacklist of CLI commands. "module unload" was already identified as a command that can not be used from the AMI. "restart gracefully" effectively unloads all modules, and will run in to the same problems. (closes issue #13894) Reported by: kernelsensei ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@164813 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Steve Murphy	e3e5457dc4	Merged revisions 164801 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r164801 | murf | 2008-12-16 13:04:46 -0700 (Tue, 16 Dec 2008) | 36 lines (closes issue #14076) Reported by: toc Tested by: murf OK, Well this issue has had its share of flip-flopping. I found the following: 1. the code in question, in ext_cmp1 in pbx.c, would not allow two extensions that vary only by any dashes contained within them, to be defined in the same context. 2. for input dialstrings, dashes are NOT ignored. So, skipping them when sorting patterns seemed a bit silly. Thus, you might declare ext 891 in a context, but if you try dialing 8-9-1, it will NOT match 891. So, I proposed to remove the code from ext_cmp1 to skip the spaces and dashes. Just kept us from declaring 891 and 8-9-1 in the same context, forcing users to generate otherwise uselessly obfuscated dialplan code to get the same effect. Then, I tried out 1.4, and found that: 1. you can declare 891 and 8-9-1 in the same context! 2. You can't define 891, and have 8-9-1 match it! Nor can you define 8-9-1, and have 891 match it! So, it appears that my proposal simply restores the pbx to behaving as it did in 1.4. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@164805 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Russell Bryant	f39a711c49	Merged revisions 164737 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r164737 | russell | 2008-12-16 11:14:01 -0600 (Tue, 16 Dec 2008) | 22 lines Merged revisions 164736 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r164736 | russell | 2008-12-16 11:06:29 -0600 (Tue, 16 Dec 2008) | 14 lines Fix memory leak and invalid reporting issues with DEBUG_THREADLOCALS. One issue was that the ast_mutex_* API was being used within the context of the thread local data destructors. We would go off and allocate more thread local data while the pthread lib was in the middle of destroying it all. This led to a memory leak. Another issue was an invalid argument being provided to the the object_add API call. (closes issue #13678) Reported by: ys Tested by: Russell ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@164739 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Steve Murphy	a13fe6807a	Merged revisions 164648 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r164648 | murf | 2008-12-16 08:31:54 -0700 (Tue, 16 Dec 2008) | 13 lines Merged revisions 164634 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r164634 | murf | 2008-12-16 08:15:58 -0700 (Tue, 16 Dec 2008) | 5 lines I added a sentence to clarify why - and ' ' are ignored in patterns as per bug 14076. Leif says he'll put some stuff about it in the extensions.conf sample, etc. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@164658 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Russell Bryant	f8dc9e9776	Merged revisions 164519 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r164519 | russell | 2008-12-15 15:53:30 -0600 (Mon, 15 Dec 2008) | 7 lines Make sure we handle a uint32_t payload in ast_frdup() (closes issue #14080) Reported by: fnordian Patches: frame.patch uploaded by fnordian (license 110) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@164521 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Joshua Colp	2277054f17	Merged revisions 164312 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r164312 | file | 2008-12-15 13:24:28 -0400 (Mon, 15 Dec 2008) | 4 lines Use ast_seekstream to return the file stream back to the beginning instead of directly seeking to zero. This is because some audio formats have headers at the front that need to be skipped, which will be done by the format module. (closes issue #14079) Reported by: elguero ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@164314 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Russell Bryant	e74bc96b7b	Merged revisions 164203 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r164203 | russell | 2008-12-15 08:40:24 -0600 (Mon, 15 Dec 2008) | 39 lines Merged revisions 164201 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r164201 | russell | 2008-12-15 08:31:37 -0600 (Mon, 15 Dec 2008) | 31 lines Handle a case where a call can be bridged to a channel that is still ringing. The issue that was reported was about a case where a RINGING channel got redirected to an extension to pick up a call from parking. Once the parked call got taken out of parking, it heard silence until the other side answered. Ideally, the caller that was parked would get a ringing indication. This patch fixes this case so that the caller receives ringback once it comes out of parking until the other side answers. The fixes are: - Make sure we remember that a channel was an outgoing channel when doing a masquerade. This prevents an erroneous ast_answer() call on the channel, which causes a bogus 200 OK to be sent in the case of SIP. - Add some additional comments to explain related parts of code. - Update the handling of the ast_channel visible_indication field. Storing values that are not stateful is pointless. Control frames that are events or commands should be ignored. - When a bridge first starts, check to see if the peer channel needs to be given ringing indication because the calling side is still ringing. - Rework ast_indicate_data() a bit for the sake of readability. (closes issue #13747) Reported by: davidw Tested by: russell Review: http://reviewboard.digium.com/r/90/ ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@164300 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	aef27a9372	Merged revisions 163762 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r163762 | tilghman | 2008-12-12 16:04:26 -0600 (Fri, 12 Dec 2008) | 14 lines Merged revisions 163761 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r163761 | tilghman | 2008-12-12 16:03:10 -0600 (Fri, 12 Dec 2008) | 7 lines Simple fix for Ctrl-C not immediately exiting Asterisk, but also add a pointer inside editline to look back to asterisk.c, so others don't spend as much time as I did looking (in the wrong place) for the appropriate function. Reported by: ZX81, via the #asterisk-users channel Fixed by: me (license 14) ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@163764 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Russell Bryant	7129aba1a5	Merged revisions 163670 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r163670 | russell | 2008-12-12 12:45:03 -0600 (Fri, 12 Dec 2008) | 6 lines Rename a number of tcptls_session variables. There are no functional changes here. The name "ser" was used in a lot of places. However, it is a relic from when the struct was a server_instance, not a session_instance. It was renamed since it represents both a server or client connection. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@163672 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Joshua Colp	79d555f70c	Merged revisions 163579 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r163579 | file | 2008-12-12 12:55:15 -0400 (Fri, 12 Dec 2008) | 4 lines Since chan_sip is callback devicestate driven do not pass in actual states, pass in unknown so we get asked. Additionally do not pass in an actual device state value in ast_setstate since the channel may be callback driven. (closes issue #13525) Reported by: pj ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@163581 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Russell Bryant	85ad905561	Merged revisions 163449 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r163449 | russell | 2008-12-12 07:55:30 -0600 (Fri, 12 Dec 2008) | 34 lines Merged revisions 163448 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r163448 | russell | 2008-12-12 07:44:08 -0600 (Fri, 12 Dec 2008) | 26 lines Resolve issues that could cause DTMF to be processed out of order. These changes come from team/russell/issue_12658 1) Change autoservice to put digits on the head of the channel's frame readq instead of the tail. If there were frames on the readq that autoservice had not yet read, the previous code would have resulted in out of order processing. This required a new API call to queue a frame to the head of the queue instead of the tail. 2) Change up the processing of DTMF in ast_read(). Some of the problems were the result of having two sources of pending DTMF frames. There was the dtmfq and the more generic readq. Both were used for pending DTMF in various scenarios. Simplifying things to only use the frame readq avoids some of the problems. 3) Fix a bug where a DTMF END frame could get passed through when it shouldn't have. If code set END_DTMF_ONLY in the middle of digit emulation, and a digit arrived before emulation was complete, digits would get processed out of order. (closes issue #12658) Reported by: dimas Tested by: russell, file Review: http://reviewboard.digium.com/r/85/ ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@163515 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	c4281ca1fa	Merged revisions 163384 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r163384 | tilghman | 2008-12-11 17:38:56 -0600 (Thu, 11 Dec 2008) | 16 lines Merged revisions 163383 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r163383 | tilghman | 2008-12-11 17:35:55 -0600 (Thu, 11 Dec 2008) | 9 lines When a Ctrl-C or Ctrl-D ends a remote console, on certain shells, the terminal is messed up. By intercepting those events with a signal handler in the remote console, we can avoid those issues. (closes issue #13464) Reported by: tzafrir Patches: 20081110__bug13464.diff.txt uploaded by Corydon76 (license 14) Tested by: blitzrage ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@163386 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Russell Bryant	39a8f051b7	Merged revisions 163171 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r163171 | russell | 2008-12-11 14:07:47 -0600 (Thu, 11 Dec 2008) | 16 lines Fix the "failed" extension for outgoing calls. The conversion to use ast_check_hangup() everywhere instead of checking the softhangup flag directly introduced this problem. The issue is that ast_check_hangup() checked for tech_pvt to be NULL. Unfortunately, this will be NULL is some valid circumstances, such as with a dummy channel. The fix is simple. Don't check tech_pvt. It's pointless, because the code path that sets this to NULL is when the channel hangup callback gets called. This happens inside of ast_hangup(), which is the same function responsible for freeing the channel. Any code calling ast_check_hangup() better not be calling it after that point, and if so, we have a bigger problem at hand. (closes issue #14035) Reported by: erogoza ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@163173 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Russell Bryant	221462c7a1	Merged revisions 163094 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r163094 | russell | 2008-12-11 11:06:16 -0600 (Thu, 11 Dec 2008) | 19 lines Merged revisions 163092 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r163092 | russell | 2008-12-11 10:54:51 -0600 (Thu, 11 Dec 2008) | 11 lines Fix an issue that made it so you could only have a single caller executing a custom feature at a time. This was especially problematic when custom features ran for any appreciable amount of time. The fix turned out to be quite simple. The dynamic features are now stored in a read/write list instead of a list using a mutex. (closes issue #13478) Reported by: neutrino88 Fix suggested by file ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@163100 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	704f4a7d5c	Merged revisions 162922,162930 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r162922 | tilghman | 2008-12-10 16:48:09 -0600 (Wed, 10 Dec 2008) | 7 lines Checking global variables here actually overwrote the previous substitution by channel variables, and in any case, was redundant; pbx_substitute_variables_helper ALREADY does substitution for global variables. (closes issue #13327) Reported by: pj ........ r162930 | tilghman | 2008-12-10 17:01:14 -0600 (Wed, 10 Dec 2008) | 2 lines Previously missing line, now the substitution works correctly ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@162949 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Joshua Colp	ffc955adae	Merged revisions 162656 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r162656 | file | 2008-12-10 12:06:59 -0400 (Wed, 10 Dec 2008) | 13 lines Merged revisions 162653 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r162653 | file | 2008-12-10 12:05:29 -0400 (Wed, 10 Dec 2008) | 6 lines Increment the sequence number on the end packets for RFC2833. After reading the RFC some more and doing some testing I agree with this change. (closes issue #12983) Reported by: vt Patches: dtmf_inc_seqnum_on_end_pkts.diff uploaded by vt (license 520) ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@162658 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Russell Bryant	5964f2e0f1	Merged revisions 162414 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r162414 | russell | 2008-12-09 16:25:06 -0600 (Tue, 09 Dec 2008) | 16 lines Merged revisions 162413 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r162413 | russell | 2008-12-09 16:17:39 -0600 (Tue, 09 Dec 2008) | 8 lines Remove the test_for_thread_safety() function completely. The test is not valid. Besides, if we actually suspected that recursive mutexes were not working, we would get a ton of LOG_ERROR messages when DEBUG_THREADS is turned on. (inspired by a discussion on the asterisk-dev list) ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@162416 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Mark Michelson	b6b83bbe9c	Merged revisions 162266 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r162266 | mmichelson | 2008-12-09 14:30:07 -0600 (Tue, 09 Dec 2008) | 14 lines Merged revisions 162265 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r162265 | mmichelson | 2008-12-09 14:28:44 -0600 (Tue, 09 Dec 2008) | 6 lines If we fail to start a thread for the pbx to run in, we need to be sure to decrease the number of active calls on the system. This fix may relate to ABE-1713, but it is not certain yet. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@162269 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Joshua Colp	8e796b4658	Merged revisions 162205 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r162205 | file | 2008-12-09 15:48:35 -0400 (Tue, 09 Dec 2008) | 14 lines Merged revisions 162204 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r162204 | file | 2008-12-09 15:47:07 -0400 (Tue, 09 Dec 2008) | 7 lines Make sure that the timestamp for DTMF is not the same as the previous voice frame and do not send audio when transmitting DTMF as this confuses some equipment. (closes issue #13209) Reported by: ip-rob Patches: 13209.diff uploaded by file (license 11) Tested by: ip-rob, bujones ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@162207 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Joshua Colp	085cfe48cf	Merged revisions 162197 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r162197 | file | 2008-12-09 15:08:39 -0400 (Tue, 09 Dec 2008) | 11 lines Merged revisions 162188 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r162188 | file | 2008-12-09 15:06:14 -0400 (Tue, 09 Dec 2008) | 4 lines Take video into account when early bridging RTP. (closes issue #13535) Reported by: davidw ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@162202 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Russell Bryant	4dae38f1b9	Merged revisions 161951 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r161951 | russell | 2008-12-09 08:57:39 -0600 (Tue, 09 Dec 2008) | 23 lines Merged revisions 161948 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r161948 | russell | 2008-12-09 08:52:25 -0600 (Tue, 09 Dec 2008) | 15 lines Fix a problem with GROUP() settings on a masquerade. The previous code carried over group settings from the old channel to the new one. However, it did nothing with the group settings that were already on the new channel. This patch removes all group settings that already existed on the new channel. I have a more complicated version of this patch which addresses only the most blatant problem with this, which is that a channel can end up with multiple group settings in the same category. However, I could not think of a use case for keeping any of the group settings from the old channel, so I went this route for now. (closes AST-152) ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@161963 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	5e7155ec1f	Merged revisions 161790 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r161790 | tilghman | 2008-12-08 12:49:50 -0600 (Mon, 08 Dec 2008) | 6 lines Allocate enough space initially for the message. (closes issue #14027) Reported by: junky Patches: M14027.diff uploaded by junky (license 177) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@161792 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Joshua Colp	f1a71be36b	Merged revisions 161787 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r161787 | file | 2008-12-08 14:47:32 -0400 (Mon, 08 Dec 2008) | 6 lines Fix a regression introduced when the PBX timeouts were converted to milliseconds. collect_digits now gets milliseconds fed to it, not seconds. (closes issue #14012) Reported by: dveiga Patches: 14012.patch uploaded by bkruse (license 132) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@161789 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Sean Bright	fc975ab998	Merged revisions 161427 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r161427 | seanbright | 2008-12-05 16:08:43 -0500 (Fri, 05 Dec 2008) | 22 lines Merged revisions 161426 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ................ r161426 | seanbright | 2008-12-05 16:02:20 -0500 (Fri, 05 Dec 2008) | 15 lines Merged revisions 161421 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r161421 | seanbright | 2008-12-05 15:50:23 -0500 (Fri, 05 Dec 2008) | 8 lines Fix build errors on FreeBSD (uint -> unsigned int). (closes issue #14006) Reported by: alphaque Patches: astobj2.h-patch uploaded by alphaque (license 259) (Slightly modified by seanbright) ........ ................ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@161429 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Russell Bryant	96e176f2a0	Merged revisions 161288 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r161288 | russell | 2008-12-05 08:16:24 -0600 (Fri, 05 Dec 2008) | 10 lines Merged revisions 161287 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r161287 | russell | 2008-12-05 08:12:14 -0600 (Fri, 05 Dec 2008) | 2 lines Fix a NULL format string warning found by buildbot. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@161290 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	69924a14f1	Merged revisions 161181 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r161181 | tilghman | 2008-12-04 23:41:41 -0600 (Thu, 04 Dec 2008) | 11 lines The first file should have a blank config filename in the structure, so that when a save occurs to a different filename, everything goes to the alternate filename, instead of appending to the original. This is important for the AMI command UpdateConfig. (closes issue #13301) Reported by: trevo Patches: 20081113__bug13301.diff.txt uploaded by Corydon76 (license 14) 20081113__bug13301__1.6.0.diff.txt uploaded by Corydon76 (license 14) Tested by: Corydon76, blitzrage ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@161182 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Jeff Peeler	69b97df472	Merged revisions 161014 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r161014 | jpeeler | 2008-12-04 12:32:20 -0600 (Thu, 04 Dec 2008) | 17 lines Merged revisions 161013 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r161013 | jpeeler | 2008-12-04 12:30:41 -0600 (Thu, 04 Dec 2008) | 9 lines (closes issue #13835) Reported by: matt_b Tested by: jpeeler This mirrors a check that was present in ast_rtp_read to also be in ast_rtp_raw_write to not schedule sending the receiver report if the remote RTCP endpoint address isn't present in the RTCP structure. Closes AST-142. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@161016 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Mark Michelson	1f2f7df7f3	Merged revisions 160945 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r160945 | mmichelson | 2008-12-04 10:45:06 -0600 (Thu, 04 Dec 2008) | 23 lines Merged revisions 160943 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r160943 | mmichelson | 2008-12-04 10:44:18 -0600 (Thu, 04 Dec 2008) | 15 lines Fix a callerid parsing issue. If someone formatted callerid like the following: "name <number>" (including the quotation marks), then the parts would be parsed as name: "name number: number This is because the closing quotation mark was not discovered since the number and everything after was parsed out of the string earlier. Now, there is a check to see if the closing quote occurs after the number, so that we can know if we should strip off the opening quote on the name. Closes AST-158 ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@160947 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Jason Parker	089fa9bb54	Merged revisions 160699-160700 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r160699 | qwell | 2008-12-03 14:32:20 -0600 (Wed, 03 Dec 2008) | 7 lines Fix typo when ListCategories returns none. (closes issue #13994) Reported by: mika Patches: ListCategoriesActionPatch.diff uploaded by mika (license 624) ........ r160700 | qwell | 2008-12-03 14:35:36 -0600 (Wed, 03 Dec 2008) | 1 line Another place this is missing ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@160702 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	6674ef2c22	Merged revisions 160208 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r160208 | tilghman | 2008-12-01 18:37:21 -0600 (Mon, 01 Dec 2008) | 10 lines Merged revisions 160207 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r160207 | tilghman | 2008-12-01 18:25:16 -0600 (Mon, 01 Dec 2008) | 3 lines Ensure that Asterisk builds with --enable-dev-mode, even on the latest gcc and glibc. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@160234 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Sean Bright	c8d7336afb	Merged revisions 160170-160172 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r160170 | seanbright | 2008-12-01 18:08:24 -0500 (Mon, 01 Dec 2008) | 1 line Pay attention to the return value of system(), even if we basically ignore it. ................ r160171 | seanbright | 2008-12-01 18:18:48 -0500 (Mon, 01 Dec 2008) | 1 line Silence a build warning. (chan_phone.c:810: warning: value computed is not used) ................ r160172 | seanbright | 2008-12-01 18:37:49 -0500 (Mon, 01 Dec 2008) | 10 lines Merged revisions 159976 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r159976 | mvanbaak | 2008-12-01 11:08:36 -0500 (Mon, 01 Dec 2008) | 3 lines Get rid of the useless format string and argument in the Bogus/ manager channelname. Noted by kpfleming and name Bogus/manager suggested by eliel ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@160175 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Michiel van Baak	02766b0209	Merged revisions 159898 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r159898 | mvanbaak | 2008-12-01 15:09:59 +0100 (Mon, 01 Dec 2008) | 11 lines Merged revisions 159897 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r159897 | mvanbaak | 2008-12-01 15:05:41 +0100 (Mon, 01 Dec 2008) | 4 lines make manager compile on OpenBSD. The last (10th) argument to ast_channel_alloc here should be a pointer and NULL is not really a pointer. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@159975 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Kevin P. Fleming	c3347e79a5	Merged revisions 159818 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r159818 | kpfleming | 2008-11-29 11:57:39 -0600 (Sat, 29 Nov 2008) | 18 lines incorporates r159808 from branches/1.4: ------------------------------------------------------------------------ r159808 | kpfleming | 2008-11-29 10:58:29 -0600 (Sat, 29 Nov 2008) | 7 lines update dev-mode compiler flags to match the ones used by default on Ubuntu Intrepid, so all developers will see the same warnings and errors since this branch already had some printf format attributes, enable checking for them and tag functions that didn't have them format attributes in a consistent way ------------------------------------------------------------------------ in addition: move some format attributes from main/utils.c to the header files they belong in, and fix up references to the relevant functions based on new compiler warnings ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@159851 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	e73e6b7b24	Merged revisions 159475 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r159475 | tilghman | 2008-11-26 12:33:04 -0600 (Wed, 26 Nov 2008) | 7 lines If the config file does not exist, then the first use crashes Asterisk. (closes issue #13848) Reported by: klaus3000 Patches: udptl.c.patch uploaded by eliel (license 64) Tested by: blitzrage ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@159477 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Jeff Peeler	3e54351b7c	Merged revisions 159402 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ........ r159402 | jpeeler | 2008-11-25 21:18:01 -0600 (Tue, 25 Nov 2008) | 3 lines Always parse arguments in park_call_exec so that app_args is valid. This prevents a crash when executing Park from the dialplan with no arguments. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@159403 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Steve Murphy	95fb6bb29c	Merged revisions 159360 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/trunk ................ r159360 | murf | 2008-11-25 16:03:01 -0700 (Tue, 25 Nov 2008) | 23 lines Merged revisions 159316 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r159316 | murf | 2008-11-25 15:41:10 -0700 (Tue, 25 Nov 2008) | 15 lines (closes issue #12694) Reported by: yraber Patches: 12694.2nd.diff uploaded by murf (license 17) Tested by: murf, laurav Thanks to file (Joshua Colp) for his IAX fix. the change to cdr.c allows no-answer to percolate up into CDR's, and feels like the right place to locate this fix; if BUSY is done here, no-answer should be, too. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@159375 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago