2325 Commits (8138003de72ee033ab07f0aab255217329311aa0)

Author	SHA1	Message	Date
Mark Michelson	1cf6ee98e0	Added logic to handle the unlikely case that someone has two queues with the same name. ... Asterisk will log a warning message letting the user know that one was already defined with that name and is it skipping all further instances. This also will work for realtime queues but in order for that to happen, the user would have to trigger a perfectly timed reload as a realtime queue is being looked up, which is highly unlikely (but taken care of nonetheless). git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82326 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Dwayne M. Hubbard	e2611d2f54	remove a race condition for the creation of recordthread's, and fix a small memory leak. This closes issue# 10636 ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82286 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	39d628adcf	Accidentally committed changes to app_voicemail which do NOT need to be in the 1.4 branch yet. reverting... ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82276 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	da18cece2c	We should only initialize a realtime queue when it is allocated, not every time we access it. This prevents the members ao2_container ... from being reallocated every time the queue is accessed. I also removed a debug message I had accidentally left in on a previous commit. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82274 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	3e11102ef8	Fix incorrect uses of ao2_find(). Every one of these calls was reading bogus ... memory ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82267 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	56b7a100bc	Fix another missing unref of member objects. This one was pointed out by Marta. ... When building the outgoing list in try_calling(), a member reference is stored in each outgoing entry. However, when this list got destroyed, the reference was not released. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82263 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	4f36c859ad	All instances of ao2_iterators which were just named 'i' have been renamed ... to 'mem_iter' so that when refcounted queues are merged into trunk, there will be little confusion regarding iterator names, especially when a queue and member iterator are used in the same function. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82252 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	808ed0e44e	Add a couple more missing unrefs of queue member objects ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82240 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	aa3a71d3bf	Add a missing unref of a queue member in an error handling block ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82238 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	ffa6e7123b	Document why membercount can not simply be replaced by ao2_container_count() ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82236 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	4913548485	Convert struct member to use refcounts (closes issue #10199) ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82155 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jason Parker	d73c04d892	Allow the MEMBERINTERFACE variable to be used as the mixmonitor filename. ... This moves the setting of the MEMBERINTERFACE variable to before mixmonitor. Issue 10671, patch by sim. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81923 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	e73fa2ba6f	(closes issue #10122) ... Reported by: stevefeinstein Patches: meetme-unmute-manager.diff uploaded by qwell (license 4) Tested by: stevefeinstein After looking over the code I agree with Qwell. Setting the file descriptor to conference each time just causes a fight back and forth. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81776 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	76ffc54255	Fixes an issue where valid DTMF had to be pressed twice to exit a queue if a member's phone ... was ringing. (closes issue #10655, reported by strider2k, patched by me) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81713 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	fbbf1e2056	Fixing the build... ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81525 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	f5cc747662	Reverting behavior of QUEUE_MEMBER_COUNT to only count members who are logged in ... and available. (related to issue #10652, reported by wuwu) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81520 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jason Parker	e805ee3d40	Rather than attempt to play a file, we can just check whether it exists. ... Issue 10634, patch by me, testing by pabelanger, sanity checked by bweschke git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81455 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	6ed2b5c1b2	Changed a comment to be more accurate. ... (really this is just a test to make sure I can commit properly from home) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81428 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	687f798f19	Fixed broken behavior of a reload on realtime queues. Prior to this patch, if a reload was issued and ... a realtime queue had callers waiting in it, then the queue would be removed from the queue list, but it would not actually be freed (in fact, a debug message warning about a memory leak would come up). With this patch, reloads do not touch realtime queues at all. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81416 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jason Parker	86c32ff0ef	Re-order dial options to be in line with the existing alpha order. ... Issue 10621, initial patch by junky git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81412 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	0589a7e1d0	Removing an extraneous (and possibly misleading) log message. Firstly, if the announce file isn't found, the ... streaming functions will report it. Secondly, not all non-zero returns from play_file mean that the announce file wasn't found. Positive return values simply mean that a digit was pressed (most likely to skip through the announcement). (closes issue #10612, reported and patched by dimas) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81397 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	4c16fcaa97	Changed some manager event messages to reflect whether a queue member is a realtime member or not ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81381 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	dbe2d229a5	This patch, in essence, will correctly pause a realtime queue member and reflect those ... changes in the realtime engine. (issue #10424, reported by irroot, patch by me) This patch creates a new function called update_realtime_member_field, which is a generic function which will allow any one field of a realtime queue member to be updated. This patch only uses this function to update the paused status of a queue member, but it lays the foundation for persisting the state of a realtime member the same way that static members' state is maintained when using the persistentmembers setting git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81349 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	872ab1519e	Changed some tabs to spaces ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81346 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	2772c71560	This fix creates a more accurate way of detecting whether realtime members were deleted. ... (closes issue 10541, reported by Alric, patched by me) The REALLY nice things about this patch is that queue members now have a "realtime" field which will be true if the member is a realtime member. This means we can check this value prior to certain processing if it should ONLY be done for realtime members. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81340 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	214d980f86	Resolve a potential deadlock. In this case, a single queue is locked, then the queue list. In changethread(), the queue list is ... locked, and then each individual queue is locked. Under the right circumstances, this could deadlock. As such, I have unlocked the individual queue before locking the queue list, and then locked the queue back after the queue list is unlocked. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81158 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	fe5489eead	Found a case where the queue's membercount is off. It does not take into account dynamic members on a reload. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81010 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Dwayne M. Hubbard	5155d31036	An empty string is an empty callerid ... so zap it. This closes issue #10502, which was pointed out by dswartz. Thank you, and may the swartz be with you ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@80878 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
BJ Weschke	318f0f6e46	A minor correction to the available logic of autofill. If a queue member is paused, they're not really "available" so don't count them as such. Somewhat related to issue #10155 ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@80818 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	09fc9c894e	Fix a possible crash in IMAP voicemail. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@80750 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	108326e3d1	Fix the build of app_queue ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@80088 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	6268d2d7ec	After a discussion on #asterisk-dev, it was decided that this should be in 1.4 as well. ... (issue #10424, reported and patched by irroot) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@80086 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	d66e174242	Found a pointless ternary if. member->dynamic was set to 1 and has no opportunity to change ... between then and this line, so "dynamic" will ALWAYS be output. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@80049 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	7c7ec6a1da	Ukrainian language voicemail support. ... (closes issue #10458, reported and patched by Oleh) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@80044 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	e6768adf1b	Missing curly braces. Oops. (Reported by snuffy via IRC) ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@79998 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	d0469e3c42	Don't allocate vmu for messagecount when we could just use the stack instead (closes issue #10490) ... Also, remove a useless (and leaky) SQLAllocHandle (closes issue #10480) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@79947 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	403ee9194c	Patch allows for more seamless transition from file storage voicemail to ODBC storage voicemail. ... If a retrieval of a greeting from the database fails, but the file is found on the file system, then we go ahead an insert the greeting into the database. The result of this is that people who switch from file storage to ODBC storage do not need to rerecord their voicemail greetings. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@79906 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	ec2f24b901	base_encode is not trying to open a log file, so we should not call it a log file in the warning. ... (related to issue #10452, reported by bcnit) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@79690 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	176f95680b	Fixed an error in the Russian language voicemail intro. ... (issue #10458, reported and patched by Oleh) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@79527 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	924c88d3d0	Instead of accepting a single DTMF character accept a full string. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@79334 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	4f8857d608	Add an API call to allow the engine to know that DTMF was received. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@79207 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	7133eb1368	Improved a bit of logic regarding comma-separated mailboxes in has_voicemail. Also added some braces to some compound if statements ... since unbraced if statements scare me in general. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@78907 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	48d9158cdd	Removing some extra debug code I left in my last commit ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@78860 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	fd5f948092	Quite a few changes regarding IMAP storage. ... 1. instead of using inboxcount as the core message counting function, we use messagecount instead. This makes it possible to count messages in folders besides just INBOX and Old. 2. inboxcount and hasvoicemail now use messagecount as their means of determining return values. 3. Added a copy_message function for IMAP storage. Unfortunately I don't have the means to test it, but it seems like a pretty straightforward function. 4. Removed a #ifndef IMAP_STORAGE and matching #endif from leave_voicemail for a couple of reasons. One, we want to support copying mail to multiple IMAP boxes, and two, IMAP was broken because a STORE macro had been moved into this section of code. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@78859 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	f2bf48ce42	add a comment to indicate that inboxcount for ODBC_STORAGE needs to be fixed to support multiple mailboxes ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@78778 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	e019aff438	Fix subscriptions to multiple mailboxes for ODBC_STORAGE. Also, leave a ... comment for this to be fixed for IMAP_STORAGE, as well. I left IMAP alone since I know MarkM was working on this code right now for another reason. This is broken even worse in trunk, but for a different reason. The fact that the mailbox option supported multiple mailboxes is completely not obvious from the code in the channel drivers. Anyway, I will fix that in another commit ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@78749 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	1996c3a71d	Fix a problem with the combination of the 'F' option to pass DTMF through a ... conference and options that use DTMF to activate various features. The problem was that the BEGIN frame would be passed through, but the END frame would get intercepted to activate a feature. Then, the other conference members would hear DTMF for forever, which they didn't seem to like very much. (closes issue #10400, reported by stevefeinstein, fixed by me) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@78717 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	c97cdff67d	Fixed some compiler warnings so that compiling with dev-mode and IMAP storage would not have any errors. ... This section of code may get changed again shortly since my change uncovers a rather silly bit of logic. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@78620 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	f8c70a5799	Changing a bit of logic so that someone will NEVER exit the queue on timeout unless they have enabled the 'n' option. ... This commit relates to issue #10320. Thanks to jfitzgibbon for detailing the idea behind this code change. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@78575 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	dcfb651931	The logic behind inboxcount's return value was reversed in has_voicemail and message_count. ... (closes issue #10401, reported by st1710, patched by me) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@78450 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago