4464 Commits (7ce921b33b3492bc6531c19d91e3fb37af2cf35e)

Author	SHA1	Message	Date
Kevin Harwell	af12c03b6e	Merge "AST-2018-006: Properly handle WebSocket frames with 0 length payload." into 15	8 years ago
George Joseph	110089a74f	Merge "AST-2018-005: res_pjsip_transport_management: Move to core" into 15	8 years ago
Joshua Colp	80f0f143d1	Merge "AST-2018-004: Restrict the number of Accept headers in a SUBSCRIBE." into 15	8 years ago
Sean Bright	f1a4691741	AST-2018-006: Properly handle WebSocket frames with 0 length payload. ... In ast_websocket_read() we were not adequately checking that the payload_len was non-zero before passing it to ws_safe_read(). Calling ws_safe_read with a len argument of 0 will result in a busy loop until the underlying socket is closed. ASTERISK-27658 #close Change-Id: I9d59f83bc563f711df1a6197c57de473f6b0663a	8 years ago
George Joseph	14de1c16a5	AST-2018-005: res_pjsip_transport_management: Move to core ... Since res_pjsip_transport_management provides several attack mitigation features, its functionality moved to res_pjsip and this module has been removed. This way the features will always be available if res_pjsip is loaded. ASTERISK-27618 Reported By: Sandro Gauci Change-Id: I21a2d33d9dda001452ea040d350d7a075f9acf0d	8 years ago
George Joseph	180715bd20	AST-2018-005: Fix tdata leaks when calling pjsip_endpt_send_response(2) ... pjsip_distributor: authenticate() creates a tdata and uses it to send a challenge or failure response. When pjsip_endpt_send_response2() succeeds, it automatically decrements the tdata ref count but when it fails, it doesn't. Since we weren't checking for a return status, we weren't decrementing the count ourselves on error and were therefore leaking tdatas. res_pjsip_session: session_reinvite_on_rx_request wasn't decrementing the ref count if an error happened while sending a 491 response. pre_session_setup wasn't decrementing the ref count if while sending an error after a pjsip_inv_verify_request failure. res_pjsip: ast_sip_send_response wasn't decrementing the ref count on error. ASTERISK-27618 Reported By: Sandro Gauci Change-Id: Iab33a6c7b6fba96148ed465b690ba8534ac961bf	8 years ago
George Joseph	c8add33919	AST-2018-005: Add a check for NULL tdata in ast_sip_failover_request ... It was discovered that there are some corner cases where a pjsip tsx might have no last_tx so calling ast_sip_failover_request with a NULL last_tx as its tdata would cause a crash. ASTERISK-27618 Reported By: Sandro Gauci Change-Id: Ic2b63f6d4ae617c4c19dcdec2a7a6156b54fd15b	8 years ago
Joshua Colp	4a1b8ca6d7	AST-2018-004: Restrict the number of Accept headers in a SUBSCRIBE. ... When receiving a SUBSCRIBE request the Accept headers from it are stored locally. This operation has a fixed limit of 32 Accept headers but this limit was not enforced. As a result it was possible for memory outside of the allocated space to get written to resulting in a crash. This change enforces the limit so only 32 Accept headers are processed. ASTERISK-27640 Reported By: Sandro Gauci Change-Id: I99a814b10b554b13a6021ccf41111e5bc95e7301	8 years ago
Jenkins2	8de6f0b667	Merge "res_http_websocket: Don't leak memory on read failure" into 15	8 years ago
Jenkins2	c4256dd911	Merge "res_pjsip_header_funcs: Various cleanups" into 15	8 years ago
Jenkins2	06c50fff14	Merge "res_pjsip: Use pjsip_sip_uri.user_param instead of other_param" into 15	8 years ago
Sean Bright	bb1bc55f76	res_http_websocket: Don't leak memory on read failure ... Change-Id: Ic449ea832bc81a1671c0e910c5fbe8c683e3da89	8 years ago
Sean Bright	68036355b9	res_pjsip_header_funcs: Various cleanups ... * Prefer strcasecmp() over stricmp() * Use a list with no lock since we never actually lock * Minor cleanups to error messages Change-Id: I8446f44795ee8f3072e1c1f9193c6912dfc0c42b	8 years ago
Sean Bright	a77c8ce375	res_pjsip: Endpoint destruction does not free DTLS configuration ... ASTERISK-27679 #close Reported by: Mak Dee Change-Id: I89a2783a11be0763bf123d1619ed176b6225cf42	8 years ago
Alexander Traud	0993f6e765	res_calendar: Specialized calendars depend on symbols of general calendar. ... ASTERISK-27680 Change-Id: Ifb77912e424fe3710a025c18526fada673ec0b79	8 years ago
Sean Bright	1680deb9e6	res_pjsip: Use pjsip_sip_uri.user_param instead of other_param ... There is a dedicated slot in the pjsip_sip_uri for the 'user' parameter, so use that instead of adding to the list of generic URI parameters. Change-Id: I0a0ce8a60ecee27489735bf56fd707719d8c2ed6	8 years ago
Jenkins2	1d9ef9f5f3	Merge "endpoint identifiers: Some code cleanup." into 15	8 years ago
Richard Mudgett	53afe4660a	res_pjsip/config_domain_aliases.c: Add check for missing domain. ... What is the point of defining an alias and not saying what is being aliased? Change-Id: I98a892016ed61dcf5efeb6619fd748925103f0be	8 years ago
Jenkins2	65ad576017	Merge "res_sorcery_realtime.c: Fix ref leak if object failed to apply." into 15	8 years ago
Jenkins2	fc55428a42	Merge "res_pjsip.c: Fix documentation typos." into 15	8 years ago
Richard Mudgett	c3916cbc0e	endpoint identifiers: Some code cleanup. ... res_pjsip_endpoint_identifier_user.c: * Fix copy/paste error in find_endpoint(). We were using a constant "anonymous" string instead of the passed in endpoint_name when checking the transport domain for an endpoint match. * Eliminate RAII_VAR in find_endpoint(). * Remove always true check in find_transport_state_in_use(). * Remove useless CMD_STOP in find_transport_state_in_use(). res_pjsip_endpoint_identifier_anonymous.c: * Eliminate RAII_VAR in anonymous_identify(). * Remove always true check in find_transport_state_in_use(). * Remove useless CMD_STOP in find_transport_state_in_use(). Change-Id: I86924c31db5bd225ca0c1219c761b668c6f91189	8 years ago
Richard Mudgett	3cc4cb9c68	res_pjsip.c: Fix documentation typos. ... Change-Id: I82ae0b92bfa2ece84a5c684efd9eefdc83ebd068	8 years ago
Richard Mudgett	cda2c914b6	res_sorcery_realtime.c: Fix ref leak if object failed to apply. ... Change-Id: I3c7106ff77009754725cee790eadf5da44154ab6	8 years ago
Joshua Elson	296711a446	res_pjsip_mwi.c: Fix null pointer crash ... ASTERISK-27652 #close Change-Id: I78a0d38bfd8d0d82830f3d53da04872d6b67284d	8 years ago
George Joseph	90e5bae6ca	Merge "res_pjsip_pubsub: Prune subs with reliable transports at startup" into 15	8 years ago
Jenkins2	29be9661a3	Merge "res_pjsip_registrar_expire: Mark module deprecated." into 15	8 years ago
Jenkins2	def9790012	Merge "res_pjsip_session: Prevent crash during shutdown." into 15	8 years ago
Corey Farrell	2a05a05038	res_pjsip_registrar_expire: Mark module deprecated. ... The functionality of this module was already moved to res_pjsip_registrar, mark it deprecated and add message to CHANGES. Change-Id: I90c7d52c7e15e85fde3389d5eaccb05b97848813	8 years ago
Richard Mudgett	5dce58ea94	res_pjsip_registrar.c: Fix compiler error. ... Need to include signal.h to define pthread_kill() and SIGURG. Change-Id: I10ae3aa4bf8e7386ac29ade78c0f2caed8e674fa	8 years ago
Corey Farrell	0b97170588	res_pjsip_session: Prevent crash during shutdown. ... pjproject does not have a function to reverse pjsip_inv_usage_init. This means we need to ignore any calls to the functions once shutdown is final. ASTERISK-27571 #close Change-Id: Ia550fcba563e2328f03162d79fb185f16b7c9b9d	8 years ago
George Joseph	af2fedb6ba	res_pjsip_pubsub: Prune subs with reliable transports at startup ... In an earlier release, inbound registrations on a reliable transport were pruned on Asterisk restart since the TCP connection would have been torn down and become unusable when Asterisk stopped. This same process is now also applied to inbound subscriptions. Also fixed issues in res_pjsip_registrar where it wasn't handling the monitoring correctly when multiple registrations came in over the same transport. To accomplish this, the pjsip_transport_event feature needed to be refactored to allow multiple monitors (multiple subcriptions or registrations from the same endpoint) to exist on the same transport. Since this changed the API, any external modules that may have used the transport monitor feature (highly unlikey) will need to be changed. ASTERISK-27612 Reported by: Ross Beer Change-Id: Iee87cf4eb9b7b2b93d5739a72af52d6ca8fbbe36	8 years ago
George Joseph	7bc91d06df	res_pjsip_registrar_expire: Refactor into res_pjsip_register ... res_pjsip_registrar_expire remains as an empty module for now. Change-Id: Ib93698938bae548d2199cb542f3692d1a171239f	8 years ago
Sean Bright	0361a073fe	res_pjsip: Document tlsv1_1 and tlsv1_2 methods ... Change-Id: I67ed9039bf3f132fb20ee7a750e0aef0f704d7d3	8 years ago
Jenkins2	c167808c9f	Merge "res_pjsip: Split type=identify to IP address and SIP header matching priorities" into 15	8 years ago
Jenkins2	0153081f9b	Merge "res_stasis_recording: Allow symbolic links in configured recordings dir." into 15	8 years ago
Jenkins2	f88ff34c47	Merge "config_transport: Enable TCP_NODELAY on TLS transports" into 15	8 years ago
George Joseph	176a09e3f3	config_transport: Enable TCP_NODELAY on TLS transports ... We did this for TCP transports already but I'm not sure why we didn't do it for TLS transports. ASTERISK_27474 #not_final_fix Change-Id: I5b1ef4b882f7b859e718236686b7898751dbb262	8 years ago
Corey Farrell	deebabfdb1	res_stasis_recording: Allow symbolic links in configured recordings dir. ... If any component of ast_config_AST_RECORDING_DIR is a symbolic link we would incorrectly assume the ARI user was trying to escape the recording path. Create additional check to check the recording directory's realpath, only deny access if both do not match. This is needed by the testsuite when run by 'run-local'. Change-Id: I9145e841865edadcb5f75cead3471ad06bbb56c0	8 years ago
Alexander Traud	45d2c913f4	res_config_pgsql: Avoid typecasting an int to unsigned char. ... clang 5.0 warned about this. ASTERISK-27576 Change-Id: If41f400a51973c06cdb9b75462e535b616bfe385	8 years ago
Richard Mudgett	821b718a96	res_pjsip: Split type=identify to IP address and SIP header matching priorities ... The type=identify endpoint identification method can match by IP address and by SIP header. However, the SIP header matching has limited usefulness because you cannot specify the SIP header matching priority relative to the IP address matching. All the matching happens at the same priority and the order of evaluating the identify sections is indeterminate. e.g., If you had two type=identify sections where one matches by IP address for endpoint alice and the other matches by SIP header for endpoint bob then you couldn't predict which endpoint is matched when a request comes in that matches both. * Extract the SIP header matching criteria into its own "header" endpoint identification method so the user can specify the relative priority of the SIP header and the IP address matching criteria in the global endpoint_identifier_order option. The "ip" endpoint identification method now only matches by IP address. ASTERISK-27491 Change-Id: I9df142a575b7e1e3471b7cda5d3ea156cef08095	8 years ago
Jenkins2	ac8a549b9e	Merge "res_pjsip_endpoint_identifier_ip.c: Remove unnecessary requirement." into 15	8 years ago
Jenkins2	6fa4f69d50	Merge "res_pjsip.c: Update the endpoint identification documentation." into 15	8 years ago
Jenkins2	9511f2c3af	Merge "res_pjsip.c: Fix ident_to_str() and refactor ident_handler()." into 15	8 years ago
Joshua Colp	b4d2d91d43	Merge "res_pjsip_endpoint_identifier_ip.c: Allow multiple IdentifyDetail AMI events." into 15	8 years ago
Joshua Colp	0bcd02b2e0	Merge "res_stasis: Reduce RAII_VAR usage." into 15	8 years ago
Jenkins2	411a7f12dc	Merge "res_pjsip_session: Always bundle streams if WebRTC is enabled." into 15	8 years ago
Richard Mudgett	6d9482267b	res_pjsip.c: Update the endpoint identification documentation. ... * Endpoint identify_by documentation. * IP/Header endpoint identifier documentation. Change-Id: Id92f00b495acca7be945daf749d2abd7f76a0b5a	8 years ago
Richard Mudgett	74ba8398fe	res_pjsip_endpoint_identifier_ip.c: Remove unnecessary requirement. ... The requirement that "ip" must be in the endpoint identify_by list to allow the type=identify method to identify the endpoint is not necessary. The "ip" identifier method can match one and only one endpoint. To even work, the "ip" identifier method configuration must explicitly specify the identified endpoint. Therefore, why bother configuring the type=identify identifier in the first place? The requirement only adds the potential for configuration errors for no benefit. Even worse, those configuration errors cannot be detected when the configuration loads. The requirement was introduced with the ASTERISK_27206 patch. * Remove the code change that enforces the requiremnt. Listing the "ip" method in the identify_by value is simply documentation. Change-Id: Ia057f92a33fb5d9f51dc5d5692e3d5ee1a6f2c11	8 years ago
Richard Mudgett	3a4e949a0e	res_pjsip.c: Fix ident_to_str() and refactor ident_handler(). ... * Extracted sip_endpoint_identifier_type2str() and sip_endpoint_identifier_str2type() to simplify the calling functions. * Fixed pjsip_configuration.c:ident_to_str() building the endpoint's identify_by value string. Change-Id: Ide876768a8d5d828b12052e2a75008b0563fc509	8 years ago
Richard Mudgett	2b24d941b9	res_pjsip_endpoint_identifier_ip.c: Allow multiple IdentifyDetail AMI events. ... The AMI PJSIPShowEndpoint action could only list one IdentifyDetail AMI event per endpoint. However, there is no reason that multiple type=identify sections cannot identify the same endpoint. * Reworked format_ami_endpoint_identify() to generate as many IdentifyDetail AMI events as there are matching identifiers. Change-Id: Ie146792aef72d78e05416ab5b27bc552a30399db	8 years ago