16734 Commits (7841475abe63dc75aecc209cac6d15ea8b24cca9)

 

All Branches   

Search

Author	SHA1	Message	Date
Mark Michelson	f150dfb95a	Merged revisions 140299 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r140299 | mmichelson | 2008-08-27 14:49:20 -0500 (Wed, 27 Aug 2008) | 11 lines Fix tag checking in get_sip_pvt_byid_locked when in pedantic mode. The problem was that the wrong tags would be compared depending on the direction of the call. (closes issue #13353) Reported by: flefoll Patches: chan_sip.c.br14.139015.patch-refer-pedantic uploaded by flefoll (license 244) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@140301 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Doug Bailey	3aca08d924	Move the mwi send thread functionality back into the do_monitor thread so that it is easier to manage CID spill resources when do_monitor needs to be killed. ... (closes issue #13213) Reported by: bbryant git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@140246 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Jeff Peeler	be000109dc	Merged revisions 140056 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r140056 | jpeeler | 2008-08-26 10:57:02 -0500 (Tue, 26 Aug 2008) | 9 lines (closes issue #12071) Reported by: tzafrir Patches: dahdi_close.diff uploaded by tzafrir (license 46) Tested by: tzafrir, jpeeler This patch fixes closing open file descriptors in the case of an error. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@140205 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	4de113179d	OpenBSD compat fix (reminded by mvanbaak on #asterisk-dev) ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@140201 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Russell Bryant	93ee81f9f8	Fix building menuselect-tree with PRINT_DIR set. We _must_ use the --quiet ... flag here, or else some arbitrary text will end up in the resulting menuselect-tree file and things will explode. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@140169 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	74dfd3fcea	Standardize the option names for consistency (but continue to work with the ... existing names for backwards compatibility). (closes issue #13370) Reported by: jsturtevant git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@140167 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Jeff Peeler	36c196abcd	Blocked revisions 140115 via svnmerge ... ........ r140115 | jpeeler | 2008-08-26 11:49:57 -0500 (Tue, 26 Aug 2008) | 1 line add HAVE_PRI if define around dahdi_close_pri_fd ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@140116 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Russell Bryant	d787786ac9	Merged revisions 140060 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r140060 | russell | 2008-08-26 11:07:58 -0500 (Tue, 26 Aug 2008) | 6 lines Fix some bogus scheduler usage in chan_sip. This code used the return value of a completely unrelated function to determine whether the scheduler should be run or not. This would have caused the scheduler to not run in cases where it should have. Also, leave a note about another scheduler issue that needs to be addressed at some point. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@140061 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Steve Murphy	8953b0f359	(closes issue #13366) ... Reported by: erousseau This was a reasonable enhancement request, which was easy to implement. Since it's an enhancement, it could only be applied to trunk. Basically, for accounting where "initiated" seconds are billed for, if the microseconds field on the end time is greater than the microseconds field for the answer time, add one second to the billsec field. The implementation was requested by erousseau, and I've implemented it as requested. I've updated the CHANGES, the cdr.conf.sample, and the .h files accordingly, to accept and set a flag for the corresponding new option. cdr.c adds in the extra second based on the usec fields if the option is set. Tested, seems to be working fine. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@140057 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Russell Bryant	b296adfe8e	Merged revisions 140051 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r140051 | russell | 2008-08-26 10:27:23 -0500 (Tue, 26 Aug 2008) | 15 lines Fix a race condition with the IAX scheduler thread. A lock and condition are used here to allow newly scheduled tasks to wake up the scheduler just in case the new task needs to run sooner than the current wakeup time when the thread is sleeping. However, there was a race condition such that a newly scheduled task would not properly wake up the scheduler or affect the wake up period. The order of execution would have been: 1) Scheduler thread determines wake up time of N ms. 2) Another thread schedules a task and signals the condition, with an execution time of < N ms. 3) Scheduler thread locks and goes to sleep for N ms. By moving the sleep time determination to inside the critical section, this possibility is avoided. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@140053 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Terry Wilson	8903409298	Blocked revisions 140050 via svnmerge ... ........ r140050 | twilson | 2008-08-26 10:22:58 -0500 (Tue, 26 Aug 2008) | 4 lines sounds/Makefile installs sounds using the "new" language directory structure, but languageprefix needs to be set = yes for sounds in subdirectories (digits/1, etc.) to play as the correct language. Fix the generation of asterisk.conf to include languageprefix=yes ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@140052 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	6dd5b8609f	Optional light colored background, for those who use black on white terminals. ... (closes issue #13306) Reported by: Corydon76 Patches: 20080814__bug13306__3.diff.txt uploaded by Corydon76 (license 14) Tested by: Corydon76, pkempgen git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@139981 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Jeff Peeler	4a122b5d8c	Merged revisions 139927 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r139927 | jpeeler | 2008-08-25 16:47:33 -0500 (Mon, 25 Aug 2008) | 3 lines Fix a typo I made. Lesson learned, apply the patch if one exists. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@139928 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Sean Bright	7c6f577aaa	Merged revisions 139909 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r139909 | seanbright | 2008-08-25 17:31:03 -0400 (Mon, 25 Aug 2008) | 9 lines Some versions of awk (nawk, for example) don't like empty regular expressions so be slightly more verbose. (closes issue #13374) Reported by: dougm Patches: 13374.diff uploaded by seanbright (license 71) Tested by: dougm ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@139915 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Terry Wilson	2717c21561	Merged revisions 139869 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r139869 | twilson | 2008-08-25 15:46:10 -0500 (Mon, 25 Aug 2008) | 2 lines Make SIPADDHEADER() propagate indefinitely ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@139870 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Mark Michelson	e833fd2ab1	Add output of variables to AgentRingNoAnswer manager ... event if eventwhencalled is set to "vars" in queues.conf. Yay for consistency. (closes issue #13369) Reported by: srt Patches: 13369_agentringnoanswer_variables.diff uploaded by srt (license 378) git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@139832 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	8d62c61678	Realtime capabilities for the Find-Me-Follow-Me application. ... (closes issue #13295) Reported by: Corydon76 Patches: 20080813__followme_realtime_enabled.diff.txt uploaded by Corydon76 (license 14) Tested by: dferrer git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@139775 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Mark Michelson	33252a1547	Blocked revisions 139769 via svnmerge ... ........ r139769 | mmichelson | 2008-08-25 10:52:59 -0500 (Mon, 25 Aug 2008) | 12 lines Fix the logic in config_text_file_save so that if an UpdateConfig manager action is issued and the file specified in DstFileName does not yet exist, an error is not returned. (closes issue #13341) Reported by: vadim Patches: 13341.patch uploaded by putnopvut (license 60) (with small modification from seanbright) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@139771 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Steve Murphy	ea898dc6c3	Merged revisions 139764 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r139764 | murf | 2008-08-25 09:33:14 -0600 (Mon, 25 Aug 2008) | 9 lines This patch reverts the changes made via 139347, and 139635, as users are seeing adverse difference. I will un-close 13251. Back to the drawing board/ concept/ beginning/ whatever! ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@139770 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	8be98abf79	Memory leak ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@139707 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	a88af95df4	Eliminate open coding of ast_str ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@139704 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Steve Murphy	de1af295c8	Merged revisions 139635 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r139635 | murf | 2008-08-22 16:24:02 -0600 (Fri, 22 Aug 2008) | 6 lines I found some problems with the code I committed earlier, when I merged them into trunk, so I'm coming back to clean up. And, in the process, I found an error in the code I added to trunk and 1.6.x, that I'll fix using this patch also. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@139662 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Steve Murphy	2488366a75	Merged revisions 139347 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r139347 | murf | 2008-08-21 17:03:50 -0600 (Thu, 21 Aug 2008) | 47 lines (closes issue #13251) Reported by: sergee Tested by: murf THis is a bold move for a static release fix, but I wouldn't have made it if I didn't feel confident (at least a *bit* confident) that it wouldn't mess everyone up. The reasoning goes something like this: 1. We simply cannot do anything with CDR's at the current point (in pbx.c, after the __ast_pbx_run loop). It's way too late to have any affect on the CDRs. The CDR is already posted and gone, and the remnants have been cleared. 2. I was very much afraid that moving the running of the 'h' extension down into the bridge code (where it would be now practical to do it), would result in a lot more calls to the 'h' exten, so I implemented it as another exten under another name, but found, to my pleasant surprise, that there was a 1:1 correspondence to the running of the 'h' exten in the pbx_run loop, and the new spot at the end of the bridge. So, I ifdef'd out the current 'h' loop, and moved it into the bridge code. The only difference I can see is the stuff about the AST_PBX_KEEPALIVE, and hopefully, if this is still an important decision point, I can replicate it if there are complaints. To be perfectly honest, the KEEPALIVE situation is not totally clear to me, and how it relates to a post-bridge situation is less clear. I suspect the users will point out everything in total clarity if this steps on anyone's toes! 3. I temporarily swap the bridge_cdr into the channel before running the 'h' exten, which makes it possible for users to edit the cdr before it goes out the door. And, of course, with the endbeforehexten config var set, the users can also get at the billsec/duration vals. After the h exten finishes, the cdr is swapped back and processing continues as normal. Please, all who deal with CDR's, please test this version of Asterisk, and file bug reports as appropriate! ........ I also made a little fix to the app_dial's 'e' option, that is related to my updates. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@139627 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Jeff Peeler	618b3eb8f8	Merged revisions 139621 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r139621 | jpeeler | 2008-08-22 16:36:13 -0500 (Fri, 22 Aug 2008) | 5 lines (closes issue #13359) Reported by: Laureano Patches: originate_channel_check.patch uploaded by Laureano (license 265) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@139624 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Jeff Peeler	ea788c02e7	remove extra comma typo ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@139622 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Mark Michelson	261d1eeb13	The -1 return value from incomplete or improper ... headers for the SipNotify manager command was causing the current manager session to become disconnected. Change the return value to 0 for these cases. Also change a test for a NULL pointer to be ast_strlen_zero instead. (closes issue #13351) Reported by: Laureano Patches: sipnotify_action_fix.patch uploaded by Laureano (license 265) git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@139563 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Mark Michelson	060f6d5c3d	Add missing unique id to ParkedCallGiveUp and ParkedCallTimeOut ... manager events (closes issue #13358) Reported by: srt Patches: 13358_parking_events.diff uploaded by srt (license 378) git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@139558 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Mark Michelson	c0754e89ad	Merged revisions 139553 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r139553 | mmichelson | 2008-08-22 14:45:19 -0500 (Fri, 22 Aug 2008) | 8 lines Fix compilation when DEBUG_THREAD_LOCALS is selected (closes issue #13298) Reported by: snuffy Patches: bug13298_20080822.diff uploaded by snuffy (license 35) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@139554 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Mark Michelson	93fa8f7649	Blocked revisions 139521 via svnmerge ... ........ r139521 | mmichelson | 2008-08-22 14:23:02 -0500 (Fri, 22 Aug 2008) | 8 lines Remove show_frame_stats_deprecated since it is not used anywhere and causes build errors if building under dev-mode with TRACE_FRAMES selected in menuselect. (closes issue #13362) Reported by: snuffy ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@139525 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Mark Michelson	e13a77e628	Merged revisions 139466 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r139466 | mmichelson | 2008-08-22 12:24:47 -0500 (Fri, 22 Aug 2008) | 3 lines Fix the build. Thanks, mvanbaak! ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@139469 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Mark Michelson	8b5c762f83	Merged revisions 139456 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r139456 | mmichelson | 2008-08-22 11:57:38 -0500 (Fri, 22 Aug 2008) | 7 lines Prevent a deadlock in chan_iax2 resulting from incorrect locking order between iax2_pvt and ast_channel structures. AST-13 ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@139457 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Jeff Peeler	a9af5a81c9	Merged revisions 139387 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r139387 | jpeeler | 2008-08-21 18:39:31 -0500 (Thu, 21 Aug 2008) | 3 lines Fixes loop that could possibly never exit in the event of a channel never being able to be opened or specify after a restart. (closes issue #11017) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@139391 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Dwayne M. Hubbard	a33f98a576	oops ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@139346 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Dwayne M. Hubbard	b639acbde9	initiate T38 negotiation in FaxSend; use channel variables; other stuff too ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@139345 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Philippe Sultan	6571a25767	Fix two memory leaks in chan_gtalk, thanks Eliel! ... (closes issue #13310) Reported by: eliel Patches: chan_gtalk.c.patch uploaded by eliel (license 64) git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@139281 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Russell Bryant	89eaa39a6a	Merged revisions 139213 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r139213 | russell | 2008-08-20 17:14:35 -0500 (Wed, 20 Aug 2008) | 11 lines Fix a crash in the ChanSpy application. The issue here is that if you call ChanSpy and specify a spy group, and sit in the application long enough looping through the channel list, you will eventually run out of stack space and the application with exit with a seg fault. The backtrace was always inside of a harmless snprintf() call, so it was tricky to track down. However, it turned out that the call to snprintf() was just the biggest stack consumer in this code path, so it would always be the first one to hit the boundary. (closes issue #13338) Reported by: ruddy ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@139215 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Jason Parker	d22fe17322	Fix output of sipshowpeer manager response. ... (closes issue #13346) Reported by: srt Patches: 13346_malformed_sip_show_peer_response.diff uploaded by srt (license 378) git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@139210 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Shaun Ruffell	b39e0f3c66	Remove extraneous debugging messages. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@139154 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Shaun Ruffell	f75d794c69	Fix bug where the samples were not accurate when in G723 mode, which would ... cause the timestamp field of the RTP header to be invalid. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@139153 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Kevin P. Fleming	3e1f872538	Blocked revisions 139145 via svnmerge ... ........ r139145 | kpfleming | 2008-08-20 14:35:59 -0500 (Wed, 20 Aug 2008) | 8 lines Backport support for Zaptel/DAHDI channel-level alarms from trunk/1.6, because not doing so just makes it difficult for people with channels that are in alarm when Asterisk starts up to get them going once the alarm is cleared (closes issue #12160) Reported by: tzafrir Patches: asterisk-chanalarms_14.patch uploaded by tzafrir (license 46) Tested by: tzafrir ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@139146 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Steve Murphy	1b2e0a4365	Merged revisions 139074 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r139074 | murf | 2008-08-20 11:14:55 -0600 (Wed, 20 Aug 2008) | 12 lines (closes issue #13263) Reported by: brainy Tested by: murf The specialized reset routine is tromping on the flags field of the CDR. I made a change to not reset the DISABLED bit. This should get rid of this problem. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@139083 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Michiel van Baak	877549af70	fix unholding phones after hangup on older cisco phones. ... Patch by wedhorn. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@139020 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Mark Michelson	c4b34ef45d	Merged revisions 139015 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r139015 | mmichelson | 2008-08-20 10:37:56 -0500 (Wed, 20 Aug 2008) | 6 lines sip_read should properly handle a NULL return from sip_rtp_read. (closes issue #13257) Reported by: travishein ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@139016 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Jeff Peeler	78c68e8015	Blocked revisions 138949 via svnmerge ... ........ r138949 | jpeeler | 2008-08-19 18:22:39 -0500 (Tue, 19 Aug 2008) | 1 line add DAHDI_POLICY_WHEN_FULL compatability define for Zaptel ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@138951 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Mark Michelson	b11ecaf4d6	Merged revisions 138942 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r138942 | mmichelson | 2008-08-19 18:17:17 -0500 (Tue, 19 Aug 2008) | 11 lines Reset agent_pvt variables back to the values in agents.conf (from what the corresponding channel variables were set to) when the agent logs out. (closes issue #13098) Reported by: davidw Patches: 20080731__issue13098_agent_ackcall_not_reset.diff uploaded by bbryant (license 36) Tested by: davidw ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@138943 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Jeff Peeler	fb5a025b71	Blocked revisions 138938 via svnmerge ... ........ r138938 | jpeeler | 2008-08-19 17:56:07 -0500 (Tue, 19 Aug 2008) | 7 lines Add configuration option to chan_dahdi.conf to allow buffering policy and number of buffers to be configured per channel. Syntax: buffers=<num of buffers>,<policy> Where the number of buffers is some non-negative integer and the policy is either "full", "half", or "immediate". ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@138939 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Mark Michelson	b949d5347e	Merged revisions 138886 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r138886 | mmichelson | 2008-08-19 13:50:53 -0500 (Tue, 19 Aug 2008) | 23 lines Add a lock and unlock prior to the destruction of the chanspy_ds lock to ensure that no other threads still have it locked. While this should not happen under normal circumstances, it appears that if the spyer and spyee hang up at nearly the same time, the following may occur. 1. ast_channel_free is called on the spyee's channel. 2. The chanspy datastore is removed from the spyee's channel in ast_channel_free. 3. In the spyer's thread, the spyer attempts to remove and destroy the datastore from the spyee channel, but the datastore has already been removed in step 2, so the spyer continues in the code. 4. The spyee's thread continues and calls the datastore's destroy callback, chanspy_ds_destroy. This involves locking the chanspy_ds. 5. Now the spyer attempts to destroy the chanspy_ds lock. The problem is that in step 4, the spyee has locked this lock, meaning that the spyer is attempting to destroy a lock which is currently locked by another thread. The backtrace provided in issue #12969 supports the idea that this is possible (and has even occurred). This commit does not close the issue, but should help in preventing one type of crash associated with the use of app_chanspy. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@138887 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Michiel van Baak	3f3b1d4dad	chan_skinny now respects callwaiting=no ... (closes issue #12691) Reported by: sbisker Patches: callwaitingv1.diff uploaded by wedhorn (license 30) Tested by: wedhorn on old skinny phones, mvanbaak on 7960 and 7905 with latest firmware git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@138851 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Steve Murphy	d78f79d82c	Oops. put a decl in a generated file. My bad, but fixed now. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@138845 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Steve Murphy	04795d963f	These changes are in regards to bug 13249, where users are being surprised by the changes made ... to the Set app in trunk/1.6.x, as they come from the 1.4 world. They are only bitten if they write their AEL dialplan in the 1.4 world, and then carry it over to a trunk/1.6.x installation where a "make samples" was executed, or where they hand-edited the asterisk.conf file and added the [compat] category with app_set = 1.6 (or higher). (this commit does not totally solve 13249, at least not yet) The change involves issueing a single warning while the AEL file is loading, if: 1. app_set is present in the config file, and set to 1.6 or higher. 2. there are double quotes in an assignment statement (eg x = "hi there";) 3. the warning was not already issued. The standalone app, aelparse, does not (yet) issue this warning. I'd have to have it read in the asterisk.conf file, and that's a bit of hassle. I'll add it if users request it, tho. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@138815 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago