asterisk

Commit Graph

Author	SHA1	Message	Date
Michiel van Baak	f1e9371da8	- revert change to ast_queue_hangup and create ast_queue_hangup_with_cause - make data member of the ast_frame struct a named union instead of a void Recently the ast_queue_hangup function got a new parameter, the hangupcause Feedback came in that this is no good and that instead a new function should be created. This I did. The hangupcause was stored in the seqno member of the ast_frame struct. This is not very elegant, and since there's already a data member that one should be used. Problem is, this member was a void *. Now it's a named union so it can hold a pointer, an uint32 and there's a padding in case someone wants to store another type in there in the future. This commit is so massive, because all ast_frame.data uses have to be altered to ast_frame.data.data Thanks russellb and kpfleming for the feedback. (closes issue #12674) Reported by: mvanbaak git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117802 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Russell Bryant	a82ab5369e	minor formatting changes git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@97804 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Kevin P. Fleming	a20b146df5	add a file-format driver for 16KHz signed linear... which may or may not work git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@96862 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago

Author

SHA1

Message

Date

Michiel van Baak

f1e9371da8

- revert change to ast_queue_hangup and create ast_queue_hangup_with_cause

- make data member of the ast_frame struct a named union instead of a void

Recently the ast_queue_hangup function got a new parameter, the hangupcause
Feedback came in that this is no good and that instead a new function should be created.
This I did.

The hangupcause was stored in the seqno member of the ast_frame struct. This is not very
elegant, and since there's already a data member that one should be used.
Problem is, this member was a void *.
Now it's a named union so it can hold a pointer, an uint32 and there's a padding in case someone
wants to store another type in there in the future.

This commit is so massive, because all ast_frame.data uses have to be
altered to ast_frame.data.data

Thanks russellb and kpfleming for the feedback.

(closes issue #12674)
Reported by: mvanbaak


git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117802 65c4cc65-6c06-0410-ace0-fbb531ad65f3

Russell Bryant

a82ab5369e

minor formatting changes

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@97804 65c4cc65-6c06-0410-ace0-fbb531ad65f3

Kevin P. Fleming

a20b146df5

add a file-format driver for 16KHz signed linear... which may or may not work

git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@96862 65c4cc65-6c06-0410-ace0-fbb531ad65f3

3 Commits (71ebf2e7ca7ed51a88d46a1ac58aed1945b97cd8)