4252 Commits (70027059409cb042e40b68ee83d87cc5386160df)

Author	SHA1	Message	Date
Jenkins2	89859f33b2	Merge "res_pjsip: Fix issues that prevented shutdown of modules."	9 years ago
Jenkins2	b877181cd9	Merge "res_pjsip_session: Fix format_cap leak."	9 years ago
Jenkins2	4914311150	Merge "res_pjsip: Fix leak of persistent endpoint references."	9 years ago
Jenkins2	13c1c72401	Merge "res_sdp_translator_pjmedia: Fix test unregistration."	9 years ago
hajekd	a0a1f95abf	res/res_ari.c Fix: Memory leaks in ARI when using Content-Type: application/json ... ASTERISK-27305 Reported by: David Hajek Tested by: David Hajek Change-Id: Ife3e289062e6cf7d0e7d342dbf79ed96feff441e	9 years ago
Corey Farrell	eb224fea5e	res_pjsip_session: Fix format_cap leak. ... ASTERISK-27306 Change-Id: I2c8d3fc148f9f53715c958314e1146f9611741f3	9 years ago
Corey Farrell	a68a91f722	res_pjsip: Fix leak of persistent endpoint references. ... Do not manually call sip_endpoint_apply_handler from load_all_endpoints. This is not necessary and causes memory leaks. Additionally reinitialize persistent->aors when we reuse a persistent object with a new endpoint. ASTERISK-27306 Change-Id: I59bbfc8da8a14d5f4af8c5bb1e71f8592ae823eb	9 years ago
Jenkins2	d4be387d41	Merge "res_pjsip: Fix leak of fake_auth references."	9 years ago
Corey Farrell	b35ac9e566	res_pjsip: Fix leak of fake_auth references. ... pjsip_distributor leaks references to fake_auth when the default realm has not changed. ASTERISK-27306 Change-Id: I3fcf103b3680ad2d1d4610dcd6738eeaebf4d202	9 years ago
Corey Farrell	0b6be1b2d4	res_sdp_translator_pjmedia: Fix test unregistration. ... ASTERISK-27306 Change-Id: Ib3ed47167cb697ab7bd0a56cab589893f491651b	9 years ago
Daniel Tryba	59b6e8467a	res_pjsip_caller_id chan_sip: Comply to RFC 3323 values for privacy ... Currently privacy requests are only granted if the Privacy header value is exactly "id" (defined in RFC 3325). It ignores any other possible value (or a combination there of). This patch reverses the logic from testing for "id" to grant privacy, to testing for "none" and granting privacy for any other value. "none" must not be used in combination with any other value (RFC 3323 section 4.2). ASTERISK-27284 #close Change-Id: If438a21f31a962da32d7a33ff33bdeb1e776fe56	9 years ago
Corey Farrell	7d04544986	res_pjsip: Fix issues that prevented shutdown of modules. ... res_pjsip and res_pjsip_session had circular references, preventing both modules from shutting down. * Move session supplement registration to res_pjsip. * Use create internal functions for use by pjsip_message_filter.c. ASTERISK-27306 Change-Id: Ifbd5c19ec848010111afeab2436f9699da06ba6b	9 years ago
krells	2301447a20	res_calendar_icalendar: Filter out occurrences superceded by another VEVENT ... When we are loading the calendars, we call libical's icalcomponent_foreach_recurrence method for each VEVENT component that we have in our calendar. That method has no knowledge concerning the existence of the other VEVENT components and will feed our callback with all ocurrences matching the requested time span. The occurrences generated by icalcomponent_foreach_recurrence while expanding a recurring VEVENT's RRULE and RDATE properties can be superceded by an other VEVENT sharing the same UID. I use an external iterator (in libical terminology) to avoid messing with the internal ones from the calling function, and search for VEVENTS which could supersede the current occurrence. The event which can invalidate this occurence needs to have: - the same UID as our recurrent component (comp) - a RECURRENCE-ID property, which represents the start time of this occurrence If one component is found, just clean and return. ASTERISK-27296 #close Reported by: Benoît Dereck-Tricot Change-Id: I8587ae3eaa765af7cb21eda3b6bf84e8a1c87af8	9 years ago
Jenkins2	5307659e96	Merge "pjsip_message_filter: Fix regression causing bad contact address"	9 years ago
Joshua Colp	47d68401d7	Merge "res_stasis: Add 'video_sfu' as a requested bridge type."	9 years ago
Joshua Colp	dd4c573e6d	Merge "res_pjsip_session: outgoing call did not offer all configured codecs"	9 years ago
Joshua Colp	a78ffe96a8	Merge "res_rtp_asterisk.c: Fix bridge_p2p_rtp_write() reentrancy potential."	9 years ago
Joshua Colp	4ea4364eef	Merge "res_rtp_asterisk: Trim trailing byte off of SDES packet"	9 years ago
Joshua Colp	f21408c866	res_stasis: Add 'video_sfu' as a requested bridge type. ... This change adds 'video_sfu' as a requested bridge type when creating a bridge. By specifying this a mixing type bridge is created that exchanges video in an SFU fashion. Change-Id: I2ada47cf5f3fc176518b647c0b4aa39d55339606	9 years ago
Richard Mudgett	a6dc0527a2	res_pjsip_outbound_publish.c: Fix misplaced parenthesis. ... The pjsip_publishc_init() call was referenced with a misplaced parentheses. As a result, outbound publication messages went out with an expiration of 1 second. ASTERISK-27298 Change-Id: I93622eabc8ee83e7a22e98c107f921284c605a08	9 years ago
George Joseph	61ea872233	pjsip_message_filter: Fix regression causing bad contact address ... The "res_pjsip: Filter out non SIP(S) requests" commit moved the filtering of messages to pjproject's PJSIP_MOD_PRIORITY_TRANSPORT_LAYER in order to filter out incoming bad uri schemes as early as possible. Since the change affected outgoing messages as well and the TRANSPORT layer is the last to be run on outgoing messages, we were overwriting the setting of external_signaling_address (which is set earlier by res_pjsip_nat) with an internal address. * pjsip_message_filter now registers itself as a pjproject module twice. Once in the TSX layer for the outgoing messages (as it was originally), then a second time in the TRANSPORT layer for the incoming messages to catch the invalid uri schemes. ASTERISK-27295 Reported by: Sean Bright Change-Id: I2c90190c43370f8a9d1c4693a19fd65840689c8c	9 years ago
Richard Mudgett	9d65057cdf	res_rtp_asterisk.c: Fix bridge_p2p_rtp_write() reentrancy potential. ... The bridge_p2p_rtp_write() has potential reentrancy problems. * Accessing the bridged RTP members must be done with the instance1 lock held. The DTMF and asymmetric codec checks must be split to be done with the correct RTP instance struct locked. i.e., They must be done when working on the appropriate side of the point to point bridge. * Forcing the RTP mark bit was referencing the wrong side of the point to point bridge. The set mark bit is used everywhere else to set the mark bit when sending not receiving. The patches for ASTERISK_26745 and ASTERISK_27158 did not take into account that not everything carried by RTP uses a codec. The telephony DTMF events are not exchanged with a codec. As a result when RFC2833/RFC4733 sent digits you would crash if "core set debug 1" is enabled, the DTMF digits would always get passed to the core even though the local native RTP bridge is active, and the DTMF digits would go out using the wrong SSRC id. * Add protection for non-format payload types like DTMF when updating the lastrxformat and lasttxformat. Also protect against non-format payload types when checking for asymmetric codecs. ASTERISK-27292 Change-Id: I6344ab7de21e26f84503c4d1fca1a41579364186	9 years ago
Sean Bright	c9e972a26a	res_rtp_asterisk: Trim trailing byte off of SDES packet ... This could have been fixed by subtracting 1 from the final value of 'len' but the way the packet was being constructed was confusing so I took the opportunity to (I think) make it more clear. We were sending 1 extra byte at the end of the SDES RTCP packet which caused Chrome to complain (in its debug log): Too little data (1 byte) remaining in buffer to parse RTCP header (4 bytes). We now send the correct number of bytes. Change-Id: I9dcf087cdaf97da0374ae0acb7d379746a71e81b	9 years ago
Joshua Colp	c8a8933558	Merge "webrtc: Allow 'webrtc' to be set on endpoints without dtls_ca_file"	9 years ago
Joshua Colp	87c4a72f16	Merge "res_pjsip_session: Reduce (and improve) SDP renegotiation."	9 years ago
Sean Bright	721947ebae	webrtc: Allow 'webrtc' to be set on endpoints without dtls_ca_file ... If using a legitimate certificate from a trusted certificate authority, you don't need to provide CA file. Change-Id: I8623973b4209b44889243716d7880274caed8a6d	9 years ago
Kevin Harwell	b74cbadd05	res_pjsip_session: outgoing call did not offer all configured codecs ... For some scenarios when an outgoing call was made only a subset of the configured codecs were offered. If the codecs being offered happened to not have a codec supported by the phone then the call would fail. For instance Alice and Bob both are configured in Asterisk for g722 and ulaw( allow=!all,g722,ulaw). Alice's endpoint however only supports g722 while Bob's only supports ulaw. When Alice calls Bob, Alice negotiates g722 fine with Asterisk. But when Asterisk sends the outgoing offer to Bob it only contains g722 and not both g722 and ulaw, so the call ends. This patch makes it so all the audio codecs configured on the endpoint always get sent, and not just a subset. However priority is given to those codecs that are compatible with the "other side". ASTERISK-27259 #close Change-Id: Iffabc373bd94cd1dc700925dcfe406e12918c696	9 years ago
Joshua Colp	360bd11c30	Merge "res_pjsip_session: Don't end session when receiving a 500 on a reinvite"	9 years ago
Joshua Colp	1b468b543d	Merge "res_pjsip: Use ast_sip_is_content_type() where appropriate"	9 years ago
Joshua Colp	601e0c563f	res_pjsip_session: Reduce (and improve) SDP renegotiation. ... When pruning a request to change the topology of a channel be more intelligent about the resulting topology that is actually used for SDP renegotiation. In a case where a stream has not already been negotiated we don't need to renegotiate and offer a declined stream. This can occur if something in Asterisk (such as ConfBridge) requests to add video to a PJSIP channel that has no video codecs configured. In this case since the stream did not already exist we can safely remove the stream from the requested topology, resulting in no renegotiation occurring. In a case where a renegotiation is requested with a codec that is not supported we can reuse the formats of the existing stream if it exists to ensure that the stream continues to flow, instead of removing it. Change-Id: I636540798d55922377318fe619c510fb6ed125fb	9 years ago
Kevin Harwell	36690c26f8	res_pjsip_session: Don't end session when receiving a 500 on a reinvite ... During a reinvite, if a remote endpoint error occurs and it returns a 500 the session would end. This patch makes it so the session is not terminated, but continues as it was. The reason for this is because some endpoints may send non session terminating "server errors" like a failed codec negotiation. So in this case instead of ending the call it can hopefully continue. In the case of a real server error the session is already "doomed", will be known soon enough and appropriately ended by Asterisk later. Change-Id: Ifeedae86b8cb44b92d52c79046522ec5f0aff1d5	9 years ago
Joshua Colp	f91a905003	Merge "res_pjsip_session/BUNDLE: Handle no audio codecs on endpoint"	9 years ago
Joshua Colp	feadd654af	Merge "res_pjsip_session: Change some asserts to warning/debug messages"	9 years ago
Sean Bright	ebd0a4bebf	res_pjsip: Use ast_sip_is_content_type() where appropriate ... Change-Id: If3ab0d73d79ac4623308bd48508af2bfd554937d	9 years ago
George Joseph	6c0e13da22	res_pjsip_session/BUNDLE: Handle no audio codecs on endpoint ... When an INVITE came in with both audio and video streams but there were no audio codecs defined for the endpoint, we weren't declining the audio stream. Since it's usually the first/transport stream, when the video stream was processed and tried to use the transport, it was empty and caused a crash. We now decline the the stream if there are no matching codecs so when the video stream is processed, it's now the first/transport stream and processes normally. Change-Id: Ic854eda54c95031e66b076ecfae3041d34daa692	9 years ago
Joshua Colp	63a3d17f0b	Merge "res_rtp_asterisk.c: Fix bundled SSRC handling."	9 years ago
Joshua Colp	8b7aed0025	Merge "res_config_pgsql: Fix removed support to previous for versions PostgreSQL 9.1"	9 years ago
Joshua Colp	f77a2367e7	Merge "bridge: Change participant SFU streams when source streams change."	9 years ago
Richard Mudgett	7c93982e9d	res_rtp_asterisk.c: Fix bundled SSRC handling. ... Assertions in the v15+ AST-2017-008 patches found that we were not handling the case if the incoming SDP did not specify the required SSRC attributes for bundled to work. * Be strict on matching SSRC for bundled instances including the parent instance. If the SSRC doesn't match then discard the packet. Bundled has to tell us in the SDP signaling what SSRC to expect. Otherwise, we will not know how to find the bundled instance structure. Change-Id: I152830bbff71c662408909042068fada39e617f9	9 years ago
Joshua Colp	b9f7b03c0b	Merge "AST-2017-008: Improve RTP and RTCP packet processing."	9 years ago
Jenkins2	f01cd0b409	Merge "res_config_pgsql: Add missing \n in debug log and update copyright year"	9 years ago
Joshua Colp	357a2f353b	Merge "res_pjsip_session: Check for removed stream state."	9 years ago
Joshua Colp	f2985e3106	bridge: Change participant SFU streams when source streams change. ... Some endpoints do not like a stream being reused for a new media stream. The frame/jitterbuffer can rely on underlying attributes of the media stream in order to order the packets. When a new stream takes its place without any notice the buffer can get confused and the media ends up getting dropped. This change uses the SSRC change to determine that a new source is reusing an existing stream and then bridge_softmix renegotiates each participant such that they see a new media stream. This causes the frame/jitterbuffer to start fresh and work as expected. ASTERISK-27277 Change-Id: I30ccbdba16ca073d7f31e0e59ab778c153afae07	9 years ago
Jenkins2	5ff46578aa	Merge "res_srtp: lower log level of auth failures"	9 years ago
George Joseph	971548405b	res_pjsip_session: Change some asserts to warning/debug messages ... There was an issue reported where an SDP received on a 183 Session Progress message caused a crash because the pending streams had already been processed when the OK was received. In that case the pending topology was legitimately NULL. There was an assert for an incorrect number of streams in the topology but not one for topology being NULL. In any case, if you're not in dev-mode the asserts don't do anything and since the scenario is legit, the asserts weren't appropriate anyway. * Changed several asserts to warning or debug messages and return codes as appropriate. ASTERISK-27264 Reported by: Daniel Heckl Change-Id: I58daaa9d2938fa980857ab3ec41925ab5ff9c848	9 years ago
Rodrigo Ramírez Norambuena	cad68137a7	res_config_pgsql: Fix removed support to previous for versions PostgreSQL 9.1 ... In PostgreSQL 9.1 the backslash are string literals and not the escape of characters. In previous issue ASTERISK_26057 was fixed the use of escape LIKE but the support for old version of Postgresql than 9.1 was dropped. The sentence before make was "ESCAPE '\'" but in version before than 9.1 need it to be as follow "ESCAPE '\\'". ASTERISK-27283 Change-Id: I96d9ee1ed7693ab17503cb36a9cd72847165f949	9 years ago
Ben Ford	e666051d79	res_pjsip_session: Check for removed stream state. ... When a sip session is refreshed, the stream topology is looped through, checking each stream for compatible formats. This would cause a crash if the stream state was AST_STREAM_STATE_REMOVED, since the formats would never be set for this stream, causing a NULL value to be returned from ast_stream_get_formats. This commit adds a check for streams with removed states. Also removed a stray semicolon. Change-Id: Ic86f8b65a4a26a60885b28b8b1a0b22e1b471d42	9 years ago
Joshua Colp	8830cc0541	Merge "res_calendar: Plug memory leak and micro-optimization"	9 years ago
Alexander Traud	1e4c1cec7f	res_srtp: lower log level of auth failures ... Previously, sRTP authentication failures were reported on log level WARNING. When such failures happen, each RT(C)P packet is affected, spamming the log. Now, those failures are reported at log level VERBOSE 2. Furthermore, the amount is further reduced (previously all two seconds, now all three seconds). Additionally, the new log entry informs whether media (RTP) or statistics (RTCP) are affected. ASTERISK-16898 #close Change-Id: I6c98d46b711f56e08655abeb01c951ab8e8d7fa0	9 years ago
George Joseph	b748038230	res_pjsip_pubsub: Check for Content-Type header in rx_notify_request ... pubsub_on_rx_notify_request wasn't checking for a null Content-Type header before checking that it was application/simple-message-summary. ASTERISK-27279 Reported by: Ross Beer Change-Id: Iec2a6c4d2e74af37ff779ecc9fd35644c5c4ea52	9 years ago