26990 Commits (6fcd361540a2b38724d5f49bd193d97f5522616c)

 

All Branches   

Search

Author	SHA1	Message	Date
Elazar Broad	ec514ad64d	core/logging: Fix logging to more than one syslog channel ... Currently, Asterisk will log to the last configured syslog channel in logger.conf. This is due to the fact that the final call to openlog() supersedes all of the previous calls. This commit removes the call to openlog() and passes the facility to ast_log_vsyslog(), along with utilizing the LOG_MAKEPRI macro to ensure that the message is routed to the correct facility and with the correct priority. ASTERISK-25407 #close Reported by: Elazar Broad Tested by: Elazar Broad Change-Id: Ie2a2416bc00cce1b04e99ef40917c2011953ddd2	10 years ago
Matt Jordan	0ce661f0c0	Merge "app_record: RECORDED_FILE variable not being populated" into 13	10 years ago
Joshua Colp	a45abbf3ce	Merge "pbx: Update device and presence state when changing a hint extension." into 13	10 years ago
Kevin Harwell	aeddee39fb	app_record: RECORDED_FILE variable not being populated ... The RECORDED_FILE variable is empty unless a '%d' is specified in the filename. This patch makes it so the variable is always set to the filename. ASTERISK-25410 #close Change-Id: I4ec826d8eb582ae2ad184e717be8668b74d37653	10 years ago
Matt Jordan	960f00939a	Merge "main/config_options: Check for existance of internal object before derefing" into 13	10 years ago
Matt Jordan	efbd0f5a97	Merge "app_queue: AgentComplete event has wrong reason" into 13	10 years ago
Matt Jordan	c7beb33ebb	Merge "app_queue: Crash when transferring" into 13	10 years ago
Matt Jordan	16f1598b31	Merge "CHAOS: res_pjsip_diversion avoid crash if allocation fails" into 13	10 years ago
Joshua Colp	c02f07b8c4	Merge "chan_sip: Fix From header truncation for extremely long CALLERID(name)." into 13	10 years ago
Joshua Colp	578429a54d	Merge "CHAOS: avoid crash if string create fails" into 13	10 years ago
Joshua Colp	2bd27d1222	pbx: Update device and presence state when changing a hint extension. ... When changing a hint extension without removing the hint first the device state and presence state is not updated. This causes the state of the hint to be that of the previous extension and not the current one. This state is kept until a state change occurs as a result of something (presence state change, device state change). This change updates the hint with the current device and presence state of the new extension when it is changed. Any state callbacks which may have been added before the hint extension is changed are also informed of the new device and presence state if either have changed. ASTERISK-25394 #close Change-Id: If268f1110290e502c73dd289c9e7e7b27bc8432f	10 years ago
Scott Griepentrog	c94f46080f	CHAOS: avoid crash if string create fails ... Validate string buffer allocation before using them. ASTERISK-25323 Change-Id: Ib9c338bdc1e53fb8b81366f0b39482b83ef56ce0	10 years ago
Walter Doekes	b59c4d82b5	chan_sip: Fix From header truncation for extremely long CALLERID(name). ... The CALLERID(num) and CALLERID(name) and other info are placed into the `char from[256]` in initreqprep. If the name was too long, the addr-spec and params wouldn't fit. Code is moved around so the addr-spec with params is placed there first, and then fitting in as much of the display-name as possible. ASTERISK-25396 #close Change-Id: I33632baf024f01b6a00f8c7f35c91e5f68c40260	10 years ago
Richard Mudgett	4cc59533b9	CHAOS: res_pjsip_diversion avoid crash if allocation fails ... Validate ast_malloc buffer returned before using it in set_redirecting_value(). ASTERISK-25323 Change-Id: I15d2ed7cb0546818264c0bf251aa40adeae83253	10 years ago
Kevin Harwell	4fb95bbc4e	app_queue: AgentComplete event has wrong reason ... When a queued caller transfers an agent to another extension sometimes the raised AgentComplete event has a reason of "caller" and sometimes "transfer". Since a transfer has taken place this should always be transfer. This occurs because sometimes the stasis hangup event arrives before the transfer event thus writing a different reason out. With this patch, when a hangup event is received during a transfer it will check to see if the channel that is hanging up is part of a transfer. If so it will return and let the subsequently received transfer event handler take care of the cleanup. ASTERISK-25399 #close Change-Id: Ic63c49bd9a5ed463ea7a032fd2ea3d63bc81a50d	10 years ago
Scott Griepentrog	fb6b5c684b	PJSIP: avoid crash when getting rtp peer ... Although unlikely, if the tech private is returned as a NULL, chan_pjsip_get_rtp_peer() would crash. ASTERISK-25323 Change-Id: Ie231369bfa7da926fb2b9fdaac228261a3152e6a	10 years ago
Joshua Colp	a665b31281	Merge "res_pjsip_pubsub: Eliminate race during initial NOTIFY." into 13	10 years ago
Kevin Harwell	6409e7b11a	app_queue: Crash when transferring ... During some transfer scenarios involving queues Asterisk would sometimes crash when trying to obtain a channel snapshot (could happen on caller or member channels). This occurred because the underlying channel had already disappeared when trying to obtain the latest snapshot. This patch adds a reference to both the member and caller channels that extends to the lifetime of the queue'd call, thus making sure the channels will always exist when retrieving the latest snapshots. ASTERISK-25185 #close Reported by: Etienne Lessard Change-Id: Ic397fa68fb4ff35fbc378e745da9246a7b552128	10 years ago
Mark Michelson	fe5077b1f8	res_pjsip_pubsub: Eliminate race during initial NOTIFY. ... There is a slim chance of a race condition occurring where two threads can both attempt to manipulate the same area. Thread A can be handling an incoming initial SUBSCRIBE request. Thread A lets the specific subscription handler know that the subscription has been established. At this point, Thread B may detect a state change on the subscribed resource and queue up a notification task on Thread C, the subscription serializer thread. Now Thread A attempts to generate the initial NOTIFY request to send to the subscriber at the same time that Thread C attempts to generate a state change NOTIFY request to send to the subscriber. The result is that Threads A and C can step on the same memory area, resulting in a crash. The crash has been observed as happening when attempting to allocate more space to hold the body for the NOTIFY. The solution presented here is to queue the subscription establishment and initial NOTIFY generation onto the subscription serializer thread (Thread C in the above scenario). This way, there is no way that a state change notification can occur before the initial NOTIFY is sent, and if there is a quick succession of NOTIFYs, we can guarantee that the two NOTIFY requests will be sent in succession. Change-Id: I5a89a77b5f2717928c54d6efb9955e5f6f5cf815	10 years ago
Alexander Traud	b88c54fa4b	translate: Fix transcoding while different in frame size. ... When Asterisk translates between codecs, each with a different frame size (for example between iLBC 30 and Speex-WB), too large frames were created by ast_trans_frameout. Now, ast_trans_frameout is called with the correct frame length, creating several frames when necessary. Affects all transcoding modules which used ast_trans_frameout: GSM, iLBC, LPC10, and Speex. ASTERISK-25353 #close Change-Id: I2e229569d73191d66a4e43fef35432db24000212	10 years ago
Mark Michelson	5c713fdf18	scheduler: Use queue for allocating sched IDs. ... It has been observed that on long-running busy systems, a scheduler context can eventually hit INT_MAX for its assigned IDs and end up overflowing into a very low negative number. When this occurs, this can result in odd behaviors, because a negative return is interpreted by callers as being a failure. However, the item actually was successfully scheduled. The result may be that a freed item remains in the scheduler, resulting in a crash at some point in the future. The scheduler can overflow because every time that an item is added to the scheduler, a counter is bumped and that counter's current value is assigned as the new item's ID. This patch introduces a new method for assigning scheduler IDs. Instead of assigning from a counter, a queue of available IDs is maintained. When assigning a new ID, an ID is pulled from the queue. When a scheduler item is released, its ID is pushed back onto the queue. This way, IDs may be reused when they become available, and the growth of ID numbers is directly related to concurrent activity within a scheduler context rather than the uptime of the system. Change-Id: I532708eef8f669d823457d7fefdad9a6078b99b2	10 years ago
Matt Jordan	4fd0af298e	Merge "res/res_pjsip_nat: Ignore REGISTER requests when looking for a Record-Route" into 13	10 years ago
Rodrigo Ramírez Norambuena	865377fc38	chan_sip.c: Validation on module reload ... Change validation on reload module because now used the cli function for reload. The sip_reload() function never fail and ever return NULL for this reason on reload() now use the call the sip_reload() and return AST_MODULE_LOAD_SUCCESS. This problem is dectected on reload by PUT method on ARI, getting always 404 http code when the module is reloaded. ASTERISK-25325 #close Reporte by: Rodrigo Ramírez Norambuena Change-Id: I41215877fb2cfc589e0d4d464000cf6825f4d7fb	10 years ago
Richard Mudgett	e75aff53e6	res_pjsip_pubsub.c: Mark ast_sip_create_subscription() as not used. ... Change-Id: I2b8db18eac36c01a5c7eb9467699124e203fd093	10 years ago
Richard Mudgett	4d91d01df1	res_pjsip_pubsub.c: Add some notification comments. ... Change-Id: Ie62ff1f4b7adc1a12fa0303f53926af249b25e20	10 years ago
Richard Mudgett	f36a9d1221	res_pjsip_pubsub.c: Set dlg_status code instead of sending SIP response. ... We should not try to send a SIP response message because we may be restoring a persistent subscription where we are not responding to a SIP request. Change-Id: Id89167ef90320c5563f37e632db0dda6cb9e7dec	10 years ago
Richard Mudgett	94582f8fab	res_pjsip_pubsub.c: Fix off-nominal memory leak. ... Fix off-nominal visited vector leak in build_resource_tree(). Change-Id: If0399c7941c9c0b1038bcfb7b9a371760977831c	10 years ago
Richard Mudgett	8b3ed52239	res_pjsip_pubsub.c: Fix one byte buffer overrun error. ... ast_sip_pubsub_register_body_generator() did not account for the null terminator set by sprintf() in the allocated output buffer. Change-Id: I388688a132e479bca6ad1c19275eae0070969ae2	10 years ago
Richard Mudgett	4329bd1e4c	res_pjsip_pubsub.c: Use ast_alloca() instead of alloca(). ... Change-Id: Ia396096b4fedc2874649ca11137612c3f55e83e3	10 years ago
Richard Mudgett	a456a20ecf	res_pjsip_pubsub.c: Add missing error return in load_module(). ... Change-Id: I15debd0f717f16ee2f78e7f56151c3b3b97b72fc	10 years ago
Richard Mudgett	f58f4c6e27	res_pjsip/location.c: Use the builtin ao2_callback() match function instead. ... Change-Id: I364906d6d2bad3472929986704a0286b9a2cbe3f	10 years ago
Mark Michelson	9d1f176e29	res_pjsip: Copy default_from_user to avoid crash. ... The default_from_user retrieval function was pulling the default_from_user from the global configuration struct in an unsafe way. If using a database as a backend configuration store, the global configuration struct is short-lived, so grabbing a pointer from it results in referencing freed memory. The fix here is to copy the default_from_user value out of the global configuration struct. Thanks go to John Hardin for discovering this problem and proposing the patch on which this fix is based. ASTERISK-25390 #close Reported by Mark Michelson Change-Id: I6b96067a495c1259da768f4012d44e03e7c6148c	10 years ago
Matt Jordan	1dd0e220bf	res/res_pjsip_nat: Ignore REGISTER requests when looking for a Record-Route ... We will only rewrite the Contact header if there is no Record-Route header in the received request. If a malfunctioning proxy places a Record-Route header into a REGISTER request, we will decide that we shouldn't update the IP/port in the Contact header, and we will end up storing a contact with an AoR that contains the NAT'd IP address. While it is nice to have the proxy *not* send a Record-Route in a REGISTER request, it's also a good idea to not process the header in a non-dialog message. This patch updates the code to explicitly ignore the Record-Route header in REGISTER requests. ASTERISK-25387 #close Change-Id: I4bd3bcccc4003d460cc354d986b0dea2e433ef3f	10 years ago
Joshua Colp	16fa1cbb6c	Merge "ParkAndAnnounce: Add variable inheritance" into 13	10 years ago
Matt Jordan	4eedd9ef9d	main/config_options: Check for existance of internal object before derefing ... Asterisk can load and register an object type while still having an invalid sorcery mapping. This can cause an issue when a creation call is invoked. For example, mis-configuring PJSIP's endpoint identifier by IP address mapping in sorcery.conf will cause the sorcery mechanism to be invalidated; however, a subsequent ARI invocation to create the object will cause a crash, as the internal type may not be registered as sorcery expects. Merely checking for a NULL pointer here solves the issue. Change-Id: I54079fb94a1440992f4735a9a1bbf1abb1c601ac	10 years ago
Matt Jordan	49b13d5624	Merge "chan_ooh323: Add ProgressIndicator IE with inband info available" into 13	10 years ago
Alexander Anikin	71408df2b8	chan_ooh323: Add ProgressIndicator IE with inband info available ... Add ProgressIndicator IE with inband info present to Progress and Alerting Q.931 message ASTERISK-25227 #close Reported by: Alexandr Dranchuk Change-Id: I326ad13cb1db9a72b3fd902bafed3c28a3684203	10 years ago
Scott Griepentrog	f72f9ceefc	pjsip: avoid possible crash req_caps allocation failure ... Make certain that the pjsip session has not failed to allocate the format capabilities structure, which can otherwise cause a crash when referenced. ASTERISK-25323 Change-Id: I602790ba12714741165e441cc64a3ecde4cb5750	10 years ago
Joshua Colp	34ad877bac	Merge "res_pjsip: Use hash for contact object identity instead of Contact URI." into 13	10 years ago
Jonathan Rose	fbf720db91	ParkAndAnnounce: Add variable inheritance ... In Asterisk 11, the announcer channel would receive channel variables from the channel being parked by means of normal channel inheritance. This functionality was lost during the big res_parking project in Asterisk 12. This patch restores that functionality. ASTERISK-25369 #close Review: https://gerrit.asterisk.org/#/c/1180/ Change-Id: Ie47e618330114ad2ea91e2edcef1cb6f341eed6e	10 years ago
Matt Jordan	777f9adfc7	Merge "res_rtp_asterisk: Add more ICE debugging" into 13	10 years ago
David M. Lee	695f26cbb7	res_rtp_asterisk: Add more ICE debugging ... In working through a recent ICE negotiation bug, I found the debug logging in res_rtp_asterisk to be lacking. This patch adds a number of debug and warning statements that were helpful. Change-Id: I950c6d8f13a41f14b3d6334b4cafe7d4e997be80	10 years ago
Guido Falsi	4ed9c9a280	Core/General: Add #ifdef needed on FreeBSD. ... pthread_attr_init() defaults to PTHREAD_EXPLICIT_SCHED on FreeBSD too. ASTERISK-25310 #close Reported by: Guido Falsi Change-Id: Iae6befac9028b5b9795f86986a4a08a1ae6ab7c4	10 years ago
Joshua Colp	9c5a0035d9	Merge "res/res_pjsip: Purge contacts when an AoR is deleted" into 13	10 years ago
Joshua Colp	5469caa9dd	res_pjsip: Use hash for contact object identity instead of Contact URI. ... In the wild it is possible for Contact URIs to be quite long as parameters can exist on them. This can present a problem when storing them in the AstDB as the URI is used as part of the object name and there is a fixed length limit for the AstDB. This will cause the contact to not get stored. This change uses the MD5 hash of the Contact URI as part of the object name instead. This has a fixed length which is guaranteed to not exceed the AstDB length limit. ASTERISK-25295 #close Change-Id: Ie8252a75331ca00b41b9f308f42cc1fbdf701a02	10 years ago
Alexander Anikin	480c443e26	chan_ooh323: call ast_rtp_instance_stop on ooh323_destroy ... Call ast_rtp_instance_stop on ooh323_destroy to free resources allocated by rtp instance ASTERISK-25299 #close Report by: Alexandr Dranchuk Change-Id: I455096bd7da016b871afe90af86067c2c7c9f33f	10 years ago
Matt Jordan	c3e6debdb9	res/res_pjsip: Purge contacts when an AoR is deleted ... When an AoR is deleted by an external mechanism, such as through ARI, we currently do not remove dynamic contacts that were created for that AoR as a result of a received REGISTER request. As a result, re-creating the AoR will cause the dynamic contact to be interpreted as a persistent contact, leading to some rather strange state being created for the contacts/endpoints. This patch adds a sorcery observer for the 'aor' object. When a delete is issued on the underlying sorcery object, the observer is called, and all contacts created and persisted in sorcery for that AoR are also removed. Note that we don't want to perform this action when an AO2 object that is an AoR is destroyed, as the AoR can still exist in the backing storage (and we would thus be removing valid contacts from an AoR that still "exists".) ASTERISK-25381 #close Change-Id: I6697e51ef6b2858b5d63401f35dc378bb0f90328	10 years ago
Matt Jordan	24be90c6d7	Merge "endpoint snapshot: avoid second cleanup on alloc failure" into 13	10 years ago
Matt Jordan	319fe8224f	Merge "channels/pjsip/dialplan_functions: Add an option for extracting the SIP call-id" into 13	10 years ago
Joshua Colp	6a4d2b2e58	Merge "res_pjsip: Change default from user value." into 13	10 years ago