704 Commits (6fb811a5905a54a07a901b25f8f3af0ad9d3f7c9)

Author	SHA1	Message	Date
George Joseph	43bf8a4ded	options: Change ast_options from ast_flags to ast_flags64. ... DeveloperNote: The 32-bit ast_options has no room left to accomodate new options and so has been converted to an ast_flags64 structure. All internal references to ast_options have been updated to use the 64-bit flag manipulation macros. External module references to the 32-bit ast_options should continue to work on little-endian systems because the least-significant bytes of a 64 bit integer will be in the same location as a 32-bit integer. Because that's not the case on big-endian systems, we've swapped the bytes in the flags manupulation macros on big-endian systems so external modules should still work however you are encouraged to test.	3 months ago
Naveen Albert	415daae95f	users.conf: Remove deprecated users.conf integration. ... users.conf was deprecated in Asterisk 21 and is now being removed for Asterisk 23, in accordance with the Asterisk deprecation policy. This consists of: * Removing integration with app_directory, app_voicemail, chan_dahdi, chan_iax2, and AMI. * users.conf was also partially used for res_phoneprov, and this remaining functionality is consolidated to a separate phoneprov_users.conf, used only by res_phoneprov. Resolves: #1292 UpgradeNote: users.conf has been removed and all channel drivers must be configured using their specific configuration files. The functionality previously in users.conf for res_phoneprov is now in phoneprov_users.conf.	3 months ago
Nathan Monfils	7805f2892a	manager.c: Invalid ref-counting when purging events ... We have a use-case where we generate a *lot* of events on the AMI, and then when doing `manager show eventq` we would see some events which would linger for hours or days in there. Obviously something was leaking. Testing allowed us to track down this logic bug in the ref-counting on the event purge. Reproducing the bug was not super trivial, we managed to do it in a production-like load testing environment with multiple AMI consumers. The race condition itself: 1. something allocates and links `session` 2. `purge_sessions` iterates over that `session` (takes ref) 3. `purge_session` correctly de-referencess that session 4. `purge_session` re-evaluates the while() loop, taking a reference 5. `purge_session` exits (`n_max > 0` is false) 6. whatever allocated the `session` deallocates it, but a reference is now lost since we exited the `while` loop before de-referencing. 7. since the destructor is never called, the session->last_ev->usecount is never decremented, leading to events lingering in the queue The impact of this bug does not seem major. The events are small and do not seem, from our testing, to be causing meaningful additional CPU usage. Mainly we wanted to fix this issue because we are internally adding prometheus metrics to the eventq and those leaked events were causing the metrics to show garbage data.	5 months ago
Peter Jannesen	032584115b	action_redirect: remove after_bridge_goto_info ... Under certain circumstances the context/extens/prio are stored in the after_bridge_goto_info. This info is used when the bridge is broken by for hangup of the other party. In the situation that the bridge is broken by an AMI Redirect this info is not used but also not removed. With the result that when the channel is put back in a bridge and the bridge is broken the execution continues at the wrong context/extens/prio. Resolves: #1144	6 months ago
George Joseph	1e469a5e06	manager.c: Check for restricted file in action_createconfig. ... The `CreateConfig` manager action now ensures that a config file can only be created in the AST_CONFIG_DIR unless `live_dangerously` is set. Resolves: #1122	7 months ago
Luz Paz	e3ad4cea4e	docs: Fix various typos in main/ ... Found via `codespell -q 3 -S "./CREDITS" -L abd,asent,atleast,childrens,contentn,crypted,dne,durationm,exten,inout,leapyear,nd,oclock,offsetp,ot,parm,parms,requestor,ser,slanguage,slin,thirdparty,varn,varns,ues`	8 months ago
George Joseph	3868f7cb47	docs: Enable since/version handling for XML, CLI and ARI documentation ... * Added the "since" element to the XML configObject and configOption elements in appdocsxml.dtd. * Added the "Since" section to the following CLI output: ``` config show help <module> <object> config show help <module> <object> <option> core show application <app> core show function <func> manager show command <command> manager show event <event> agi show commands topic <topic> ``` * Refactored the commands above to output their sections in the same order: Synopsis, Since, Description, Syntax, Arguments, SeeAlso * Refactored the commands above so they all use the same pattern for writing the output to the CLI. * Fixed several memory leaks caused by failure to free temporary output buffers. * Added a "since" array to the mustache template for the top-level resources (Channel, Endpoint, etc.) and to the paths/methods underneath them. These will be added to the generated markdown if present. Example: ``` "resourcePath": "/api-docs/channels.{format}", "requiresModules": [ "res_stasis_answer", "res_stasis_playback", "res_stasis_recording", "res_stasis_snoop" ], "since": [ "18.0.0", "21.0.0" ], "apis": [ { "path": "/channels", "description": "Active channels", "operations": [ { "httpMethod": "GET", "since": [ "18.6.0", "21.8.0" ], "summary": "List all active channels in Asterisk.", "nickname": "list", "responseClass": "List[Channel]" }, ``` NOTE: No versioning information is actually added in this commit. Those will be added separately and instructions for adding and maintaining them will be published on the documentation site at a later date.	9 months ago
Sean Bright	7b71efd172	manager.c: Rename restrictedFile to is_restricted_file. ... Also correct the spelling of 'privileges.'	9 months ago
Ben Ford	7f70190c59	manager.c: Restrict ListCategories to the configuration directory. ... When using the ListCategories AMI action, it was possible to traverse upwards through the directories to files outside of the configured configuration directory. This action is now restricted to the configured directory and an error will now be returned if the specified file is outside of this limitation. Resolves: #GHSA-33x6-fj46-6rfh UserNote: The ListCategories AMI action now restricts files to the configured configuration directory.	9 months ago
Mike Pultz	e020ee5795	manager.c: Add Processed Call Count to CoreStatus output ... This update adds the processed call count to the CoreStatus AMI Action responsie. This output is similar to the values returned by "core show channels" or "core show calls" in the CLI. UserNote: The current processed call count is now returned as CoreProcessedCalls from the CoreStatus AMI Action.	11 months ago
George Joseph	4623abb8bb	manager.c: Add unit test for Originate app and appdata permissions ... This unit test checks that dialplan apps and app data specified as parameters for the Originate action are allowed with the permissions the user has.	1 year ago
Naveen Albert	d1bba7efc0	main, res, tests: Fix compilation errors on FreeBSD. ... asterisk.c, manager.c: Increase buffer sizes to avoid truncation warnings. config.c: Include header file for WIFEXITED/WEXITSTATUS macros. res_timing_kqueue: Use more portable format specifier. test_crypto: Use non-linux limits.h header file. Resolves: #916	1 year ago
Ben Ford	e19da5d86f	manager.c: Restrict ModuleLoad to the configured modules directory. ... When using the ModuleLoad AMI action, it was possible to traverse upwards through the directories to files outside of the configured modules directory. We decided it would be best to restrict access to modules exclusively in the configured directory. You will now get an error when the specified module is outside of this limitation. Fixes: #897 UserNote: The ModuleLoad AMI action now restricts modules to the configured modules directory.	1 year ago
George Joseph	affeec710c	manager: Enhance event filtering for performance ... UserNote: You can now perform more granular filtering on events in manager.conf using expressions like `eventfilter(name(Newchannel),header(Channel),method(starts_with)) = PJSIP/` This is much more efficient than `eventfilter = Event: Newchannel.*Channel: PJSIP/` Full syntax guide is in configs/samples/manager.conf.sample.	1 year ago
George Joseph	c470ba1f90	manager.c: Split XML documentation to manager_doc.xml	1 year ago
George Joseph	2328a0ab3a	manager.c: Fix FRACK when doing CoreShowChannelMap in DEVMODE ... If you run an AMI CoreShowChannelMap on a channel that isn't in a bridge and you're in DEVMODE, you can get a FRACK because the bridge id is empty. We now simply return an empty list for that request.	1 year ago
George Joseph	0f67c2696f	manager.c: Add entries to Originate blacklist ... Added Reload and DBdeltree to the list of dialplan application that can't be executed via the Originate manager action without also having write SYSTEM permissions. Added CURL, DB*, FILE, ODBC and REALTIME* to the list of dialplan functions that can't be executed via the Originate manager action without also having write SYSTEM permissions. If the Queue application is attempted to be run by the Originate manager action and an AGI parameter is specified in the app data, it'll be rejected unless the manager user has either the AGI or SYSTEM permissions. Resolves: #GHSA-c4cg-9275-6w44	1 year ago
Sean Bright	26eabed246	manager.c: Properly terminate `CoreShowChannelMap` event. ... Fixes #761	1 year ago
Naveen Albert	01ff5c8140	loader.c: Allow dependent modules to be unloaded recursively. ... Because of the (often recursive) nature of module dependencies in Asterisk, hot swapping a module on the fly is cumbersome if a module is depended on by other modules. Currently, dependencies must be popped manually by unloading dependents, unloading the module of interest, and then loading modules again in reverse order. To make this easier, the ability to do this recursively in certain circumstances has been added, as an optional extension to the "module refresh" command. If requested, Asterisk will check if a module that has a positive usecount could be unloaded safely if anything recursively dependent on it were unloaded. If so, it will go ahead and unload all these modules and load them back again. This makes hot swapping modules that provide dependencies much easier. Resolves: #474 UserNote: In certain circumstances, modules with dependency relations can have their dependents automatically recursively unloaded and loaded again using the "module refresh" CLI command or the ModuleLoad AMI command.	1 year ago
George Joseph	52881ef6e5	manager.c: Add missing parameters to Login documentation ... * Added the AuthType and Key parameters for MD5 authentication. * Added the Events parameter. Resolves: #689	2 years ago
jonatascalebe	988986bdc9	manager.c: Add new parameter 'PreDialGoSub' to Originate AMI action ... manager.c: Add new parameter 'PreDialGoSub' to Originate AMI action The action originate does not has the ability to run an subroutine at initial channel, like the Aplication Originate. This update give this ability for de action originate too. For example, we can run a routine via Gosub on the channel to request an automatic answer, so the caller does not need to accept the call when using the originate command via manager, making the operation more efficient. UserNote: When using the Originate AMI Action, we now can pass the PreDialGoSub parameter, instructing the asterisk to perform an subrouting at channel before call start. With this parameter an call initiated by AMI can request the channel to start the call automaticaly, adding a SIP header to using GoSUB, instructing to autoanswer the channel, and proceeding the outbuound extension executing. Exemple of an context to perform the previus indication: [addautoanswer] exten => _s,1,Set(PJSIP_HEADER(add,Call-Info)=answer-after=0) exten => _s,n,Set(PJSIP_HEADER(add,Alert-Info)=answer-after=0) exten => _s,n,Return()	2 years ago
Naveen Albert	ef7788e0e4	manager.c: Add CLI command to kick AMI sessions. ... This adds a CLI command that can be used to manually kick specific AMI sessions. Resolves: #485 UserNote: The "manager kick session" CLI command now allows kicking a specified AMI session.	2 years ago
George Joseph	6871d1cdfc	Reduce startup/shutdown verbose logging ... When started with a verbose level of 3, asterisk can emit over 1500 verbose message that serve no real purpose other than to fill up logs. When asterisk shuts down, it emits another 1100 that are of even less use. Since the testsuite runs asterisk with a verbose level of 3, and asterisk starts and stops for every one of the 700+ tests, the number of log messages is staggering. Besides taking up resources, it also makes it hard to debug failing tests. This commit changes the log level for those verbose messages to 5 instead of 3 which reduces the number of log messages to only a handful. Of course, NOTICE, WARNING and ERROR message are unaffected. There's also one other minor change... ast_context_remove_extension_callerid2() logs a DEBUG message instead of an ERROR if the extension you're deleting doesn't exist. The pjsip_config_wizard calls that function to clean up the config and has been triggering that annoying error message for years. Resolves: #582	2 years ago
Naveen Albert	f1a9ec4703	manager.c: Fix erroneous reloads in UpdateConfig. ... Currently, a reload will always occur if the Reload header is provided for the UpdateConfig action. However, we should not be doing a reload if the header value has a falsy value, per the documentation, so this makes the reload behavior consistent with the existing documentation. Resolves: #551	2 years ago
Naveen Albert	fa3922a4d2	manager.c: Fix regression due to using wrong free function. ... Commit 424be34563 introduced a regression by calling ast_free on memory allocated by realpath. This causes Asterisk to abort when executing this function. Since the memory is allocated by glibc, it should be freed using ast_std_free. Resolves: #513	2 years ago
Ben Ford	424be34563	manager.c: Prevent path traversal with GetConfig. ... When using AMI GetConfig, it was possible to access files outside of the Asterisk configuration directory by using filenames with ".." and "./" even while live_dangerously was not enabled. This change resolves the full path and ensures we are still in the configuration directory before attempting to access the file.	2 years ago
Naveen Albert	ce1f4b3018	manager.c: Improve clarity of "manager show connected". ... Improve the "manager show connected" CLI command to clarify that the last two columns are permissions related, not counts, and use sufficient widths to consistently display these values. ASTERISK-30143 #close Resolves: #482	2 years ago
George Joseph	f309ffad3d	chan_pjsip: Add PJSIPHangup dialplan app and manager action ... See UserNote below. Exposed the existing Hangup AMI action in manager.c so we can use all of it's channel search and AMI protocol handling without duplicating that code in dialplan_functions.c. Added a lookup function to res_pjsip.c that takes in the string represenation of the pjsip_status_code enum and returns the actual status code. I.E. ast_sip_str2rc("DECLINE") returns 603. This allows the caller to specify PJSIPHangup(decline) in the dialplan, just like Hangup(call_rejected). Also extracted the XML documentation to its own file since it was almost as large as the code itself. UserNote: A new dialplan app PJSIPHangup and AMI action allows you to hang up an unanswered incoming PJSIP call with a specific SIP response code in the 400 -> 699 range.	2 years ago
George Joseph	67fd66e2fe	file.c: Add ability to search custom dir for sounds ... To better co-exist with sounds files that may be managed by packages, custom sound files may now be placed in AST_DATA_DIR/sounds/custom instead of the standard AST_DATA_DIR/sounds/<lang> directory. If the new "sounds_search_custom_dir" option in asterisk.conf is set to "true", asterisk will search the custom directory for sounds files before searching the standard directory. For performance reasons, the "sounds_search_custom_dir" defaults to "false". Resolves: #315 UserNote: A new option "sounds_search_custom_dir" has been added to asterisk.conf that allows asterisk to search AST_DATA_DIR/sounds/custom for sounds files before searching the standard AST_DATA_DIR/sounds/<lang> directory.	2 years ago
Ben Ford	cfde21c0c7	AMI: Add CoreShowChannelMap action. ... Adds a new AMI action (CoreShowChannelMap) that takes in a channel name and provides a list of all channels that are connected to that channel, following local channel connections as well. Resolves: #104 UserNote: New AMI action CoreShowChannelMap has been added.	2 years ago
Naveen Albert	ed77b365ce	manager: Fix appending variables. ... The if statement here is always false after the for loop finishes, so variables are never appended. This removes that to properly append to the end of the variable list. ASTERISK-30351 #close Reported by: Sebastian Gutierrez Change-Id: I1b7f8b85a8918f6a814cb933a479d4278cf16199	3 years ago
Michael Kuron	6b8d3cb89a	manager: AOC-S support for AOCMessage ... ASTERISK-21502 Change-Id: I051b778f8c862d3b4794d28f2f3d782316707b08	3 years ago
Mike Bradeen	c59eb7e6d8	manager: prevent file access outside of config dir ... Add live_dangerously flag to manager and use this flag to determine if a configuation file outside of AST_CONFIG_DIR should be read. ASTERISK-30176 Change-Id: I46b26af4047433b49ae5c8a85cb8cda806a07404 (cherry picked from commit 81f10e847e)	3 years ago
Naveen Albert	80e9e77261	manager: Update ModuleCheck documentation. ... The ModuleCheck XML documentation falsely claims that the module's version number is returned. This has not been the case since 14, since the version number is not available anymore, but the documentation was not changed at the time. It is now updated to reflect this. ASTERISK-30285 #close Change-Id: Idde2d1205a11f2623fa1ddab192faa3dc4081e91	3 years ago
Jaco Kroon	2043234cf4	manager: be more aggressive about purging http sessions. ... If we find that n_max (currently hard wired to 1) sessions were purged, schedule the next purge for 1ms into the future rather than 5000ms (as per current). This way we will purge up to 1000 sessions per second rather than 1 every 5 seconds. This mitigates a build-up of sessions should http sessions gets established faster than 1 per 5 seconds. Change-Id: I9820d39aa080109df44fe98c1325cafae48d54f5 Signed-off-by: Jaco Kroon <jaco@uls.co.za>	3 years ago
Naveen Albert	3143a01e84	manager: Remove documentation for nonexistent action. ... The manager XML documentation documents a "FilterList" action, but there is no such action. Therefore, this can lead to confusion when people try to use a documented action that does not, in fact, exist. This is removed as the action never did exist in the past, nor would it be trivial to add since we only store the regex_t objects, so the filter list can't actually be provided without storing that separately. Most likely, the documentation was originally added (around version 10) in anticipation of something that never happened. ASTERISK-29917 #close Change-Id: I846b16fd6f80a91d4ddc5d8a861b522d7c6f8f97	3 years ago
Naveen Albert	f5378f63c4	general: Improve logging levels of some log messages. ... Adjusts some logging levels to be more or less important, that is more prominent when actual problems occur and less prominent for less noteworthy things. ASTERISK-30153 #close Change-Id: Ifc8f7df427aa018627db462125ae744986d3261b	3 years ago
Naveen Albert	7a54badf31	manager: Fix incomplete filtering of AMI events. ... The global event filtering code was only in one possible execution path, so not all events were being properly filtered out if requested. This moves that into the universal AMI handling code so all events are properly handled. Additionally, the CLI listing of disabled events can also get truncated, so we now print out everything. ASTERISK-30137 #close Change-Id: If8c42edcb2abc5158552da7eba2a8ff6b20e1959	3 years ago
Naveen Albert	0c70d497bc	documentation: Adds versioning information. ... Adds version information for applications, functions, and manager events/actions. This is not completely exhaustive by any means but covers most new things added that have release versioning information in the issue tracker. ASTERISK-29940 #close Change-Id: I506401e93c799715dbbe97c0a8ba18af2bf5e131	4 years ago
Joshua C. Colp	f6062b17cc	manager: Terminate session on write error. ... On a write error to an AMI session a flag was set to indicate that the write error had occurred, with the expected result being that the session be terminated. This was not actually happening and instead writing would continue to be attempted. This change adds a check for the write error and causes the session to actually terminate. ASTERISK-29948 Change-Id: Icaf5d413d4c0d5dc78292a17287fecc8720a31a5	4 years ago
Naveen Albert	fbde0186c7	ami: Improve substring parsing for disabled events. ... ASTERISK_29853 added the ability to selectively disable AMI events on a global basis, but the logic for this uses strstr which means that events with names which are the prefix of another event, if disabled, could disable those events as well. Instead, we account for this possibility to prevent this undesired behavior from occuring. ASTERISK_29853 Change-Id: Icccd1872602889806740971e4adf932f92466959	4 years ago
Naveen Albert	585c2d17bb	ami: Allow events to be globally disabled. ... The disabledevents setting has been added to the general section in manager.conf, which allows users to specify events that should be globally disabled and not sent to any AMI listeners. This allows for processing of these AMI events to end sooner and, for frequent AMI events such as Newexten which users may not have any need for, allows them to not be processed. Additionally, it also cleans up core debug as previously when debug was 3 or higher, the debug was constantly spammed by "Analyzing AMI event" messages along with a complete dump of the event contents (often for Newexten). ASTERISK-29853 #close Change-Id: Id42b9a3722a1f460d745cad1ebc47c537fd4f205	4 years ago
Sean Bright	16fccf140d	manager.c: Simplify AMI ModuleCheck handling ... This code was needlessly complex and would fail to properly delimit the response message if LOW_MEMORY was defined. Change-Id: Iae50bf09ef4bc34f9dc4b49435daa76f8b2c5b6e	4 years ago
Sean Bright	134cbebc1f	manager.c: Generate valid XML if attribute names have leading digits. ... The XML Manager Event Interface (amxml) now generates attribute names that are compliant with the XML 1.1 specification. Previously, an attribute name that started with a digit would be rendered as-is, even though attribute names must not begin with a digit. We now prefix attribute names that start with a digit with an underscore ('_') to prevent XML validation failures. This is not backwards compatible but my assumption is that compliant XML parsers would already have been complaining about this. ASTERISK-29886 #close Change-Id: Icfaa56a131a082d803e9b7db5093806d455a0523	4 years ago
Alexander Traud	9440f6ec58	main: Fix for Doxygen. ... ASTERISK-29763 Change-Id: Ib8359e3590a9109eb04a5376559d040e5e21867e	4 years ago
Josh Soref	f382775241	main: Spelling fixes ... Correct typos of the following word families: analysis nuisance converting although transaction desctitle acquire update evaluate thousand this dissolved management integrity reconstructed decrement further on irrelevant currently constancy anyway unconstrained featuregroups right larger evaluated encumbered languages digits authoritative framing blindxfer tolerate traverser exclamation perform permissions rearrangement performing processing declension happily duplicate compound hundred returns elicit allocate actually paths inheritance atxferdropcall earlier synchronization multiplier acknowledge across against thousands joyous manipulators guaranteed emulating soundfile ASTERISK-29714 Change-Id: I926ba4b11e9f6dd3fdd93170ab1f9b997910be70	4 years ago
Sean Bright	1b74555fcf	asterisk: Export additional manager functions ... Rename check_manager_enabled() and check_webmanager_enabled() to begin with ast_ so that the symbols are automatically exported by the linker. ASTERISK~29184 Change-Id: I85762b9a5d14500c15f6bad6507138c8858644c9	5 years ago
Kevin Harwell	cfed0ea033	manager - Add Content-Type parameter to the SendText action ... This patch allows a user of AMI to now specify the type of message content contained within by setting the 'Content-Type' parameter. Note, the AMI version has been bumped for this change. ASTERISK-28945 #close Change-Id: Ibb5315702532c6b954e1498beddc8855fabdf4bb	5 years ago
Jaco Kroon	d32e559e8a	acl: implement a centralized ACL output mechanism for HAs and ACLs. ... named_acl.c (which is really a named_ha) now uses ast_ha_output. I've also updated main/manager.c to output the actual ACL on "manager show user <username>" if one is set. If this works then we can add similar to other modules as required. Change-Id: I0ec9876a90dddd379c80ec078d48e3ee6991eb0f	6 years ago
George Joseph	7e3a6e158f	manager.c: Prevent the Originate action from running the Originate app ... If an AMI user without the "system" authorization calls the Originate AMI command with the Originate application, the second Originate could run the "System" command. Action: Originate Channel: Local/1111 Application: Originate Data: Local/2222,app,System,touch /tmp/owned If the "system" authorization isn't set, we now block the Originate app as well as the System, Exec, etc. apps. ASTERISK-28580 Reported by: Eliel Sardañons Change-Id: Ic4c9dedc34c426f03c8c14fce334a71386d8a5fa	6 years ago