31340 Commits (6af57d5750c60e97f3fed3569ad83d3cb64bc5b0)

 

All Branches   

Search

Author	SHA1	Message	Date
Sean Bright	27fc662cf2	res_calendar: Resolve memory leak on calendar destruction ... Calling ne_uri_parse allocates memory that needs to be freed with a corresponding call to ne_uri_free. ASTERISK-28572 #close Change-Id: I8a6834da27000a6807d89cb7a157b2a88fcb5e61	6 years ago
Joshua Colp	50feafe9b8	res_ari_events: Add module reference when a WebSocket is open. ... This change ensures that the module isn't unloaded when a WebSocket is open. Previously it was possible to unload the module manually or during shutdown which could cause a crash when any active WebSockets were terminated. ASTERISK-28585 Change-Id: I85c71ab112f99875b586419a34c08c8b34c14c5c	6 years ago
Friendly Automation	6f2431cb13	Merge "utils.h: Set lower bound for thread stack size to PTHREAD_STACK_MIN" into 13	6 years ago
Sean Bright	f1e3a13579	utils.h: Set lower bound for thread stack size to PTHREAD_STACK_MIN ... ASTERISK-28590 #close Change-Id: I51abce00c04d0a06550bda5205580705185b9c1c	6 years ago
Friendly Automation	8e42a55ebd	Merge "app_voicemail.c: Support multiple file formats for forwarded messages." into 13	6 years ago
Friendly Automation	c56663b2cf	Merge "Crash during "pjsip show channelstats" execution" into 13	6 years ago
Sean Bright	0cccfcba9e	README-SERIOUSLY.bestpractices.md: Speling correetions. ... ASTERISK-28586 #close Change-Id: I43dc4e8bd9dc685b17695b215a5360314074734f	6 years ago
Salah Ahmed	414eebcbc9	Crash during "pjsip show channelstats" execution ... During execution "pjsip show channelstats" cli command by an external module asterisk crashed. It seems this is a separate thread running to fetch and print rtp stats. The crash happened on the ao2_lock method, just before it going to read the rtp stats on a rtp instance. According to gdb backtrace log, it seems the session media was already cleaned up at that moment. ASTERISK-28578 Change-Id: Ia918bfa3c8119060633e39b14852e8d983e0417e	6 years ago
cmaj	c8e38f8550	app_voicemail.c: Support multiple file formats for forwarded messages. ... If you specify multiple formats in voicemail.conf, eg. "format = gsm|wav" and are using realtime ODBC backend, only the first format gets stored in the database. So when you forward a message later on, there is a bug generating the email, related to the stored format (GSM) being different than the desired email format (WAV) specified for the user. Sox can handle this, but Asterisk needs to tell sox exactly what to do. ASTERISK-22192 Change-Id: I7321e7f7e7c58adbf41dd4fd7191c887b9b2eafd	6 years ago
Friendly Automation	78ad383837	Merge "res_pjsip_mwi: potential double unref, and potential unwanted double link" into 13	6 years ago
Friendly Automation	59487acfb8	Merge "pbx: deadlock when outgoing dialed channel hangs up too quickly" into 13	6 years ago
Joshua Colp	337e4ed671	Merge "cdr_pgsql cel_pgsql res_config_pgsql: compatibility with PostgreSQL 12" into 13	6 years ago
Christoph Moench-Tegeder	a7749f4fcd	cdr_pgsql cel_pgsql res_config_pgsql: compatibility with PostgreSQL 12 ... PostgreSQL 12 finally removed column adsrc from table pg_catalog.pg_attrdef (column default values), which has been deprecated since version 8.0. Since then, the official/correct/supported way to retrieve the column default value from the catalog is function pg_catalog.pg_get_expr(). This change breaks compatibility with pre-8.0 PostgreSQL servers, but has reached end-of-support more than a decade ago. cdr_pgsql and res_config_pgsql still have support for pre-7.3 servers, but cleaning that up is perhaps a topic for a major release, not this bugfix. ASTERISK-28571 Change-Id: I834cb3addf1937e19e87ede140bdd16cea531ebe	6 years ago
George Joseph	91d5094464	Merge "pjproject_bundled: Replace earlier reverts with official fixes." into 13	6 years ago
csavinovich	c3a1f2ce91	test_taskprocessor.c: Fix test failure on Ubuntu ... Fixes a failure in /main/taskprocesor unit test, only occurring in Ubuntu. Newer versions of GCC require variable initialization. Change-Id: I2994d8aab9307a8c2c7330584f287a27144a580c	6 years ago
Kevin Harwell	e34651d62c	res_pjsip_mwi: potential double unref, and potential unwanted double link ... When creating an unsolicited MWI aggregate subscription it was possible for the subscription object to be double unref'ed. This patch removes the explicit unref as it is not needed since the RAII_VAR will handle it at function end. Less concerning there was also a bug that could potentially allow the aggregate subscription object to be added to the unsolicited container twice. This patch ensures it is added only once. ASTERISK-28575 Change-Id: I9ccfdb5ea788bc0c3618db183aae235e53c12763	6 years ago
George Joseph	ba55298891	Merge "Revert "app_voicemail: Cleanup stale lock files on module load"" into 13	6 years ago
George Joseph	6ff5432a07	Merge "res_pjsip_mwi: use an ao2_global object for mwi containers" into 13	6 years ago
George Joseph	1bb0e60e55	Merge "res_pjsip/res_pjsip_mwi: use centralized serializer pools" into 13	6 years ago
George Joseph	46c70c67f9	Merge "serializer: move/add asterisk serializer pool functionality" into 13	6 years ago
George Joseph	164e5372a2	pjproject_bundled: Replace earlier reverts with official fixes. ... Issues in pjproject 2.9 caused us to revert some of their changes as a work around. This introduced another issue where pjproject wouldn't build with older gcc versions such as that found on CentOS 6. This commit replaces the reverts with the official fixes for the original issues and allows pjproject to be built on CentOS 6 again. ASTERISK-28574 Reported-by: Niklas Larsson Change-Id: I06f8507bea553d1a01b0b8874197d35b9d47ec4c	6 years ago
Kevin Harwell	a2ddaaac32	pbx: deadlock when outgoing dialed channel hangs up too quickly ... Here's the basic scenario that occurred when executing an AMI fast originate while at the same time something else locks the channels container, and also wants a lock on the dialed channel: 1. pbx_outgoing_attempt obtains a lock on a dialed channel 2. concurrently another thread obtains a lock on the channels container, and subsequently requests a lock on the dialed channel. It waits on #1. For instance, "core show channel <dialed channel" 3. the outgoing call does not fail, but ends before the pbx_outgoing_attempt function exits 4. pbx_outgoing_attempt function exits, the outgoing structure destructs, and attempts to hang up the dialed channel 5. hang up tries to obtain the channels container lock, but can't due to #2. 6. Asterisk is deadlocked. The solution was to allow the pbx_outgoing_exec function to "steal" ownership of the dialed channel, and handle hanging it up. The channel now is either hung up prior to it being potentially locked by the initiating thread, or if locked the hang up takes place in a different thread, thus alleviating the deadlock. ASTERISK-28561 patches: iliketrains.diff submitted by Joshua Colp (license 5000) Change-Id: I51b42b92dde8f2215b69bb509e28667ee3a3853a	6 years ago
lvl	bc8d56816d	chan_pjsip: Prevent segfault when running PlayDTMF on hungup channel ... ASTERISK-28086 #close Change-Id: Ib3baadc89b9f0477a6f25a63861433812368c5ea	6 years ago
George Joseph	32c52b7dda	Merge "cdr_mysql: Don't clean up on unload unless we can unregister from CDRs" into 13	6 years ago
Sean Bright	0834e06673	Revert "app_voicemail: Cleanup stale lock files on module load" ... This reverts commit fd2e8d0da7. Reason for revert: Problematic for users who store their voicemail on network storage devices, or share voicemail storage between multiple Asterisk instances. ASTERISK-28567 #close Change-Id: I3ff4ca983d8e753fe2971f3439bd154705693c41	6 years ago
Kevin Harwell	3f7f376a68	res_pjsip_mwi: use an ao2_global object for mwi containers ... On shutdown it's possible for the unsolicited mwi container to be freed before other dependent threads are done using it. This patch ensures this can no longer happen by wrapping the container in an ao2_global object. The solicited container was also changed too. ASTERISK-28552 Change-Id: I8f812286dc19a34916acacd71ce2ec26e1042047	6 years ago
Kevin Harwell	2042020abf	res_pjsip/res_pjsip_mwi: use centralized serializer pools ... Both res_pjsip and res_pjsip_mwi made use of serializer pools. However, they both implemented their own serializer pool functionality that was pretty much identical in each of the source files. This patch removes the duplicated code, and uses the new 'ast_serializer_pool' object instead. Additionally res_pjsip_mwi enables a shutdown group on the pool since if the timing was right the module could be unloaded while taskprocessor threads still needed to execute, thus causing a crash. Change-Id: I959b0805ad024585bbb6276593118be34fbf6e1d	6 years ago
Kevin Harwell	0b7efc1687	serializer: move/add asterisk serializer pool functionality ... Serializer pools have previously existed in Asterisk. However, for the most part the code has been duplicated across modules. This patch abstracts the code into an 'ast_serializer_pool' object. As well the code is now centralized in serializer.c/h. In addition serializer pools can now optionally be monitored by a shutdown group. This will prevent the pool from being destroyed until all serializers have completed. Change-Id: Ib1e906144b90ffd4d5ed9826f0b719ca9c6d2971	6 years ago
Friendly Automation	a3ef4d22d4	Merge "channel/chan_pjsip: add dialplan function for music on hold" into 13	6 years ago
Sean Bright	fa897059a5	cdr_mysql: Don't clean up on unload unless we can unregister from CDRs ... ASTERISK-28566 #close Change-Id: I6daa4e5128e9406d04d3aed670c3bae98d38d40c	6 years ago
George Joseph	1b29d0a7ed	Merge "res_pjsip_transport_websocket: Don't put brackets around local_name if IPv6" into 13	6 years ago
Torrey Searle	6fd195ca91	channel/chan_pjsip: add dialplan function for music on hold ... Add a new dialplan function PJSIP_MOH_PASSTHROUGH that allows the on-hold behavior to be controlled on a per-call basis ASTERISK-28542 #close Change-Id: Iebe905b2ad6dbaa87ab330267147180b05a3c3a8	6 years ago
Alexei Gradinari	c1d82f73a3	res_pjsip_pubsub: add endpoint to some warning ... There are some warning messages which are not informative without endpoint: "No registered subscribe handler for event presence.winfo" "No registered publish handler for event presence" This patch adds an endpoint name to these messages. Change-Id: Ia2811ec226d8a12659b4f9d4d224b48289650827	6 years ago
Sean Bright	438085f10e	res_pjsip_transport_websocket: Don't put brackets around local_name if IPv6 ... ASTERISK-28544 #close Change-Id: I8e62c444d107674c298f472e3545661de8a80dce	6 years ago
George Joseph	c6f81a7ba4	Merge "taskprocessor.c: Added "like" support to 'core show taskprocessors'" into 13	6 years ago
Friendly Automation	88dea7a111	Merge "pbx: Prevent Realtime switch crash on invalid priority" into 13	6 years ago
Friendly Automation	ac64659b33	Merge "res_pjsip_registrar: Validate Contact URI before adding to responses" into 13	6 years ago
Joshua Colp	b60bf27881	Merge "chan_pjsip: Add support for passing hold and unhold requests through." into 13	6 years ago
Ben Ford	67bd02d08d	taskprocessor.c: Added "like" support to 'core show taskprocessors' ... Added "like" support for 'core show taskprocessors'. Now you can specify a specific set of taskprocessors (or just one) by adding the keyword "like" to the above command, followed by your search criteria. Change-Id: I021e740201e9ba487204b5451e46feb0e3222464	6 years ago
Asterisk Development Team	0dc1ba17b8	Update CHANGES and UPGRADE.txt for 13.29.0-rc2	6 years ago
Sean Bright	7280e2ec51	pbx: Prevent Realtime switch crash on invalid priority ... pbx_extension_helper takes two 'context' arguments. One (con) is a pointer directly to a 'struct ast_context' and the other (context) is the name of the context. In all cases, one of these arguments is NULL and the other is non-NULL. Functions that are ultimately called by pbx_extension_helper expect that 'context' will be non-NULL, so we set it unconditionally on entry into this function. ASTERISK-28534 #close Change-Id: Ifbbc5e71440afd80efd441f7a9d72e8b10b6f47d	6 years ago
Friendly Automation	fde6ed7d91	Merge "core: Fix ABI mismatch of ao2_global_obj." into 13	6 years ago
George Joseph	85f47022e0	Merge "res_pjsip_pubsub: change warning to debug" into 13	6 years ago
George Joseph	c5a9c039ba	Merge "taskprocessor.c: Add CLI commands to reset taskprocessor stats." into 13	6 years ago
Sean Bright	22fb0f286d	res_pjsip_registrar: Validate Contact URI before adding to responses ... If a permanent contact URI associated with an AOR is invalid, we add a Contact header to REGISTER responses with a NULL URI, causing a crash. ASTERISK-28463 #close Change-Id: Id2b643e58b975bc560aab1c111e6669d54db9102	6 years ago
Joshua Colp	d775bc5add	chan_pjsip: Add support for passing hold and unhold requests through. ... This change adds an option, moh_passthrough, that when enabled will pass hold and unhold requests through using a SIP re-invite. When placing on hold a re-invite with sendonly will be sent and when taking off hold a re-invite with sendrecv will be sent. This allows remote servers to handle the musiconhold instead of the local Asterisk instance being responsible. Review: https://reviewboard.asterisk.org/r/4103/ Change-Id: Ib6294e906e577e1a4245cb1f058d3976ff484c52	6 years ago
George Joseph	6991a944c0	Merge "pjproject_bundled: Revert pjproject 2.9 commits causing leaks" into 13	6 years ago
Kevin Harwell	9384639953	res_pjsip_pubsub: change warning to debug ... The following message: "Subscription request from endpoint <blah> rejected. Expiration of 0 is invalid" Would sometimes spam the log with warnings if Asterisk restarted and a bunch of clients sent unsubscribes. This patch changes it from a warning to a debug message. Change-Id: I841ec42f65559f3135e037df0e55f89b6447a467	6 years ago
Corey Farrell	c881d36319	core: Fix ABI mismatch of ao2_global_obj. ... astobj2.c declares DEBUG_THREADS_LOOSE_ABI to avoid overhead of debug threads tracking information in the internal structures of astobj2. Unfortunately this means that ao2_global_obj contains the statically allocated debug threads tracking fields which are used by initialization and cleanup but main/astobj2.c believed those fields and associated space did not exist. Change-Id: Icef41ad97d88a8c1d1515e034ec8133cab3b1527	6 years ago
Ben Ford	3069153bdf	taskprocessor.c: Add CLI commands to reset taskprocessor stats. ... Added two new CLI commands to reset stats for taskprocessors. You can reset stats for a single, specific taskprocessor ('core reset taskprocessor <taskprocessor>'), or you can reset all taskprocessors ('core reset taskprocessors'). These commands will reset the counter for the number of tasks processed as well as the max queue size. Change-Id: Iaf17fc4ae29396ab0c6ac92408fc7bdc2f12362d	6 years ago