33346 Commits (69a2bc15b51d397055b0e685a857b2c5005c0e02)

 

All Branches   

Search

Author	SHA1	Message	Date
George Joseph	be9b5bf0a9	.github: Update github-script to v7 and fix a rest bug ... Need to update the github-script to v7 to squash deprecation warnings. Also fixed the API name for github.rest.pulls.requestReviewers.	2 years ago
Naveen Albert	3ff081e581	manager.c: Fix regression due to using wrong free function. ... Commit 424be34563 introduced a regression by calling ast_free on memory allocated by realpath. This causes Asterisk to abort when executing this function. Since the memory is allocated by glibc, it should be freed using ast_std_free. Resolves: #513	2 years ago
George Joseph	a4f9d885a7	res_rtp_asterisk: Fix regression issues with DTLS client check ... * Since ICE candidates are used for the check and pjproject is required to use ICE, res_rtp_asterisk was failing to compile when pjproject wasn't available. The check is now wrapped with an #ifdef HAVE_PJPROJECT. * The rtp->ice_active_remote_candidates container was being used to check the address on incoming packets but that container doesn't contain peer reflexive candidates discovered during negotiation. This was causing the check to fail where it shouldn't. We now check against pjproject's real_ice->rcand array which will contain those candidates. * Also fixed a bug in ast_sockaddr_from_pj_sockaddr() where we weren't zeroing out sin->sin_zero before returning. This was causing ast_sockaddr_cmp() to always return false when one of the inputs was converted from a pj_sockaddr, even if both inputs had the same address and port. Resolves: #500 Resolves: #503 Resolves: #505	2 years ago
George Joseph	85fc4ce712	doc: Remove obsolete CHANGES-staging directrory ... This should have been removed after the last release but was missed.	2 years ago
Gitea	6b4f9ab005	res_pjsip_header_funcs: Duplicate new header value, don't copy. ... When updating an existing header the 'update' code incorrectly just copied the new value into the existing buffer. If the new value exceeded the available buffer size memory outside of the buffer would be written into, potentially causing a crash. This change makes it so that the 'update' now duplicates the new header value instead of copying it into the existing buffer.	2 years ago
George Joseph	2b66362173	res_rtp_asterisk.c: Check DTLS packets against ICE candidate list ... When ICE is in use, we can prevent a possible DOS attack by allowing DTLS protocol messages (client hello, etc) only from sources that are in the active remote candidates list. Resolves: GHSA-hxj9-xwr8-w8pq	2 years ago
Ben Ford	705cd2845d	manager.c: Prevent path traversal with GetConfig. ... When using AMI GetConfig, it was possible to access files outside of the Asterisk configuration directory by using filenames with ".." and "./" even while live_dangerously was not enabled. This change resolves the full path and ensures we are still in the configuration directory before attempting to access the file.	2 years ago
Mike Bradeen	c7050787f3	res_pjsip: disable raw bad packet logging ... Add patch to split the log level for invalid packets received on the signaling port. The warning regarding the packet will move to level 2 so that it can still be displayed, while the raw packet will be at level 4.	2 years ago
George Joseph	0f20f39db8	MergeApproved.yml: Remove unneeded concurrency ... The concurrency parameter on the MergeAndCherryPick job has been rmeoved. It was a hold-over from earlier days.	2 years ago
George Joseph	c53cd1c82d	SECURITY.md: Update with correct documentation URL	2 years ago
George Joseph	8e012faf9e	chan_pjsip: Add PJSIPHangup dialplan app and manager action ... See UserNote below. Exposed the existing Hangup AMI action in manager.c so we can use all of it's channel search and AMI protocol handling without duplicating that code in dialplan_functions.c. Added a lookup function to res_pjsip.c that takes in the string represenation of the pjsip_status_code enum and returns the actual status code. I.E. ast_sip_str2rc("DECLINE") returns 603. This allows the caller to specify PJSIPHangup(decline) in the dialplan, just like Hangup(call_rejected). Also extracted the XML documentation to its own file since it was almost as large as the code itself. UserNote: A new dialplan app PJSIPHangup and AMI action allows you to hang up an unanswered incoming PJSIP call with a specific SIP response code in the 400 -> 699 range.	2 years ago
Mark Murawski	81c400a1c2	Remove files that are no longer updated ... Fixes: #360	2 years ago
Mike Bradeen	db5767f19d	res_speech: allow speech to translate input channel ... * Allow res_speech to translate the input channel if the format is translatable to a format suppored by the speech provider. Resolves: #129 UserNote: res_speech now supports translation of an input channel to a format supported by the speech provider, provided a translation path is available between the source format and provider capabilites.	2 years ago
George Joseph	05d26994af	.github: PRSubmitActions: Fix adding reviewers to PR	2 years ago
George Joseph	cd640dc67b	.github: New PR Submit workflows ... The workflows that get triggered when PRs are submitted or updated have been replaced with ones that are more secure and have a higher level of parallelism.	2 years ago
George Joseph	5eb676bab5	.github: New PR Submit workflows ... The workflows that get triggered when PRs are submitted or updated have been replaced with ones that are more secure and have a higher level of parallelism.	2 years ago
Mike Bradeen	5342562892	res_stasis: signal when new command is queued ... res_statsis's app loop sleeps for up to .2s waiting on input to a channel before re-checking the command queue. This can cause delays between channel setup and bridge. This change is to send a SIGURG on the sleeping thread when a new command is enqueued. This exits the sleeping thread out of the ast_waitfor() call triggering the new command being processed on the channel immediately. Resolves: #362 UserNote: Call setup times should be significantly improved when using ARI.	2 years ago
George Joseph	20b06e7bb5	logger.h: Add ability to change the prefix on SCOPE_TRACE output ... You can now define the _TRACE_PREFIX_ macro to change the default trace line prefix of "file:line function" to something else. Full documentation in logger.h.	2 years ago
George Joseph	d0a1c2b026	.github: Fix job prereqs in PROpenedUpdated	2 years ago
George Joseph	825d3b981a	.github: Block PR tests until approved	2 years ago
George Joseph	733ab35848	Add libjwt to third-party ... The current STIR/SHAKEN implementation is not currently usable due to encryption issues. Rather than trying to futz with OpenSSL and the the current code, we can take advantage of the existing capabilities of libjwt but we first need to add it to the third-party infrastructure already in place for jansson and pjproject. A few tweaks were also made to the third-party infrastructure as a whole. The jansson "dest" install directory was renamed "dist" to better match convention, and the third-party Makefile was updated to clean all product directories not just the ones currently in use. Resolves: #349	2 years ago
Mike Bradeen	7369de127a	res_pjsip: update qualify_timeout documentation with DNS note ... The documentation on qualify_timeout does not explicitly state that the timeout includes any time required to perform any needed DNS queries on the endpoint. If the OPTIONS response is delayed due to the DNS query, it can still render an endpoint as Unreachable if the net time is enough for qualify_timeout to expire. Resolves: #352	2 years ago
George Joseph	04183eb246	lock.c: Separate DETECT_DEADLOCKS from DEBUG_THREADS ... Previously, DETECT_DEADLOCKS depended on DEBUG_THREADS. Unfortunately, DEBUG_THREADS adds a lot of lock tracking overhead to all of the lock lifecycle calls whereas DETECT_DEADLOCKS just causes the lock calls to loop over trylock in 200us intervals until the lock is obtained and spits out log messages if it takes more than 5 seconds. From a code perspective, the only reason they were tied together was for logging. So... The ifdefs in lock.c were refactored to allow DETECT_DEADLOCKS to be enabled without also enabling DEBUG_THREADS. Resolves: #321 UserNote: You no longer need to select DEBUG_THREADS to use DETECT_DEADLOCKS. This removes a significant amount of overhead if you just want to detect possible deadlocks vs needing full lock tracing.	2 years ago
Mike Bradeen	5c58a6fd56	cel: add publish user event helper ... Add a wrapper function around ast_cel_publish_event that packs event and extras into a blob before publishing Resolves:#330	2 years ago
George Joseph	7b42ebb90d	file.c: Add ability to search custom dir for sounds ... To better co-exist with sounds files that may be managed by packages, custom sound files may now be placed in AST_DATA_DIR/sounds/custom instead of the standard AST_DATA_DIR/sounds/<lang> directory. If the new "sounds_search_custom_dir" option in asterisk.conf is set to "true", asterisk will search the custom directory for sounds files before searching the standard directory. For performance reasons, the "sounds_search_custom_dir" defaults to "false". Resolves: #315 UserNote: A new option "sounds_search_custom_dir" has been added to asterisk.conf that allows asterisk to search AST_DATA_DIR/sounds/custom for sounds files before searching the standard AST_DATA_DIR/sounds/<lang> directory.	2 years ago
George Joseph	8d506370f5	make_buildopts_h, et. al. Allow adding all cflags to buildopts.h ... The previous behavior of make_buildopts_h was to not add the non-ABI-breaking MENUSELECT_CFLAGS like DETECT_DEADLOCKS, REF_DEBUG, etc. to the buildopts.h file because "it caused ccache to invalidate files and extended compile times". They're only defined by passing them on the gcc command line with '-D' options. In practice, including them in the include file rarely causes any impact because the only time ccache cares is if you actually change an option so the hit occurrs only once after you change it. OK so why would we want to include them? Many IDEs follow the include files to resolve defines and if the options aren't in an include file, it can cause the IDE to mark blocks of "ifdeffed" code as unused when they're really not. So... * Added a new menuselect compile option ADD_CFLAGS_TO_BUILDOPTS_H which tells make_buildopts_h to include the non-ABI-breaking flags in buildopts.h as well as the ABI-breaking ones. The default is disabled to preserve current behavior. As before though, only the ABI-breaking flags appear in AST_BUILDOPTS and only those are used to calculate AST_BUILDOPT_SUM. A new AST_BUILDOPT_ALL define was created to capture all of the flags. * make_version_c was streamlined to use buildopts.h and also to create asterisk_build_opts_all[] and ast_get_build_opts_all(void) * "core show settings" now shows both AST_BUILDOPTS and AST_BUILDOPTS_ALL. UserNote: The "Build Options" entry in the "core show settings" CLI command has been renamed to "ABI related Build Options" and a new entry named "All Build Options" has been added that shows both breaking and non-breaking options.	2 years ago
Mike Bradeen	cf623753a9	func_periodic_hook: Add hangup step to avoid timeout ... func_periodic_hook does not hangup after playback, relying on hangup which keeps the channel alive longer than necessary. Resolves: #325	2 years ago
George Joseph	2e59f9fd6a	func_periodic_hook: Don't truncate channel name ... func_periodic_hook was truncating long channel names which causes issues when you need to run other dialplan functions/apps on the channel. Resolves: #319	2 years ago
George Joseph	4e43b9d308	safe_asterisk: Change directory permissions to 755 ... If the safe_asterisk script detects that the /var/lib/asterisk directory doesn't exist, it now creates it with 755 permissions instead of 770. safe_asterisk needing to create that directory should be extremely rare though because it's normally created by 'make install' which already sets the permissions to 755. Resolves: #316	2 years ago
Joshua C. Colp	405a08aaed	variables: Add additional variable dialplan functions. ... Using the Set dialplan application does not actually delete channel or global variables. Instead the variables are set to an empty value. This change adds two dialplan functions, GLOBAL_DELETE and DELETE which can be used to delete global and channel variables instead of just setting them to empty. There is also no ability within the dialplan to determine if a global or channel variable has actually been set or not. This change also adds two dialplan functions, GLOBAL_EXISTS and VARIABLE_EXISTS which can be used to determine if a global or channel variable has been set or not. Resolves: #289 UserNote: Four new dialplan functions have been added. GLOBAL_DELETE and DELETE have been added which allows the deletion of global and channel variables. GLOBAL_EXISTS and VARIABLE_EXISTS have been added which checks whether a global or channel variable has been set.	2 years ago
George Joseph	3d01cbaae9	ari-stubs: Fix more local anchor references ... Also allow CreateDocs job to be run manually with default branches.	2 years ago
George Joseph	2f1d12b7dc	ari-stubs: Fix more local anchor references ... Also allow CreateDocs job to be run manually with default branches.	2 years ago
George Joseph	e54d867f25	ari-stubs: Fix broken documentation anchors ... All of the links that reference page anchors with capital letters in the ids (#Something) have been changed to lower case to match the anchors that are generated by mkdocs.	2 years ago
George Joseph	d2172582f7	rest-api: Updates for new documentation site ... The new documentation site uses traditional markdown instead of the Confluence flavored version. This required changes in the mustache templates and the python that generates the files.	2 years ago
George Joseph	56e592248d	.github: Update workflow-application-token-action to v2	2 years ago
Mike Bradeen	8f5fb2af23	app_voicemail: Fix for loop declarations ... Resolve for loop initial declarations added in cli changes. Resolves: #275	2 years ago
George Joseph	bebf843253	download_externals: Fix a few version related issues ... * Fixed issue with the script not parsing the new tag format for certified releases. The format changed from certified/18.9-cert5 to certified-18.9-cert5. * Fixed issue where the asterisk version wasn't being considered when looking for cached versions. Resolves: #263	2 years ago
George Joseph	87773dc11f	Remove .lastclean and .version from source control ... Historically these were checked in for certified releases but since the move to github and the unified release process, they are no longer needed and cause issues.	2 years ago
George Joseph	a95f98f8bb	.github: Use generic releaser	2 years ago
Joshua C. Colp	c83c14ba2d	manager: Tolerate stasis messages with no channel snapshot. ... In some cases I have yet to determine some stasis messages may be created without a channel snapshot. This change adds some tolerance to this scenario, preventing a crash from occurring.	2 years ago
Joshua C. Colp	b37b28e071	audiohook: Unlock channel in mute if no audiohooks present. ... In the case where mute was called on a channel that had no audiohooks the code was not unlocking the channel, resulting in a deadlock. Resolves: #233	2 years ago
Joshua C. Colp	82c0971e6e	app_queue: Add support for applying caller priority change immediately. ... The app_queue module provides both an AMI action and a CLI command to change the priority of a caller in a queue. Up to now this change of priority has only been reflected to new callers into the queue. This change adds an "immediate" option to both the AMI action and CLI command which immediately applies the priority change respective to the other callers already in the queue. This can allow, for example, a caller to be placed at the head of the queue immediately if their priority is sufficient. Resolves: #202 UserNote: The 'queue priority caller' CLI command and 'QueueChangePriorityCaller' AMI action now have an 'immediate' argument which allows the caller priority change to be reflected immediately, causing the position of a caller to move within the queue depending on the priorities of the other callers.	2 years ago
George Joseph	8aba4a4f88	.github: Fix cherry-pick reminder issues	2 years ago
George Joseph	e46f7892a6	app.h: Move declaration of ast_getdata_result before its first use ... The ast_app_getdata() and ast_app_getdata_terminator() declarations in app.h were changed recently to return enum ast_getdata_result (which is how they were defined in app.c). The existing declaration of ast_getdata_result in app.h was about 1000 lines after those functions however so under certain circumstances, a "use before declaration" error was thrown by the compiler. The declaration of the enum was therefore moved to before those functions. Resolves: #200	2 years ago
George Joseph	7c84bf40e0	doc: Remove obsolete CHANGES-staging and UPGRADE-staging	2 years ago
Sean Bright	836f0bed18	res_geolocation: Ensure required 'location_info' is present. ... Fixes #189	2 years ago
Mike Bradeen	4929a2c419	Adds manager actions to allow move/remove/forward individual messages ... in a particular mailbox folder. The forward command can be used to copy a message within a mailbox or to another mailbox. Also adds a VoicemailBoxSummarry, required to retrieve message ID's. Resolves: #181 UserNote: The following manager actions have been added VoicemailBoxSummary - Generate message list for a given mailbox VoicemailRemove - Remove a message from a mailbox folder VoicemailMove - Move a message from one folder to another within a mailbox VoicemailForward - Copy a message from one folder in one mailbox to another folder in another or the same mailbox.	2 years ago
Mike Bradeen	8f8413b494	app_voicemail: add CLI commands for message manipulation ... Adds CLI commands to allow move/remove/forward individual messages from a particular mailbox folder. The forward command can be used to copy a message within a mailbox or to another mailbox. Also adds a show mailbox, required to retrieve message ID's. Resolves: #170 UserNote: The following CLI commands have been added to app_voicemail voicemail show mailbox <mailbox> <context> Show contents of mailbox <mailbox>@<context> voicemail remove <mailbox> <context> <from_folder> <messageid> Remove message <messageid> from <from_folder> in mailbox <mailbox>@<context> voicemail move <mailbox> <context> <from_folder> <messageid> <to_folder> Move message <messageid> in mailbox <mailbox>&<context> from <from_folder> to <to_folder> voicemail forward <from_mailbox> <from_context> <from_folder> <messageid> <to_mailbox> <to_context> <to_folder> Forward message <messageid> in mailbox <mailbox>@<context> <from_folder> to mailbox <mailbox>@<context> <to_folder>	2 years ago
George Joseph	3bb5cef959	.github: Minor tweak to Asterisk Releaser	2 years ago
George Joseph	e1e294a5e3	.github: Suppress cherry-pick reminder for some situations ... In PROpenedOrUpdated, the cherry-pick reminder will now be suppressed if there are already valid 'cherry-pick-to' comments in the PR or the PR contained a 'cherry-pick-to: none' comment.	2 years ago