143 Commits (66cce0927e582b326b080e77d7fc5a679cc8293a)

Author	SHA1	Message	Date
Richard Mudgett	f3d38eb801	ooh323c: Fix gcc 4.6.3 compiler warnings. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@404212 65c4cc65-6c06-0410-ace0-fbb531ad65f3	12 years ago
Alexandr Anikin	a889d8768f	reject call attempts when gatekeeper is configured but not registered ... (closes issue ASTERISK-21800) Reported by: Dmitry Melekhov Patches: ASTERISK-21800-1.patch Tested by: Dmitry Melekhov git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@390181 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Michael L. Young	7d7e11de51	Fix Sorting Order For Parking Lots Stored In Static Realtime ... When retrieving the parking lots from a MySQL database table, the current order is "filename, cat_metric desc, var_metric asc, category". If there are multiple parking lots with the same cat_metric but different categories, everything is being sorted on cat_metric first resulting in errors when loading the parking lots. This patch fixes the problem by sorting on the category field first, then the cat_metric field. (closes issue ASTERISK-21035) Reported by: Alex Epshteyn Patches: asterisk-21035-orderby.diff Michael L. Young (license 5026) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@382942 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Matthew Jordan	b028e09f9e	Clean up use of va_end/va_args in res_config_mysql ... There were several problems using variadic argument macros in res_config_mysql. * Improper use of va_end. Multiple calls to va_end were possible resulting in an unbalanced matching of va_start/va_end. * Calls to va_arg after a possible encounter of a SENTINEL value. This patch corrects those errors. (closes issue ASTERISK-19451) Reported by: wdoekes patches: ASTERISK-19451-1.8--2.diff uploaded by wdoekes (License 5674) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@382021 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Matthew Jordan	02c1a29aaf	Fix issue where chan_mobile fails to bind to first available port ... Per the bluez API, in order to bind to the first available port, the rc_channel field of the socket addressing structure used to bind the socket should be set to 0. Previously, Asterisk had set the rc_channel field set to 1, causing it to connect to whatever happens to be on port 1. We could probably not explicitly set rc_channel to 0 since we memset the struct earlier, but explicitly setting it will hopefully prevent someone from coming in and setting it to some explicit port in the future. (closes issue ASTERISK-16357) Reported by: challado Tested by: Alexander Heinz, Nikolay Ilduganov, benjamin, eliafino, David van Geyn patches: ASTERISK-16357.diff uploaded by Nikolay Ilduganov (license 6253) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@379342 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Matthew Jordan	bcc92a8d2d	Fix parsing SMSSRC for SMS messages ... The parser for SMS messages would incorrectly parse out the from number. The parsing would incorrectly start scanning for the from number at the same index as the first double quote ("); this would inadvertently cause it to treat the first double quote as the terminating double quote for the from number as well. The SMSSRC should now populate correctly. (closes issue ASTERISK-16822) Reported by: menschentier Tested by: Jonas Falck patches: fixSMSSRC.patch uploaded by jonax (license 6320) (closes issue ASTERISK-19153) Reported by: Panos Gkikakis patches: sms-sender-fix.diff uploaded by roeften (license 5884) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@379178 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Tilghman Lesher	6769e186b9	Remove some dead code and additionally handle a case that wasn't handled. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@377487 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Richard Mudgett	1e8a45c170	Remove unnecessary channel module references. ... * Removed call to ast_module_user_hangup_all() in res_config_mysql.c since it is effectively a noop. No channels can attach a reference to that module. * Removed call to ast_module_user_hangup_all() in app_celgenuserevent.c. The caller of unload_module() has already called it. * Removed redundant channel module references in pbx_dundi.c. The registered dialplan function callback dispatchers for the read/read2/write callbacks already reference the module before calling. * pbx_dundi: Moved unregistering CLI commands, DUNDi switch, and dialplan functions to the first thing the unload_module() does. This will reduce the chance of new channels using DUNDi services while the module is being torn down. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@376657 65c4cc65-6c06-0410-ace0-fbb531ad65f3	13 years ago
Alexandr Anikin	eefc33dd34	remove ALREADYGONE flag on ooh323 call data by ooh323_indicate ... (CONGESTION/BUSY) due to call hasn't gone there really. This indication arrive from asterisk core not h.323 stack (closes issue ASTERISK-19308) Reported by: Dmitry Melekhov Patches: ASTERISK-19308.patch git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@371089 65c4cc65-6c06-0410-ace0-fbb531ad65f3	14 years ago
Alexandr Anikin	c6d75bc2f5	Send re-register packets by GRQ (gatekeeper request) interval ... (close issue ASTERISK-20094) Patches: ASTERISK-20094-2.patch git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@371060 65c4cc65-6c06-0410-ace0-fbb531ad65f3	14 years ago
Alexandr Anikin	74d2044626	Fix to resend GRQ/RRQ if RRJ (registration reject) is received ... (close issue ASTERISK-20094) Patches: ASTERISK-20094.patch git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@371011 65c4cc65-6c06-0410-ace0-fbb531ad65f3	14 years ago
Alexandr Anikin	ec6801aa0d	change opening h323 logfile with append mode instead of overwrite ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@370988 65c4cc65-6c06-0410-ace0-fbb531ad65f3	14 years ago
Kinsey Moore	377caa7fb1	Clean up and ensure proper usage of alloca() ... This replaces all calls to alloca() with ast_alloca() which calls gcc's __builtin_alloca() to avoid BSD semantics and removes all NULL checks on memory allocated via ast_alloca() and ast_strdupa(). (closes issue ASTERISK-20125) Review: https://reviewboard.asterisk.org/r/2032/ Patch-by: Walter Doekes (wdoekes) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@370642 65c4cc65-6c06-0410-ace0-fbb531ad65f3	14 years ago
Kevin P. Fleming	ecbaf1ee3f	Ensure that all ast_datastore_info structures are 'const'. ... While addressing a bug, I came across a instance of 'struct ast_datastore_info' that was not declared 'const'. Since the API already expects them to be 'const', this patch changes the declarations of all existing instances that were not already declared that way. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@370183 65c4cc65-6c06-0410-ace0-fbb531ad65f3	14 years ago
Alexandr Anikin	c1bafc8f9f	fix locking issue on empty callList ... (issue ASTERISK-19298) Reported by: Dmitry Melekhov Patches: ASTERISK-18322-2.patch git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@369146 65c4cc65-6c06-0410-ace0-fbb531ad65f3	14 years ago
Alexandr Anikin	71fbf1a748	fix compile error (1.8 don't have ast_channel_name macro) ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@369130 65c4cc65-6c06-0410-ace0-fbb531ad65f3	14 years ago
Alexandr Anikin	1ab70391f8	check rtptimeouts in ooh323 channels as per config file ... (rtp voice, video, udptl except rtcp) (closes issue ASTERISK-19179) Reported by: TSAREGORODTSEV Yury Patches: 19179-ooh323-2.patch git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@369090 65c4cc65-6c06-0410-ace0-fbb531ad65f3	14 years ago
Russell Bryant	dac30f1523	format_mp3: Fix a possible crash in mp3_read(). ... This patch fixes a potential crash in mp3_read() by not assuming that dbuf has enough data to finish filling up the output buffer. The patch also makes sure that the dbuf state gets reset after we know we read everything out of it already. In passing, this patch includes some other cleanups of this module, including stripping trailing whitespace, formatting fixes based on coding guidelines, and removing a number of unused members from the private state struct. (closes issue ASTERISK-19761) Reported by: Chris Maciejewsk Tested by: Chris Maciejewsk git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@366296 65c4cc65-6c06-0410-ace0-fbb531ad65f3	14 years ago
Alexandr Anikin	4bddfcf335	Fix warning of Coverity Static analysis, change H225ProtocolIdentifier ... from value to pointer per functions that use this. (close issue ASTERISK-19670) Reported by: Matt Jordan Patches: ASTERISK-19670.patch (License #5415) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@365159 65c4cc65-6c06-0410-ace0-fbb531ad65f3	14 years ago
Alexandr Anikin	0b9bca22bd	Fix coverity static analysis warning, allocate full ie structure ... instead of without data buffer (close issue ASTERISK-19674) Reported by: Matt Jordan Patches: ASTERISK-19674.patch (License #5415) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@365143 65c4cc65-6c06-0410-ace0-fbb531ad65f3	14 years ago
Alexandr Anikin	97787d8c5e	Fix use freed pointer in return value from call thread ... (issue ASTERISK-19663) Reported by: Matt Jordan Patches: ASTERISK-19663-ooh323.patch (License #5415) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@364649 65c4cc65-6c06-0410-ace0-fbb531ad65f3	14 years ago
Matthew Jordan	0e488d7cc4	Fix a variety of potential buffer overflows ... * chan_mobile: Fixed an overrun where the cind_state buffer (an integer array of size 16) would be overrun due to improper bounds checking. At worst, the buffer can be overrun by a total of 48 bytes (assuming 4-byte integers), which would still leave it within the allocated memory of struct hfp. This would corrupt other elements in that struct but not necessarily cause any further issues. * app_sms: The array imsg is of size 250, while the array (ud) that the data is copied into is of size 160. If the size of the inbound message is greater then 160, up to 90 bytes could be overrun in ud. This would corrupt the user data header (array udh) adjacent to ud. * chan_unistim: A number of invalid memmoves are corrected. These would move data (which may or may not be valid) into the ends of these buffers. * asterisk: ast_console_toggle_loglevel does not check that the console log level being set is less then or equal to the allowed log levels of 32. * frame: In ast_codec_pref_prepend, if any occurrence of the specified codec is not found, the value used to index into the array pref->order would be one greater then the maximum size of the array. * jitterbuf: If the element being placed into the jitter buffer lands in the last available slot in the jitter history buffer, the insertion sort attempts to move the last entry in the buffer into one slot past the maximum length of the buffer. Note that this occurred for both the min and max jitter history buffers. * tdd: If a read from fsk_serial returns a character that is greater then 32, an attempt to read past one of the statically defined arrays containing the values that character maps to would occur. * localtime: struct ast_time and tm are not the same size - ast_time is larger, although it contains the elements of tm within it in the same layout. Hence, when using memcpy to copy the contents of tm into ast_time, the size of tm should be used, as opposed to the size of ast_time. * extconf: this treats ast_timing's minmask array as if it had a length of 48, when it has defined the size of the array as 24. pbx.h defines minmask as having a size of 48. (issue ASTERISK-19668) Reported by: Matt Jordan git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@362485 65c4cc65-6c06-0410-ace0-fbb531ad65f3	14 years ago
Kinsey Moore	4148e51555	Add missing newlines to CLI logging ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@361471 65c4cc65-6c06-0410-ace0-fbb531ad65f3	14 years ago
Jonathan Rose	78e9a8e5f0	Fix some stuff involving calls to memcpy and memset ... The important parts of the patch were already applied through other updates. (closes issue ASTERISK-19445) Reported by: Makoto Dei Patches: memset-memcpy-length.patch uploaded by Makoto Dei (license 5027) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@361210 65c4cc65-6c06-0410-ace0-fbb531ad65f3	14 years ago
Jonathan Rose	ed76cdda72	Replace GNU old-style field designator extensions to fix clang warnings ... (issue ASTERISK-19540) Reported by: Makoto Dei Patches: clang-gnu-designator.patch uploaded by Makoto Dei (license 5027) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@361142 65c4cc65-6c06-0410-ace0-fbb531ad65f3	14 years ago
Terry Wilson	d58fe85724	Destroy configs when they are no longer used ... https://reviewboard.asterisk.org/r/1834/ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@360712 65c4cc65-6c06-0410-ace0-fbb531ad65f3	14 years ago
Paul Belanger	d2cb0914e4	Fix -Werror=unused-but-set-variable compiler error (gcc 4.6.2) ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@356430 65c4cc65-6c06-0410-ace0-fbb531ad65f3	14 years ago
Paul Belanger	e31d0dfe40	Revert 355700 and 355701 ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@355711 65c4cc65-6c06-0410-ace0-fbb531ad65f3	14 years ago
Paul Belanger	1fd85ee397	Missed a variable ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@355701 65c4cc65-6c06-0410-ace0-fbb531ad65f3	14 years ago
Paul Belanger	0e93bc868e	Fix -Werror=unused-but-set-variable compiler error (gcc 4.6.2) ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@355700 65c4cc65-6c06-0410-ace0-fbb531ad65f3	14 years ago
Alexandr Anikin	7d0ee59215	call manager_event only if there is not null channel structure ... (Closes issue ASTERISK-19298) Reported by: robinfood Patches: issue19298.patch uploaded by may213 (License #5415) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@355136 65c4cc65-6c06-0410-ace0-fbb531ad65f3	14 years ago
Alexandr Anikin	197662dd4d	Fix outbound DTMF for inband mode (tell asterisk core to generate DTMF ... sounds). (Closes issue ASTERISK-19233) Reported by: Matt Behrens Patches: chan_ooh323.c.patch uploaded by Matt Behrens (License #6346) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@352807 65c4cc65-6c06-0410-ace0-fbb531ad65f3	14 years ago
Kevin P. Fleming	3bfed7039f	Correct some 'set-but-not-used' variable warnings. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@350789 65c4cc65-6c06-0410-ace0-fbb531ad65f3	14 years ago
Alexandr Anikin	7e7e263652	process null frame pointer returned by ast_rtp_instance_read correctly ... (closes issue ASTERISK-16697) Reported by: under Patches: segfault.diff (License #5871) patch uploaded by under git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@346762 65c4cc65-6c06-0410-ace0-fbb531ad65f3	14 years ago
Alexandr Anikin	1aa6f26827	(closes issue ASTERISK-18748) ... Reported by: Fabrizio Lazzaretti Patches: ASTERISK-18748-5.patch (License #5415) patch uploaded by may213 Tested by: Fabrizio Lazzaretti git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@344158 65c4cc65-6c06-0410-ace0-fbb531ad65f3	14 years ago
Alexandr Anikin	fc52d0af86	Final fix memleaks in GkClient codes, same for Timer codes. ... (these memleaks stop development of gk codes, now i can continue) Fix printHandler 'Unbalanced Structure' issues with locking printHandler data for single thread. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@343281 65c4cc65-6c06-0410-ace0-fbb531ad65f3	14 years ago
Alexandr Anikin	0c360ed6be	fix issue on channel numbering (calls could have same channel number ... on heavy loaded system) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@341312 65c4cc65-6c06-0410-ace0-fbb531ad65f3	14 years ago
Alexandr Anikin	37c390ac02	fix forget declaration in previous change ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@339244 65c4cc65-6c06-0410-ace0-fbb531ad65f3	14 years ago
Alexandr Anikin	3795f80d2c	destroy memheap mutex properly before memheap deleted ... (fix memory leak occured after r304950 changes with DEBUG_THREAD compile option) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@339087 65c4cc65-6c06-0410-ace0-fbb531ad65f3	14 years ago
Matthew Jordan	7dc49195d8	Updated SIP 484 handling; added Incomplete control frame ... When a SIP phone uses the dial application and receives a 484 Address Incomplete response, if overlapped dialing is enabled for SIP, then the 484 Address Incomplete is forwarded back to the SIP phone and the HANGUPCAUSE channel variable is set to 28. Previously, the Incomplete application dialplan logic was automatically triggered; now, explicit dialplan usage of the application is required. Additionally, this patch adds a new AST_CONTOL_FRAME type called AST_CONTROL_INCOMPLETE. If a channel driver receives this control frame, it is an indication that the dialplan expects more digits back from the device. If the device supports overlap dialing it should attempt to notify the device that the dialplan is waiting for more digits; otherwise, it can handle the frame in a manner appropriate to the channel driver. (closes issue ASTERISK-17288) Reported by: Mikael Carlsson Tested by: Matthew Jordan Review: https://reviewboard.asterisk.org/r/1416/ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@335064 65c4cc65-6c06-0410-ace0-fbb531ad65f3	14 years ago
Alexandr Anikin	1ae6d66b92	cleanups in ACF/ARJ GK replies processing ... fixed long (24 sec) pause if acf/arj proccessed before ast_cond_wait called to wait this git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@333947 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Richard Mudgett	97959f3e9a	Fix deadlock potential of chan_mobile.c:mbl_ast_hangup(). ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@333784 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Alexandr Anikin	8f37bc12c4	move ast_cond_signal for admitted call after all data filled/freed ... clear all log channels by pointed number not only first free allocated callToken in ooh323_answer git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@331146 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Alexandr Anikin	65a7f1b205	change gk client behaivour on rrq/grq failures to setup timers ... and next tries after timeout instead of complete failure in the ooh323 stack git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@330827 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Alexandr Anikin	92ba1aed9f	small gk processing fixes: ... - decrease for 1 second registration ttl for very low expirations (some providers expire few earlier than TTL) - delete rrq and registration expire timers on URQ received as we make new registration. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@328427 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Leif Madsen	d4938a111e	Introduce <support_level> tags in MODULEINFO. ... This change introduces MODULEINFO into many modules in Asterisk in order to show the community support level for those modules. This is used by changes committed to menuselect by Russell Bryant recently (r917 in menuselect). More information about the support level types and what they mean is available on the wiki at https://wiki.asterisk.org/wiki/display/AST/Asterisk+Module+Support+States git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@328209 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Alexandr Anikin	c8c5461a76	Fix double alerting, add forced alerting before answer ... Fix double alerting (it wasn't fixed here by issue #18542) Add forced alerting before connect (if it wasn't before) Try to send all packets from outgoing queue rather than one only Call goes into clearing state when disconnect command is received (closes issue #19361) Reported by: vmikhelson Patches: issue19361-3.patch uploaded by may213 (license 454) Tested by: vmikhelson git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@321528 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Terry Wilson	5427820aaf	Cast data as char * before using S_OR ... This is required for compiling successfully under dev mode git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@320716 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Russell Bryant	5caa350fab	Fix a crash in the MySQL() application. ... This code was not handling channel datastores safely. The channel must be locked. (closes issue #17964) Reported by: wuwu Patches: issue17964_addon_1.6.2_svn.patch uploaded by seanbright (license 71) Tested by: wuwu git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317837 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Sean Bright	ccbc674e56	Don't duplicate our data on the stack and just use the MYSQL_ROW directly. ... With large result sets we were blowing out the stack. (closes issue #19090) Reported by: mickecarlsson Patches: issue19090_trunk_svn.patch uploaded by seanbright (license 71) Tested by: mickecarlsson git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.8@317370 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago