5962 Commits (6531f8b2ea50c0e9ead60f29f355912df907c43b)

Author	SHA1	Message	Date
Friendly Automation	e7de71ee24	Merge "main/json.c: Added app_name, app_data to channel type" into 13	6 years ago
Friendly Automation	7b64432c4e	Merge "res/res_ari: Added ARI resource /ari/channels/{channelId}/rtp_statistics" into 13	6 years ago
sungtae kim	707897e5f7	main/json.c: Added app_name, app_data to channel type ... It was difficult to check the channel's current application and parameters using ARI for current channels. Added app_name, app_data items to show the current application information. ASTERISK-28343 Change-Id: Ia48972b3850e5099deab0faeaaf51223a1f2f38c	6 years ago
George Joseph	0fdfac87f3	Merge "manager: Use separate lock for session event notification." into 13	6 years ago
sungtae kim	fb7aa52ae0	res/res_ari: Added ARI resource /ari/channels/{channelId}/rtp_statistics ... Added ARI resource for channel statistics. GET /ari/channels/{channelId}/rtp_statistics : It returns given channel's rtp statistics detail. ASTERISK-28320 Change-Id: I4343eec070438cec13f2a4f22e7fd9e574381376	6 years ago
Joshua Colp	03708f435c	manager: Use separate lock for session event notification. ... When notifying a manager session that new events were available the same lock was used that was also held when doing things within the session (such as sending events out). If the manager session blocked for a period of time this would cause a back up of messages in Stasis and would also block any other sessions from receiving events. This change adds a separate lock to the manager session which is strictly used for notifying it that new events are available. ASTERISK-28350 Change-Id: Ifbcac007faca9ad0231640f5e82a6ca9228f261b	6 years ago
Matthew Fredrickson	4315634bc9	main/taskprocessor: Increase max name length of taskprocessors ... Since the new names went in, the maximum taskprocessor name is too short. This patch increases the name field to a length to better handle the new names. Change-Id: I32f32d6926f25c8ef5a91303fd2988d2c2858877	6 years ago
George Joseph	85f87790a5	Merge "sorcery.c: Sorcery enhancements for wizard management" into 13	6 years ago
George Joseph	69b194c837	sorcery.c: Sorcery enhancements for wizard management ... Added ability to specifiy a wizard is read-only when applying it to a specific object type. This allows you to specify create, update and delete callbacks for the wizard but limit which object types can use them. Added the ability to allow an object type to have multiple wizards of the same type. This is indicated when a wizard is added to a specific object type. Added 3 new sorcery wizard functions: * ast_sorcery_object_type_insert_wizard which does the same thing as the existing ast_sorcery_insert_wizard_mapping function but accepts the new read-only and allot-duplicates flags and also returns the ast_sorcery_wizard structure used and it's internal data structure. This allows immediate use of the wizard's callbacks without having to register a "wizard mapped" observer. * ast_sorcery_object_type_apply_wizard which does the same thing as the existing ast_sorcery_apply_wizard_mapping function but has the added capabilities of ast_sorcery_object_type_insert_wizard. * ast_sorcery_object_type_remove_wizard which removes a wizard matching both its name and its original argument string. * The original logic in __ast_sorcery_insert_wizard_mapping was moved to __ast_sorcery_object_type_insert_wizard and enhanced for the new capabilities, then __ast_sorcery_insert_wizard_mapping was refactored to just call __ast_sorcery_insert_wizard_mapping. * Added a unit test to test_sorcery.c to test the read-only capability. Change-Id: I40f35840252e4313d99e11dbd80e270a3aa10605	6 years ago
George Joseph	93d5e4b106	Merge "app.c: Remove deletion of pool topic on mwi state delete" into 13	6 years ago
Richard Mudgett	f4bb80ba85	taskprocessor.c: Fix printf type mismatch ... A size_t is not always an unsigned long. * Use the %zu format specifier in the ast_cli() printf format string since AST_VECTOR_SIZE() returns a size_t value. Change-Id: Ib102dd36bbe6c2a7a4ce6870ae9110d978dd7e98	6 years ago
George Joseph	c87158f2da	app.c: Remove deletion of pool topic on mwi state delete ... As part of an earlier voicemail refactor, ast_delete_mwi_state_full was modified to remove the pool topic for a mailbox when the state was deleted. This was an attempt to prevent stale topics from accumulating when app_voicemail was reloaded and a mailbox went away. Unfortunately because of the fact that when app_voicemail reloads, ALL mailboxes are deleted then only current ones recreated, topics were being removed from the pool that still had subscribers on them, then recreated as new topics of the same name. So now modules like res_pjsip_mwi are listening on a topic that will never receive any messages because app_voicemail is publishing on a different topic that happens to have the same name. The solutiuon to this is not easy and given that accumulating topics for deleted mailboxes is less evil that not sending NOTIFYs... * Removed the call to stasis_topic_pool_delete_topic in ast_delete_mwi_state_full. Also: * Fixed a topic reference leak in res_pjsip_mwi mwi_stasis_subscription_alloc. * Added some debugging to mwi_stasis_subscription_alloc, stasis_topic_create, and topic_dtor. * Fixed a topic reference leak in an error path in internal_stasis_subscribe. ASTERISK-28306 Reported-by: Jared Hull Change-Id: Id7da0990b3ac4be4b58491536b35f41291247b27	6 years ago
Joshua C. Colp	c7d58aec7a	Merge "stasis: Improve topic/subscription names and statistics." into 13	6 years ago
Joshua Colp	07b3253155	stasis: Improve topic/subscription names and statistics. ... Topic names now follow: <subsystem>:<functionality>[/<object>] This ensures that they are all unique, and also provides better insight in to what each topic is for. Subscriber ids now also use the main topic name they are subscribed to and an incrementing integer as their identifier to make it easier to understand what the subscription is primarily responsible for. Both the CLI commands for listing topic and subscription statistics now sort to make it a bit easier to see what is going on. Subscriptions will now show all topics that they are receiving messages from, not just the main topic they were subscribed to. ASTERISK-28335 Change-Id: I484e971a38c3640f2bd156282e532eed84bf220d	6 years ago
sungtae kim	4dd4dbddbb	bridging: Add creation timestamps ... This small feature will help to checking the bridge's status to figure out which bridge is in old/zombie or not. Also added detail items for the 'bridge show *' cli to provide more detail info. And added creation item to the ARI as well. ASTERISK-28279 Change-Id: I460238c488eca4d216b9176576211cb03286e040	6 years ago
Friendly Automation	c4a172efba	Merge "Revert "http.c: Support separated HTTP request"" into 13	6 years ago
Joshua Colp	2f4a15101b	Revert "http.c: Support separated HTTP request" ... This reverts commit 148ddfba9a. Reason for revert: Under 13 this change appears to break HTTP body processing, causing test failures and problems. Change-Id: Ica47ca2cac1b21c6ef907c1ffbfaf2cebdea8e80	6 years ago
Joshua C. Colp	600db408c7	Merge "http.c: Support separated HTTP request" into 13	6 years ago
Joshua C. Colp	9921262c85	Merge "taskprocessor: Enable subsystems and overload by subsystem" into 13	6 years ago
Sungtae Kim	148ddfba9a	http.c: Support separated HTTP request ... Currently, the Asterisk does not support seperated HTTP request. This patch make the Asterisk enables to wait lest part of HTTP request. Also increases acceptable HTTP body length to 40k to support more larger request. ASTERISK-28236 Change-Id: I48a401aa64a21c3b37bf3cb4e0486d64b7dd8aa1	6 years ago
Joshua C. Colp	82758295df	stasis: Store subscriber uniqueids with topic statistics. ... This change provides an easier mechanism to determine which subscribers are subscribed to a topic. Using this you can inspect the specific subscribers for further details. Change-Id: I8deea21703cd5c5357b85593b46c3eaf24e18c0c	6 years ago
George Joseph	bae3fd04c1	taskprocessor: Enable subsystems and overload by subsystem ... To prevent one subsystem's taskprocessors from causing others to stall, new capabilities have been added to taskprocessors. * Any taskprocessor name that has a '/' will have the part before the '/' saved as its "subsystem". Examples: "sorcery/acl-0000006a" and "sorcery/aor-00000019" will be grouped to subsystem "sorcery". "pjsip/distributor-00000025" and "pjsip/distributor-00000026" will bn grouped to subsystem "pjsip". Taskprocessors with no '/' have an empty subsystem. * When a taskprocessor enters high-water alert status and it has a non-empty subsystem, the subsystem alert count will be incremented. * When a taskprocessor leaves high-water alert status and it has a non-empty subsystem, the subsystem alert count will be decremented. * A new api ast_taskprocessor_get_subsystem_alert() has been added that returns the number of taskprocessors in alert for the subsystem. * A new CLI command "core show taskprocessor alerted subsystems" has been added. * A new unit test was addded. REMINDER: The taskprocessor code itself doesn't take any action based on high-water alerts or overloading. It's up to taskprocessor users to check and take action themselves. Currently only the pjsip distributor does this. * A new pjsip/global option "taskprocessor_overload_trigger" has been added that allows the user to select the trigger mechanism the distributor uses to pause accepting new requests. "none": Don't pause on any overload condition. "global": Pause on ANY taskprocessor overload (the default and current behavior) "pjsip_only": Pause only on pjsip taskprocessor overloads. * The core pjsip pool was renamed from "SIP" to "pjsip" so it can be properly grouped into the "pjsip" subsystem. * stasis taskprocessor names were changed to "stasis" as the subsystem. * Sorcery core taskprocessor names were changed to "sorcery" to match the object taskprocessors. Change-Id: I8c19068bb2fc26610a9f0b8624bdf577a04fcd56	6 years ago
Kevin Harwell	b2d3c9d2de	json.c/strings.c - Add a couple of utility functions ... Added 'ast_json_object_string_get' to the JSON wrapper in order to make it a little easier to retrieve a string field from the JSON object. Also added an 'ast_strings_equal' function that safely checks (checks for NULLs) for equality between two strings. Change-Id: I26f0a16d61537505eb41b4b05ef2e6d67fc2541b	6 years ago
George Joseph	1ec00d205f	Merge "Revert "Test_cel: Fails when DONT_OPTIMIZE is off"" into 13	6 years ago
Chris Savinovich	3e922adcc1	Revert "Test_cel: Fails when DONT_OPTIMIZE is off" ... This reverts commit 9b85882f04. Change-Id: I36cf159abb103502e48d6f8fd70d560d7f0bda56	6 years ago
George Joseph	d496bf2099	Merge "sounds: Sort 'core show sounds' output" into 13	6 years ago
Sungtae Kim	f16d711679	main/cdr: Fixed cdr start overwriting ... The CDR was overwriting the start time when the call continued the dialplan from the ARI stasis or a Local channel was originated. This change fixes this by no longer reinitializing the CDR when transitioning out of the dialed pending state to the single state. ASTERISK-28181 Change-Id: I921bc04064b6cff1deb2eea56a94d86489561cdc	6 years ago
George Joseph	1edcff6b03	Merge "Fix deadlock handling subscribe req during res_parking reload" into 13	6 years ago
Sean Bright	e70f8f7c20	sounds: Sort 'core show sounds' output ... Change-Id: Ib39052a745040f75eb635f15a042da15b20e22ab	6 years ago
Joshua C. Colp	41da4ed8b2	Merge "media_index.c: Refactored so it doesn't cache the index" into 13	6 years ago
George Joseph	66982824bf	media_index.c: Refactored so it doesn't cache the index ... Testing revealed that the cache added no benefit but that it could consume excessive memory. Two new index related functions were created: ast_sounds_get_index_for_file() and ast_media_index_update_for_file() which restrict index updating to specific sound files. The original ast_sounds_get_index() and ast_media_index_update() calls are still available but since they no longer cache the results internally, developers should re-use an index they may already have instead of calling ast_sounds_get_index() repeatedly. If information for only a single file is needed, ast_sounds_get_index_for_file() should be called instead of ast_sounds_get_index(). The media_index directory scan code was elimininated in favor of using the existing ast_file_read_dirs() function. Since there's no more cache, ast_sounds_index_init now only registers the sounds cli commands instead of generating the initial index and subscribing to stasis format register/unregister messages. ast_sounds_reindex() is now a no-op but left for backwards compatibility. loader.c no longer registers "sounds" as a special reload target. Both the sounds cli commands and the sounds ari resources were refactored to only call ast_sounds_get_index() once per invocation and to use ast_sounds_get_index_for_file() when a specific sound file is requested. Change-Id: I1cef327ba1b0648d85d218b70ce469ad07f4aa8d	6 years ago
Giuseppe Sucameli	a618d20ca4	Fix deadlock handling subscribe req during res_parking reload ... Split destroy_hint method to separate hint removal and extension hint state changed callback, the latter now called via stasis. This avoids deadlock between res_parking reload that is removing the parking lot and the related hint and subscribe requests coming for the same parking lot. ASTERISK-28173 Change-Id: I5b03c3455b3b12b6f83cea4cc34f4b4b20444f7e	6 years ago
Friendly Automation	b9b095bb2e	Merge "Test_cel: Fails when DONT_OPTIMIZE is off" into 13	6 years ago
Joshua C. Colp	e47e8ff39a	Merge "manager_channels: Fix throwing of HangupHandler manager events" into 13	6 years ago
Joshua C. Colp	2c1ac524b8	Merge "stasis / manager / ari: Better filter messages." into 13	6 years ago
Gerald Schnabel	8791dda672	manager_channels: Fix throwing of HangupHandler manager events ... The type value extracted from stasis message data in channel_hangup_handler_cb isn't compared against the valid values "run", "pop" and "push". Thus the manager events HangupHandlerPush, HangupHandlerPop and HangupHandlerRun are never thrown. This regression was introduced by ASTERISK_21462. ASTERISK-28252 Change-Id: I9956e35e18da1873113644df1ddc3c7cd37bf524	6 years ago
Chris-Savinovich	9b85882f04	Test_cel: Fails when DONT_OPTIMIZE is off ... A bug in GCC causes TEST_CEL to return failure under the following conditions: 1. TEST_FRAMEWORK on 2. DONT_OPTIMIZE off 3. Fedora and Ubuntu 4. GCC 8.2.1 5. Test name: test_cel_dial_pickup 6. There must exist a certain combination of multithreading. The bug affects arithmetic calculations when the optimization level is bigger than O1 and the -fpartial-inline flag is on. Provided these conditions, function ast_str_to_lower() fails to convert to lower case due to said function being of type force_inline. The solution is to remove the "force_inline" type declaration from function ast_str_to_lower() Change-Id: Ied32e0071f12ed9d5f3b4cdd878b2532a1c769d7	6 years ago
Valentin Vidic	efde1ab138	channel.c: Fix segfault with Monitor(wav,file,i) ... If the Monitor is started with the i option the read_stream will be NULL. One code path in channel.c checks if write_stream is set but than uses read_stream instead causing a segfault. ASTERISK-28249 Change-Id: I1bae9126537be54895c7fea2d08dd9488d8cc525	6 years ago
Joshua C. Colp	42922af7b8	stasis / manager / ari: Better filter messages. ... Previously both AMI and ARI used a default route on their stasis message router to handle some of the messages for publishing out their respective connection. This caused messages to be given to their subscription that could not be formatted into AMI or JSON. This change adds an API call to the stasis message router which allows a default route to be set as well as formatters that the default route is expecting. This allows both AMI and ARI to specify that their default route only wants messages of their given formatter. By doing so stasis can more intelligently filter at publishing time so that they do not receive messages which will not be turned into AMI or JSON. ASTERISK-28244 Change-Id: I65272819a53ce99f869181d1d370da559a7d1703	6 years ago
Sean Bright	28da2948d1	sched: Make sched_settime() return void because it cannot fail ... Change-Id: I66b8b2b2778f186919d73ae9bf592104b8fb1cd5	6 years ago
mohitdhiman	84a7b4d356	stasis/endpoint: Fix memory leak of channel_ids in ast_endpoint structure. ... During Bridging of two channels if masquerade operation is performed on a channel (clone channel) which was created with endpoint details (ast_channel_alloc_with_endpoint()) and the original channel which is created without endpoint details (ast_channel_alloc()) then both the channels must exchange their endpoint details or else after masquerade when clone channel is being destroyed the endpoint cleanup callbacks will be destroyed too and after call completion unique_id of original channel will still be there in ast_endpoint structure's channel_ids container. ASTERISK-28197 Change-Id: Ied0451f378a3f2a36acc8c0984959a69895efa17	6 years ago
George Joseph	e3439d3011	Merge "stasis: Fix ABI between DEVMODE and non-DEVMODE." into 13	7 years ago
Richard Mudgett	b26ec935ec	stasic.c: Fix printf format type mismatches with arguments. ... An int64_t is not likely the same size as a long. * Changed the int64_t values in the statistics structs to longs so casting is not necessary when generating the formatted CLI output. The offending members did not need to be int64_t anyway as they were only set by an int type variable which was already truncating bits. * Reordered the statistics structs to reduce potential padding bytes. Change-Id: Ic090a070e9dc4ca650ebdb9c01ed50a581289962	7 years ago
George Joseph	7f2a953691	Merge "backtrace.c: Fix casting pointer to/from integral type." into 13	7 years ago
Corey Farrell	240f339938	stasis: Fix ABI between DEVMODE and non-DEVMODE. ... Create compatibility stubs for maximum ABI compatibility. ASTERISK-28212 #close Change-Id: I872c04842ab6b61e9dd6d37e4166bc619aa20626	7 years ago
George Joseph	96f8b19b1f	Revert "stasis_cache: Stop caching stasis subscription change messages" ... This reverts commit 94a4eea7f6. This commit caused issues with polling when combined with the revert commit "Revert "app_voicemail: Remove need to subscribe to stasis" ASTERISK-28222 Reported by: abelbeck Change-Id: I0aaab5218a282706dfc6fcbbaeead228d599b99b	7 years ago
Richard Mudgett	a551539048	backtrace.c: Fix casting pointer to/from integral type. ... The backtrace library bfd.h include file does not get the sizes of pointers and ints right on some platforms. On my old test box the size of bfd_vma is 8 while the size of a pointer is 4. gcc on the box complains of the integer casting to/from pointers size mismatch. * uintptr_t to the rescue by doing an appropriate two stage cast. Change-Id: Icb2621583f50c8728de08a3c824d95fe53cc45d0	7 years ago
Friendly Automation	70a2f51786	Merge "utils: Don't set or clear flags that don't need setting or clearing" into 13	7 years ago
Friendly Automation	ac5c4316ef	Merge "stasis: Add statistics gathering in developer mode." into 13	7 years ago
Friendly Automation	212f2a3aa3	Merge "Use non-blocking socket() and pipe() wrappers" into 13	7 years ago