809 Commits (6177d367e2d7a1f57e2dc1522b5ef4e8e8311857)

Author	SHA1	Message	Date
Tilghman Lesher	9d294cd934	Deallocate database connection handle on disconnect, as we allocate another ... one on connect. (closes issue #13271) Reported by: dveiga git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@137138 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	ee8adb313e	(closes issue #12982) ... Reported by: bcnit Tested by: murf I discovered that also, in the previous bug fixes and changes, the cdr.conf 'unanswered' option is not being obeyed, so I fixed this. And, yes, there are two 'answer' times involved in this scenario, and I would agree with you, that the first answer time is the time that should appear in the CDR. (the second 'answer' time is the time that the bridge was begun). I made the necessary adjustments, recording the first answer time into the peer cdr, and then using that to override the bridge cdr's value. To get the 'unanswered' CDRs to appear, I purposely output them, using the dial cmd to mark them as DIALED (with a new flag), and outputting them if they bear that flag, and you are in the right mode. I also corrected one small mention of the Zap device to equally consider the dahdi device. I heavily tested 10-sec-wait macros in dial, and without the macro call; I tested hangups while the macro was running vs. letting the macro complete and the bridge form. Looks OK. Removed all the instrumentation and debug. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@135799 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	08450d1a93	(closes issue #11849) ... Reported by: greyvoip Tested by: murf OK, a few days of debugging, a bunch of instrumentation in chan_sip, main/channel.c, main/pbx.c, etc. and 5 solid notebook pages of notes later, I have made the small tweek necc. to get the start time right on the second CDR when: A Calls B B answ. A hits Xfer button on sip phone, A dials C and hits the OK button, A hangs up C answers ringing phone B and C converse B and/or C hangs up But does not harm the scenario where: A Calls B B answ. B hits xfer button on sip phone, B dials C and hits the OK button, B hangs up C answers ringing phone A and C converse A and/or C hangs up The difference in start times on the second CDR is because of a Masquerade on the B channel when the xfer number is sent. It ends up replacing the CDR on the B channel with a duplicate, which ends up getting tossed out. We keep a pointer to the first CDR, and update *that* after the bridge closes. But, only if the CDR has changed. I hope this change is specific enough not to muck up any current CDR-based apps. In my defence, I assert that the previous information was wrong, and this change fixes it, and possibly other similar scenarios. I wonder if I should be doing the same thing for the channel, as I did for the peer, but I can't think of a scenario this might affect. I leave it, then, as an exersize for the users, to find the scenario where the chan's CDR changes and loses the proper start time. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@134883 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	0dff9821d6	launch_netscript sometimes returns -1, which fails to set AGISTATUS. Map ... failure to -1, so that AGISTATUS is always set. (closes issue #13199) Reported by: smw1218 git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@134480 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Brett Bryant	5d4058b41a	Fix a bug in blind transfers where the BLINDTRANSFER variable isn't always set to the other end of the blind transfer. ... (closes issue #12586) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@131915 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	74c78a9e3a	Oops ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@129741 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	e9f5152eba	The CDRfix4/5/6 omnibus cdr fixes. ... (closes issue #10927) Reported by: murf Tested by: murf, deeperror (closes issue #12907) Reported by: falves11 Tested by: murf, falves11 (closes issue #11849) Reported by: greyvoip As to 11849, I think these changes fix the core problems brought up in that bug, but perhaps not the more global problems created by the limitations of CDR's themselves not being oriented around transfers. Reopen if necc, but bug reports are not the best medium for enhancement discussions. We need to start a second-generation CDR standardization effort to cover transfers. (closes issue #11093) Reported by: rossbeer Tested by: greyvoip, murf git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@127663 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jeff Peeler	a2266547c6	fixed dahdi compatability header from assuming either dahdi or zaptel is installed (may not have either) ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@122663 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Terry Wilson	e128c2a314	This should fix the behavior of the 'T' dial feature being passed incorrectly to the transferee when builtin_atxfers are used. ... Also, doing a builtin_atxfer to parking was broken and is fixed here as well. (closes issue #11898) Reported by: sergee Tested by: otherwiseguy git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@122589 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jeff Peeler	f9818af8dd	Adds DAHDI support alongside Zaptel. DAHDI usage favored, but all Zap stuff should continue working. Release announcement to follow. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@122314 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jeff Peeler	0c0a5cdc73	(closes issue #12193) ... Reported by: davidw Patch by: Corydon76, modified by me to work properly with ParkAndAnnounce app git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@122208 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Terry Wilson	c340004d76	Backport fix for 11520--for some reason I didn't do this back in February when I patched for trunk. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@121992 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Philippe Sultan	d9ad9cc1e4	Ignore appended resource when comparing JIDs. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@120675 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	dae683eb3f	It turns out that searching on the forwarding station isn't very useful for ... most people, so pull in the changes that allow searching for SMDI messages based on other components of the SMDI message. Also, update the SMDI documentation. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@120671 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Philippe Sultan	59410a3f01	Do not link the guest account with any configured XMPP client (in ... jabber.conf). The actual connection is made when a call comes in Asterisk. Fix the ast_aji_get_client function that was not able to retrieve an XMPP client from its JID. (closes issue #12085) Reported by: junky Tested by: phsultan git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@119740 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	b5ac40e980	Use the right pthread lock and condition when waiting. ... (closes issue #12664) Reported by: tomo1657 Patches: res_smdi.c.patch uploaded by tomo1657 (license 484) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@117135 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	01f5aee7ac	Avoid zombies when the channel exits before the AGI. ... (closes issue #12648) Reported by: gkloepfer Patches: 20080514__bug12648.diff.txt uploaded by Corydon76 (license 14) Tested by: gkloepfer git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@116466 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jason Parker	00415742a5	Switch to using ast_random() rather than just rand(). ... This does not fix the bug reported, but I believe it is correct. (from issue #12446) Patches: bug_12446.diff uploaded by snuffy (license 35) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@115418 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jason Parker	06b0749cfd	Change warning message to debug, since there are cases where 0 results is perfectly fine. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@114829 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jason Parker	02bd4cbebc	Fix reload/unload for res_musiconhold module. ... (closes issue #11575) Reported by: sunder Patches: M11575_14_rev3.diff uploaded by junky (license 177) bug11575_trunk.diff.txt uploaded by jamesgolovich (license 176) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@114594 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	e4ed5a76f1	Trivial change to read the number of samples from a frame before calling ast_write() ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@114545 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	d87023aef0	After a parked call times out, allow the call back to the parker to time out. ... (closes issue #10890) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@114542 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	0dc35f4e26	MOH usage information needs a terminating newline, or else ... "asterisk -rx 'help moh reload'" will hang. Reported via -dev list, fixed by me. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@114297 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Philippe Sultan	2ebfcb323b	Use keepalives effectively in order diagnose bug #12432. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@114198 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	176add9ecd	Add special case for when the agi cannot be executed, to comply with the documentation that ... we return failure in that case. (closes issue #12462) Reported by: fmueller Patches: 20080416__bug12462.diff.txt uploaded by Corydon76 (license 14) Tested by: fmueller git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@114195 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	7bce362fa7	Fix a race condition that may happen between a sip hangup ... and a "core show channel" command. This patch adds locking to prevent the resulting crash. (closes issue #12155) Reported by: tsearle Patches: show_channels_crash2.patch uploaded by tsearle (license 373) Tested by: tsearle git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@114063 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	ba782ce5f9	Add sanity checking for position resuming. We *have* to make sure that the position does not exceed the total number of files present, and we have to make sure that the position's filename is the same as previous. These values can change if a music class is reloaded and give unpredictable behavior. ... (closes issue #11663) Reported by: junky git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@110035 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jason Parker	503ca9f30c	Fix a potential segfault if chan (or chan->music_state) is NULL. ... Closes issue #12210, credit to edantie for pointing this out. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@108682 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	8f65ef8264	Make sure the visible indication is on the right channel so when the masquerade happens the proper indication is enacted. ... (closes issue #11707) Reported by: iam git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@107646 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jason Parker	47f33c87f4	Fix type for astNumChannels. ... (closes issue #12114) Reported by: jeffg Patches: 12114.patch uploaded by jeffg (license 192) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@105572 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Philippe Sultan	899ce48345	Fix a potential memory leak ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@105326 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Philippe Sultan	5d1234fb4f	Automatically create new buddy upon reception of a presence stanza of ... type subscribed. (closes issue #12066) Reported by: ffadaie Patches: branch-1.4-12066-1.diff uploaded by phsultan (license 73) trunk-12066-1.diff uploaded by phsultan (license 73) Tested by: ffadaie, phsultan git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@105209 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jason Parker	841283adfe	Inherit language from the transfering channel on a blind transfer. ... (closes issue #11682) Reported by: caio1982 Patches: local_atxfer_lang3-1.4.diff uploaded by caio1982 (license 22) Tested by: caio1982, victoryure git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@104598 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	bb7aa0e4bc	Only stop the MWI monitor thread if it was actually started. ... (closes issue #12086) Reported by: francesco_r git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@104536 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	bc56a84c58	Merge changes from team/russell/smdi-1.4 ... This commit brings in a significant set of changes to the SMDI support in Asterisk. There were a number of bugs in the current implementation, most notably being that it was very likely on busy systems to pop off the wrong message from the SMDI message queue. So, this set of changes fixes the issues discovered as well as introducing some new ways to use the SMDI support which are required to avoid the bugs with grabbing the wrong message off of the queue. This code introduces a new interface to SMDI, with two dialplan functions. First, you get an SMDI message in the dialplan using SMDI_MSG_RETRIEVE() and then you access details in the message using the SMDI_MSG() function. A side benefit of this is that it now supports more than just chan_zap. For example, with this implementation, you can have some FXO lines being terminated on a SIP gateway, but the SMDI link in Asterisk. Another issue with the current implementation is that it is quite common that the station ID that comes in on the SMDI link is not necessarily the same as the Asterisk voicemail box. There are now additional directives in the smdi.conf configuration file which let you map SMDI station IDs to Asterisk voicemail boxes. Yet another issue with the current SMDI support was related to MWI reporting over the SMDI link. The current code could only report a MWI change when the change was made by someone calling into voicemail. If the change was made by some other entity (such as with IMAP storage, or with a web interface of some kind), then the MWI change would never be sent. The SMDI module can now poll for MWI changes if configured to do so. This work was inspired by and primarily done for the University of Pennsylvania. (also related to issue #9260) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@104119 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jason Parker	caa961fbcf	Specify which digit string was matched in debug message. ... (closes issue #11949) Reported by: dimas Patches: v1-feature-debug.patch uploaded by dimas (license 88) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@102858 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Kevin P. Fleming	5b8cef7ecb	ensure that all remaining multi-object modules are built using their proper CFLAGS and include directory paths ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@102627 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	8dad56f666	Perform dialing asynchronously when using the originate CLI command so the CLI does not appear to block. ... (closes issue #11927) Reported by: bbhoss git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@102378 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	bd9a40f98a	1. Prevent the addition of an extra '/' to the beginning of an absolute pathname. ... 2. If ast_monitor_change_fname is called and the new filename is the same as the old, then exit early and don't set the filename_changed field in the monitor structure. Setting it in this case was causing ast_monitor_stop to erroneously delete them. (closes issue #11741) Reported by: garlew Tested by: putnopvut git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@101531 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	9b53acdbf5	Fix a crash in ast_masq_park_call() ... (issue #11342) Reported by: DEA Patches: res_features-park.txt uploaded by DEA (license 3) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@100626 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	d97a51a50b	Oops, should have checked for a NULL obj, here, too ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@99775 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Olle Johansson	48066f4cfd	Add more dependencies on chan_local and add a note to the description of chan_local ... so that people don't disable it in menuselect just to clean up. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@99594 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	cae4280341	Permit the user to specify number of seconds that a connection may remain idle, ... which fixes a crash on reconnect with the MyODBC driver. (closes issue #11798) Reported by: Corydon76 Patches: 20080119__res_odbc__idlecheck.diff.txt uploaded by Corydon76 (license 14) Tested by: mvanbaak git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@99341 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Terry Wilson	eab2f166c3	This should at least temporarily fix a problem where the 't' Dial ... option is incorrectly passed to the transferee when built-in attended transfers are used. There is still a problem with 'T', but better to fix some problems than no problems while we work on it. (closes issue #7904) Reported by: k-egg Patches: transfer-fix-b14-r97657.diff uploaded by sergee (license 138) Tested by: sergee, otherwiseguy git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@99032 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	6efee0907d	Add a connection timeout attribute, as that was what was intended with the ... login timeout, but ODBC divides it up into 2 different timeouts. (Closes issue #11745) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@98467 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	ebdf2940b8	If the channel is hungup during RECORD FILE send a result code of -1 to be uniform with everything else. ... (closes issue #11743) Reported by: davevg Patches: res_agi.diff uploaded by davevg (license 209) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@98317 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	eebd74ee97	Fix saying the parking space number to the caller doing the parking ... ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@97529 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	61a1ce95a5	Don't crash if something happens when setting up an SMDI interface and it gets ... destroyed before the SMDI port handling thread gets created. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@96884 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Philippe Sultan	ee7978e96e	Indentation fix, makes the code easier to read ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@96815 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Philippe Sultan	e531dcb1af	Compute the base64 value over the [authzid]\0authcid\0password string, ... thus excluding the trailing NULL byte. This change has already been committed to trunk, see #11644. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@96797 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago