584 Commits (5a5d549b1df544b9e7a80928dbfb0bd22521e6f0)

Author	SHA1	Message	Date
Kevin P. Fleming	5a5d549b1d	ensure that a burst of full frames (AST_FRAME_DTMF being the prime example) will not be processed out of order... this is a brute force fix, but seems to be the safest fix for now (thanks to the Digium PQ department for finding this bug) ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67270 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	3b5bd316ed	Fix up a bunch of places where the iax2 pvt structure can disappear and the ... code did not account for it and crashes. (issues #9642, #9569, #9666, probably others ... based on the work by stevedavies and mihai, with additional changes from me) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67158 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	885d846739	Add comments for two functions that get called with the appropriate call locked, ... but perform operations that could result in the pvt structure getting destroyed before returning again, causing numerous seg faults all over the module. (inspired by issues #9642, #9569, and #9666, and the work done by stevedavies and mihai) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67119 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	0b7719e9a1	Resolve a deadlock in chan_iax2. When handling an implicit ACK to a frame that ... was marked as the final transmission for a call, don't call iax2_destroy() for that call while the global frame queue is still locked. There is a very nice explanation of the deadlock in the report. (issue #9663, thorough report and patch from stevedavies, additional positive test reports from mihai and joff_oconnell) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67020 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Kevin P. Fleming	e1518f42ae	start the delayed PBX when receive voice or video full frames as well, and comment this delayed-PBX activity ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@65685 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Kevin P. Fleming	b89faf596b	clear the 'delay PBX' flag when we are ready to start the PBX ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@65680 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Kevin P. Fleming	09dc4253d8	don't start a PBX on a new incoming IAX2 channel until we have some sort of response to our ACCEPT (ACK or anything else) ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@65679 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Kevin P. Fleming	f608d90283	Merged revisions 65676 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r65676 | kpfleming | 2007-05-23 16:06:13 -0400 (Wed, 23 May 2007) | 2 lines if we are going to set variables on a newly created channel, it should be done *before* we start the PBX on it ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@65677 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jason Parker	c2c91c7fef	Merged revisions 63828 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r63828 | qwell | 2007-05-10 18:14:55 -0500 (Thu, 10 May 2007) | 4 lines Fix an issue with trying to kill a thread before it gets created. Issue 9709, patch by nic_bellamy. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@63830 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	8bcfcfca88	Merged revisions 62691 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r62691 | tilghman | 2007-05-02 12:38:16 -0500 (Wed, 02 May 2007) | 4 lines Issue 9638 - if a text frame is sent with no terminating NULL through a bridged IAX connection, the remote end will receive garbage characters tacked onto the end. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@62692 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	0525347958	Merged revisions 62037 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r62037 | file | 2007-04-26 12:30:57 -0400 (Thu, 26 Apr 2007) | 2 lines Revert previous fix for when the IAX2 channel goes funky (that's the technical term). This is causing legit calls to be prematurely hung up. (issue #9600 reported by justdave) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@62038 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	5574da0c12	Merged revisions 61866 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r61866 | russell | 2007-04-25 16:55:23 -0500 (Wed, 25 Apr 2007) | 2 lines If the callerid= option is specified, but empty, clear any previous data. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@61870 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	e6aa1145ed	Merged revisions 61862 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r61862 | russell | 2007-04-25 16:06:22 -0500 (Wed, 25 Apr 2007) | 2 lines Ensure that callerid settings are reset on a reload. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@61863 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Steve Murphy	7d5a79a0b9	This is a big improvement over the current CDR fixes. It may still need refinement, but this won't have as many folks bothered. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@60989 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	8acd1e8349	When the IAX2 read callback gets called, return NULL instead of a "null frame". ... This will cause Asterisk to hangup the call instead of keep trying whatever it was doing. Under normal conditions, this function would *never* be called. However, the author of this patch says an error will occur that will cause it to get called every 100 thousand calls or so. When this does happen, it puts the channel in a loop that eventually brings down the system. So, hangup up the call is certainly a better alternative. (issue #8286, john) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@59341 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	8fdf6e3c47	Merged revisions 59258 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r59258 | russell | 2007-03-27 13:04:02 -0500 (Tue, 27 Mar 2007) | 4 lines Fix the use of the "sourceaddress" option when "bindaddr" is set to 0.0.0.0 instead of having each interface explicitly listed. (issue #7874, patch by stevens) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@59259 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	6548086af0	Don't assume that the pvt structure will still exist after calling schedule_delivery as it may not. (issue #9278 reported by fmachado) ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@58923 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	8ae4e264d1	Fix a few more places in chan_iax2 where the ast_frame used for receiving a ... frame was not properly initialized. - Interpolating a frame when the jitterbuffer is in use - decrypting a frame when IAX2 encryption is on - frames in an IAX2 trunk git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@58705 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	f34c30860e	(This bug was reported to me by Kinsey Moore) ... Merged revisions 58242 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r58242 | russell | 2007-03-07 12:17:07 -0600 (Wed, 07 Mar 2007) | 7 lines Fix a problem where the Asterisk channel name could be that of the wrong IAX2 user for a call. This is because the first step of choosing this name is to look for an IAX2 peer that happens to have the same IP/port number that this call is coming from and assuming that is it. However, this is not always correct. So, I have made it change this name after authentication happens since at that point, we have an exact match. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@58243 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Joshua Colp	94c9dcda60	Since chan_iax2 does not support reception of DTMF with duration ensure that it is set to 0 on the frame. (issue #8521 reported by gdhgdh) ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@57914 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Russell Bryant	dd6b58edcd	Fix a crash in my last change to iax2_indicate(). (issue #9150) ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@56847 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Russell Bryant	268fc8a9cc	Do more complete locking of the chan_iax2_pvt struct in the indicate callback. ... (Problem brought up by Ben Smithurst on the asterisk-dev list) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@56785 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Russell Bryant	76a643978e	Merged revisions 56406 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r56406 | russell | 2007-02-23 14:17:56 -0600 (Fri, 23 Feb 2007) | 4 lines Don't destroy mutexes before unregistering all of the entry points from the core. Also, fix a potential memory leak from not destroying the locks for all of the possible call numbers (about 32k of them). ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@56407 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Doug Bailey	c967342095	Changed iax2 process thread to detached to correct memory leak due to left over thread context on thread exit. ... Modified module unload process to avoid deadlocks on pthread cancels git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@55397 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Joshua Colp	2f6312a37e	Merged revisions 53357 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r53357 | file | 2007-02-07 10:38:48 -0500 (Wed, 07 Feb 2007) | 2 lines Fix a few potential memory leaks with realtime users and peers. (issue #8999 reported by bsmithurst) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@53358 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Russell Bryant	9aab046002	Merged revisions 53045 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r53045 | russell | 2007-01-31 15:25:11 -0600 (Wed, 31 Jan 2007) | 3 lines Fix a bunch of places where pthread_attr_init() was called, but pthread_attr_destroy() was not. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@53046 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Joshua Colp	362abb9deb	Drop the deprecated show commands since the original ones were changed back. (issue #8937 reported by PCadach) ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@52856 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Russell Bryant	a46e6d74df	Merged revisions 52762 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r52762 | russell | 2007-01-29 18:15:06 -0600 (Mon, 29 Jan 2007) | 5 lines Fix the extraction of the timestamp from video frames. It was using the mapping for a mini-frame instead of a video-frame, which caused it to get invalid data. (issue #8795, mihai) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@52763 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Joshua Colp	6b462c95c9	Merged revisions 52360 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r52360 | file | 2007-01-26 19:03:23 -0500 (Fri, 26 Jan 2007) | 2 lines Make the last context entry read in the dominant one. (issue #8918 reported by pj) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@52370 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Joshua Colp	8f7ddbef0d	Update channel drivers to use module referencing so that unloading them while in use will not result in crashes. (issue #8897 reported by junky) ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51788 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Russell Bryant	33235b40d6	Merge the changes from the /team/group/vldtmf_fixup branch. ... The main bug being addressed here is a problem introduced when two SIP channels using SIP INFO dtmf have their media directly bridged. So, when a DTMF END frame comes into Asterisk from an incoming INFO message, Asterisk would try to emulate a digit of some length by first sending a DTMF BEGIN frame and sending a DTMF END later timed off of incoming audio. However, since there was no audio coming in, the DTMF_END was never generated. This caused DTMF based features to no longer work. To fix this, the core now knows when a channel doesn't care about DTMF BEGIN frames (such as a SIP channel sending INFO dtmf). If this is the case, then Asterisk will not emulate a digit of some length, and will instead just pass through the single DTMF END event. Channel drivers also now get passed the length of the digit to their digit_end callback. This improves SIP INFO support even further by enabling us to put the real digit duration in the INFO message instead of a hard coded 250ms. Also, for an incoming INFO message, the duration is read from the frame and passed into the core instead of just getting ignored. (issue #8597, maybe others...) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51311 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Joshua Colp	f986c4f2c3	Move rescheduling of lagrq/pings into the scheduler callback. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51172 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Joshua Colp	0a51642588	Merged revisions 49889 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r49889 | file | 2007-01-08 00:10:07 -0500 (Mon, 08 Jan 2007) | 2 lines Ensure we use the default refresh value of 60 if the remote server does not send one. (issue #8746 reported by maethor) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49890 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Kevin P. Fleming	444adcb477	reduce stack consumption for AMI and AMI/HTTP requests by nearly 20K in most cases ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49676 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Kevin P. Fleming	fb010e49aa	Merged revisions 49635 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r49635 | kpfleming | 2007-01-05 10:56:40 -0600 (Fri, 05 Jan 2007) | 2 lines ensure that threads which are supposed to be detached (because we aren't going to wait on them) are created properly ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49636 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Kevin P. Fleming	ab4da71374	revert the dynamic_list insertion change... that was not the right thing to do ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49600 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Kevin P. Fleming	aed1467281	create the IAX2 processing threads as background threads so they will use smaller stacks ... when we create a dynamic thread, put it on the dynamic_list right away so we don't lose track of it git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49581 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Joshua Colp	62b8b03294	It's possible for the iax2 pvt to disappear, so if it has... don't bother looking for dpentries. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49568 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Kevin P. Fleming	497dd42772	only do IAX2 frame caching for voice and video frames ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49465 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Joshua Colp	40707f097a	Check pvt structure presence before passing to send_command. This gets rid of the irritating message about a packet without pvt structure. This happens because the scheduled item is getting cancelled at almost the exact moment it is getting executed. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49259 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Joshua Colp	37e5a39d76	Initialize the packet queue in load_module instead of just declaring the list with the default value. (issue #8695 reported by ssokol) ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49063 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Russell Bryant	53115ff688	Merged revisions 48943 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r48943 | russell | 2006-12-24 02:23:07 -0500 (Sun, 24 Dec 2006) | 3 lines Check for the proper return value on an error in a call to mmap(). This was reported by Andy Wang on the asterisk-dev list. Thanks! ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@48944 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Joshua Colp	11e61ea68a	Put thread into proper list if we abort handling due to an error, and also hold the lock while putting it back into the proper idle list so we don't prematurely get a signal. (issue #8604 reported by arkadia) ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@48564 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Joshua Colp	a0c21d30ac	Hold call structure lock in places where a qualify or peer action can destroy it. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@48504 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Joshua Colp	195c66b4a1	Lock network retransmission queue in all places that it is used. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@48502 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Joshua Colp	3706ecbbc5	Use a wakeup variable so that we don't wait on IO indefinitely if packets need to be retransmitted. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@48478 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Russell Bryant	eeb415e8dd	Use locking when accessing the registrations list. This list is not actually ... used very often, so the likelihood of there being a problem is pretty small, but still possible. For example, if the CLI command to list the registrations was called at the same time that a reload was occurring and the registrations list was getting destroyed and rebuilt, a crash could occur. In passing, go ahead and convert this list to use the linked list macros. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@48363 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Joshua Colp	422c97eab7	Merged revisions 48157 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r48157 | file | 2006-11-30 15:06:43 -0500 (Thu, 30 Nov 2006) | 2 lines Only print out debug message if bridged channel is not NULL. (issue #8412 reported by jubilex) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@48158 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Russell Bryant	3964b50b05	Merged revisions 47496 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r47496 | russell | 2006-11-12 01:09:03 -0500 (Sun, 12 Nov 2006) | 4 lines Only do the check to determine whether the channel calling this function is an IAX2 channel when getting the IP address using the special argument, CURRENTCHANNEL. (issue #8341, jcovert) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47497 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago
Tilghman Lesher	f11ea0549d	Discussion of these CLI changes resulted in more consistency (Bug 8236) ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47436 65c4cc65-6c06-0410-ace0-fbb531ad65f3	19 years ago