5489 Commits (54d7e65014dbe18b0ae882892782e43810de0f2d)

Author	SHA1	Message	Date
George Joseph	54d7e65014	build: Various OpenBSD issues ... OpenBSD's 'find' doesn't take the -delete argument so you have to pipe through 'xargs rm -rf'. 'echo -e' doesn't like \t starting a line. It just prints 't' which causes the libasteriskpj.exports file to be garbage. They were just cosmetic so they were removed. librt doesn't exist so the link of libasteriskpj.so fails. It's not actually needed for linux anyway so -lrt was removed from the link. res_rtp_asterisk was failing to load because of an undefined DTLS_method. '|| defined(LIBRESSL_VERSION_NUMBER)' was added to the #if so DTLSv1_method is used instead. ASTERISK-26608 Change-Id: I926ec95b0b69633231e3ad1d6e803b977272c49c	9 years ago
George Joseph	0825528322	Revert "Revert "AGI: Only defer frames when in an interception routine."" ... This reverts commit 7155020c96. Change-Id: I4e1681d2ca8bf36eda849f129bc0dcbc39ef5bc6	9 years ago
George Joseph	6b2efc116f	Revert "Revert "autoservice: Use frame deferral API"" ... This reverts commit 8b9996a90c. Change-Id: Ibb2fccfc37188dc54f3776c2d5b41cc425d5cd9c	9 years ago
George Joseph	f6acb765a8	Revert "Revert "channel: Use frame deferral API for safe sleep."" ... This reverts commit 97679ee846. Change-Id: Ib68f76e75882c0230378c4fed97964988e690f3c	9 years ago
Joshua Colp	aa1482aed4	Merge "channel: Fix issues in hangup scenarios caused by frame deferral" into 14	9 years ago
Joshua Colp	caa207bc4f	Merge "Revert "Revert "Add API for channel frame deferral.""" into 14	9 years ago
zuul	fdea7fe9e4	Merge "res/ari/resource_bridges: Add the ability to manipulate the video source" into 14	9 years ago
George Joseph	42254406ad	Merge "cli: Fix ast_el_read_char to work with libedit >= 3.1" into 14	9 years ago
George Joseph	d6f9e2b54a	file.c/__ast_file_read_dirs: Fix issues on filesystems without d_type ... One of the code paths in __ast_file_read_dirs will only get executed if the OS doesn't support dirent->d_type OR if the filesystem the particular file is on doesn't support it. So, while standard Linux systems support the field, some filesystems like XFS do not. In this case, we need to call stat() to determine whether the directory entry is a file or directory so we append the filename to the supplied directory path and call stat. We forgot to truncate path back to just the directory afterwards though so we were passing a complete file name to the callback in the dir_name parameter instead of just the directory name. The logic has been re-written to only create a full_path if we need to call stat() or if we need to descend into another directory. Change-Id: I54e4228bd8355fad65200c6df3ec4c9c8a98dfba	9 years ago
Matt Jordan	62cbcb2e54	res/ari/resource_bridges: Add the ability to manipulate the video source ... In multi-party bridges, Asterisk currently supports two video modes: * Follow the talker, in which the speaker with the most energy is shown to all participants but the speaker, and the speaker sees the previous video source * Explicitly set video sources, in which all participants see a locked video source Prior to this patch, ARI had no ability to manipulate the video source. This isn't important for two-party bridges, in which Asterisk merely relays the video between the participants. However, in a multi-party bridge, it can be advantageous to allow an external application to manipulate the video source. This patch provides two new routes to accomplish this: (1) setVideoSource: POST /bridges/{bridgeId}/videoSource/{channelId} Sets a video source to an explicit channel (2) clearVideoSource: DELETE /bridges/{bridgeId}/videoSource Removes any explicit video source, and sets the video mode to talk detection ASTERISK-26595 #close Change-Id: I98e455d5bffc08ea5e8d6b84ccaf063c714e6621	9 years ago
George Joseph	ac6051c302	channel: Fix issues in hangup scenarios caused by frame deferral ... ASTERISK-26343 Change-Id: I06dbf7366e26028251964143454a77d017bb61c8 (cherry picked from commit 0be46aaf6b) (cherry picked from commit 7263a17ca0) (cherry picked from commit ebf8d94eb2)	9 years ago
George Joseph	88111da235	Revert "Revert "Add API for channel frame deferral."" ... This reverts commit b640f18a44. Change-Id: I4ad8e7f66b3e6457ac07e7965822ae39ac08464d	9 years ago
Sebastien Duthil	eb5077fb26	res_ari: Add support for channel variables in ARI events. ... This works the same as for AMI manager variables. Set "channelvars=foo,bar" in your ari.conf general section, and then the channel variables "foo" and "bar" (along with their values), will appear in every Stasis websocket channel event. ASTERISK-26492 #close patches: ari_vars.diff submitted by Mark Michelson Change-Id: I5609ba239259577c0948645df776d7f3bc864229	9 years ago
George Joseph	e2046bfaf3	cli: Fix ast_el_read_char to work with libedit >= 3.1 ... Libedit 3.1 is not build with unicode on as a default and so the prototype for the el_gets callback changed from expecting a char buffer to accepting a wchar buffer. If ast_el_read_char isn't changed, the cli reads garbage from teh terminal. Added a configure test for (*el_rfunc_t)(EditLine *, wchar_t *) and updated ast_el_read_char to use the HAVE_ define to detemrine whether to use char or wchar. ASTERISK-26592 #close Change-Id: I9099b46f68e06d0202ff80e53022a2b68b08871a	9 years ago
George Joseph	c7511029c3	Merge "Revert "AGI: Only defer frames when in an interception routine."" into 14	9 years ago
George Joseph	6384ac9f39	Merge "Revert "channel: Use frame deferral API for safe sleep."" into 14	9 years ago
George Joseph	b55bdb0740	Merge "Revert "Add API for channel frame deferral."" into 14	9 years ago
George Joseph	588336b738	Merge "Revert "autoservice: Use frame deferral API"" into 14	9 years ago
George Joseph	b640f18a44	Revert "Add API for channel frame deferral." ... This reverts commit 4a8b1940b8. Multiple testsuite failures were detected after the fact. Change-Id: Ife9f86872d323adb9c068d2942339c7be9499257	9 years ago
George Joseph	7155020c96	Revert "AGI: Only defer frames when in an interception routine." ... This reverts commit 8d8323b142. Multiple testsuite failures were detected after the fact. Change-Id: I322684ed82ba32cfce226a94fe19b87a4ec02567	9 years ago
George Joseph	8b9996a90c	Revert "autoservice: Use frame deferral API" ... This reverts commit 0288fba2f0. Multiple testsuite failures were detected after the fact. Change-Id: I9951207019a0f528787f735ccfed7c4b76335505	9 years ago
George Joseph	97679ee846	Revert "channel: Use frame deferral API for safe sleep." ... This reverts commit 1db9e7886c. Multiple testsuite failures were detected after the fact. Change-Id: Ifd5817e90371e05c4011d5cc97da145c196d60fe	9 years ago
Mark Michelson	1db9e7886c	channel: Use frame deferral API for safe sleep. ... This is another case where manual frame deferral can be replaced with centralized routines instead. Change-Id: I42cdf205f8f29a7977e599751a57efbaac07c30e (cherry picked from commit d149c4b9e0)	9 years ago
Mark Michelson	0288fba2f0	autoservice: Use frame deferral API ... Rather than use manual frame deferral, just let the channel API do it for us. ASTERISK-26343 Change-Id: I688386f36e765dbc07be863943a43f26bd5eac49 (cherry picked from commit 8ba3e2fc27)	9 years ago
Mark Michelson	8d8323b142	AGI: Only defer frames when in an interception routine. ... AGI recently was modified to defer important frames. This was because when AGI was used in a connected line interception routine, the resulting connected line frame would end up getting discarded by the AGI. However, this caused bad behavior in other cases. Specifically, during a transfer, if someone attempted to manually set the Caller ID on a channel in an AGI, the deferred connected line frame would end up overwriting what had been manually set in the AGI. Since the initial issue was specific to interception routines, this change removes the manual frame deferral from AGI and instead uses the new frame deferral API in interception routines. ASTERISK-26343 #close Reported by Morton Tryfoss Change-Id: Iab7d39436d0ee99bfe32ad55ef91e9bd88db4208	9 years ago
Mark Michelson	4a8b1940b8	Add API for channel frame deferral. ... There are several places in Asterisk that have duplicated logic for deferring important frames until later. This commit adds a couple of API calls to facilitate this automatically. ast_channel_start_defer_frames(): Future reads of deferrable frames on this channel will be deferred until later. ast_channel_stop_defer_frames(): Any frames that have been deferred get requeued onto the channel. ASTERISK-26343 Change-Id: I3e1b87bc6796f222442fa6f7d1b6a4706fb33641	9 years ago
Joshua Colp	1be6c9d26a	Merge "stasis_recording/stored: remove calls to deprecated readdir_r function." into 14	9 years ago
Joshua Colp	a4d145e465	Merge "main/bridge_channel: Fix channel reference leak on video source" into 14	9 years ago
Joshua Colp	51ff8e3899	Merge "main/bridge: Add some verbose logging for video source changes" into 14	9 years ago
Matt Jordan	62d60c1f58	main/bridge_channel: Fix channel reference leak on video source ... When a channel is made the video source, the bridge holds a reference to it. Whenever the video source changes, that reference is released. However, a ref leak does occur if the channel leaves the bridge (such as being hung up) while it is the video source, as the bridge never releases the ref in such a case. This patch adds a line to the bridge_channel_internal_join routine such that, when a channel finishes its time in the bridge, it notifies the bridge via ast_bridge_remove_video_src that if it is a video source its reference should be released. ASTERISK-26555 #close Change-Id: I3a2f5238a9d2fc49c591f0e65199d782ab0be76a	9 years ago
Matt Jordan	be254aa8e3	main/bridge: Add some verbose logging for video source changes ... It's actually quite useful to see the source of a video stream change. This doesn't happen terribly often, even with talk detection - but when it does, it's nice to know which channel is now providing your video stream. As a verbose 5 level message, it shouldn't be terribly spammy or costly to have, and is 'lower level' then most other verbose messages that the bridge system emits. ASTERISK-26555 Change-Id: Ia1c20ecafa9670171fd38bddcf3beccae47fb15c	9 years ago
Kevin Harwell	25895897f8	stasis_recording/stored: remove calls to deprecated readdir_r function. ... The readdir_r function has been deprecated and should no longer be used. This patch removes the readdir_r dependency (replaced it with readdir) and also moves the directory search code to a more centralized spot (file.c) Also removed a strict dependency on the dirent structure's d_type field as it is not portable. The code now checks to see if the value is available. If so, it tries to use it, but defaults back to using the stats function if necessary. Lastly, for most implementations of readdir it *should* be thread-safe to make concurrent calls to it as long as different directory streams are specified. glibc falls into this category. However, since it is possible that there exist some implementations that are not safe, locking has been added for those other than glibc. ASTERISK-26412 ASTERISK-26509 #close Change-Id: Id8f54689b1e2873e82a09d0d0d2faf41964e80ba	9 years ago
Alexander Traud	6445f21caa	rtp_engine: Allow more than 32 dynamic payload types. ... Since adding all remaining rates of Signed Linear (ASTERISK-24274) and SILK (Gerrit 3136), only one RTP Payload Type is left in the dynamic range (96-127). RFC 3551 section 3 allows to reassign other ranges. Consequently, when the dynamic range is exhausted, you can go for "rtp_pt_dynamic = 35" (or 0) in asterisk.conf. This enables the range 35-63 (or 0-63) giving room for another 29 (or 64) payload types. ASTERISK-26311 #close Change-Id: I7bc96ab764bc30098a178b841cbf7146f9d64964	9 years ago
Joshua Colp	eaf04cb6d0	Merge "netsock.c: fix includes for HURD" into 14	9 years ago
Tzafrir Cohen	2897fc9ab0	netsock.c: fix includes for HURD ... ASTERISK-25070 Change-Id: I43bf94d2d36d3d8a8d0df40cd6c027d65a462814	9 years ago
Etienne Lessard	d9f9691d31	manager: Add documentation for NewConnectedLine event. ... The NewConnectedLine event has been added by commit fe7671f, but the documentation was missing. ASTERISK-26537 #close Change-Id: I7fc331f18caa28492da9303e576f70884ca8c9e6	9 years ago
Corey Farrell	39ba7aa91f	astobj2: Declare private variable data_size for AO2_DEBUG only. ... Every ao2 object contains storage for a private variable data_size, though the value is never read if AO2_DEBUG is disabled. This change makes the variable conditional, reducing memory usage. ASTERISK-26524 #close Change-Id: If859929e507676ebc58b0f84247a4231e11da07f	9 years ago
George Joseph	d84eaa46fa	pjproject_bundled: Fix issue where "/version.mak" wasn't found ... main/Makefile includes third-party/pjproject/build.mak but doesn't set PJDIR beforehand so "include $(PJDIR)/version.mak" evaluates to "/version.mak". Fix is to set PJDIR in main/Makefile before the include. Change-Id: I0f7c67d60209049056fe9c4b041bf0463aa95604	9 years ago
Corey Farrell	b76afa5e4f	Fix shutdown crash caused by modules being left open. ... It is only safe to run ast_register_cleanup callbacks when all modules have been unloaded. Previously these callbacks were run during graceful shutdown, making it possible to crash during shutdown. ASTERISK-26513 #close Change-Id: Ibfa635bb688d1227ec54aa211d90d6bd45052e21	9 years ago
Joshua Colp	1567ccfc82	Merge "ARI: Detect duplicate channel IDs" into 14	9 years ago
Pascal Cadotte Michaud	cb342298cd	typo: s/paranthesis/parenthesis/ in a comment ... Change-Id: I7c1f4eb051177ee22cbe97e063d4a3effe29be30	9 years ago
Mark Michelson	98378133c0	ARI: Detect duplicate channel IDs ... ARI and AMI allow for an explicit channel ID to be specified when originating channels. Unfortunately, there is nothing in place to prevent someone from using the same ID for multiple channels. Further complicating things, adding ID validation to channel allocation makes it impossible for ARI to discern why channel allocation failed, resulting in a vague error code being returned. The fix for this is to institute a new method for channel errors to be discerned. The method mirrors errno, in that when an error occurs, the caller can consult the channel errno value to determine what the error was. This initial iteration of the feature only introduces "unknown" and "channel ID exists" errors. However, it's possible to add more errors as needed. ARI uses this feature to determine why channel allocation failed and can return a 409 error during origination to show that a channel with the given ID already exists. ASTERISK-26421 Change-Id: Ibba7ae68842dab6df0c2e9c45559208bc89d3d06	9 years ago
snuffy	8e3aee2036	Fix issue with CLI not returning to prompt after running "features show" ... ASTERISK-26444 #close Change-Id: I91d645b7e6e5dba35f8c410df2be77a8c0e3acb8	9 years ago
zuul	1ecb4f9e2b	Merge "utils.c: Fix ast_set_default_eid for multiple platforms" into 14	9 years ago
Mark Michelson	0abc71dfd6	CDR: Alter destruction pattern for CDR chains. ... CDRs form chains. When the root of the chain is destroyed, it then unreferences the next CDR in the chain. That CDR is destroyed, and it then unreferences the next CDR in the chain. This repeats until the end of the chain is reached. While this typically does not cause any sort of problems, it is possible in strange scenarios for the CDR chain to grow way longer than expected. In such a scenario, the destruction pattern can result in a stack overflow. This patch fixes the problem by switching from a recursive pattern to an iterative pattern for destruction. When the root CDR is destroyed, it is responsible for iterating over the rest of the CDRs and unreferencing each one. Other CDRs in the chain, since they are not the root, will simply destroy themselves and be done. This causes the stack depth not to increase. ASTERISK-26421 #close Reported by Andrew Nagy Change-Id: I3ca90c2b8051f3b7ead2e0e43f60d2c18fb204b8	9 years ago
Alexander Traud	3938e3320f	cli: Auto-complete File not Module for core set debug. ... Since Asterisk 1.8, the command "core set debug" on the command-line interface asks not for a file (.c) but a module name. This change shows modules (.so) on the auto-completion via a tabulator or the question mark. Now, when you partially type a module name, TAB or ?, you get the correct candidiates. ASTERISK-26480 Change-Id: I1213f1dd409bd4ff8de08ad80cb0c73cafb1bae0	9 years ago
George Joseph	13aa241b9c	utils.c: Fix ast_set_default_eid for multiple platforms ... ast_set_default_eid was searching for ethX, emX, enoX, ensX and even pciD#U interface names. While this was a good attempt, it wasn't inclusive enough to capture interfaces like enp6s0 or ens6d1, etc. Rather than relying on interface names, we now simply find the first interface returned by the OS that has a hardware address and that address isn't all 0x00 or all 0xff. The code IS different for BSD, Solaris and Linux based on what method is available for enumerating interfaces. Tested on: FreeBSD9 CentOS6 Ubuntu14 Fedora24 I was unable to test on Solaris at this time but the code for Solaris is used elsewhere at Digium. Change-Id: Iaa6db87ca78a9a375e47d70e043ae08c1448cb72	9 years ago
Joshua Colp	839766f5e1	Merge "Audit ast_json_pack() calls for needed UTF-8 checks." into 14	9 years ago
Joshua Colp	465ba82ea2	Merge "json: Check party id name, number, subaddresses for UTF-8." into 14	9 years ago
Joshua Colp	6d5e11dc91	Merge "json: Add UTF-8 check call." into 14	9 years ago