31109 Commits (54d31e2b41d6d49643560b7eb242147ac4f4545b)

 

All Branches   

Search

Author	SHA1	Message	Date
Richard Mudgett	10f4c68f70	pjsip_scheduler.c: Fix some corner cases. ... * Fix the periodic interval wander because it may take significant time between the sched thread queueing the task in the serializer and the serializer actually executing the task. The time it takes to actually execute the task was already taken into account. * Pass a schtd ref to the serializer when we queue a scheduled task on the serializer. We don't want it going away on us while it is in the serializer queue. * Skip the scheduled task if the task was canceled between queueing the task to the serializer and the serializer actually executing the task. * Reorder struct ast_sip_sched_task to avoid unnecessary padding. Removed task_id and added next_periodic. * Hold a ref to the passed in serializer so the serializer cannot go away on the scheduled task. ASTERISK_26806 Change-Id: I6c8046b75f6953792c8c30e55b836a4291143f24	8 years ago
Richard Mudgett	54a6bb5f8a	pjsip_scheduler.c: Sort "pjsip show scheduled_tasks" output. ... * A side benefit is that the scheduled tasks are not completely blocked while the CLI command executes. * Adjusted the "Task Name" column width to have more room for longer names. Change-Id: Iec64aa463ee8b10eef90120e00c38b1fb444087e	8 years ago
Jenkins2	4e7d73968a	Merge "res_pjsip_notify.c: enable in-dialog NOTIFY" into 15	8 years ago
Jenkins2	2cf078c475	Merge "pjsip_scheduler.c: Fix ao2 usage errors." into 15	8 years ago
Jenkins2	1953d05224	Merge "Build System: Strip '-std=c99' from CFLAGS provided by libraries." into 15	8 years ago
Joshua Colp	d4817a0965	Merge "cdr_mysql: Compile error because MYSQL_PORT definition is missing" into 15	8 years ago
Evandro Cesar Arruda	dca6a4e774	cdr_mysql: Compile error because MYSQL_PORT definition is missing ... If it is not defined, it will add MYSQL_PORT definition. After some research on MySQL/MariaDB development tree, I couldn't find any reference to MYSQL_PORT definition in include files. ASTERISK-27782 #close Change-Id: Ieee56c836fc2e8bd021c456145bba04c6068bb77	8 years ago
Chris-Savinovich	b21fabc73b	res_pjsip_session: Rewrite o= with external_media_address. ... It now appends the external IP address on the o= line of the SDP packet. The decision was made to write the numeric IP address as opposed to the RFC that states the FQDN should be used if and when available. We believe the usage of literal IP address will help avoid potential problems. ASTERISK-27614 #close Change-Id: I84f3360f3606b8c4e8d161edb228799ec0b8a302	8 years ago
Jenkins2	7f02d86c9d	Merge "res_pjsip_refer/chan_sip: Fix INVITE with replaces transfer to ConfBridge" into 15	8 years ago
Nathan Bruning	e8b3da8896	res_pjsip_notify.c: enable in-dialog NOTIFY ... This patch adds support to send in-dialog SIP NOTIFY commands on chan_pjsip channels, similar to the functionality recently added for chan_sip (ASTERISK_27461). This extends res_pjsip_notify to allow for in-dialog messages. ASTERISK-27697 Change-Id: If7f3151a6d633e414d5dc319d5efc1443c43dd29	8 years ago
Jenkins2	6d62dc7ad7	Merge "chan_sip.c: Fix INVITE with replaces channel ref leak." into 15	8 years ago
Richard Mudgett	6b9933fe44	pjsip_scheduler.c: Fix ao2 usage errors. ... * Removed several invalid uses of OBJ_NOLOCK. These uses resulted in the 'tasks' container being accessed without a lock in a multi-threaded environment. A recipe for crashes. * Removed needlessly obtaining schtd object references. If the caller providing you a pointer to an object doesn't have a valid reference then you cannot safely get one from it. * Getting a ref to 'tasks' when you aren't copying the pointer into another location is useless. The 'tasks' container pointer is global. * Removed many unnecessary uses of RAII_VAR. * Make ast_sip_schedule_task() name parameter const. ASTERISK_26806 Change-Id: I5c62488e651314e2a1dbc01f5b078a15512d73db	8 years ago
Joshua Colp	f2a9129d8c	Merge "app_confbridge / bridge_softmix: Add ability to configure REMB interval." into 15	8 years ago
Jenkins2	7f9ab4a230	Merge "pjsip / res_rtp_asterisk: Add support for sending REMB" into 15	8 years ago
Joshua Colp	0e370c0915	Merge "res_rtp_asterisk: Queue video update on picture loss indication." into 15	8 years ago
Jenkins2	b5ec354963	Merge "res_rtp_asterisk: Fix minimum block word length for REMB." into 15	8 years ago
Jenkins2	5aa8623fdb	Merge "Build System: Fixes for configure script." into 15	8 years ago
Corey Farrell	ae9c8d999d	Build System: Enable python3 compatibility. ... * Consistently use spaces in rest-api-templates/asterisk_processor.py. * Exclude third-party from docs/full-en_US.xml. * Add docs/full-en_US.xml to .gitignore. * Use list() to convert python3 view. * Use python3 print function. * Replace cmp() with equivalent equation. * Replace reference to out of scope subtype variable with name parameter. * Use unescaping triple bracket notation in mustache templates where needed. This causes behavior of Python2 to be maintained when using Python3. * Fix references to has_websocket / is_websocket in res_ari_resource.c.mustache. * Update calculation of has_websocket to use any(). * Use unicode mode for writing output file in transform.py. * Replace 'from swagger_model import *' with explicit import of required symbols. I have not tested spandspflow2pcap.py or voicemailpwcheck.py, only the print syntax has been fixed. Change-Id: If5c5b556a2800d41a3e2cfef080ac2e151178c33	8 years ago
Richard Mudgett	49aa0da75f	res_pjsip_refer/chan_sip: Fix INVITE with replaces transfer to ConfBridge ... There is a problem when an INVITE-with-Replaces transfer targets a channel in a ConfBridge. The transfer will unconditionally swap out the ConfBridge channel. Unfortunately, the ConfBridge state will not be aware of this change. Unexpected behavior will happen as a result since ConfBridge channels currently can only be replaced by a masquerade and not normal bridge channel moves. * We just need to pretend that the channel isn't in a bridge (like other transfer methods already do) so the transfer channel will masquerade into the ConfBridge channel. Change-Id: I209beb0e748fa4f4b92a576f36afa8f495ba4c82	8 years ago
Joshua Colp	2fb12dcbc0	pjsip / res_rtp_asterisk: Add support for sending REMB ... This change allows chan_pjsip to be given an AST_FRAME_RTCP containing REMB feedback and pass it to res_rtp_asterisk. Once res_rtp_asterisk receives the frame a REMB RTCP feedback packet is constructed with the appropriate contents and sent to the remote endpoint. ASTERISK-27776 Change-Id: Ic53f821c1560d8924907ad82c4d9c0bc322b38cd	8 years ago
Jenkins2	ad4c757f88	Merge "res_pjsip: Update authenticate_qualify documentation." into 15	8 years ago
Joshua Colp	a5db8c47d6	res_rtp_asterisk: Fix minimum block word length for REMB. ... The minimum block word length is actually 4, not 5. Change-Id: I878542218225aed72c72bdf1b856fc822cd2d649	8 years ago
Joshua Colp	01cc0731d0	res_rtp_asterisk: Queue video update on picture loss indication. ... The previous payload specific feedback handling was very single minded in that it just assumed everything should trigger a video update. This was changed but the handling of picture loss indication was not added. The result was that video may not flow. This change adds it explicitly in. Change-Id: I1894be02e39ee10a0af841b5a1dca5f0ec7d60b6	8 years ago
Richard Mudgett	8dd7ba31e9	chan_sip.c: Fix INVITE with replaces channel ref leak. ... Given the below call scenario: A -> Ast1 -> B C <- Ast2 <- B 1) A calls B through Ast1 2) B calls C through Ast2 3) B transfers A to C When party B transfers A to C, B sends a REFER to Ast1 causing Ast1 to send an INVITE with replaces to Ast2. Ast2 then leaks a channel ref of the channel between Ast1 and Ast2. Channel ref leaks are easily seen in the CLI "core show channels" output. The leaked channels appear in the output but you can do nothing with them and they never go away unless you restart Asterisk. * Properly account for the channel refs when imparting a channel into a bridge when handling an INVITE with replaces in handle_invite_replaces(). The ast_bridge_impart() function steals a channel ref but the code didn't account for how many refs were held by the code at the time and which ref was stolen. * Eliminated RAII_VAR in handle_invite_replaces(). ASTERISK-27740 Change-Id: I7edbed774314b55acf0067b2762bfe984ecaa9a4	8 years ago
Richard Mudgett	be75004852	res_pjsip: Update authenticate_qualify documentation. ... Change-Id: I3811de0014b1ffe96d4a3b49cddd5d4ca02ee5d4	8 years ago
Richard Mudgett	1790ffb390	app_agent_pool.c: Fix off nominal ref leak. ... Change-Id: Ib427ffc2c802620eaafb08b1c2a17dddd8fb8eb6	8 years ago
Corey Farrell	c3ecb39406	Build System: Strip '-std=c99' from CFLAGS provided by libraries. ... Asterisk requires GNU C extensions. On some systems certain libraries may incorrectly push -std=c99 into CFLAGS, thus breaking the build. This change causes that flag to be stripped so the Asterisk build is not broken by those libraries. This change is made for both pkgconfig and tool based libraries. ASTERISK-27629 #close Change-Id: I13389613b194abbac77becf90cd950dc168704db	8 years ago
Corey Farrell	c7f4aaf4c1	Build System: Fixes for configure script. ... * Replace all 'else if' statements with 'elif'. * Use loop to detect versioned lua headers and libraries. The loop for detecting lua fixes a bug where LUA_INCLUDE would be appended with the directory of every lua version after the first one is found. Change-Id: I3276f9aee955014108345be6092f51c932b43a0f	8 years ago
Joshua Colp	132fd2abdb	app_confbridge / bridge_softmix: Add ability to configure REMB interval. ... This change adds a configuration option to app_confbridge which can be used to set the interval at which we will send a combined REMB (remote estimated maximum bitrate) frame to sources of video. The bridging API has also been extended slightly to allow setting this so bridge_softmix can use it. ASTERISK-27786 Change-Id: I0e49eae60f369c86434414f3cb8278709c793c82	8 years ago
Jenkins2	3719880d49	Merge "install_prereq: Add Slackware (somehow)." into 15	8 years ago
Jenkins2	fd9c91df20	Merge "res_pjsip: Correct usages of pjproject's timer heap" into 15	8 years ago
Jenkins2	901e0a8973	Merge "pjroject_bundled: Add already-destroyed check to tsx_timer_callback" into 15	8 years ago
George Joseph	264eeb1c7d	Merge "install_prereq: Add Gentoo Linux." into 15	8 years ago
Jenkins2	bc7b82731a	Merge "pjproject_bundled: timer: Clean up usage of timer heap" into 15	8 years ago
Jenkins2	b1d2960318	Merge "BuildSystem: With external editline, do not require libs for internal editline." into 15	8 years ago
Jenkins2	1655e27240	Merge "core: Create main/options.c." into 15	8 years ago
George Joseph	0f5a215bf2	Merge "pjproject_bundled: Add patch for pj_atomic crashes" into 15	8 years ago
Richard Mudgett	f044ae1804	res_pjsip: Fix deadlock on reliable transport shutdown. ... A deadlock can happen when the PJSIP monitor thread is shutting down a connection oriented transport (TCP/TLS) used by a subscription at the same time as another thread tries to send something for that subscription. The deadlock is between the pjsip monitor thread attempting to get the dialog lock and another thread sending something for that dialog when it tries to get the transport manager lock. * res_pjsip_pubsub.c: Avoid the deadlock by pushing the subscription removal to the subscription serializer. * res_pjsip_registrar.c: Pushed off incoming registration contact removals to a default serializer as a precaution. Removing the contacts involves sorcery access which in this case will involve database access. Depending upon the setup, the database may not be on the same machine and could take awhile. We don't want to hold up the pjsip monitor thread with potentially long access times. ASTERISK-27706 Change-Id: I56b647aea565f24dba33e9e5ebeed4cd3f31f8c4	8 years ago
Kevin Harwell	4773b3bd78	Merge "test_data_buffer.c: Add unit tests for data buffer API." into 15	8 years ago
Kevin Harwell	048ff3c2f0	Merge "res_rtp_asterisk: Add support for raising additional RTCP messages." into 15	8 years ago
Kevin Harwell	2ccd9a6ad0	Merge "pjsip_transport_events.c: Fix crash using stale transport pointer." into 15	8 years ago
Kevin Harwell	91c61953d5	Merge "main/indications: Use ast_cli_completion_add for all completions." into 15	8 years ago
Jenkins2	b6f524a46a	Merge "BuildSystem: pjsip_evsub_set_uas_timeout was not used (part 2)." into 15	8 years ago
Jenkins2	44498b8f4b	Merge "Add data buffer API to store packets." into 15	8 years ago
Ross Beer	71b3a72c32	pjsip_transport_events.c: Fix crash using stale transport pointer. ... Apparently it is possible for the transport to be destroyed without triggering the transport callback logic. As a result the transport gets destroyed and we have a stale pointer in the active_transports container. * Invoke the transport monitor callback checks when the transport is destroyed in addition to when it is disconnected and shutdown. ASTERISK-27688 Change-Id: Ia9b5469fea8f2b3f2d8476fae6b748a4d23e7261	8 years ago
Ben Ford	fdabd5726d	test_data_buffer.c: Add unit tests for data buffer API. ... Added unit tests for the data buffer API. These tests include creating a data buffer, putting payloads into the buffer, resizing the buffer, and the nominal case for data buffer usage, which consists of adding the max number of payloads to the buffer, checking to see if the correct payloads are present, then adding more payloads and checking again to see if the previous payloads were replaced or not. For more information, refer to the wiki page: https://wiki.asterisk.org/wiki/display/AST/WebRTC+User+Experience+Improvements Change-Id: Id5b599aa15a5e61d0ec080f97cd0c57bd07e6f8f	8 years ago
Ben Ford	77b6f8c44e	Add data buffer API to store packets. ... Adds a data buffer with a configurable size that can store different kinds of packets (like RTP packets for retransmission). Given a number it will store a data packet at that position relative to the others. Given a number it will retrieve the given data packet if it is present. This is purposely a storage of arbitrary things so it can be used not just for RTP packets but also Asterisk frames in the future if needed. The API does not internally use a lock, so it will be up to the user of the API to properly protect the data buffer. For more information, refer to the wiki page: https://wiki.asterisk.org/wiki/display/AST/WebRTC+User+Experience+Improvements Change-Id: Iff13c5d4795d52356959fe2a57360cd57dfade07	8 years ago
George Joseph	42abd6d3d8	pjproject_bundled: Add patch for pj_atomic crashes ... There have been some crashes in the past where something attempts to use a pj_atomic after it's already been destroyed. This patch tries to prevent it by making sure that pj_atomic_destroy sets its mutex to NULL when it's done. The pj_mutex functions already check for a NULL mutex and just return PJ_EINVAL. Teluu also added some checks to the win32 implementation as well. Change-Id: Id25f70b79fdedf44ead6e6e1763a4417d3b3f825	8 years ago
Corey Farrell	9348e05585	core: Create main/options.c. ... This creates a separate source to 'own' symbols related to options.h and paths.h. This significantly reduces the number of exports created by main/asterisk.o. This change is required to eventually be able to link unmodified Asterisk sources to utilities and/or stand-alone tests. ASTERISK~26245 Change-Id: I5cf184f4757f9363b80c9e678bdc35c477122380	8 years ago
Joshua Colp	ad3a8dc497	res_rtp_asterisk: Add support for raising additional RTCP messages. ... This change extends the existing AST_FRAME_RTCP frame type to be able to contain additional RTCP message types, such as feedback messages. The payload type is contained in the subclass which allows knowing what is in the frame itself. The RTCP feedback message type is now handled and REMB[1] messages are raised with their containing information. This also fixes a bug where all feedback messages were triggering video updates instead of just FIR and FUR. Finally RTCP frames are now passed up through the Asterisk core to what is handling the channel, mapped appropriately in the case of bridging, and written to an outgoing stream. Since RTCP frames are on a per-stream basis this is only done on multistream capable channels. [1] https://tools.ietf.org/html/draft-alvestrand-rmcat-remb-03 ASTERISK-27758 ASTERISK-26366 Change-Id: I680da0ad8d5059d5e9655d896fb9d92e9da8491e	8 years ago