929 Commits (5244713b028b5862b82cf7e24476d943e93f0c7d)

Author	SHA1	Message	Date
Naveen Albert	bc02626477	func_frame_drop: Add debug messages for dropped frames. ... Add debug messages in scenarios where frames that are usually processed are dropped or skipped. Resolves: #1371 (cherry picked from commit 00b6ab22a0)	3 weeks ago
Naveen Albert	3951365cdb	func_frame_drop: Handle allocation failure properly. ... Handle allocation failure and simplify the allocation using asprintf. Resolves: #1366 (cherry picked from commit 40e6f2b12c)	3 weeks ago
Naveen Albert	c5de8a71fe	func_curl: Allow auth methods to be set. ... Currently the CURL function only supports Basic Authentication, the default auth method in libcurl. Add an option that also allows enabling digest authentication. Resolves: #1332 UserNote: The httpauth field in CURLOPT now allows the authentication methods to be set. (cherry picked from commit 99b310a33f)	3 weeks ago
Naveen Albert	bfbbe28344	sig_analog: Add Call Waiting Deluxe support. ... Adds support for Call Waiting Deluxe options to enhance the current call waiting feature. As part of this change, a mechanism is also added that allows a channel driver to queue an audio file for Dial() to play, which is necessary for the announcement function. ASTERISK-30373 #close Resolves: #271 UserNote: Call Waiting Deluxe can now be enabled for FXS channels by enabling its corresponding option.	3 weeks ago
George Joseph	4441e88db6	func_strings.c: Prevent SEGV in HASH single-argument mode. ... When in single-argument mode (very rarely used), a malformation of a column name (also very rare) could cause a NULL to be returned when retrieving the channel variable for that column. Passing that to strncat causes a SEGV. We now check for the NULL and print a warning message. Resolves: #1101 (cherry picked from commit 1d5a6f5706)	7 months ago
Sean Bright	ee0a50e749	docs: Indent <since> tags. ... Also updates the 'since' of applications/functions that existed before XML documentation was introduced (1.6.2.0). (cherry picked from commit 174006fcaa)	7 months ago
George Joseph	e6fe538d81	docs: Add version information to application and function XML elements ... * Do a git blame on the embedded XML application or function element. * From the commit hash, grab the summary line. * Do a git log --grep <summary> to find the cherry-pick commits in all branches that match. * Do a git patch-id to ensure the commits are all related and didn't get a false match on the summary. * Do a git tag --contains <commit> to find the tags that contain each commit. * Weed out all tags not ..0. * Sort and discard any .0.0 and following tags where the commit appeared in an earlier branch. * The result is a single tag for each branch where the application or function was defined. The applications and functions defined in the following files were done by hand because the XML was extracted from the C source file relatively recently. * channels/pjsip/dialplan_functions_doc.xml * main/logger_doc.xml * main/manager_doc.xml * res/res_geolocation/geoloc_doc.xml * res/res_stir_shaken/stir_shaken_doc.xml (cherry picked from commit 54d67711f8)	9 months ago
George Joseph	3fc90e7810	docs: Add version information to manager event instance XML elements ... * Do a git blame on the embedded XML managerEvent elements. * From the commit hash, grab the summary line. * Do a git log --grep <summary> to find the cherry-pick commits in all branches that match. * Do a git patch-id to ensure the commits are all related and didn't get a false match on the summary. * Do a git tag --contains <commit> to find the tags that contain each commit. * Weed out all tags not ..0. * Sort and discard any .0.0 and following tags where the commit appeared in an earlier branch. * The result is a single tag for each branch where the application or function was defined. The events defined in res/res_pjsip/pjsip_manager.xml were done by hand because the XML was extracted from the C source file relatively recently. Two bugs were fixed along the way... * The get_documentation awk script was exiting after it processed the first DOCUMENTATION block it found in a file. We have at least 1 source file with multiple DOCUMENTATION blocks so only the first one in them was being processed. The awk script was changed to continue searching rather than exiting after the first block. * Fixing the awk script revealed an issue in logger.c where the third DOCUMENTATION block contained a XML fragment that consisted only of a managerEventInstance element that wasn't wrapped in a managerEvent element. Since logger_doc.xml already existed, the remaining fragments in logger.c were moved to it and properly organized. (cherry picked from commit 2897d87a99)	9 months ago
Maksim Nesterov	6181408bf0	func_uuid: Add a new dialplan function to generate UUIDs ... This function is useful for uniquely identifying calls, recordings, and other entities in distributed environments, as well as for generating an argument for the AudioSocket application. (cherry picked from commit e9220e80f9)	9 months ago
Mike Pultz	7fe5ebd4ea	func_curl.c: Add additional CURL options for SSL requests ... This patch adds additional CURL TLS options / options to support mTLS authenticated requests: * ssl_verifyhost - perform a host verification on the peer certificate (CURLOPT_SSL_VERIFYHOST) * ssl_cainfo - define a CA certificate file (CURLOPT_CAINFO) * ssl_capath - define a CA certificate directory (CURLOPT_CAPATH) * ssl_cert - define a client certificate for the request (CURLOPT_SSLCERT) * ssl_certtype - specify the client certificate type (CURLOPT_SSLCERTTYPE) * ssl_key - define a client private key for the request (CURLOPT_SSLKEY) * ssl_keytype - specify the client private key type (CURLOPT_SSLKEYTYPE) * ssl_keypasswd - set a password for the private key, if required (CURLOPT_KEYPASSWD) UserNote: The following new configuration options are now available in the res_curl.conf file, and the CURL() function: 'ssl_verifyhost' (CURLOPT_SSL_VERIFYHOST), 'ssl_cainfo' (CURLOPT_CAINFO), 'ssl_capath' (CURLOPT_CAPATH), 'ssl_cert' (CURLOPT_SSLCERT), 'ssl_certtype' (CURLOPT_SSLCERTTYPE), 'ssl_key' (CURLOPT_SSLKEY), 'ssl_keytype', (CURLOPT_SSLKEYTYPE) and 'ssl_keypasswd' (CURLOPT_KEYPASSWD). See the libcurl documentation for more details. (cherry picked from commit fdd916e590)	9 months ago
George Joseph	e481aad978	func_pjsip_aor/contact: Fix documentation for contact ID ... Clarified the use of the contact ID returned from PJSIP_AOR. Resolves: #990 (cherry picked from commit e50e4ab33a)	11 months ago
Naveen Albert	525c13786a	func_evalexten: Add EVAL_SUB function. ... This adds an EVAL_SUB function, which is similar to the existing EVAL_EXTEN function but significantly more powerful, as it allows executing arbitrary dialplan and capturing its return value as the function's output. While EVAL_EXTEN should be preferred if it is possible to use it, EVAL_SUB can be used in a wider variety of cases and allows arbitrary computation to be performed in a dialplan function call, leveraging the dialplan. Resolves: #951 (cherry picked from commit 5a4026d080)	11 months ago
Sean Bright	b1e7d472d6	func_base64.c: Ensure we set aside enough room for base64 encoded data. ... Reported by SingularTricycle on IRC. Fixes #940 (cherry picked from commit 7d0b342261)	11 months ago
Ben Ford	df01693e01	channel: Add multi-tenant identifier. ... This patch introduces a new identifier for channels: tenantid. It's a stringfield on the channel that can be used for general purposes. It will be inherited by other channels the same way that linkedid is. You can set tenantid in a few ways. The first is to set it in the dialplan with the Set and CHANNEL functions: exten => example,1,Set(CHANNEL(tenantid)=My tenant ID) It can also be accessed via CHANNEL: exten => example,2,NoOp(CHANNEL(tenantid)) Another method is to use the new tenantid option for pjsip endpoints in pjsip.conf: [my_endpoint] type=endpoint tenantid=My tenant ID This is considered the best approach since you will be able to see the tenant ID as early as the Newchannel event. It can also be set using set_var in pjsip.conf on the endpoint like setting other channel variable: set_var=CHANNEL(tenantid)=My tenant ID Note that set_var will not show tenant ID on the Newchannel event, however. Tenant ID has also been added to CDR. It's read-only and can be accessed via CDR(tenantid). You can also get the tenant ID of the last channel communicated with via CDR(peertenantid). Tenant ID will also show up in CEL records if it has been set, and the version number has been bumped accordingly. Fixes: #740 UserNote: tenantid has been added to channels. It can be read in dialplan via CHANNEL(tenantid), and it can be set using Set(CHANNEL(tenantid)=My tenant ID). In pjsip.conf, it is recommended to use the new tenantid option for pjsip endpoints (e.g., tenantid=My tenant ID) so that it will show up in Newchannel events. You can set it like any other channel variable using set_var in pjsip.conf as well, but note that this will NOT show up in Newchannel events. Tenant ID is also available in CDR and can be accessed with CDR(tenantid). The peer tenant ID can also be accessed with CDR(peertenantid). CEL includes tenant ID as well if it has been set. UpgradeNote: A new versioned struct (ast_channel_initializers) has been added that gets passed to __ast_channel_alloc_ap. The new function ast_channel_alloc_with_initializers should be used when creating channels that require the use of this struct. Currently the only value in the struct is for tenantid, but now more fields can be added to the struct as necessary rather than the __ast_channel_alloc_ap function. A new option (tenantid) has been added to endpoints in pjsip.conf as well. CEL has had its version bumped to include tenant ID. (cherry picked from commit 7990f6b589)	1 year ago
Naveen Albert	e5f9ce52ed	say.c: Fix cents off-by-one due to floating point rounding. ... Some of the money announcements can be off by one cent, due to the use of floating point in the money calculations, which is bad for obvious reasons. This replaces floating point with simple string parsing to ensure the cents value is converted accurately. Resolves: #525 (cherry picked from commit c38f352d20)	1 year ago
Naveen Albert	51b0ca2db0	callerid.c: Parse previously ignored Caller ID parameters. ... Commit f2f397c1a8 previously made it possible to send Caller ID parameters to FXS stations which, prior to that, could not be sent. This change is complementary in that we now handle receiving all these parameters on FXO lines and provide these up to the dialplan, via chan_dahdi. In particular: * If a redirecting reason is provided, the channel's redirecting reason is set. No redirecting number is set, since there is no parameter for this in the Caller ID protocol, but the reason can be checked to determine if and why a call was forwarded. * If the Call Qualifier parameter is received, the Call Qualifier variable is set. * Some comments have been added to explain why some of the code is the way it is, to assist other people looking at it. With this change, Asterisk's Caller ID implementation is now reasonably complete for both FXS and FXO operation. Resolves: #681 (cherry picked from commit 44381b2fe9)	1 year ago
Naveen Albert	0abe9e60b1	func_callerid: Emit warning if invalid redirecting reason set. ... Emit a warning if REDIRECTING(reason) is set to an invalid reason, consistent with what happens when REDIRECTING(orig-reason) is set to an invalid reason. Resolves: #683 (cherry picked from commit c16e3c2ac5)	1 year ago
Naveen Albert	410909fbfb	func_frame_trace: Add CLI command to dump frame queue. ... This adds a simple CLI command that can be used for analyzing all frames currently queued to a channel. A couple log messages are also adjusted to be more useful in tracing bridging problems. Resolves: #533 (cherry picked from commit d075a08d7e)	2 years ago
Naveen Albert	a6d856aba2	func_channel: Expose previously unsettable options. ... Certain channel options are not set anywhere or exposed in any way to users, making them unusable. This exposes some of these options which make sense for users to manipulate at runtime. Resolves: #442 (cherry picked from commit c222343ec6)	2 years ago
Sean Bright	69a19aabd8	func_curl.c: Remove CURLOPT() plaintext documentation. ... I assume this was missed when initially converting to XML documentation and we've been kicking the can down the road since. (cherry picked from commit 9e1a60727e)	2 years ago
Naveen Albert	4d928ee975	func_lock: Add missing see-also refs to documentation. ... Resolves: #423 (cherry picked from commit 12b353eae0)	2 years ago
Sean Bright	d7a01afa50	func_curl.c: Ensure channel is locked when manipulating datastores. ... (cherry picked from commit acb2348f90)	2 years ago
Bastian Triller	7a1208410a	func_json: Fix crashes for some types ... This commit fixes crashes in JSON_DECODE() for types null, true, false and real numbers. In addition it ensures that a path is not deeper than 32 levels. Also allow root object to be an array. Add unit tests for above cases. (cherry picked from commit e6d5b8d8cf)	2 years ago
Mike Bradeen	58a37523dd	func_periodic_hook: Add hangup step to avoid timeout ... func_periodic_hook does not hangup after playback, relying on hangup which keeps the channel alive longer than necessary. Resolves: #325 (cherry picked from commit dd817c2708)	2 years ago
George Joseph	9ee35c259a	func_periodic_hook: Don't truncate channel name ... func_periodic_hook was truncating long channel names which causes issues when you need to run other dialplan functions/apps on the channel. Resolves: #319 (cherry picked from commit 9e2433f73f)	2 years ago
Joshua C. Colp	6521066fbe	variables: Add additional variable dialplan functions. ... Using the Set dialplan application does not actually delete channel or global variables. Instead the variables are set to an empty value. This change adds two dialplan functions, GLOBAL_DELETE and DELETE which can be used to delete global and channel variables instead of just setting them to empty. There is also no ability within the dialplan to determine if a global or channel variable has actually been set or not. This change also adds two dialplan functions, GLOBAL_EXISTS and VARIABLE_EXISTS which can be used to determine if a global or channel variable has been set or not. Resolves: #289 UserNote: Four new dialplan functions have been added. GLOBAL_DELETE and DELETE have been added which allows the deletion of global and channel variables. GLOBAL_EXISTS and VARIABLE_EXISTS have been added which checks whether a global or channel variable has been set. (cherry picked from commit abe4f62554)	2 years ago
phoneben	cbcde0624b	func_cut: Add example to documentation. ... This adds an example to the XML documentation clarifying usage of the CUT function to address a common misusage. (cherry picked from commit c0b8adfe4d)	2 years ago
Sean Bright	29fbf1b2c8	func_export: Use correct function argument as variable name. ... Fixes #208 (cherry picked from commit b8aee4a2c6)	2 years ago
Naveen Albert	f40e50ce19	sig_analog: Add fuller Caller ID support. ... A previous change, ASTERISK_29991, made it possible to send additional Caller ID parameters that were not previously supported. This change adds support for analog DAHDI channels to now be able to receive these parameters for on-hook Caller ID, in order to enhance the usability of CPE that support these parameters. Resolves: #94 ASTERISK-30331 UserNote: Additional Caller ID properties are now supported on incoming calls to FXS stations, namely the redirecting reason and call qualifier. (cherry picked from commit 87f44dc0f9)	2 years ago
Mike Bradeen	2ac8388c6d	bridge_builtin_features: add beep via touch variable ... Add periodic beep option to one-touch recording by setting the touch variable TOUCH_MONITOR_BEEP or TOUCH_MIXMONITOR_BEEP to the desired interval in seconds. If the interval is less than 5 seconds, a minimum of 5 seconds will be imposed. If the interval is set to an invalid value, it will default to 15 seconds. A new test event PERIODIC_HOOK_ENABLED was added to the func_periodic_hook hook_on function to indicate when a hook is started. This is so we can test that the touch variable starts the hook as expected. ASTERISK-30446 Change-Id: I800e494a789ba7a930bbdcd717e89d86040d6661 (cherry picked from commit ffe346b2de)	2 years ago
Naveen Albert	e104bd0852	func_json: Fix JSON parsing issues. ... Fix issue with returning empty instead of dumping the JSON string when recursing. Also adds a unit test to capture this fix. ASTERISK-30441 #close Change-Id: If0bde9f3fe84f7af485e0838205cc21e0f752a85 (cherry picked from commit f9fd76677f)	2 years ago
Naveen Albert	8a45cd7af4	func_json: Enhance parsing capabilities of JSON_DECODE ... Adds support for arrays to JSON_DECODE by allowing the user to print out entire arrays or index a particular key or print the number of keys in a JSON array. Additionally, adds support for recursively iterating a JSON tree in a single function call, making it easier to parse JSON results with multiple levels. A maximum depth is imposed to prevent potentially blowing the stack. Also fixes a bug with the unit tests causing an empty string to be printed instead of the actual test result. ASTERISK-29913 #close Change-Id: I603940b216a3911b498fc6583b18934011ef5d5b	3 years ago
Naveen Albert	68e345286b	func_frame_trace: Print text for text frames. ... Since text frames contain a text body, make FRAME_TRACE more useful for text frames by actually printing the text. ASTERISK-30353 #close Change-Id: Ia6ce3d15cecd7a673a528d34faac86854a2bab50	3 years ago
Naveen Albert	cbb1fd2cb9	func_callerid: Warn about invalid redirecting reason. ... Currently, if a user attempts to set a Caller ID related function to an invalid value, a warning is emitted, except for when setting the redirecting reason. We now emit a warning if we were unable to successfully parse the user-provided reason. ASTERISK-30332 #close Change-Id: Ic341f5d5f7303b6f1115549be64db58a85944f5a	3 years ago
Naveen Albert	83eb113e0f	func_presencestate: Fix invalid memory access. ... When parsing information from AstDB while loading, it is possible that certain pointers are never set, which leads to invalid memory access and then, fatally, invalid free attempts on this memory. We now initialize to NULL to prevent this. ASTERISK-30311 #close Change-Id: I6120681d04fd2c12a9473f35ce95a1f8e74e3929	3 years ago
Naveen Albert	002afc3f2a	func_json: Fix memory leak. ... A memory leak was present in func_json due to using ast_json_free, which just calls ast_free, as opposed to recursively freeing the JSON object as needed. This is now fixed to use the right free functions. ASTERISK-30293 #close Change-Id: I982324dde841dc9147c8d8ad35c8719daf418b49	3 years ago
Naveen Albert	407216a0a5	say: Don't prepend ampersand erroneously. ... Some logic in say.c for determining if we need to also add an ampersand for file seperation was faulty, as non-successful files would increment the count, causing a leading ampersand to be added improperly. This is fixed, and a unit test that captures this regression is also added. ASTERISK-30248 #close Change-Id: I02c1d3a11d82fe4ea8b462070cbd1effb5834d2b	3 years ago
Naveen Albert	407167cc28	func_logic: Don't emit warning if both IF branches are empty. ... The IF function currently emits warnings if both IF branches are empty. However, there is no actual necessity that either branch be non-empty as, unlike other conditional applications/ functions, nothing is inherently done with IF, and both sides could legitimately be empty. The warning is thus turned into a debug message. ASTERISK-30243 #close Change-Id: I5250625dd720f95e1859b5dfb933905d7e7a730e	3 years ago
Naveen Albert	1ed4518328	func_export: Add EXPORT function ... Adds the EXPORT function, which allows write access to variables and functions on other channels. ASTERISK-29432 #close Change-Id: I7492645ae4307553d0f586d78e13a4f586231fdf	3 years ago
Naveen Albert	8aae0b9f08	func_scramble: Fix null pointer dereference. ... Fix segfault due to null pointer dereference inside the audiohook callback. ASTERISK-30220 #close Change-Id: Ideb80f606974366e89d619d908744230b5a5a259	3 years ago
Naveen Albert	ab1dbfef75	func_strings: Add trim functions. ... Adds TRIM, LTRIM, and RTRIM, which can be used for trimming leading and trailing whitespace from strings. ASTERISK-30222 #close Change-Id: I50fb0c40726d044a7a41939fa9026f3da4872554	3 years ago
Naveen Albert	2dac2bf8dc	func_frame_trace: Remove bogus assertion. ... The FRAME_TRACE function currently asserts if it sees a MASQUERADE_NOTIFY. However, this is a legitimate thing that can happen so asserting is inappropriate, as there are no clear negative ramifications of such a thing. This is adjusted to be like the other frames to print out the subclass. ASTERISK-30210 #close Change-Id: I8ecbdcf17e35f64bdeab42868471f581ad1d1a56	3 years ago
Naveen Albert	83912496ab	func_srv: Document field parameter. ... Adds missing documentation for the field parameter for the SRVRESULT function. ASTERISK-30151 Reported by: Chris Young Change-Id: I4385a2e0892a07e30dea1a8a0588e2c1bea2b1f1	3 years ago
Naveen Albert	bcc18ca9f5	general: Fix various typos. ... ASTERISK-30089 #close Change-Id: I1f5db911fd05a3a211c522c13e990fa1d0e62275	3 years ago
Naveen Albert	51d262af12	xmldocs: Improve examples. ... Use example tags instead of regular para tags where possible. ASTERISK-30090 Change-Id: Iada8bbfda08f30b118cedf2d040bbb21e4966ec5	3 years ago
George Joseph	4aa541683b	GCC12: Fixes for 16+ ... Most issues were in stringfields and had to do with comparing a pointer to an constant/interned string with NULL. Since the string was a constant, a pointer to it could never be NULL so the comparison was always "true". gcc now complains about that. There were also a few issues where determining if there was enough space for a memcpy or s(n)printf which were fixed by defining some of the involved variables as "volatile". There were also a few other miscellaneous fixes. ASTERISK-30044 Change-Id: Ia081ca1bcfb329df6487c4660aaf1944309eb570	3 years ago
Naveen Albert	306ce09df2	func_db: Add function to return cardinality at prefix ... Adds the DB_KEYCOUNT function, which can be used to retrieve the number of keys at a given prefix in AstDB. ASTERISK-29968 #close Change-Id: Ib2393b77b7e962dbaae6192f8576bc3f6ba92d09	3 years ago
Naveen Albert	6ddb0ec939	func_evalexten: Extension evaluation function. ... This adds the EVAL_EXTEN function, which may be used to retrieve the variable-substituted data at any extension. ASTERISK-29486 Change-Id: Iad81019689674c9f4ac77d235f5d7234adbb1432	3 years ago
Naveen Albert	0c70d497bc	documentation: Adds versioning information. ... Adds version information for applications, functions, and manager events/actions. This is not completely exhaustive by any means but covers most new things added that have release versioning information in the issue tracker. ASTERISK-29940 #close Change-Id: I506401e93c799715dbbe97c0a8ba18af2bf5e131	3 years ago
Joshua C. Colp	4aedaaadeb	func_odbc: Add SQL_ESC_BACKSLASHES dialplan function. ... Some databases depending on their configuration using backslashes for escaping. When combined with the use of ' this can result in a broken func_odbc query. This change adds a SQL_ESC_BACKSLASHES dialplan function which can be used to escape the backslashes. This is done as a dialplan function instead of being always done as some databases do not require this, and always doing it would result in incorrect data being put into the database. ASTERISK-29838 Change-Id: I152bf34899b96ddb09cca3e767254d8d78f0c83d	4 years ago