5301 Commits (50fa868ab81992dfdfc0f50834fa06cb370290c3)

Author	SHA1	Message	Date
Corey Farrell	b96f18560b	astobj2: Declare private variable data_size for AO2_DEBUG only. ... Every ao2 object contains storage for a private variable data_size, though the value is never read if AO2_DEBUG is disabled. This change makes the variable conditional, reducing memory usage. ASTERISK-26524 #close Change-Id: If859929e507676ebc58b0f84247a4231e11da07f	9 years ago
George Joseph	6b1c55dc9b	pjproject_bundled: Fix issue where "/version.mak" wasn't found ... main/Makefile includes third-party/pjproject/build.mak but doesn't set PJDIR beforehand so "include $(PJDIR)/version.mak" evaluates to "/version.mak". Fix is to set PJDIR in main/Makefile before the include. Change-Id: I0f7c67d60209049056fe9c4b041bf0463aa95604	9 years ago
Corey Farrell	f373de3020	Fix shutdown crash caused by modules being left open. ... It is only safe to run ast_register_cleanup callbacks when all modules have been unloaded. Previously these callbacks were run during graceful shutdown, making it possible to crash during shutdown. ASTERISK-26513 #close Change-Id: Ibfa635bb688d1227ec54aa211d90d6bd45052e21	9 years ago
Joshua Colp	5677e18631	Merge "typo: s/paranthesis/parenthesis/ in a comment" into 13	9 years ago
Joshua Colp	578e34b445	Merge "ARI: Detect duplicate channel IDs" into 13	9 years ago
Pascal Cadotte Michaud	640203802e	typo: s/paranthesis/parenthesis/ in a comment ... Change-Id: I7c1f4eb051177ee22cbe97e063d4a3effe29be30	9 years ago
Mark Michelson	eff97808fb	ARI: Detect duplicate channel IDs ... ARI and AMI allow for an explicit channel ID to be specified when originating channels. Unfortunately, there is nothing in place to prevent someone from using the same ID for multiple channels. Further complicating things, adding ID validation to channel allocation makes it impossible for ARI to discern why channel allocation failed, resulting in a vague error code being returned. The fix for this is to institute a new method for channel errors to be discerned. The method mirrors errno, in that when an error occurs, the caller can consult the channel errno value to determine what the error was. This initial iteration of the feature only introduces "unknown" and "channel ID exists" errors. However, it's possible to add more errors as needed. ARI uses this feature to determine why channel allocation failed and can return a 409 error during origination to show that a channel with the given ID already exists. ASTERISK-26421 Change-Id: Ibba7ae68842dab6df0c2e9c45559208bc89d3d06	9 years ago
snuffy	c2036c827c	Fix issue with CLI not returning to prompt after running "features show" ... ASTERISK-26444 #close Change-Id: I91d645b7e6e5dba35f8c410df2be77a8c0e3acb8	9 years ago
zuul	87483f3545	Merge "utils.c: Fix ast_set_default_eid for multiple platforms" into 13	9 years ago
Joshua Colp	1bde92f68c	Merge "CDR: Alter destruction pattern for CDR chains." into 13	9 years ago
Mark Michelson	012fda29d2	CDR: Alter destruction pattern for CDR chains. ... CDRs form chains. When the root of the chain is destroyed, it then unreferences the next CDR in the chain. That CDR is destroyed, and it then unreferences the next CDR in the chain. This repeats until the end of the chain is reached. While this typically does not cause any sort of problems, it is possible in strange scenarios for the CDR chain to grow way longer than expected. In such a scenario, the destruction pattern can result in a stack overflow. This patch fixes the problem by switching from a recursive pattern to an iterative pattern for destruction. When the root CDR is destroyed, it is responsible for iterating over the rest of the CDRs and unreferencing each one. Other CDRs in the chain, since they are not the root, will simply destroy themselves and be done. This causes the stack depth not to increase. ASTERISK-26421 #close Reported by Andrew Nagy Change-Id: I3ca90c2b8051f3b7ead2e0e43f60d2c18fb204b8	9 years ago
Alexander Traud	662b560c35	cli: Auto-complete File not Module for core set debug. ... Since Asterisk 1.8, the command "core set debug" on the command-line interface asks not for a file (.c) but a module name. This change shows modules (.so) on the auto-completion via a tabulator or the question mark. Now, when you partially type a module name, TAB or ?, you get the correct candidiates. ASTERISK-26480 Change-Id: I1213f1dd409bd4ff8de08ad80cb0c73cafb1bae0	9 years ago
George Joseph	74d9385273	utils.c: Fix ast_set_default_eid for multiple platforms ... ast_set_default_eid was searching for ethX, emX, enoX, ensX and even pciD#U interface names. While this was a good attempt, it wasn't inclusive enough to capture interfaces like enp6s0 or ens6d1, etc. Rather than relying on interface names, we now simply find the first interface returned by the OS that has a hardware address and that address isn't all 0x00 or all 0xff. The code IS different for BSD, Solaris and Linux based on what method is available for enumerating interfaces. Tested on: FreeBSD9 CentOS6 Ubuntu14 Fedora24 I was unable to test on Solaris at this time but the code for Solaris is used elsewhere at Digium. Change-Id: Iaa6db87ca78a9a375e47d70e043ae08c1448cb72	9 years ago
zuul	3bdd7c0e38	Merge "Audit ast_json_pack() calls for needed UTF-8 checks." into 13	9 years ago
zuul	8d12d6021b	Merge "json: Check party id name, number, subaddresses for UTF-8." into 13	9 years ago
zuul	05c6ab0d8f	Merge "json: Add UTF-8 check call." into 13	9 years ago
Richard Mudgett	3c54328c57	Audit ast_json_pack() calls for needed UTF-8 checks. ... Added needed UTF-8 checks before constructing json objects in various files for strings obtained outside the system. In this case string values from a channel driver's peer and not from the user setting channel variables. * aoc.c: Fixed type mismatch in s_to_json() for time and granularity json object construction. ASTERISK-26466 Reported by: Richard Mudgett Change-Id: Iac2d867fa598daba5c5dbc619b5464625a7f2096	9 years ago
Richard Mudgett	7f8f125738	json: Check party id name, number, subaddresses for UTF-8. ... * Updated unit test as ast_json_name_number() is now NULL tolerant. ASTERISK-26466 #close Reported by: Richard Mudgett Change-Id: I7d4e14194f8f81f24a1dc34d1b8602c0950265a6	9 years ago
Richard Mudgett	9621c9bcbc	json: Add UTF-8 check call. ... Since the json library does not make the check function public we recreate/copy the function in our interface module. ASTERISK-26466 Reported by: Richard Mudgett Change-Id: I36d3d750b6f5f1a110bc69ea92b435ecdeeb2a99	9 years ago
Richard Mudgett	e4bb9f9a37	aoc.c: Whitespace cleanup ... * In s_to_json() removed unnecessary ast_json_ref() to ast_json_null() when creating the type json object. The ref is a noop. Change-Id: I2be8b836876fc2e34a27c161f8b1c53b58a3889a	9 years ago
zuul	2971c1b4eb	Merge "audiohooks: Remove redundant codec translations when using audiohooks" into 13	9 years ago
Corey Farrell	dd873bcada	astobj2: Add backtrace to log_bad_ao2. ... * Compile __ast_assert_failed unconditionally. * Use __ast_assert_failed to log messages from log_bad_ao2 * Remove calls to ast_assert(0) that happen after log_bad_ao2 was run. Change-Id: I48f1af44b2718ad74a421ff75cb6397b924a9751	9 years ago
Michael Walton	430f6e5388	audiohooks: Remove redundant codec translations when using audiohooks ... The main frame read and write handlers in main/channel.c don't use the optimum placement in the processing flow for calling audiohooks callbacks, as far as codec translation is concerned. This change places the audiohooks callback code: * After the channel read translation if the frame is not linear before the translation, thereby increasing the chance that the frame is linear as required by audiohooks * Before the channel write translation if the frame is linear at this point This prevents the audiohooks code from instantiating additional translation paths to/from linear where a linear frame format is already available, saving valuable CPU cycles ASTERISK-26419 Change-Id: I6edd5771f0740e758e7eb42558b953f046c01f8f	9 years ago
zuul	52e3c6c2e0	Merge "chan_sip: Address runaway when realtime peers subscribe to mailboxes" into 13	9 years ago
George Joseph	0056bcaebd	chan_sip: Address runaway when realtime peers subscribe to mailboxes ... Users upgrading from asterisk 13.5 to a later version and who use realtime with peers that have mailboxes were experiencing runaway situations that manifested as a continuous stream of taskprocessor congestion errors, memory leaks and an unresponsive chan_sip. A related issue was that setting rtcachefriends=no NEVER worked in asterisk 13 (since the move to stasis). In 13.5 and earlier, when a peer tried to register, all of the stasis threads would block and chan_sip would again become unresponsive. After 13.5, the runaway would happen. There were a number of causes... * mwi_event_cb was (indirectly) calling build_peer even though calls to mwi_event_cb are often caused by build_peer. * In an effort to prevent chan_sip from being unloaded while messages were still in flight, destroy_mailboxes was calling stasis_unsubscribe_and_join but in some cases waited forever for the final message. * add_peer_mailboxes wasn't properly marking the existing mailboxes on a peer as "keep" so build_peer would always delete them all. * add_peer_mwi_subs was unsubscribing existing mailbox subscriptions then just creating them again. All of this was causing a flood of subscribes and unsubscribes on multiple threads all for the same peer and mailbox. Fixes... * add_peer_mailboxes now marks mailboxes correctly and build_peer only deletes the ones that really are no longer needed by the peer. * add_peer_mwi_subs now only adds subscriptions marked as "new" instead of unsubscribing and resubscribing everything. It also adds the peer object's address to the mailbox instead of its name to the subscription userdata so mwi_event_cb doesn't have to call build_peer. With these changes, with rtcachefriends=yes (the most common setting), there are no leaks, locks, loops or crashes at shutdown. rtcachefriends=no still causes leaks but at least it doesn't lock, loop or crash. Since making rtcachefriends=no work wasnt in scope for this issue, further work will have to be deferred to a separate patch. Side fixes... * The ast_lock_track structure had a member named "thread" which gdb doesn't like since it conflicts with it's "thread" command. That member was renamed to "thread_id". ASTERISK-25468 #close Change-Id: I07519ef7f092629e1e844f855abd279d6475cdd0	9 years ago
zuul	7cce1a7817	Merge "core: Ensure presencestate subtype and message are NULL." into 13	10 years ago
Joshua Colp	323aff3a09	core: Ensure presencestate subtype and message are NULL. ... When retrieving presence state information there is no guarantee that the subtype and message passed in are set to NULL. This change ensures they are. ASTERISK-26397 #close Change-Id: I61f8187972d5d8bbd7d6b7f4daa4f4f7e8237b23	10 years ago
zuul	81bb672861	Merge "logger: Fix default console settings." into 13	10 years ago
zuul	5cb3fc5d67	Merge "core: Fix LOW_MEMORY missing symbol ast_pbx_uuid_get." into 13	10 years ago
zuul	a6b05e6371	Merge "asterisk.c: Non-root users also get the astcanary after core restart." into 13	10 years ago
Corey Farrell	c9ce299b64	core: Fix LOW_MEMORY missing symbol ast_pbx_uuid_get. ... Move the function outside the conditional block that excludes LOW_MEMORY. ASTERISK-26273 #close Change-Id: Ic290fa128222c410c3531107e30efacabc8493b4	10 years ago
Corey Farrell	610eb4c189	logger: Fix default console settings. ... When logger.conf is missing or invalid we should be printing notices, warnings and errors to the console. The logmask was incorrectly calculated. Change-Id: Ibaa9465a8682854bc1a5e9ba07079bea1bfb6bb3	10 years ago
Tzafrir Cohen	36092ee3a0	sd_notify (systemd status notifications) support ... sd_notify() is used to notify systemd of changes to the status of the process. This allows the systemd daemon to know when the process finished loading (and thus only start another program after Asterisk has finished loading). To use this, use a systemd unit with 'Type=notify' for Asterisk. This commit also adds the function ast_sd_notify(), a wrapper around sd_notify that does nothing if not built with systemd support. Also adds support for libsystemd detection in the configure script. Change-Id: Ied6a59dafd5ef331c5c7ae8f3ccd2dfc94be7811 (cherry picked from commit 07b95f7c65)	10 years ago
Walter Doekes	9372d32100	asterisk.c: Non-root users also get the astcanary after core restart. ... Without this change, a 'core restart' would kill the astcanary forever if you're not running as root. Both with and without this patch, the scheduling priority was still SCHED_RR after restart. Additionally, the astcanary is now spawned if you start with high priority and Asterisk doesn't get a chance to lower it. For example through: `chrt -r 10 sudo -u asterisk asterisk -c` Also reap killed astcanary processes on core restart. ASTERISK-26352 #close Change-Id: Iacb49f26491a0717084ad46ed96b0bea5f627a55	10 years ago
zuul	34461b89ac	Merge "asterisk.c: When astcanary dies on linux, reset priority on all threads." into 13	10 years ago
Walter Doekes	e96448e991	asterisk.c: When astcanary dies on linux, reset priority on all threads. ... Previously only the canary checking thread itself had its priority set to SCHED_OTHER. Now all threads are traversed and adjusted. ASTERISK-19867 #close Reported by: Xavier Hienne Change-Id: Ie0dd02a3ec42f66a78303e9c1aac28f7ed9aae39	10 years ago
Timo Teräs	01884a7af6	Fix showing of swap details when sysinfo() is available ... If sysinfo() is available, but not sysctl() or swapctl() the printing code for swap buffer sizes is incorrectly omitted. The above condition happens with musl c-library. Fix #if rule to consider defined(HAVE_SYSINFO). And also remove the redundant || defined(HAVE_SYSCTL) which was incorrectly there to start with. Now swap information is displayed only if an actual libc function to get it is available. This also fixes warnings previously seen with musl libc: [CC] asterisk.c -> asterisk.o asterisk.c: In function 'handle_show_sysinfo': asterisk.c:773:6: warning: variable 'totalswap' set but not used [-Wunused-but-set-variable] int totalswap = 0; ^~~~~~~~~ asterisk.c:770:11: warning: variable 'freeswap' set but not used [-Wunused-but-set-variable] uint64_t freeswap = 0; ^~~~~~~~ Change-Id: I1fb21dad8f27e416c60f138c6f2bff03fb626eca	10 years ago
Joshua Colp	1cac856e17	rtp: Preserve timestamps on video frames. ... Currently when receiving video over RTP we store only a calculated samples on the frame. When starting the video it can take some time for this calculation to actually yield a value as it requires constant changing timestamps. As well if a video frame passes over multiple RTP packets this calculation will fail as the timestamp is the same as the previous RTP packet and the number of samples calculated will be 0. This change preserves the timestamp on the frame and allows it to pass through the core. When sending the video this timestamp is used instead of a new one being calculated. ASTERISK-26367 #close Change-Id: Iba8179fb5c14c9443aee4baf670d2185da3ecfbd	10 years ago
Richard Mudgett	8d1c535bd6	format_cap.c: Fix CLI "core show channeltype Surrogate" crash. ... * Make ast_format_cap_get_names() NULL tolerant. ASTERISK-26331 #close Reported by: CGI.NET Change-Id: Id67e93936dc8ec2a33a9d33655843d43b59285a3	10 years ago
Etienne Lessard	27951792c4	pbx.c: Prevent infinite recursion in manager_show_dialplan_helper. ... Previously, if context A was including context B and context B was including context A, i.e. if there was a circular dependency between contexts, then calling manager_show_dialplan_helper could lead to an infinite recursion, resulting in a crash. This commit applies the same solution as the one implemented in the show_dialplan_helper function. The manager_show_dialplan_helper and show_dialplan_helper functions contain lots of code in common, but the former was missing the "infinite recursion avoidance" code. ASTERISK-26226 #close Change-Id: I1aea85133c21787226f4f8442253a93000aa0897	10 years ago
zuul	ba3984753a	Merge "channel: No hung-up on failing security requirements." into 13	10 years ago
Alexander Traud	847bd47ff0	channel: No hung-up on failing security requirements. ... In your Diaplan, if you specify same => n,Set(CHANNEL(secure_bridge_media)=1) same => n,Set(CHANNEL(secure_bridge_signaling)=1) only the SIP channel driver chan_sip supports this. All other channels drivers like res_pjsip fail. In case of failure, the original sRTP source code released the whole channel, even if not hung-up, yet. This change does not release the channel but instead hangs-up the channel. ASTERISK-26306 Change-Id: I0489f0cb660fab6673b0db8af027d116e70a66db	10 years ago
Richard Mudgett	88e9d05ef7	ast_framehook_attach() must be called with the channel locked. ... The framehook container could become corrupted if the channel lock is not held before calling. Change-Id: I1a6b957a1f7b899eb29a186915f8cccab886a438	10 years ago
Corey Farrell	cb8fd610e2	Fix checks for allocation debugging. ... MALLOC_DEBUG should not be used to check if debugging is actually enabled, __AST_DEBUG_MALLOC should be used instead. MALLOC_DEBUG only indicates that debugging is requested, __AST_DEBUG_MALLOC indicates it is active. Change-Id: I3ce9cdb6ec91b74ee1302941328462231be1ea53	10 years ago
Torrey Searle	6f448f32fe	res_ari: Add http prefix to generated docs ... updated the uri handler to include the url prefix of the http server this enables res_ari to add it to the uris when generating docs Change-Id: I279335a2625261a8492206c37219698f42591c2e	10 years ago
zuul	455bc78901	Merge "Refactor usage pattern of xmldoc info tag." into 13	10 years ago
Joshua Colp	d85310e3e8	Merge "sorcery.c: Minor optimizations." into 13	10 years ago
zuul	7ed9bc8169	Merge "sorcery.c: Tweak some container declaration formatting." into 13	10 years ago
zuul	050b90769a	Merge "core: Entity ID is not set or invalid" into 13	10 years ago
zuul	6c4c31456f	Merge "pbx.c: Additional fixes to ast_context_remove_extension_callerid2." into 13	10 years ago