5443 Commits (494bebeb6f362666150493580154fd0c6bc38c16)

Author	SHA1	Message	Date
Alexander Traud	3938e3320f	cli: Auto-complete File not Module for core set debug. ... Since Asterisk 1.8, the command "core set debug" on the command-line interface asks not for a file (.c) but a module name. This change shows modules (.so) on the auto-completion via a tabulator or the question mark. Now, when you partially type a module name, TAB or ?, you get the correct candidiates. ASTERISK-26480 Change-Id: I1213f1dd409bd4ff8de08ad80cb0c73cafb1bae0	9 years ago
Joshua Colp	839766f5e1	Merge "Audit ast_json_pack() calls for needed UTF-8 checks." into 14	9 years ago
Joshua Colp	465ba82ea2	Merge "json: Check party id name, number, subaddresses for UTF-8." into 14	9 years ago
Joshua Colp	6d5e11dc91	Merge "json: Add UTF-8 check call." into 14	9 years ago
Richard Mudgett	aba27b5a60	Audit ast_json_pack() calls for needed UTF-8 checks. ... Added needed UTF-8 checks before constructing json objects in various files for strings obtained outside the system. In this case string values from a channel driver's peer and not from the user setting channel variables. * aoc.c: Fixed type mismatch in s_to_json() for time and granularity json object construction. ASTERISK-26466 Reported by: Richard Mudgett Change-Id: Iac2d867fa598daba5c5dbc619b5464625a7f2096	9 years ago
Richard Mudgett	beae5022bf	json: Check party id name, number, subaddresses for UTF-8. ... * Updated unit test as ast_json_name_number() is now NULL tolerant. ASTERISK-26466 #close Reported by: Richard Mudgett Change-Id: I7d4e14194f8f81f24a1dc34d1b8602c0950265a6	9 years ago
Richard Mudgett	2433a9d0c0	json: Add UTF-8 check call. ... Since the json library does not make the check function public we recreate/copy the function in our interface module. ASTERISK-26466 Reported by: Richard Mudgett Change-Id: I36d3d750b6f5f1a110bc69ea92b435ecdeeb2a99	9 years ago
Richard Mudgett	b288b8b997	aoc.c: Whitespace cleanup ... * In s_to_json() removed unnecessary ast_json_ref() to ast_json_null() when creating the type json object. The ref is a noop. Change-Id: I2be8b836876fc2e34a27c161f8b1c53b58a3889a	9 years ago
zuul	357134fef1	Merge "audiohooks: Remove redundant codec translations when using audiohooks" into 14	9 years ago
zuul	dd6d6a55fe	Merge "astobj2: Add backtrace to log_bad_ao2." into 14	9 years ago
Michael Walton	4cf2d9f261	audiohooks: Remove redundant codec translations when using audiohooks ... The main frame read and write handlers in main/channel.c don't use the optimum placement in the processing flow for calling audiohooks callbacks, as far as codec translation is concerned. This change places the audiohooks callback code: * After the channel read translation if the frame is not linear before the translation, thereby increasing the chance that the frame is linear as required by audiohooks * Before the channel write translation if the frame is linear at this point This prevents the audiohooks code from instantiating additional translation paths to/from linear where a linear frame format is already available, saving valuable CPU cycles ASTERISK-26419 Change-Id: I6edd5771f0740e758e7eb42558b953f046c01f8f	9 years ago
Corey Farrell	2f2ef9b8a6	logger: Prevent output of verbose messages initiated from rasterisk. ... Remote asterisk consoles should only display verbose log messages created by the daemon. The first patch for ASTERISK-26410 caused a couple verbose messages to be printed when the rasterisk process ended. ASTERISK-26410 Change-Id: Ie2a1bb3753ad2724c0349ec1a336f52f7117b52a	9 years ago
Corey Farrell	d236973657	astobj2: Add backtrace to log_bad_ao2. ... * Compile __ast_assert_failed unconditionally. * Use __ast_assert_failed to log messages from log_bad_ao2 * Remove calls to ast_assert(0) that happen after log_bad_ao2 was run. Change-Id: I48f1af44b2718ad74a421ff75cb6397b924a9751	9 years ago
Corey Farrell	013414ca4b	logger: Output early verbose messages to console. ... Verbose messages should be printed to the console if the sublevel is less than option_verbose. This fix ensures the welcome message with copyright and license are printed at daemon and interactive rasterisk startup. ASTERISK-26410 #close Change-Id: Ia44235e30ec328aba92ea2c8a837b094e65c9a03	9 years ago
George Joseph	d64edafa63	chan_sip: Address runaway when realtime peers subscribe to mailboxes ... Users upgrading from asterisk 13.5 to a later version and who use realtime with peers that have mailboxes were experiencing runaway situations that manifested as a continuous stream of taskprocessor congestion errors, memory leaks and an unresponsive chan_sip. A related issue was that setting rtcachefriends=no NEVER worked in asterisk 13 (since the move to stasis). In 13.5 and earlier, when a peer tried to register, all of the stasis threads would block and chan_sip would again become unresponsive. After 13.5, the runaway would happen. There were a number of causes... * mwi_event_cb was (indirectly) calling build_peer even though calls to mwi_event_cb are often caused by build_peer. * In an effort to prevent chan_sip from being unloaded while messages were still in flight, destroy_mailboxes was calling stasis_unsubscribe_and_join but in some cases waited forever for the final message. * add_peer_mailboxes wasn't properly marking the existing mailboxes on a peer as "keep" so build_peer would always delete them all. * add_peer_mwi_subs was unsubscribing existing mailbox subscriptions then just creating them again. All of this was causing a flood of subscribes and unsubscribes on multiple threads all for the same peer and mailbox. Fixes... * add_peer_mailboxes now marks mailboxes correctly and build_peer only deletes the ones that really are no longer needed by the peer. * add_peer_mwi_subs now only adds subscriptions marked as "new" instead of unsubscribing and resubscribing everything. It also adds the peer object's address to the mailbox instead of its name to the subscription userdata so mwi_event_cb doesn't have to call build_peer. With these changes, with rtcachefriends=yes (the most common setting), there are no leaks, locks, loops or crashes at shutdown. rtcachefriends=no still causes leaks but at least it doesn't lock, loop or crash. Since making rtcachefriends=no work wasnt in scope for this issue, further work will have to be deferred to a separate patch. Side fixes... * The ast_lock_track structure had a member named "thread" which gdb doesn't like since it conflicts with it's "thread" command. That member was renamed to "thread_id". ASTERISK-25468 #close Change-Id: I07519ef7f092629e1e844f855abd279d6475cdd0	9 years ago
zuul	d4422a2253	Merge "core: Ensure presencestate subtype and message are NULL." into 14	9 years ago
zuul	c526e3d94c	Merge "logger: Simplify ast_callid handling code." into 14	9 years ago
Joshua Colp	64df75b02c	core: Ensure presencestate subtype and message are NULL. ... When retrieving presence state information there is no guarantee that the subtype and message passed in are set to NULL. This change ensures they are. ASTERISK-26397 #close Change-Id: If38cd730e409e9a9b6eb9adef6591d15a9e61f86	9 years ago
zuul	79070e486d	Merge "logger: Always enable verbose for console channel." into 14	9 years ago
zuul	6b8de13946	Merge "logger: Fix default console settings." into 14	9 years ago
zuul	5325e7a500	Merge "core: Fix LOW_MEMORY missing symbol ast_pbx_uuid_get." into 14	9 years ago
zuul	7f8d570c8d	Merge "asterisk.c: Non-root users also get the astcanary after core restart." into 14	9 years ago
Corey Farrell	ba3269f12b	core: Fix LOW_MEMORY missing symbol ast_pbx_uuid_get. ... Move the function outside the conditional block that excludes LOW_MEMORY. ASTERISK-26273 #close Change-Id: Ic290fa128222c410c3531107e30efacabc8493b4	9 years ago
zuul	381cafe335	Merge "sd_notify (systemd status notifications) support" into 14	9 years ago
Corey Farrell	1a7d39818f	logger: Simplify ast_callid handling code. ... Routines responsible for managing ast_callid's are overly complicated. This is left-over code from when ast_callid was an AO2 object. Now that it is an integer the code can be reduced. ast_callid handler code no longer prints it's own error message upon failure to allocate threadstorage as ast_calloc would have already printed a message. Debug messages that were printed when TEST_FRAMEWORK was enabled have been also been removed. Change-Id: I65a768a78dc6cf3cfa071e97f33ce3dce280258e	9 years ago
Corey Farrell	1b61a21757	logger: Always enable verbose for console channel. ... Previous versions of Asterisk did not require verbose to be specified in logger.conf for the console channel, if it was requested by command line or asterisk.conf it just worked. This change causes Asterisk to always enable verbose in the console channel level mask. Verbose is displayed on consoles if requested by command line, option_verbose or 'core set verbose'. This also delays initialization of the logger until after threadstorage is initialized. Initializing too early can cause messages to be printed multiple times to the console (stdout). ASTERISK-26391 #close Change-Id: I52187d67c2fcb3efd5561bf04b3e5e23e5ee8a04	9 years ago
Corey Farrell	68ff7362ae	logger: Fix default console settings. ... When logger.conf is missing or invalid we should be printing notices, warnings and errors to the console. The logmask was incorrectly calculated. Change-Id: Ibaa9465a8682854bc1a5e9ba07079bea1bfb6bb3	9 years ago
zuul	5205b0196b	Merge "rtp: Only accept the first payload for a format in SDP." into 14	9 years ago
Tzafrir Cohen	29e096cd13	sd_notify (systemd status notifications) support ... sd_notify() is used to notify systemd of changes to the status of the process. This allows the systemd daemon to know when the process finished loading (and thus only start another program after Asterisk has finished loading). To use this, use a systemd unit with 'Type=notify' for Asterisk. This commit also adds the function ast_sd_notify(), a wrapper around sd_notify that does nothing if not built with systemd support. Also adds support for libsystemd detection in the configure script. Change-Id: Ied6a59dafd5ef331c5c7ae8f3ccd2dfc94be7811 (cherry picked from commit 07b95f7c65)	9 years ago
Walter Doekes	2b75559e6c	asterisk.c: Non-root users also get the astcanary after core restart. ... Without this change, a 'core restart' would kill the astcanary forever if you're not running as root. Both with and without this patch, the scheduling priority was still SCHED_RR after restart. Additionally, the astcanary is now spawned if you start with high priority and Asterisk doesn't get a chance to lower it. For example through: `chrt -r 10 sudo -u asterisk asterisk -c` Also reap killed astcanary processes on core restart. ASTERISK-26352 #close Change-Id: Iacb49f26491a0717084ad46ed96b0bea5f627a55	9 years ago
zuul	b56717b396	Merge "asterisk.c: When astcanary dies on linux, reset priority on all threads." into 14	9 years ago
Walter Doekes	bd39d2c0ab	asterisk.c: When astcanary dies on linux, reset priority on all threads. ... Previously only the canary checking thread itself had its priority set to SCHED_OTHER. Now all threads are traversed and adjusted. ASTERISK-19867 #close Reported by: Xavier Hienne Change-Id: Ie0dd02a3ec42f66a78303e9c1aac28f7ed9aae39	9 years ago
Timo Teräs	1e9ae453fd	Fix showing of swap details when sysinfo() is available ... If sysinfo() is available, but not sysctl() or swapctl() the printing code for swap buffer sizes is incorrectly omitted. The above condition happens with musl c-library. Fix #if rule to consider defined(HAVE_SYSINFO). And also remove the redundant || defined(HAVE_SYSCTL) which was incorrectly there to start with. Now swap information is displayed only if an actual libc function to get it is available. This also fixes warnings previously seen with musl libc: [CC] asterisk.c -> asterisk.o asterisk.c: In function 'handle_show_sysinfo': asterisk.c:773:6: warning: variable 'totalswap' set but not used [-Wunused-but-set-variable] int totalswap = 0; ^~~~~~~~~ asterisk.c:770:11: warning: variable 'freeswap' set but not used [-Wunused-but-set-variable] uint64_t freeswap = 0; ^~~~~~~~ Change-Id: I1fb21dad8f27e416c60f138c6f2bff03fb626eca	9 years ago
Joshua Colp	696824df89	rtp: Only accept the first payload for a format in SDP. ... When receiving an SDP offer with multiple payloads for the same format we would generate an answer with the first payload, but during the payload crossover operation (to set the payloads for receiving) we would remove all payloads but the last. This would result in incoming traffic being matched against the wrong format and outgoing traffic being sent using the wrong payload. This change makes it so that once a format has a payload number put into the mapping all subsequent ones are ignored. This ensures there is only ever one payload in the mapping and that it is the payload placed into the answer SDP. ASTERISK-26365 #close Change-Id: I1e8150860a3518cab36d00b1fab50f9352b64e60	9 years ago
Joshua Colp	34e82d16b4	rtp: Preserve timestamps on video frames. ... Currently when receiving video over RTP we store only a calculated samples on the frame. When starting the video it can take some time for this calculation to actually yield a value as it requires constant changing timestamps. As well if a video frame passes over multiple RTP packets this calculation will fail as the timestamp is the same as the previous RTP packet and the number of samples calculated will be 0. This change preserves the timestamp on the frame and allows it to pass through the core. When sending the video this timestamp is used instead of a new one being calculated. ASTERISK-26367 #close Change-Id: Iba8179fb5c14c9443aee4baf670d2185da3ecfbd	9 years ago
Joshua Colp	e455036e9e	Merge "sorcery: Create function ast_sorcery_lockable_alloc." into 14	9 years ago
Joshua Colp	dec772d46c	Merge "named_locks: Use ao2_weakproxy to deal with cleanup from container." into 14	9 years ago
Joshua Colp	ddd6c810a9	Merge "astobj2: Support using a separate object for locking." into 14	9 years ago
Richard Mudgett	2a8d27e020	format_cap.c: Fix CLI "core show channeltype Surrogate" crash. ... * Make ast_format_cap_get_names() NULL tolerant. ASTERISK-26331 #close Reported by: CGI.NET Change-Id: Id67e93936dc8ec2a33a9d33655843d43b59285a3	9 years ago
Corey Farrell	e65f170d9c	sorcery: Create function ast_sorcery_lockable_alloc. ... Create an alternative to ast_sorcery_generic_alloc which uses astobj2 shared locking. Use this new method for the 'struct ast_sip_aor' allocator. Change-Id: I3f62f2ada64b622571950278fbb6ad57395b5d6f	9 years ago
Corey Farrell	3af3860151	named_locks: Use ao2_weakproxy to deal with cleanup from container. ... This allows standard ao2 functions to be used to release references to an ast_named_lock. This change can cause less frequent locking of the global named_locks container. The container is no longer locked when a named_lock reference is being release except when this causes the named_lock to be destroyed. Change-Id: I644e39c6d83a153d71b3fae77ec05599d725e7e6	9 years ago
Corey Farrell	e260e507f2	astobj2: Support using a separate object for locking. ... Create ao2_alloc_with_lockobj function to support shared locking. Change-Id: Iba687eb9843922be7e481e23a32c0700ecf88a80	9 years ago
Etienne Lessard	f9dc20b8cb	pbx.c: Prevent infinite recursion in manager_show_dialplan_helper. ... Previously, if context A was including context B and context B was including context A, i.e. if there was a circular dependency between contexts, then calling manager_show_dialplan_helper could lead to an infinite recursion, resulting in a crash. This commit applies the same solution as the one implemented in the show_dialplan_helper function. The manager_show_dialplan_helper and show_dialplan_helper functions contain lots of code in common, but the former was missing the "infinite recursion avoidance" code. ASTERISK-26226 #close Change-Id: I1aea85133c21787226f4f8442253a93000aa0897	9 years ago
zuul	4a2371f1cd	Merge "channel: No hung-up on failing security requirements." into 14	9 years ago
Alexander Traud	1d2d4e2ae9	channel: No hung-up on failing security requirements. ... In your Diaplan, if you specify same => n,Set(CHANNEL(secure_bridge_media)=1) same => n,Set(CHANNEL(secure_bridge_signaling)=1) only the SIP channel driver chan_sip supports this. All other channels drivers like res_pjsip fail. In case of failure, the original sRTP source code released the whole channel, even if not hung-up, yet. This change does not release the channel but instead hangs-up the channel. ASTERISK-26306 Change-Id: I0489f0cb660fab6673b0db8af027d116e70a66db	9 years ago
Richard Mudgett	fc859dfee9	ast_framehook_attach() must be called with the channel locked. ... The framehook container could become corrupted if the channel lock is not held before calling. Change-Id: I1a6b957a1f7b899eb29a186915f8cccab886a438	9 years ago
Corey Farrell	a8b3d8d7f9	Fix checks for allocation debugging. ... MALLOC_DEBUG should not be used to check if debugging is actually enabled, __AST_DEBUG_MALLOC should be used instead. MALLOC_DEBUG only indicates that debugging is requested, __AST_DEBUG_MALLOC indicates it is active. Change-Id: I3ce9cdb6ec91b74ee1302941328462231be1ea53	9 years ago
Torrey Searle	1466737dbc	res_ari: Add http prefix to generated docs ... updated the uri handler to include the url prefix of the http server this enables res_ari to add it to the uris when generating docs Change-Id: I279335a2625261a8492206c37219698f42591c2e (cherry picked from commit 6f448f32fe)	9 years ago
Corey Farrell	ba91710bc4	Refactor usage pattern of xmldoc info tag. ... This updates func_channel.c and main/message.c to use a generic xpointer include instead of including info from each channel driver. Now the name attribute of info is CHANNEL or CHANNEL_EXAMPLES to be included in documentation for func_channel. Setting the name attribute of info to MessageToInfo or MessageFromInfo causes it to be included in the MessageSend application and AMI action. Change-Id: I89fd8276a3250824241a618009714267d3a8d1ea	9 years ago
zuul	72b102bab8	Merge "core: Entity ID is not set or invalid" into 14	9 years ago