Joshua Colp
51fc74da59
Use ast_strlen_zero to see if the language and/or context argument is not present for Background instead of just checking if it is NULL. (issue #9141 reported by mjagdis)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@56805 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
693cdc775e
Allow both of the show version files and core show file versions CLI commands to work. (issue #9135 reported by mvanbaak)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@56783 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Tilghman Lesher
185d7f5a3a
Merged revisions 56684 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r56684 | tilghman | 2007-02-25 08:38:03 -0600 (Sun, 25 Feb 2007) | 3 lines
Issue 9130 - If prev is the last item on the channel list, then evaluating
additional conditions (e.g. name prefix) will cause a NULL dereference.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@56685 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Russell Bryant
2020191f67
Merged revisions 56504 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r56504 | russell | 2007-02-23 17:20:55 -0600 (Fri, 23 Feb 2007) | 8 lines
Fix up a couple more signal handlers to not do bad things that could cause
various undesirable results. The other day, I made Asterisk deadlock by
hitting Control-C because of a bad signal handler. Now, signal handlers
just set a flag and write to an alert pipe for the flag to be handled. Then,
there is another thread that is monitoring for these flags. If being run in
console mode, it is just the main thread. If Asterisk is in the background,
a thread is created to do it.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@56505 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
40712e5eaf
Change log notice to debug. It is possible for a scheduled item to execute and be deleted at close to the same time and unavoidable. If this happens this message creeps up.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@56457 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Russell Bryant
f314685447
Merge changes from team/russell/sla_updates.
...
This batch of changes to the SLA code does a few different things.
* I made the SLA code event driven instead of having to act in a lot of busy
loops while dialing things to wait for state changes. This makes the code
more efficient and readable at the same time.
* I have implemented a couple of new features. The first is inbound trunk
ringing timeouts. This is an option that defines how long to let an incoming
call on a trunk to ring.
* I have also implemented ring timeouts for stations. They may be specified
for the entire station, meaning it is how long to let the station ring before
giving up. You can also specify a ring timeout for a specific trunk on a
station. So, you can say that you only want a specific station to ring 5
seconds if it is line1 ringing, but otherwise, there is no timeout.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@56277 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
4565c1483c
Merged revisions 56230 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r56230 | file | 2007-02-22 13:44:24 -0500 (Thu, 22 Feb 2007) | 2 lines
Only change the original or clone channel if it's the channel behind the proxy channel, not if it's just a regular bridged channel.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@56231 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
58ce1edf27
Print out deprecation notice on usage output of CLI commands. (issue #8925 reported by blitzrage)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@56008 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Kevin P. Fleming
26bb928cfc
disable unloading of embedded modules... there is a fundamental problem with doing so that will not be fixed in this version of Asterisk due to its invasiveness
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@56006 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Russell Bryant
cb03702de9
Add the Asterisk version information to the Server header in HTTP
...
responses. (requested by Pari)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@55634 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Jason Parker
84d057c5a5
Clarify a restart message. It's silly, but the reporter had a very valid point.
...
Issue 9079
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@54886 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
7d029cabf6
Add G722 to ast_best_codec. If anyone disagrees with it's placement, feel free to change it. (issue #9045 reported by gork)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@54290 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Russell Bryant
913948066e
Change ast_set_state_callback() to ast_dial_set_state_callback()
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@54103 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Russell Bryant
5bc6ee1714
- Add the ability to register a callback to monitor state changes in an
...
asynchronous dial operation.
- Rename the various references to "status" to "state" in the dial API
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@54066 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Paul Cadach
3a68e31940
Provide correct DTMF duration
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@53879 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Paul Cadach
39d6429a35
Bring deprecated 'debug channel <x|all>' command back
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@53878 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Russell Bryant
7ee02f585d
Merge team/russell/sla_rewrite
...
This is a completely new implementation of the SLA functionality introduced in
Asterisk 1.4. It is now functional and ready for testing. However, I will be
adding some additional features over the next week, as well.
For information on how to set this up, see configs/sla.conf.sample
and doc/sla.txt.
In addition to the changes in app_meetme.c for the SLA implementation itself,
this merge brings in various other changes:
chan_sip:
- Add the ability to indicate HOLD state in NOTIFY messages.
- Queue HOLD and UNHOLD control frames even if the channel is not bridged to
another channel.
linkedlists.h:
- Add support for rwlock based linked lists.
dial.c:
- Add the ability to run ast_dial_start() without a reference channel to
inherit information from.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@53810 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Olle Johansson
89a3a01d0b
Don't output debug unless we asked for it
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@53672 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Tilghman Lesher
ce2414804c
Issue 9007 - Mutex not released on early return
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@53532 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Russell Bryant
2620b515a7
When building libdb1.a, put the additional flags needed at the beginning of
...
ASTCFLAGS, instead of at the end. This way, we ensure that we find the local
headers first before accidentally trying to use headers that exist in
locations specified in the ASTCFLAGS passed from the main Makefile.
(issue #8637 , ovi)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@53497 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Russell Bryant
2b39ea96f0
The clean target actually needs to run "distclean" on editline. This is
...
because we need to make sure that its configure script gets executed again,
because the CFLAGS we want to pass to editline may have changed.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@53464 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
204b58a23c
We can not reliably do P2P bridging with DTMF passing back with compensation if we need to listen for DTMF frames. (issue #8962 reported by caio1982)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@53434 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Russell Bryant
2b5990387c
When parsing the NTP timestamp in a sender report message, you are supposed to
...
take the low 16 bits of the integer part, and the high 16 bits of the
fractional part. However, the code here was erroneously taking the low 16 bits
of the fractional part. It then shifted the result 16 bits down, so the result
was always zero. This fix makes it grab the appropriate high 16 bits, instead.
(issue #8991 , pointed out by andre_abrantes)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@53429 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Tilghman Lesher
f2decd2446
Merged revisions 53245 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r53245 | tilghman | 2007-02-06 00:58:28 -0600 (Tue, 06 Feb 2007) | 2 lines
Issue 8987 - Status could return two responses (mnicholson)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@53246 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
f0329105f3
Correct a copy/pasted error message line for RTCP.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@53120 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
089486cfcf
Merged revisions 53117 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r53117 | file | 2007-02-02 10:58:09 -0600 (Fri, 02 Feb 2007) | 2 lines
Pass the glob expanded filename to process_text_line so that error messages contain the actual filename, not the original include one. (issue #8959 reported by tzafrir)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@53118 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
ffe220faa5
Huh... fix the berkeley DB to compile here as well, but it apparently required both dev mode and no optimizations to creep up.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@53099 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
9e90d55a78
Add missing 'F' letter to getopt so it magically becomes a valid option. (issue #8960 reported by tzafrir)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@53072 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Tilghman Lesher
7e0a469bda
Merged revisions 53069 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r53069 | tilghman | 2007-02-01 13:13:53 -0600 (Thu, 01 Feb 2007) | 2 lines
No wonder FIELDQTY doesn't work with functions... the documentation in pbx.c was wrong
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@53070 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
28dacda047
When going on hold have the side that was put on hold reinvite back to Asterisk. When going off hold have the side that was taken off hold reinvited back to the other party.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@53052 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
7229c2ba48
Add more frame types to forward in the RTP bridge loops.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@53050 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Russell Bryant
9aab046002
Merged revisions 53045 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r53045 | russell | 2007-01-31 15:25:11 -0600 (Wed, 31 Jan 2007) | 3 lines
Fix a bunch of places where pthread_attr_init() was called, but
pthread_attr_destroy() was not.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@53046 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Russell Bryant
0bc7ef3b06
Merged revisions 53039 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r53039 | russell | 2007-01-31 11:41:51 -0600 (Wed, 31 Jan 2007) | 3 lines
Use the proper format string to print unsigned values in the rtp debug output.
(issue #8954 , wmis)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@53040 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Russell Bryant
083a9198ea
Merged revisions 52903 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r52903 | russell | 2007-01-30 11:12:04 -0600 (Tue, 30 Jan 2007) | 9 lines
The SIGHUP handler was implemented to allow admins to send SIGHUP to a running
Asterisk process to reload the configuration. However, doing the actual reload
in the signal handler itself is a very bad thing to do, because the reload
process includes calling non-reentrant functions such as malloc/calloc/etc.
If Asterisk is running in the background, then the reload will happen
immediately. However, if running in console mode, the reload doesn't work
until something is typed at the console. That sort of defeats the purpose,
but I don't see an easy way to get around it at this point.
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@52904 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Russell Bryant
4bc823f540
Add a missing quotation mark. This was pointed out by jcmoore on #asterisk-dev.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@52695 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Russell Bryant
771be23a9c
Remove a recursive lock of the manager session. This was pointed out by
...
zandbelt in issue #8711 .
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@52688 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Russell Bryant
108085ed2d
ASTLDFLAGS needs to be passed to the editline configure script as LDFLAGS.
...
(issue #8928 , zandbelt)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@52647 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Russell Bryant
06a3110ed8
Fix a problem with packet-to-packet bridging and DTMF mode translation. P2P
...
bridging can only be used when the DTMF modes don't match if the core is
monitoring DTMF in both directions. Then, the core will handle the translation.
Otherwise, this bridging method can not be used.
(issue #8936 )
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@52645 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Russell Bryant
ce753cf0d9
The session lock can not be held while calling action callbacks. If so, then
...
when the WaitEvent callback gets called, then no event can happen because the
session can't be locked by another thread. Also, the session needs to be
locked in the HTTP callback when it reads out the output string. This fixes
the deadlock reported in both 8711 and 8934.
Regarding issue 8711, there still may be an issue. If there is a second action
requested before the processing of the first action is finished, there could
still be some corruption of the output string buffer used to build the result.
(issue #8711 , #8934 )
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@52611 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Steve Murphy
f2fab700c3
this is for 8778 (pt_BR backport to 1.4). It was committed to trunk via 7663. But it wasn't so much an enhancement as a fix for the bad language output for portuguese in Brazil, so, after a lot of prodding from patient Brazilians, here is the same fix for 1.4
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@52535 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Russell Bryant
824bed6260
Clean up a few things in the last commit to the adaptive jitterbuffer code.
...
- Specifically indicate to the compiler that the "dropem" variable only
needs one but.
- Change formatting to conform to coding guidelines.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@52506 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Jim Dixon
2132e4f865
Fixed problem with jitterbuf, whereas it would not complain about, and
...
would allow itself to be overfilled (per the max_jitterbuf parameter). Now
it rejects any data over and above that size, and complains about it.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@52494 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
9c289fe01b
Have the manager interface send back an "Already logged in" message instead of "Invalid/Unknown Command" when the client authenticates for a second time. (issue #8509 reported by pari)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@52373 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
bc43c82f05
Fix core show file formats CLI command.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@52335 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
3b44625323
Merged revisions 52264 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r52264 | file | 2007-01-25 14:15:29 -0500 (Thu, 25 Jan 2007) | 2 lines
Allow dequeueing of frames with negative timestamp by moving jitterbuffer frames check to jb_next. (issue #8546 reported by harmen)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@52265 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
8acccb9254
Merge in dialing API and the app_page that uses it. (issue #BE-118)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@52049 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Russell Bryant
9440d428a0
Merged revisions 51843 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r51843 | russell | 2007-01-23 18:57:28 -0600 (Tue, 23 Jan 2007) | 6 lines
Fix an issue related to synchronization of recordings when using Monitor().
The bug is a miscalculation of the amount to seek the stream for writing to
disk when the number of samples coming in and out of a channel do not match up.
(issue #8298 , #8887 , report and patch by guillecabeza, patch files created and
testing done by whoiswes)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51848 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Russell Bryant
2a37a53c57
Fix some bugs in process_message(). The manager session lock needs to be held
...
when sending some sort of response, or calling one of the manager action
callbacks. This resolves an issue where people using the GUI would get random
crashes when they start clicking around a lot.
(issue #8711 , reported and debugged by zandbelt)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51781 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Russell Bryant
86f8e0a527
Fix setting the default port of 8088 on 64-bit or big-endian machines.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51755 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Russell Bryant
3d5e9fa43c
When traversing the list of manager actions, the iterator needs to be
...
initialized to the list head *after* locking the list. Also, lock the actions
list in one place it is being accessed where it was not being done.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51750 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Steve Murphy
ec2c64c81b
via 8748 (callerid.c loses name when returning PRIVATE_NUMBER flag), the user suggested this mod, saying it would allow 'WITHHELD' to appear in the name field, which would be useful
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51683 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Russell Bryant
33235b40d6
Merge the changes from the /team/group/vldtmf_fixup branch.
...
The main bug being addressed here is a problem introduced when two SIP
channels using SIP INFO dtmf have their media directly bridged. So, when a
DTMF END frame comes into Asterisk from an incoming INFO message, Asterisk
would try to emulate a digit of some length by first sending a DTMF BEGIN
frame and sending a DTMF END later timed off of incoming audio. However,
since there was no audio coming in, the DTMF_END was never generated. This
caused DTMF based features to no longer work.
To fix this, the core now knows when a channel doesn't care about DTMF BEGIN
frames (such as a SIP channel sending INFO dtmf). If this is the case, then
Asterisk will not emulate a digit of some length, and will instead just pass
through the single DTMF END event.
Channel drivers also now get passed the length of the digit to their digit_end
callback. This improves SIP INFO support even further by enabling us to put
the real digit duration in the INFO message instead of a hard coded 250ms.
Also, for an incoming INFO message, the duration is read from the frame and
passed into the core instead of just getting ignored.
(issue #8597 , maybe others...)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51311 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Russell Bryant
879a71e921
Merged revisions 51300 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r51300 | russell | 2007-01-19 10:44:09 -0600 (Fri, 19 Jan 2007) | 4 lines
Fix a memory leak on command line tab completion. The container for the
matches was freed, but the individual matches themselves were not.
(issue #8851 , arkadia)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51302 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Jason Parker
76eb4e76dc
Add some more checks for option_debug before ast_log(LOG_DEBUG, ...) calls.
...
Issue 8832, patch(es) by tgrman
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51265 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Russell Bryant
eedd121fbc
Ensure that the locations given to the Asterisk configure script for ncurses,
...
curses, termcap, or tinfo are further passed along to the editline configure
script. This fixes some cross-compilation environments.
(issue #8637 , reported by ovi, patch by me)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51262 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Tilghman Lesher
8d59d5173a
Merged revisions 51255 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r51255 | tilghman | 2007-01-18 15:11:34 -0600 (Thu, 18 Jan 2007) | 2 lines
If a timezone is not specified, assume localtime (instead of gmtime) (Issue #7748 )
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51256 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Jason Parker
65565ac74d
Fix an issue with file name completion in "module load" and "load".
...
Issue 8846
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51245 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Jason Parker
eab59cabdb
Fix an issue with deprecated commands
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51241 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Russell Bryant
c5a3194042
Make the "hasmanager" option in users.conf actually have an effect.
...
(issue #8740 , LnxPrgr3)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51233 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
9461aa0027
Pass data as well for hold/unhold/vidupdate frames. (issue #8840 reported by mdu113)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51211 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Tilghman Lesher
0baf4aa941
Merged revisions 51194 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r51194 | tilghman | 2007-01-17 14:52:21 -0600 (Wed, 17 Jan 2007) | 4 lines
When ast_strip_quoted was called with a zero-length string, it would treat a
NULL as if it were the quoting character (and would thus return the string
in memory immediately following the passed-in string).
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51195 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
9f0ad6093e
Return the correct result when directly writing out a packet so that the core doesn't then decide to handle it the regular way again. (issue #8833 reported by rcourtna)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51182 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Jason Parker
1825fc3ee2
Fix issue with dtmf continuation packets when the dtmf digit is 0...
...
Issue 8831
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51170 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Jason Parker
897e4b5eaa
Display more useful output when streaming files.
...
Include the channel name to which the file is being played.
Issue 8828, patch by junky.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51146 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Russell Bryant
de14e3d549
It is possible for the config pointer to be NULL here, so it needs to be
...
checked before dereferencing it.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@51057 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Jason Parker
9d49164921
re-add deprecated "show version" CLI command.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@50921 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
caa099357b
Move event processing into do_message so that it gets executed again when events are tripped.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@50895 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Kevin P. Fleming
dd357a71a7
use the ACX_PTHREAD macro from the Autoconf macro archive for setting up compiler pthreads support... should improve portability to platforms with unusual pthreads requirements
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@50867 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
50f951764f
Add missing newlines for two memory CLI commands.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@50820 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Tilghman Lesher
3fb08d4e9d
Merged revisions 50781 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r50781 | tilghman | 2007-01-13 23:01:16 -0600 (Sat, 13 Jan 2007) | 2 lines
Bug 8814 - db should look for its header using a relative path, instead of the system path (Fixes FreeWRT)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@50782 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
e4de85c4f5
Only write a frame out to the channel if one exists. There are cases where one may not and would therefore cause the channel driver to segfault. (issue #8434 reported by slimey)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@50727 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
5fe88c5f88
We need to check for res being 0 in do_message itself, otherwise our headers will get lost.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@50602 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Kevin P. Fleming
34b5a7c8ae
Merged revisions 50561 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r50561 | kpfleming | 2007-01-12 08:34:15 -0600 (Fri, 12 Jan 2007) | 2 lines
minor documentation clarification
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@50562 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
240ca25bea
Add support to see whether NAT was detected (yay symmetric RTP) and also add a check in chan_sip so that if NAT has been detected and the reinvite behind nat option has been turned off, then just do partial bridge. (issue #8655 reported by mnicholson)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@50466 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
c4d1757329
Fix parsing when using something like ldap settings. (done by anthonyl)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@50405 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
59432b9e21
Ensure data's existence before trying to access it. (issue #8774 reported by rcourtna)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@50266 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Jason Parker
281b1a890c
Re-add CLI command that should have only been deprecated in 1.4.
...
Thanks kshumard! (reported in person, so no associated issue #)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@50186 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
46700b62af
Disable the more intense packet2packet bridging until the bugs can be worked out.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@50032 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Jason Parker
9e621e99a5
Save 1 whopping byte of allocated memory!
...
This looks like it may have been a chicken/egg scenario..
You had to call a cleanup func, because everything was allocated.
Then since you had to call a cleanup func, you were forced to allocate - ie; strdup("").
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49742 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Kevin P. Fleming
d2d50d7a8e
ast_func_read() needs a writable copy of the function name to be passed
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49710 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Kevin P. Fleming
c56f17425c
don't 'consume' the params list before we try to use it again
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49680 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Kevin P. Fleming
444adcb477
reduce stack consumption for AMI and AMI/HTTP requests by nearly 20K in most cases
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49676 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
ac75028a50
Don't keep repeating the warning over and over when the end of the call is reached. (issue #8724 reported by xrg)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49675 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Kevin P. Fleming
46d91e71c5
add support for tracking thread-local-storage objects that exist via 'threadstorage' CLI commands
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49553 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
3d460e5a68
Only free comments and line buffer once we reach the first level. (issue #8678 reported by ssokol, fixed by anthonyl)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49551 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Kevin P. Fleming
24bb7d865e
don't mark these allocations as 'cache' allocations when caching has been disabled
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49536 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Kevin P. Fleming
fa5de60c6e
don't do frame header caching in the core if LOW_MEMORY is defined
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49461 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Steve Murphy
49cce60e51
This is a slight modification to Josh's edits for #8579 ; both files edited were the produced by flex; so the source files need to be changed instead, and the generated files regenerated.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49237 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Jason Parker
0b50088366
Allow fractions of a second in the Wait() application, like it says it allows.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49189 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
156a6cf5db
If the Packet2Packet bridge is being broken because of a masquerade then attempt to read a frame in so the masquerade actually happens. Otherwise weirdness will occur. (issue #8696 reported by kjotte)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49066 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Jason Parker
52fb756adc
Fix some deprecated commands.
...
Issue 8682, patch by me
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49035 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Jason Parker
c38c990bc7
saw this in passing... fix a small typo
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49032 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Jason Parker
c2f688d2fd
make the uris_lock a rwlock instead of a mutex lock - needs to be forward ported to trunk
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49024 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Steve Murphy
4d6a91eef0
removed <err.h> as in trunk from the ael stuff. Also, threw in a minor fix to frame.c to avoid build-killing compiler warnings.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49020 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
6d582d75c7
ast_copy_string is not available when LOW_MEMORY is used and things are being built in the utils directory, so we need to resort to the old method of strncpy. (issue #8579 reported by mottano)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49009 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Kevin P. Fleming
a299485952
since these variables all have static duration, none of them need initializers (they default to zero anyway)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@49006 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Kevin P. Fleming
3307ae060a
move extern declaration for this option to a header file where it belongs
...
provide an initial value for 'languageprefix' option, instead of relying on randomness to provide a useful value
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@48998 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Kevin P. Fleming
b2c8abbc6d
allow 'show memory' and 'show memory summary' to distinguish memory allocations that were done for caching purposes, so they don't look like memory leaks
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@48987 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
9cc04e026d
Add an API call that initializes an RTP structure. We need this because chan_sip is cheeky and uses a temporary RTP structure for codec purposes, and the API calls that are used rely on the lock. (Pointed out on asterisk-dev by Andy Wang)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@48964 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Russell Bryant
395db9ea8b
Implement locking for the list of URI handlers to make it thread-safe.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@48931 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Jason Parker
d017436015
Minor fixes for Solaris.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@48906 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Kevin P. Fleming
9a78e1f90e
remove some now-unnecessary explicit includes of autoconfig.h
...
clean up per-file dependencies during 'make clean'
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@48554 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Kevin P. Fleming
0509ca82b4
simplify dependency tracking system, using the compiler's built-in method for generating them, and only doing dependency tracking if developer mode is enabled via the configure script
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@48525 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Kevin P. Fleming
be1b5dab06
since we really, really have to have autoconfig.h included before all other headers (especially system headers), the Makefile will now force it to happen (this will fix build problems with files like ast_expr2f.c, where we can't control the inclusion order in the file itself)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@48521 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
8df2c7228f
Turn payload_lock into bridge_lock and make it encompass all RTP structure contents that may relate to bridge information, including who we are bridged to.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@48506 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
0995fb8aeb
Payload values on the RTP structure can change AFTER a bridge has started. This comes from the packet handling of the SIP response when indication that it was answered has been sent. Therefore we need to protect this data with a lock when we read/write. (issue #8232 reported by tgrman)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@48472 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
87a03da072
Remove direct RTCP bridging. I've come to the conclusion that we should handle this through the core and not just forward it on. Should solve a few bugs.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@48461 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
c866263f50
Merge in my latest RTP changes. Break out RTP and RTCP callback functions so they no longer share a common one.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@48381 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Steve Murphy
0ab411f2ed
Here lies the fixes that killed bug 8423 -- OriginateSuccess and OriginateError incomplete channel name. May it rest in peace.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@48349 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Olle Johansson
f89143bd13
- Disable RTP hold timers while T.38 fax transmission happens
...
- Encapsulate RTP timers in the rtp structure so we have one for video and one for audio
The video one is not used in 1.4, really. Will be used for RTP keepalives when we can send
something that video phones support in the RTP stream.
I now this is a big architectual change at this stage for 1.4, but decided it was needed
to avoid future bug reports.
- Document the RTP NAT keepalive option in sip.conf.sample
Issue 7679 in the bug tracker. Please test.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@48199 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Tilghman Lesher
a78cc926d4
Double-unlock error (reported by blitzrage on IRC)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@48179 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
b2b70adede
Do not do a partial bridge for Google Talk since we need to handle STUN. (issue #8448 reported by phsultan)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@48168 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
191c129b4f
Merged revisions 48151 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r48151 | file | 2006-11-30 13:42:45 -0500 (Thu, 30 Nov 2006) | 2 lines
Print certain CDR messages out at the NOTICE level versus WARNING since they can occur when used with the CDR applications and are perfectly fine. (issue #8367 reported by dartvader)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@48152 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
558639ff6a
Merged revisions 48106 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r48106 | file | 2006-11-29 11:47:10 -0500 (Wed, 29 Nov 2006) | 2 lines
If the frame was duplicated before writing out then we need to free it. (issue #8429 reported by edguy3)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@48107 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Russell Bryant
a569bfd1f2
Remove a couple of unused variables (issue #8380 , casper)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@48046 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Steve Murphy
e6ce5ce979
bug 8189 posted this fix for main/translate.c for PLC
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47992 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
090c412c27
Video will never reach Packet2Packet bridging and can do more harm then good.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47944 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
8c0f4c8711
If we have the non standard G726-32 setting turned on we want to return G726-32 to the SDP, not our AAL2 string. (issue #8330 reported by voipgate)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47897 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
0e684abd82
Merged revisions 47859 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r47859 | file | 2006-11-20 14:50:21 -0500 (Mon, 20 Nov 2006) | 2 lines
Don't forget to byte swap if we are exiting the smoother feed early. (issue #8287 reported by arturs)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47860 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
b42279c142
Only remove/destroy the RTCP I/O item if it exists.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47852 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
cb11263607
We need to ensure timelimit stuff is included as well so warnings get played. (issue #8050 reported by KNK)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47707 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Kevin P. Fleming
3302cbea3e
don't try to call fclose() if fopen() failed
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47701 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Kevin P. Fleming
7a5771161e
Merged revisions 47686,47688-47689 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r47686 | kpfleming | 2006-11-15 13:42:05 -0600 (Wed, 15 Nov 2006) | 2 lines
clear the category's variable tail pointer as well when variables are detached from it
........
r47688 | kpfleming | 2006-11-15 13:47:43 -0600 (Wed, 15 Nov 2006) | 2 lines
when appending a list of variable to a category, ensure the tail pointer points to the last variable in the list
........
r47689 | kpfleming | 2006-11-15 13:58:46 -0600 (Wed, 15 Nov 2006) | 2 lines
when re-writing the config file, don't repeat the path if it hasn't changed
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47690 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Kevin P. Fleming
cb4ed839c3
Merged revisions 47682 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r47682 | kpfleming | 2006-11-15 12:39:47 -0600 (Wed, 15 Nov 2006) | 2 lines
ouch... don't use printf, use ast_log/ast_verbose
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47684 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Luigi Rizzo
a9057b2c65
fix longest match search in find_cli.
...
Trunk already fixed.
1.2 not affected (well, i have no idea, the code is totally
different there).
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47672 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
bc6cff37bc
If NAT detection is turned on or already detected then say NAT is active when setting the remote RTP peer when doing early bridging. (issue #8365 reported by marcelbarbulescu)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47645 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Kevin P. Fleming
8dc804fafe
more formatting cleanup, and avoid running off the end of the string
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47641 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
708b84da2f
Turn notice about unknown RTCP packet type into a debug message instead.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47639 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Steve Murphy
2a0ac6ad9a
This solves bug 8342, whereby a crash occurs under certain circumstances while reading a config file with comments-- a call to CB_ADD shouldn't happen if withcomments is zero
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47576 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Tilghman Lesher
6e4d0e50c8
Re-enable old deprecated commands
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47573 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
6351e6bb2c
Free full command string upon unregistering of CLI command. Backported from revision 47536 from rizzo.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47542 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Russell Bryant
7ac2161b50
Tweak the formatting of this new function to better conform to coding guidelines.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47492 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Matt O'Gorman
5b02ba2bf1
woohoo safe out put!
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47490 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Tilghman Lesher
f11ea0549d
Discussion of these CLI changes resulted in more consistency (Bug 8236)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47436 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Russell Bryant
5654be2803
fix tab completion for "core debug channel" and "core no debug channel"
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47377 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Russell Bryant
795ba043e2
Fix "core show channel". Also, fix tab completion for both "core show channel"
...
and "core show channels".
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47375 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Russell Bryant
6609cebaf2
Fix "core debug channel <whatever>". I guess someone needs to go through and
...
audit every CLI command that changed number of arguments ...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47372 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Russell Bryant
9009cfcf79
revert the previous change, which actually modified the deprecated command,
...
"show profile". Now, actually apply the change to "core show profile".
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47370 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Russell Bryant
38be3e38e2
Fix argument parsing for the "core show profile" CLI command
...
(fixed by rizzo in his branch, team/rizzo/astobj2)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47369 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Russell Bryant
0b927d2208
Fix another CLI command, "core show uptime" ...
...
(issue #8323 , reported by johnlange, fixed by myself)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47366 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Russell Bryant
15ba13f1ec
fix "core show version" to reflect the new number of arguments for this
...
CLI command (issue #8316 , kshumard)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47352 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Steve Murphy
729ce4d791
This update fixes 7531
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47348 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Kevin P. Fleming
ea53cfcea3
the battle over CLI command formats has broken stuff...
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47338 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Steve Murphy
517978fd5f
These mods are to solve the problem in bug 7506. It's a lot of rework to solve a fairly small problem... such is life.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47303 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Russell Bryant
c8ee894823
Fix another bug in "core set debug" ...
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47196 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Russell Bryant
789234df2d
Really fix the "core set debug" and "core set verbose" CLI commands.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47195 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Russell Bryant
da6cf383d4
fix the "atleast" option to the "core set verbose" and "core set debug"
...
CLI commands
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47192 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Tilghman Lesher
56a1e60c54
More changes making the CLI more consistent with "category verb arguments" (continuation of issue 8236)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47053 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Tilghman Lesher
e05a2752e8
Reverse change of "show" to "list" and make several other commands more consistent with "category verb arguments"
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@47051 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Russell Bryant
105fa492b4
Add the missing call to free described in issue #8268 . Also, add a bunch of
...
missing calls to free in callerid_feed_jp().
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@46883 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Russell Bryant
e626d78269
fix saying one hundred and two hundred in hebrew (issue #7810 , eldadran)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@46857 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
673e9f53a8
Force poll() emulation for Darwin to always be on. It's too broken to consider being used. This resolves the console issue OSX users have been seeing. I would have liked to autoconf this but I haven't been able to come up with a test case that works. Que sera.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@46780 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Steve Murphy
a0078bbbc0
Cleanups suggested by Russell.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@46760 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Jason Parker
b12229c1ff
Fix "core show translation" output. Issue #8243 , patch by Damin.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@46716 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Kevin P. Fleming
f532d2f198
add an API so that translators can activate/deactivate themselves when needed
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@46714 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Kevin P. Fleming
160a0448c2
revert changes that were the wrong way to address this... proper fix coming
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@46713 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Kevin P. Fleming
f725940328
let's set the seen flag early enough to actually make a difference...
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@46712 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Kevin P. Fleming
59186bb2d2
don't re-do setup operations for translators that can dynamically register themselves
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@46711 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Olle Johansson
d318976f4d
Issue #8089 - Fix the ENUM support (picking one record by number). Thanks otmar!
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@46631 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Russell Bryant
e998b2b609
Merged revisions 46560 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r46560 | russell | 2006-10-31 01:18:36 -0500 (Tue, 31 Oct 2006) | 3 lines
When handling the case where the hostname is just an IPV4 numeric address,
be sure to set the address type. (issue #8247 , alexr)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@46561 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Russell Bryant
68720145e3
Add a small tweak to the code that checks to see whether destination formats
...
are translatable based on the source format. If we have already determined
that there is no translation path in one direction, don't bother checking the
other direction.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@46554 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Kevin P. Fleming
d8817c0d3c
when unregistering a translator, don't rebuild the translation matrix unless needed
...
when filtering formats out of an offer, ensure we check for translation ability in both directions
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@46526 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Olle Johansson
86c973f71f
Issue #8246 - Doxygen fixes from kshumard.
...
An extra big thankyou is given to everyone that contributes to doxygen!
THANK YOU!
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@46433 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Olle Johansson
e93e64a005
Bind RTCP to the same IP as RTP
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@46431 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Russell Bryant
d7f9b5f912
We should always be using _exit() after a fork() or vfork() instead of exit().
...
This is because exit() does some extra cleanup which in some implementations
of vfork(), for example, can actually modify the state of the parent process,
causing very weird bugs or crashes. (issue #7971 , Nick Gavrikov)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@46363 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Russell Bryant
3cb7bcd6d7
- If the source has no audio or no video portion, do not call powerof() to
...
get the format index.
- Don't run through the audio and video loops if there is no audio or video
portion of the source
If 0 is passed to powerof, it will return -1. This value of -1 was then being
used as an array index in these loops, which caused a crash on some systems.
Other than this issue, this code works as we expected it to. If a format is
not in the source, and we have to translation path to it, it is not offered in
the list of acceptable destination formats.
(fixes issue #8231 )
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@46329 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Mark Spencer
72146fab32
Fix config comment code preservation code (thanks murf!)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@46287 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Kevin P. Fleming
ce4b0afb73
apparently developers are still not aware that they should be use ast_copy_string instead of strncpy... fix up many more users, and fix some bugs in the process
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@46200 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Tilghman Lesher
ab677899a7
WaitExten truncates decimals of times to wait, instead of accepting them (Bug 8208)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@46165 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Kevin P. Fleming
6c17f1e07e
add passthrough and file format support for G.722 16KHz audio (issue #5084 , original patch by andrew, updated by mithraen)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@46154 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Kevin P. Fleming
05eb71c699
code zone experiment: don't offer formats in the outbound INVITE that aren't either passthrough or translatable
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@46153 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Kevin P. Fleming
c5f096e220
if multiple translators are registered for the same source/dest combination, ensure that the lowest-cost one is always inserted earlier in the list
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@46152 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Luigi Rizzo
e6451274d2
merge 45152 don't leak descriptors in http.c
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@46117 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Kevin P. Fleming
471c0eebdc
ensure that the translation matrix is properly lock-protected every place it is used
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@46083 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Kevin P. Fleming
d2b10d5f4f
add an API call to allow channel drivers to determine which media formats are compatible (passthrough or transcode) with the format an existing channel is already using
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@46082 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Tilghman Lesher
de9c3aaa8d
Pass through a frame if we don't know what it is, rather than trying to pass a
...
NULL, which will segfault a channel driver (Bug 8149)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@46078 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
bd40b393ec
Don't use promotion on Darwin because it doesn't seem to work quite right in all cases, this should solve the unresolved symbol issue people have been seeing.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@45817 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
54790d5ceb
Don't modify things if we are using vfork as this is very bad and may cause unexpected behavior (issue #7970 reported by Nick Gavrikov)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@45595 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Luigi Rizzo
4280d28549
merge from trunk: move ast_variables_destroy() to a better
...
place in handle_uri() to avoid leaking memory on non existing files.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@45464 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
64a875951a
Don't segfault if you're using a channel driver that doesn't turn RTCP on
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@45452 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Russell Bryant
0a78fea2ac
Don't attempt to access private data members of the pthread_mutex_t object,
...
because this does not work on all linux systems. Instead, just access
the reentrancy field in the ast_mutex_info struct when DEBUG_THREADS is
enabled. If DEBUG_CHANNEL_LOCKS is enabled, the developer probably has
DEBUG_THREADS on as well.
(issue #8139 , me)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@45441 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Kevin P. Fleming
227d415709
optimize the 'quick response' code a bit more... no more malloc() or memset() for each response
...
expand stringfields API a bit to allow reusing the stringfield pool on a structure when needed, and remove some unnecessary code when the structure was being freed
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@45408 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Kevin P. Fleming
60a11a7568
------------------------------------------------------------------------
...
r45119 | kpfleming | 2006-10-13 17:57:42 -0500 (Fri, 13 Oct 2006) | 2 lines
don't drop the entire permit/deny list when an attempt is made to add an invalid entry (BE-92)
------------------------------------------------------------------------
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@45125 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
a825206313
Merged revisions 45030 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r45030 | file | 2006-10-13 11:49:53 -0400 (Fri, 13 Oct 2006) | 2 lines
Pass the right value to usleep for sleeping, and always add the background refresh item back into the scheduler if enabled since it is deleted during reload. (issue #8142 reported by p_lindheimer)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@45031 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Kevin P. Fleming
1944a9a07c
use a configure script test for PMTU discovery control instead of just assuming it's available on Linux
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@45027 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Kevin P. Fleming
09f6a6a167
Merged revisions 44955 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r44955 | kpfleming | 2006-10-12 13:31:26 -0500 (Thu, 12 Oct 2006) | 2 lines
ensure that IAX2 and SIP sockets allow UDP fragmentation when running on Linux (thanks to Brian Candler on the asterisk-dev list for the tip)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@44956 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Russell Bryant
def01ced3d
fix a silly typo in a comment that I saw while reading the commit list
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@44945 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Nadi Sarrar
8adb217804
append_event must be called while holding the session lock
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@44921 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Jason Parker
3c72ad9cb1
These are already set by the parent Makefile..
...
There is no need to have this here (it doesn't actually work anyways).
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@44888 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Paul Cadach
53024e3508
CHANNEL() function sometime mix parameter and value
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@44809 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
faf38b71ef
Remove the seqno check for RFC2833, the handler is smart enough to not need it.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@44628 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
2d3da5b500
When the sequence number rolls over then reset the recorded sequence number for DTMF (issue #8106 reported by bungalow)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@44605 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
1a5c679e51
Merged revisions 44580 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r44580 | file | 2006-10-06 12:52:14 -0400 (Fri, 06 Oct 2006) | 2 lines
Even more frames to treat as though the remote side disappeared (issue #8097 reported by eldadran)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@44581 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Luigi Rizzo
f24ec459b2
make sure sockets are blocking when they should be blocking.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@44567 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
dba3dae7f8
Merged revisions 44501 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r44501 | file | 2006-10-05 15:55:41 -0400 (Thu, 05 Oct 2006) | 2 lines
Treat busy control frames as hangup in the file streaming core (issue #8097 reported by eldadran)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@44502 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Kevin P. Fleming
6a70807a36
don't segfault when an argument without a close parenthesis is found
...
stop parsing as soon as that situation occurs
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@44476 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Kevin P. Fleming
5c4434d0e7
make LOW_MEMORY builds actually work
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@44390 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Kevin P. Fleming
ff05bf15c8
update thread creation code a bit
...
reduce standard thread stack size slightly to allow the pthreads library to allocate the stack+data and not overflow a power-of-2 allocation in the kernel and waste memory/address space
add a new stack size for 'background' threads (those that don't handle PBX calls) when LOW_MEMORY is defined
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@44378 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Kevin P. Fleming
fc72291807
ensure that local include files are always used
...
avoid a duplicate function name (term_init())
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@44322 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago
Joshua Colp
e7a2e3cb07
Merged revisions 44168 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r44168 | file | 2006-10-02 13:22:27 -0400 (Mon, 02 Oct 2006) | 2 lines
Shrink when current_ioc is unused. It is set to -1 when unused, not 0. (issue #7941 reported by eclubb)
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@44169 65c4cc65-6c06-0410-ace0-fbb531ad65f3
19 years ago