361 Commits (2ef94103630c4c69821f6bc749335ca922f8afcb)

Author	SHA1	Message	Date
Joshua Colp	2187f79e54	Protect the CDR record from modification by pbx_exec so that the application data contains the Queue data. ... (closes issue #10761) Reported by: snar Patches: app-queue-mixmonitor.patch uploaded by snar (license 245) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@83074 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	88cfb003df	Initialize a variable to NULL to make the world happy. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82961 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	3d1a567df0	Moving the logic for handling an empty membername to the create_member function so that there is a common place ... where this occurs instead of being spread out to several different places. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82865 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Kevin P. Fleming	a809a030d9	there is no need for conditional logic to select ->interface or ->membername, snince ->membername will always be populated ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82834 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Kevin P. Fleming	43c2cf7938	fix a couple of places where a logical member name (if specified) was not used, but instead the direct interface was listed ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82590 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	e53d7231dd	Crap, I broke the build. Fixed. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82398 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	c7b6c42ef5	Adding member name field to manager events where they were missing before ... (closes issue #10721, reported by snar) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82396 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	d6b1a0bfd6	Preemptively fixing a possible segfault. It is possible that queuename is NULL ... (meaning pause ALL queues), so use q->name instead. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82346 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	1cf6ee98e0	Added logic to handle the unlikely case that someone has two queues with the same name. ... Asterisk will log a warning message letting the user know that one was already defined with that name and is it skipping all further instances. This also will work for realtime queues but in order for that to happen, the user would have to trigger a perfectly timed reload as a realtime queue is being looked up, which is highly unlikely (but taken care of nonetheless). git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82326 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	da18cece2c	We should only initialize a realtime queue when it is allocated, not every time we access it. This prevents the members ao2_container ... from being reallocated every time the queue is accessed. I also removed a debug message I had accidentally left in on a previous commit. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82274 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	3e11102ef8	Fix incorrect uses of ao2_find(). Every one of these calls was reading bogus ... memory ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82267 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	56b7a100bc	Fix another missing unref of member objects. This one was pointed out by Marta. ... When building the outgoing list in try_calling(), a member reference is stored in each outgoing entry. However, when this list got destroyed, the reference was not released. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82263 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	4f36c859ad	All instances of ao2_iterators which were just named 'i' have been renamed ... to 'mem_iter' so that when refcounted queues are merged into trunk, there will be little confusion regarding iterator names, especially when a queue and member iterator are used in the same function. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82252 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	808ed0e44e	Add a couple more missing unrefs of queue member objects ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82240 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	aa3a71d3bf	Add a missing unref of a queue member in an error handling block ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82238 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	ffa6e7123b	Document why membercount can not simply be replaced by ao2_container_count() ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82236 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Tilghman Lesher	4913548485	Convert struct member to use refcounts (closes issue #10199) ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@82155 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jason Parker	d73c04d892	Allow the MEMBERINTERFACE variable to be used as the mixmonitor filename. ... This moves the setting of the MEMBERINTERFACE variable to before mixmonitor. Issue 10671, patch by sim. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81923 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	76ffc54255	Fixes an issue where valid DTMF had to be pressed twice to exit a queue if a member's phone ... was ringing. (closes issue #10655, reported by strider2k, patched by me) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81713 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	fbbf1e2056	Fixing the build... ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81525 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	f5cc747662	Reverting behavior of QUEUE_MEMBER_COUNT to only count members who are logged in ... and available. (related to issue #10652, reported by wuwu) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81520 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	6ed2b5c1b2	Changed a comment to be more accurate. ... (really this is just a test to make sure I can commit properly from home) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81428 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	687f798f19	Fixed broken behavior of a reload on realtime queues. Prior to this patch, if a reload was issued and ... a realtime queue had callers waiting in it, then the queue would be removed from the queue list, but it would not actually be freed (in fact, a debug message warning about a memory leak would come up). With this patch, reloads do not touch realtime queues at all. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81416 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	0589a7e1d0	Removing an extraneous (and possibly misleading) log message. Firstly, if the announce file isn't found, the ... streaming functions will report it. Secondly, not all non-zero returns from play_file mean that the announce file wasn't found. Positive return values simply mean that a digit was pressed (most likely to skip through the announcement). (closes issue #10612, reported and patched by dimas) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81397 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	4c16fcaa97	Changed some manager event messages to reflect whether a queue member is a realtime member or not ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81381 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	dbe2d229a5	This patch, in essence, will correctly pause a realtime queue member and reflect those ... changes in the realtime engine. (issue #10424, reported by irroot, patch by me) This patch creates a new function called update_realtime_member_field, which is a generic function which will allow any one field of a realtime queue member to be updated. This patch only uses this function to update the paused status of a queue member, but it lays the foundation for persisting the state of a realtime member the same way that static members' state is maintained when using the persistentmembers setting git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81349 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	872ab1519e	Changed some tabs to spaces ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81346 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	2772c71560	This fix creates a more accurate way of detecting whether realtime members were deleted. ... (closes issue 10541, reported by Alric, patched by me) The REALLY nice things about this patch is that queue members now have a "realtime" field which will be true if the member is a realtime member. This means we can check this value prior to certain processing if it should ONLY be done for realtime members. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81340 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	214d980f86	Resolve a potential deadlock. In this case, a single queue is locked, then the queue list. In changethread(), the queue list is ... locked, and then each individual queue is locked. Under the right circumstances, this could deadlock. As such, I have unlocked the individual queue before locking the queue list, and then locked the queue back after the queue list is unlocked. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81158 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	fe5489eead	Found a case where the queue's membercount is off. It does not take into account dynamic members on a reload. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@81010 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
BJ Weschke	318f0f6e46	A minor correction to the available logic of autofill. If a queue member is paused, they're not really "available" so don't count them as such. Somewhat related to issue #10155 ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@80818 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	108326e3d1	Fix the build of app_queue ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@80088 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	6268d2d7ec	After a discussion on #asterisk-dev, it was decided that this should be in 1.4 as well. ... (issue #10424, reported and patched by irroot) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@80086 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	d66e174242	Found a pointless ternary if. member->dynamic was set to 1 and has no opportunity to change ... between then and this line, so "dynamic" will ALWAYS be output. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@80049 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	f8c70a5799	Changing a bit of logic so that someone will NEVER exit the queue on timeout unless they have enabled the 'n' option. ... This commit relates to issue #10320. Thanks to jfitzgibbon for detailing the idea behind this code change. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@78575 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	5739eba48e	Fixes an issue I introduced to queues wherein a queue with joinempty=yes would kick people out of the queue because of erroneously ... thinking the 'n' option was in use. (closes issue #10320, reported by jfitzgibbon, patched by me, tested by blitzrage and me) Thank you blitzrage for all the testing you've done lately with queues! It's much appreciated! git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@77854 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	7e6f78d95e	If a queue uses dynamic realtime members, then the member list should be updated after each attempt to call the queue. ... This fixes an issue where if a caller calls into a queue where no one is logged in, they would wait forever even if a member logged in at some point. (closes issue #10346, reported by and tested by blitzrage, patched by me) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@77852 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	ad4eb1b347	Added a membercount variable to call_queue struct which keeps track of the number of logged in members in a particular queue. ... This makes it so that the 'n' option for Queue() can act properly depending on which strategy is used. If the strategy is roundrobin, rrmemory, or ringall, we want to ring each phone once before moving on in the dialplan. However, if any other strategy is used, we will only ring one phone since it cannot be guaranteed that a different phone will ring on subsequent attempts to ring a phone. As a side effect of this, the QUEUE_MEMBER_COUNT dialplan function now just reads the membercount variable instead of traversing through the member list to figure out how many members there are. Special thanks to blitzrage for helping to test this out. (closes issue #10127, reported by bcnit, patched by me, tested by blitzrage) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@76801 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	34b000a0e7	Move makeannouncement variable declaration to proper place. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@76054 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	049fb8d98e	The diff on this looks pretty big but all I did was remove a pointless if statement (always evaluates true). ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@75978 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	1f9e2457dd	Changes in handling return values of several functions in app_queue. This all started as a fix for issue #10008 ... but now includes all of the following changes: 1. Simplifying the code to handle positive return values from ast API calls. 2. Removing the background_file function. 3. The fix for issue #10008 (closes issue #10008, reported and patched by dimas) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@75969 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Dwayne M. Hubbard	226a627244	Merged revisions 75657 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r75657 | dhubbard | 2007-07-18 12:48:33 -0500 (Wed, 18 Jul 2007) | 1 line removed the word 'pissed' from ast_log(...) function call for BE-90 ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@75658 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jason Parker	05923bb562	Merged revisions 74427 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r74427 | qwell | 2007-07-10 14:57:20 -0500 (Tue, 10 Jul 2007) | 6 lines Fix an issue where it was possible to have a service level of over 100% Between the time recalc_holdtime and update_queue was called, it was possible that the call could have been hungup. Move both additions to the same place, so this won't happen. Issue 10158, initial patch by makoto, modified by me. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@74428 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	5112357ae1	Forgot to get rid of an extraneous debug message. ... git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@74122 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	591f77fe14	The n option for Queue should make the queue exit immediately after failure to reach any members and should not ... be dependent on the timeout value passed to Queue (closes issue #10127, reported by bcnit, repaired by me) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@74120 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Mark Michelson	60c9f69f20	Correcting a minor CLI bug I found. When issuing the queue show command, if you type ... queue show and then press tab, you can continue pressing tab and it will keep auto-completing queue names even though only 1 queue can be used as an argument. git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@73400 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	6fec0a545f	Merged revisions 73315 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r73315 | file | 2007-07-05 10:19:17 -0300 (Thu, 05 Jul 2007) | 2 lines Reset ServicelevelPerf variable back to 0 if we are unable to calculate it each time... otherwise we will get previous values. (issue #10117 reported by noriyuki) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@73316 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	2c67ae6869	Merged revisions 72327 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r72327 | file | 2007-06-27 18:43:11 -0400 (Wed, 27 Jun 2007) | 2 lines Fix issue where queue log events might be missing. (issue #7765 reported by mtryfoss) ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@72328 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	e7cb53e8b2	Fix loading persistent queue members when using realtime configuration for queues. ... Also, remove an unneeded leading slash for the astdb family. (issue #9911, patch by atis) git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68280 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	ece55e3de7	Merged revisions 65389 via svnmerge from ... https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r65389 | russell | 2007-05-22 08:07:03 -0500 (Tue, 22 May 2007) | 4 lines Fix a memory leak that I just noticed in the device state handling in app_queue. On most device state changes, it would leak roughly 8 to 64 bytes (the length of the name of the device). ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@65394 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago