30310 Commits (2d16c855740cc55ac788d4bfa04c9310c3a62f9c)

 

All Branches   

Search

Author	SHA1	Message	Date
Richard Mudgett	c4f02c975b	pjsip_scheduler.c: Fix ao2 usage errors. ... * Removed several invalid uses of OBJ_NOLOCK. These uses resulted in the 'tasks' container being accessed without a lock in a multi-threaded environment. A recipe for crashes. * Removed needlessly obtaining schtd object references. If the caller providing you a pointer to an object doesn't have a valid reference then you cannot safely get one from it. * Getting a ref to 'tasks' when you aren't copying the pointer into another location is useless. The 'tasks' container pointer is global. * Removed many unnecessary uses of RAII_VAR. * Make ast_sip_schedule_task() name parameter const. ASTERISK_26806 Change-Id: I5c62488e651314e2a1dbc01f5b078a15512d73db	7 years ago
Jenkins2	36f94cbcde	Merge "Build System: Fixes for configure script." into 13	7 years ago
Corey Farrell	7593359787	Build System: Enable python3 compatibility. ... * Consistently use spaces in rest-api-templates/asterisk_processor.py. * Exclude third-party from docs/full-en_US.xml. * Add docs/full-en_US.xml to .gitignore. * Use list() to convert python3 view. * Use python3 print function. * Replace cmp() with equivalent equation. * Replace reference to out of scope subtype variable with name parameter. * Use unescaping triple bracket notation in mustache templates where needed. This causes behavior of Python2 to be maintained when using Python3. * Fix references to has_websocket / is_websocket in res_ari_resource.c.mustache. * Update calculation of has_websocket to use any(). * Use unicode mode for writing output file in transform.py. * Replace 'from swagger_model import *' with explicit import of required symbols. * Add missing 'import os' * Fix invalid reference to swagger_version from exception handler. I have not tested voicemailpwcheck.py, only the print syntax has been fixed. Change-Id: If5c5b556a2800d41a3e2cfef080ac2e151178c33	7 years ago
Richard Mudgett	72b16ee400	res_pjsip_refer/chan_sip: Fix INVITE with replaces transfer to ConfBridge ... There is a problem when an INVITE-with-Replaces transfer targets a channel in a ConfBridge. The transfer will unconditionally swap out the ConfBridge channel. Unfortunately, the ConfBridge state will not be aware of this change. Unexpected behavior will happen as a result since ConfBridge channels currently can only be replaced by a masquerade and not normal bridge channel moves. * We just need to pretend that the channel isn't in a bridge (like other transfer methods already do) so the transfer channel will masquerade into the ConfBridge channel. Change-Id: I209beb0e748fa4f4b92a576f36afa8f495ba4c82	7 years ago
Jenkins2	dcac292ae3	Merge "BuildSystem: Add support for building RADIUS with radcli." into 13	7 years ago
Jenkins2	9117bbb45d	Merge "res_pjsip: Update authenticate_qualify documentation." into 13	7 years ago
Richard Mudgett	ea055386e0	chan_sip.c: Fix INVITE with replaces channel ref leak. ... Given the below call scenario: A -> Ast1 -> B C <- Ast2 <- B 1) A calls B through Ast1 2) B calls C through Ast2 3) B transfers A to C When party B transfers A to C, B sends a REFER to Ast1 causing Ast1 to send an INVITE with replaces to Ast2. Ast2 then leaks a channel ref of the channel between Ast1 and Ast2. Channel ref leaks are easily seen in the CLI "core show channels" output. The leaked channels appear in the output but you can do nothing with them and they never go away unless you restart Asterisk. * Properly account for the channel refs when imparting a channel into a bridge when handling an INVITE with replaces in handle_invite_replaces(). The ast_bridge_impart() function steals a channel ref but the code didn't account for how many refs were held by the code at the time and which ref was stolen. * Eliminated RAII_VAR in handle_invite_replaces(). ASTERISK-27740 Change-Id: I7edbed774314b55acf0067b2762bfe984ecaa9a4	7 years ago
Richard Mudgett	e94f8e4a24	res_pjsip: Update authenticate_qualify documentation. ... Change-Id: I3811de0014b1ffe96d4a3b49cddd5d4ca02ee5d4	7 years ago
Richard Mudgett	906db6a3ff	app_agent_pool.c: Fix off nominal ref leak. ... Change-Id: Ib427ffc2c802620eaafb08b1c2a17dddd8fb8eb6	7 years ago
Corey Farrell	07e408e588	Build System: Strip '-std=c99' from CFLAGS provided by libraries. ... Asterisk requires GNU C extensions. On some systems certain libraries may incorrectly push -std=c99 into CFLAGS, thus breaking the build. This change causes that flag to be stripped so the Asterisk build is not broken by those libraries. This change is made for both pkgconfig and tool based libraries. ASTERISK-27629 #close Change-Id: I13389613b194abbac77becf90cd950dc168704db	7 years ago
Corey Farrell	01b3c435d8	Build System: Fixes for configure script. ... * Replace all 'else if' statements with 'elif'. * Use loop to detect versioned lua headers and libraries. The loop for detecting lua fixes a bug where LUA_INCLUDE would be appended with the directory of every lua version after the first one is found. Change-Id: I3276f9aee955014108345be6092f51c932b43a0f	7 years ago
Jenkins2	7888b6115a	Merge "install_prereq: Add Slackware (somehow)." into 13	7 years ago
George Joseph	cea1a22ef3	res_pjsip: Correct usages of pjproject's timer heap ... Fix some timer heap initializations and cancels to try and prevent crashes and timer heap issues. Change-Id: I64885d190fa22097d1b55987091375541e57a7ee	7 years ago
George Joseph	158c0efd4f	pjroject_bundled: Add already-destroyed check to tsx_timer_callback ... There have been cases that when the transaction timer callback is called the tsx is already destroyed. This causes a crash. We now check the tsx state and return if the tsx is already destroyed. Change-Id: If93acd5e48d9ca5bb553f2405d5afc836842fe1c	7 years ago
George Joseph	69c61237cd	pjproject_bundled: timer: Clean up usage of timer heap ... Added a new pj_timer_entry_reset function that resets a timer_entry for re-use. Changed direct settings of timer_entry fields to use pj_timer_entry_init and pj_timer_entry_reset. Fixed issues where timers were being rescheduled incorrectly. Change-Id: I5b624bfbc5c1429117484b9b24567293002148e6	7 years ago
Jenkins2	b621ea4109	Merge "install_prereq: Add Gentoo Linux." into 13	7 years ago
Joshua Colp	945f7c6082	Merge "BuildSystem: With external editline, do not require libs for internal editline." into 13	7 years ago
Alexander Traud	83353997f4	BuildSystem: Add support for building RADIUS with radcli. ... Radcli is yet another RADIUS client library, generally compatible with freeradius and radiusclient-ng. This commit adds autoconf option for detecting it as well and changes cdr_radius and cel_radius to use its header file in that case. ASTERISK-26540 Reported by: Tzafrir Cohen Change-Id: Icc056d476b7acf481309219e9abdca416866c6ec	7 years ago
Jenkins2	e9313920e5	Merge "pjproject_bundled: Add patch for pj_atomic crashes" into 13	7 years ago
Jenkins2	025fe67f2a	Merge "core: Create main/options.c." into 13	7 years ago
Richard Mudgett	e1363283d7	res_pjsip: Fix deadlock on reliable transport shutdown. ... A deadlock can happen when the PJSIP monitor thread is shutting down a connection oriented transport (TCP/TLS) used by a subscription at the same time as another thread tries to send something for that subscription. The deadlock is between the pjsip monitor thread attempting to get the dialog lock and another thread sending something for that dialog when it tries to get the transport manager lock. * res_pjsip_pubsub.c: Avoid the deadlock by pushing the subscription removal to the subscription serializer. * res_pjsip_registrar.c: Pushed off incoming registration contact removals to a default serializer as a precaution. Removing the contacts involves sorcery access which in this case will involve database access. Depending upon the setup, the database may not be on the same machine and could take awhile. We don't want to hold up the pjsip monitor thread with potentially long access times. ASTERISK-27706 Change-Id: I56b647aea565f24dba33e9e5ebeed4cd3f31f8c4	7 years ago
Kevin Harwell	f17d53fd32	Merge "BuildSystem: pjsip_evsub_set_uas_timeout was not used (part 2)." into 13	7 years ago
Kevin Harwell	dfaa8a4935	Merge "pjsip_transport_events.c: Fix crash using stale transport pointer." into 13	7 years ago
George Joseph	c63a2e28f1	pjproject_bundled: Add patch for pj_atomic crashes ... There have been some crashes in the past where something attempts to use a pj_atomic after it's already been destroyed. This patch tries to prevent it by making sure that pj_atomic_destroy sets its mutex to NULL when it's done. The pj_mutex functions already check for a NULL mutex and just return PJ_EINVAL. Teluu also added some checks to the win32 implementation as well. Change-Id: Id25f70b79fdedf44ead6e6e1763a4417d3b3f825	7 years ago
Corey Farrell	5908c6753b	core: Create main/options.c. ... This creates a separate source to 'own' symbols related to options.h and paths.h. This significantly reduces the number of exports created by main/asterisk.o. This change is required to eventually be able to link unmodified Asterisk sources to utilities and/or stand-alone tests. ASTERISK~26245 Change-Id: I5cf184f4757f9363b80c9e678bdc35c477122380	7 years ago
Alexander Traud	e8e4fc6202	install_prereq: Add Slackware (somehow). ... ASTERISK-27770 Change-Id: Ib87e0483c785542238cfe34c1e884d5a31edfaab	7 years ago
Alexander Traud	96a668e60b	install_prereq: Add Gentoo Linux. ... ASTERISK-27769 Change-Id: Ieb13293cd67481f3a33f58f6f7c8c3ee1e338e7a	7 years ago
Corey Farrell	6615469a05	main/indications: Use ast_cli_completion_add for all completions. ... Change-Id: I371be01f178fb542a9fbe8d97e7ae21aa4d82c36	7 years ago
Jenkins2	2041d56d58	Merge "bridge_softmix: Clear "talking" when a channel is put on hold" into 13	7 years ago
Joshua Colp	c399e8528b	Merge "Revert "BuildSystem: In NetBSD, the Python Programming Language is python-X.Y."" into 13	7 years ago
Alexander Traud	de4e2c1de8	BuildSystem: pjsip_evsub_set_uas_timeout was not used (part 2). ... The previous change was not complete. ASTERISK-27435 Change-Id: I11082c14c0ef9c6af8c995084a6851337ea2a90f	7 years ago
Alexander Traud	79bb956b69	BuildSystem: With external editline, do not require libs for internal editline. ... ASTERISK-27761 Change-Id: Ib17a7415297a210cfcdbf149e4df9b6edadbfab6	7 years ago
George Joseph	3a4a441817	Revert "BuildSystem: In NetBSD, the Python Programming Language is python-X.Y." ... Something is causing a python2/python3 mismatch on Fedora27. PYTHON='/usr/bin/python2' PYTHONDEV_CFLAGS='-I/usr/include/python3.6m ' PYTHONDEV_INCLUDE='-I/usr/include/python3.6m ' PYTHONDEV_LIB='-lpython3.6m ' PYTHONDEV_LIBS='-lpython3.6m ' This reverts commit c0c537c1d3. Change-Id: I670a82aa7c872fa5facea1e3bc718e2d3124cc28	7 years ago
Jenkins2	b9eb86b56e	Merge "chan_sip: Peers with distinct source ports don't match, regardless of transport." into 13	7 years ago
Kevin Harwell	17cd687679	bridge_softmix: Clear "talking" when a channel is put on hold ... This patch clears the talking flag from the channel (if already set), and notifies listeners when that channel is put on hold. Note however, if the endpoint continues to send audio frames and these are received by the bridge then that channel will be put back into a "talking" state even though they are on hold. ASTERISK-27755 #close Change-Id: I930e16c4662810f9f02043d69062f88173c5e2ef	7 years ago
Ross Beer	5955cdf5ae	pjsip_transport_events.c: Fix crash using stale transport pointer. ... Apparently it is possible for the transport to be destroyed without triggering the transport callback logic. As a result the transport gets destroyed and we have a stale pointer in the active_transports container. * Invoke the transport monitor callback checks when the transport is destroyed in addition to when it is disconnected and shutdown. ASTERISK-27688 Change-Id: Ia9b5469fea8f2b3f2d8476fae6b748a4d23e7261	7 years ago
Ivan Poddubny	69de659224	func_channel: Delete dead CHANNEL_TRACE code ... The functions behind the flag and the flag itself were removed from Asterisk 12 as incompatible with the new architecture. Change-Id: I058493ef7a53ee290fd225bbcbb07bf46b623ccf	7 years ago
Alexander Traud	7580d1e0bb	BuildSystem: For consistency, avoid extra libs to be empty. ... AST_EXT_LIB_CHECK has several optional parameters. When an optional parameter is left empty, [] is used to indicate this. However, this is done in the script ./configure only then, when a further parameter is not empty. For example, when no extra libraries are needed to test the checked library, parameter 5 is not mentioned. Except parameter 6 and higher are used, then parameter 5 must be empty. However, this general rule was broken * three times for parameter 5 (extra libs) and * three times for parameter 4 (header) as found via the Regular Expression \[\]\). In case of parameter 5, all cases were changed, because that happened for no reason. In case of parameter 4, an [] improves readability actually. Therefore for parameter 4, the only case which did not do it was changed. All this aims to create more consistency: Only do something different if there is a reason to do so. Change-Id: I037ef170cf1ad94497151a9ea5071a31c656cafe	7 years ago
Jenkins2	7d8445d576	Merge "core: Remove dead symbols from asterisk.exports.in." into 13	7 years ago
Jenkins2	b39c727848	Merge "channel.c: Allow generic plc then channel formats are equal" into 13	7 years ago
Jenkins2	8b1665bc55	Merge "BuildSystem: In NetBSD, the Python Programming Language is python-X.Y." into 13	7 years ago
Joshua Colp	6bda2d7baf	Merge "BuildSystem: Instead of $PJPROJECT_LIBS with s, use $PJPROJECT_LIB everywhere." into 13	7 years ago
Joshua Colp	4040b0e909	Merge "main/sounds: Use ast_cli_completion_add." into 13	7 years ago
Jenkins2	fbd2504907	Merge "named_acl: Use ast_cli_completion_add." into 13	7 years ago
Jenkins2	44c85ddc57	Merge "manager: Use ast_cli_completion_add for completion generators." into 13	7 years ago
Jenkins2	7f40e09b3e	Merge "main/test: Use ast_cli_completion_add." into 13	7 years ago
Joshua Colp	38d081c9f6	Merge "core: Minor cleanup of ast_el_read_char." into 13	7 years ago
Joshua Colp	3742534956	Merge "aco: Use ast_cli_completion_add for 'config show help'." into 13	7 years ago
Jenkins2	648405779e	Merge "main/config: Use ast_cli_completion_add for reload completion." into 13	7 years ago
Jenkins2	1a82f5b645	Merge "main/translate: Use ast_cli_completion_add." into 13	7 years ago