asterisk

Commit Graph

Author	SHA1	Message	Date
Tilghman Lesher	98ce0e5b6c	Eliminate several needless checks and fix a few memory leaks (closes issue #14833) Reported by: contactmayankjain Patches: all_changes.patch uploaded by contactmayankjain (license 740) slightly modified by me git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@197616 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Kevin P. Fleming	e6b2e9a750	Const-ify the world (or at least a good part of it) This patch adds 'const' tags to a number of Asterisk APIs where they are appropriate (where the API already demanded that the function argument not be modified, but the compiler was not informed of that fact). The list includes: - CLI command handlers - CLI command handler arguments - AGI command handlers - AGI command handler arguments - Dialplan application handler arguments - Speech engine API function arguments In addition, various file-scope and function-scope constant arrays got 'const' and/or 'static' qualifiers where they were missing. Review: https://reviewboard.asterisk.org/r/251/ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@196072 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Sean Bright	fd8caa1778	This is basically a complete rollback of r155401, as it was determined that it would be best to maintain API compatibility. Instead, this commit introduces ao2_callback_data() which is functionally identical to ao2_callback() except that it allows you to pass arbitrary data to the callback. Reviewed by Mark Michelson via ReviewBoard: http://reviewboard.digium.com/r/64 git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@158959 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Russell Bryant	ab2b24d6ee	Use the new case insensitive hash function for console interfaces. The comparison function is case insensitive. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@157039 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Sean Bright	30d1744ffc	Add ability to pass arbitrary data to the ao2_callback_fn (called from ao2_callback and ao2_find). Currently, passing OBJ_POINTER to either of these mandates that the passed 'arg' is a hashable object, making searching for an ao2 object based on outside criteria difficult. Reviewed by Russell and Mark M. via ReviewBoard: http://reviewboard.digium.com/r/36/ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@155401 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Michiel van Baak	90751b16ca	Merge the cli_cleanup branch. This work is done by lmadsen, junky and mvanbaak during AstriDevCon. This is the second audit the CLI got, and this time lmadsen made sure he had _ALL_ modules loaded that have CLI commands in them. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@145121 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Tilghman Lesher	08af5bb312	Create a new config file status, CONFIG_STATUS_FILEINVALID for differentiating when a file is invalid from when a file is missing. This is most important when we have two configuration files. Consider the following example: Old system: sip.conf users.conf Old result New result ======== ========== ========== ========== Missing Missing SIP doesn't load SIP doesn't load Missing OK SIP doesn't load SIP doesn't load Missing Invalid SIP doesn't load SIP doesn't load OK Missing SIP loads SIP loads OK OK SIP loads SIP loads OK Invalid SIP loads incompletely SIP doesn't load Invalid Missing SIP doesn't load SIP doesn't load Invalid OK SIP doesn't load SIP doesn't load Invalid Invalid SIP doesn't load SIP doesn't load So in the case when users.conf doesn't load because there's a typo that disrupts the syntax, we may only partially load users, instead of failing with an error, which may cause some calls not to get processed. Worse yet, the old system would do this with no indication that anything was even wrong. (closes issue #10690) Reported by: dtyoo Patches: 20080716__bug10690.diff.txt uploaded by Corydon76 (license 14) git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@142992 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Mark Michelson	5dfefa5ee6	Merged revisions 140488 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r140488 \| mmichelson \| 2008-08-29 12:34:17 -0500 (Fri, 29 Aug 2008) \| 22 lines After working on the ao2_containers branch, I noticed something a bit strange. In all cases where we provide a callback function to ao2_container_alloc, the callback function would only return 0 or CMP_MATCH. After inspecting the ao2_callback() code carefully, I found that if you're only looking for one specific item, then you should return CMP_MATCH \| CMP_STOP. Otherwise, astobj2 will continue traversing the current bucket until the end searching for more matches. In cases like chan_iax2 where in 1.4, all the peers are shoved into a single bucket, this makes for potentially terrible performance since the entire bucket will be traversed even if the peer is one of the first ones come across in the bucket. All the changes I have made were for cases where the callback function defined was passed to ao2_container_alloc so that calls to ao2_find could find a unique instance of whatever object was being stored in the container. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@140489 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Sean Bright	bea1644dc2	Merge more changes from the resolve-shadow-warnings branch (henceforth known as RSW since i am too lazy to keep typing it all out). This time a few of the channels. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@136888 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Russell Bryant	bbf50cf072	Be explicit that we don't want a result from this callback. The callback would never indicate a match, so nothing would have been returned anyway, but it was still a poor example of proper usage. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@135439 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Jeff Peeler	33b3d38a3c	This was accidentally reverted. Fixes a bug where if a stream monitor thread was not created (caused from failure of opening or starting the stream) pthread_cancel was called with an invalid thread ID. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@121163 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Michiel van Baak	6d018f0774	chan_console fixes because of ast_frame.data => ast_frame.data.ptr git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117834 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Michiel van Baak	f1e9371da8	- revert change to ast_queue_hangup and create ast_queue_hangup_with_cause - make data member of the ast_frame struct a named union instead of a void Recently the ast_queue_hangup function got a new parameter, the hangupcause Feedback came in that this is no good and that instead a new function should be created. This I did. The hangupcause was stored in the seqno member of the ast_frame struct. This is not very elegant, and since there's already a data member that one should be used. Problem is, this member was a void *. Now it's a named union so it can hold a pointer, an uint32 and there's a padding in case someone wants to store another type in there in the future. This commit is so massive, because all ast_frame.data uses have to be altered to ast_frame.data.data Thanks russellb and kpfleming for the feedback. (closes issue #12674) Reported by: mvanbaak git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@117802 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	59f170973e	Merged revisions 114891 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r114891 \| russell \| 2008-04-30 11:30:01 -0500 (Wed, 30 Apr 2008) \| 28 lines Merge changes from team/russell/iax2_find_callno and iax2_find_callno_1.4 These changes address a critical performance issue introduced in the latest release. The fix for the latest security issue included a change that made Asterisk randomly choose call numbers to make them more difficult to guess by attackers. However, due to some inefficient (this is by far, an understatement) code, when Asterisk chose high call numbers, chan_iax2 became unusable after just a small number of calls. On a small embedded platform, it would not be able to handle a single call. On my Intel Core 2 Duo @ 2.33 GHz, I couldn't run more than about 16 IAX2 channels. Ouch. These changes address some performance issues of the find_callno() function that have bothered me for a very long time. On every incoming media frame, it iterated through every possible call number trying to find a matching active call. This involved a mutex lock and unlock for each call number checked. So, if the random call number chosen was 20000, then every media frame would cause 20000 locks and unlocks. Previously, this problem was not as obvious since Asterisk always chose the lowest call number it could. A second container for IAX2 pvt structs has been added. It is an astobj2 hash table. When we know the remote side's call number, the pvt goes into the hash table with a hash value of the remote side's call number. Then, lookups for incoming media frames are a very fast hash lookup instead of an absolutely insane array traversal. In a quick test, I was able to get more than 3600% more IAX2 channels on my machine with these changes. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114892 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jeff Peeler	7cfd8389ac	Fixes a bug where if a stream monitor thread was not created (caused from failure of opening or starting the stream) pthread_cancel was called with an invalid thread ID. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114888 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Sean Bright	f98b2cfef9	Speaking of building... git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114644 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Jeff Peeler	41fd7a6a21	(closes issue #6113 ) Reported by: oej Tested by: jpeeler This patch implements multiple parking lots for parked calls. The default parkinglot is used by default, however setting the channel variable PARKINGLOT in the dialplan will allow use of any other configured parkinglot. See configs/features.conf.sample for more details on setting up another non-default parkinglot. Also, one can (currently) set the default parkinglot to use in the driver configuration file via the parkinglot option. Patch initially written by oej, brought up to date and finalized by mvanbaak, and then stabilized and converted to astobj2 by me. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@114487 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Joshua Colp	496adc6fc0	Merged revisions 106235 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r106235 \| file \| 2008-03-05 18:32:10 -0400 (Wed, 05 Mar 2008) \| 4 lines Add a control frame to indicate the source of media has changed. Depending on the underlying technology it may need to change some things. (closes issue #12148) Reported by: jcomellas ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@106239 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Olle Johansson	8f19d8523b	Remove compiler warning for uninitialized variable git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@99384 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	3a95a07e69	Add a "console active" CLI command, which lets you find out which console device is currently active for the Asterisk CLI, or to set it. Also, knock multiple device support off of the to-do list. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@99248 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	f20450ea03	Merge changes from team/russell/console_devices - Add support for multiple devices. All devices are configured in console.conf. - Add "console list devices" CLI command to show configured devices. Also, changed the old "list devices" to be "list available", which queries PortAudio for all audio devices that are available for use. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@99227 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	89778a05c1	Make the output of "console list devices" a bit prettier. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@99011 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	30de4fc350	List which devices are inputs and outputs in "console list devices" git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@99009 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Olle Johansson	2905e69622	Change reference to external library so it appears on the extref listing http://www.asterisk.org/doxygen/trunk/extref.html git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@97200 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	f5580269e1	Add the URL to the home page for portaudio. Also add the location of the svn repository to check out portaudio v19. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@96692 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	fa39abb50b	Add support for generating a ringing sound on an incoming call. This is a bit of a hack. It just asks the core to generate the same tone that it would when you hear ringback when making an outbound call. But hey, it works, and you get the localized ring tone for the appropriate language set on the channel. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@96079 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	b8caf43b3a	Note that this module doesn't actually play a ringing sound for an incoming call ... oops git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@96077 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	d6c016a5aa	Show the correct CLI command to answer the call git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@96076 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	067fcc2a03	Update chan_console to natively use a 16 kHz sample rate. If it is talking to an 8 kHz endpoint, then codec_resample will automatically be used to properly resample the audio before sending it to/from chan_console. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@95527 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago
Russell Bryant	4e99cc88e2	Merge the main set of changes from team/russell/chan_console. Add a new console channel driver, chan_console, which is a console channel driver that uses portaudio as a cross platform audio interface. It was written to provide a console channel driver that works with Mac CoreAudio, but it supports a number of other audio interfaces, as well, including OSS and ALSA. It could one day be the single console channel driver, but does not yet have as many features as chan_oss. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@95412 65c4cc65-6c06-0410-ace0-fbb531ad65f3	18 years ago

30 Commits (2a68d05b9673c2895a4d483f17271a495327bc28)