32729 Commits (28bae5e901b2595cac7b159734762128a2c591fe)

 

All Branches   

Search

Author	SHA1	Message	Date
Joshua C. Colp	87fda066ea	res_rtp_asterisk: Improve video performance in certain networks. ... The receive buffer will now grow if we end up flushing the receive queue after not receiving the expected packet in time. This is done in hopes that if this is encountered again the extra buffer size will allow more time to pass and any missing packets to be received. The send buffer will now grow if we are asked for packets and can't find them. This is done in hopes that the packets are from the past and have simply been expired. If so then in the future with the extra buffer space the packets should be available. Sequence number cycling has been handled so that the correct sequence number is calculated and used in various places, including for sorting packets and for determining if a packet is old or not. NACK sending is now more aggressive. If a substantial number of missing sequence numbers are added a NACK will be sent immediately. Afterwards once the receive buffer reaches 25% a single NACK is sent. If the buffer continues to grow and reaches 50% or greater a NACK will be sent for each received future packet to aggressively ask the remote endpoint to retransmit. ASTERISK-28764 Change-Id: I97633dfa8a09a7889cef815b2be369f3f0314b41	5 years ago
Kevin Harwell	f8a852605d	Merge "res/res_pjsip_sdp_rtp: Fix MOH transitions"	5 years ago
Kevin Harwell	a715cf5aaa	message & stasis/messaging: make text message variables work in ARI ... When a text message was received any associated variable was not written to the ARI TextMessageReceived event. This occurred because Asterisk only wrote out "send" variables. However, even those "send" variables would fail ARI validation due to a TextMessageVariable formatting bug. Since it seems the TextMessageReceived event has never been able to include actual variables it was decided to remove the TextMessageVariable object type from ARI, and simply return a JSON object of key/value pairs for variables. This aligns more with how the ARI sendMessage handles variables, and other places in ARI. ASTERISK-28755 #close Change-Id: Ia6051c01a53b30cf7edef84c27df4ed4479b8b6f	5 years ago
Kevin Harwell	8a8253e55b	Merge "addons/res_config_mysql: silense warnings about printf format errors."	5 years ago
Kevin Harwell	2d9ecd9cd1	Merge "app_queue: Refactor odd placement of if's around say_position"	5 years ago
Kevin Harwell	d18af40431	Merge "say: Remove unused "plural" option from main/say"	5 years ago
Kevin Harwell	999fdef335	Merge "app_mixmonitor: Turn on synchronization by default"	5 years ago
Kevin Harwell	566f9a541f	Merge "format_cap: make function parameters 'const'"	5 years ago
Kevin Harwell	a3b3a9d2dc	Merge "pjsip: Update ACLs on named ACL changes."	5 years ago
Sebastian Kemper	b7fbb9c41f	check_expr2: fix cross-compile/hardening issues ... When building check_expr2 with ASLR PIE hardening enabled the linker fails. This is resolved by adding the regular compiler flags when building the object files from ast_expr2f.c and ast_expr2.c. Note: The STANDALONE define is removed because it is already defined in _ASTCFLAGS. YY_NO_INPUT is defined so that the compile survives '--enable-dev-mode'. Also, a Makefile variable "CROSS_COMPILING" is added so that the build system doesn't try to run check_expr2 when cross-compiling, because that will fail the build as will. ASTERISK-28685 #close Signed-off-by: Sebastian Kemper <sebastian_ml@gmx.net> Change-Id: If435b7db9f9ad8266245bda51c81c220f9658915	5 years ago
Torrey Searle	77c9ba8e63	res/res_pjsip_sdp_rtp: Fix MOH transitions ... Update the state of remote_hold immediately on receipt of remote SDP so that the information is available when building the SDP answer ASTERISK-28754 #close Change-Id: I7026032a807e9c95081cb8f060400b05deb4836f	5 years ago
Walter Doekes	680e6b9774	app_queue: Refactor odd placement of if's around say_position ... Change-Id: Icba97905e331812f129e5966e91a59b104c7a748	5 years ago
Kevin Harwell	1e1651b4f4	format_cap: make function parameters 'const' ... There were a couple places where the format cap function parameter was not 'const' when it should have been. This patch makes them 'const'. Change-Id: Ife753fb16a962d842a6b44f45363a61a66bfdb2e	5 years ago
Walter Doekes	0b5c6fddf1	say: Remove unused "plural" option from main/say ... There are exceptions for plural objects, but they are detected using the supplied NUMBER, not using an extra option. Change-Id: I95d1d1b2796b1aba92048a2dbae8a3856ed8a113	5 years ago
Jaco Kroon	5cd7230f3c	addons/res_config_mysql: silense warnings about printf format errors. ... Warnings without this: res_config_mysql.c: In function 'update2_mysql': res_config_mysql.c:741:15: warning: format '%llu' expects argument of type 'long long unsigned int', but argument 6 has type 'my_ulonglong' {aka 'long unsigned int'} [-Wformat=] ast_debug(1, "MySQL RealTime: Updated %llu rows on table: %s\n", numrows, tablename); (reformatted for readability within line-wrap) Change-Id: I2af4d419a37c1a7eeee750cf9ae4a9a2b3a37fd3	5 years ago
George Joseph	838583783f	Merge "tcptls.c: Log more informative OpenSSL errors"	5 years ago
George Joseph	3854b561a5	Merge "bridging: Add better support for adding/removing streams."	5 years ago
George Joseph	9f25b4aa44	Merge "ast_tls_cert: Allow private key size to be set on command line"	5 years ago
George Joseph	4f1ab6404b	Merge "app_mixmonitor: Set MIXMONITOR_FILENAME to correct value when wav49 is used"	5 years ago
George Joseph	12540a46a1	Merge "RTP/ICE: Send on first valid pair."	5 years ago
Joshua C. Colp	d6712790cd	pjsip: Update ACLs on named ACL changes. ... This change extends the Sorcery API to allow a wizard to be told to explicitly reload objects or a specific object type even if the wizard believes that nothing has changed. This has been leveraged by res_pjsip and res_pjsip_acl to reload endpoints and PJSIP ACLs when a named ACL changes. ASTERISK-28697 Change-Id: Ib8fee9bd9dd490db635132c479127a4114c1ca0b	5 years ago
Sean Bright	7f2d56fc8c	tcptls.c: Log more informative OpenSSL errors ... Dump OpenSSL's error stack to the error log when things fail. ASTERISK-28750 #close Reported by: Martin Zeh Change-Id: Ib63cd0df20275586e68ac4c2ddad222ed7bd9c0a	5 years ago
Sean Bright	de6919f339	ast_tls_cert: Allow private key size to be set on command line ... The default size in release branches will be 1024 but we'll use 2048 in master. ASTERISK~28750 Change-Id: I435cea18bdd58824ed2b55259575c7ec7133842a	5 years ago
George Joseph	78b01f41ae	res_pjsip_outbound_registration: Fix SRV failover on timeout ... In order to retry outbound registrations for some situations, we need access to the tdata from the original request. For instance, for 401/407 responses we need it to properly construct the subsequent request with the authentication. We also need it if we're iterating over a DNS SRV response record set so we can skip entries we've already tried. We've been getting the tdata from the server response rdata and transaction but that only works for the failures where there was actually a response (4XX, 5XX, etc). For timeouts there's no response and therefore no rdata or transaction from which to get the tdata. When processing a single A/AAAA record for a server, this wasn't an issue as we just retried that same server after the retry timer expired. If we got an SRV record set for the server though, without the state from the tdata, we just kept trying the first entry in the set repeatedly instead of skipping to the next one in the list. * Added a "last_tdata" member to the client state structure to keep track of the sent tdata. * Updated registration_client_send() to save the tdata it used into the client_state. * Updated sip_outbound_registration_response_cb() to use the tdata saved in client_state when we don't get a response from the server. We still use the tdata from the transaction when we DO get a response from the server so we can properly handle 4XX responses where our new request depends on it. General note on timeouts: Although res_pjsip_outbound_registration skips to the next record immediately when a timeout occurs during SRV set traversal, it's pjproject that determines how long to wait before a timeout is declared. As with other SIP message types, pjproject will continue trying the same server at an interval specified by "timer_t1" until "timer_b" expires. Both of those timers are set in the pjsip.conf "system" section. ASTERISK-28746 Change-Id: I199b8274392d17661dd3ce3b4d69a3968368fa06	5 years ago
Joshua C. Colp	5a5be92b79	bridging: Add better support for adding/removing streams. ... This change adds support to bridge_softmix to allow the addition and removal of additional video source streams. When such a change occurs each participant is renegotiated as needed to reflect the update. If another video source is added then each participant gets another source. If a video source is removed then it is removed from each participant. This functionality allows you to have both your webcam and screenshare providing video if you desire, or even more streams. Mapping has been changed to use the topology index on the source channel as a unique identifier for outgoing participant streams, this will never change and provides an easy way to establish the mapping. The bridge_simple and bridge_native_rtp modules have also been updated to renegotiate when the stream topology of a party changes allowing the same behavior to occur as added to bridge_softmix. If a screen share is added then the opposite party is renegotiated. If that screen share is removed then the opposite party is renegotiated again. Some additional fixes are also included in here. Stream state is now conveyed in SDP so sendonly/recvonly/inactive streams can be requested. Removed streams now also remove previous state from themselves so consumers don't get confused. ASTERISK-28733 Change-Id: I93f41fb41b85646bef71408111c17ccea30cb0c5	5 years ago
George Joseph	a6de4497e6	Merge "res_pjsip_sdp_rtp: implement hold state handling on moh_passthrough"	5 years ago
Ben Ford	168637cc0c	RTP/ICE: Send on first valid pair. ... When handling ICE negotiations, it's possible that there can be a delay between STUN binding requests which in turn will cause a delay in ICE completion, preventing media from flowing. It should be possible to send media when there is at least one valid pair, preventing this scenario from occurring. A change was added to PJPROJECT that adds an optional callback (on_valid_pair) that will be called when the first valid pair is found during ICE negotiation. Asterisk uses this to start the DTLS handshake, allowing media to flow. It will only be called once, either on the first valid pair, or when ICE negotiation is complete. ASTERISK-28716 Change-Id: Ia7b68c34f06d2a1d91c5ed51627b66fd0363d867	5 years ago
Sean Bright	8dcdce42a9	app_mixmonitor: Turn on synchronization by default ... The optional synchronization behavior created in 64906c4c9b is now the default for MixMonitor. * Add a new flag 'n' that allows for this behavior to be turned off * Add a notice when the 'S' option is used indicating that it is no longer necessary Change-Id: I158987c475cda4e1ff1256dd0daccdd99df568b4	5 years ago
George Joseph	1fc1336b2c	Merge "res_rtp_asterisk: bad audio (static) due to incomplete dtls/srtp setup"	5 years ago
Joshua Colp	12ba0682ed	Merge "stasis: Use format specifier for size_t."	5 years ago
Sean Bright	ddfb60ac2c	app_mixmonitor: Set MIXMONITOR_FILENAME to correct value when wav49 is used ... When opening a file for writing, Asterisk silently converts filenames ending with 'wav49' to 'WAV.' We aren't taking that in to account when setting the MIXMONITOR_FILENAME variable in MixMonitor. * If the user wants to write to a wav49 file, make sure that it is reflected properly in MIXMONITOR_FILENAME. * Add a note to the documentation describing this behavior. * Add a note in main/file.c indicating that app_mixmonitor needs to be changed if the logic in build_filename was changed. ASTERISK-24798 #close Reported by: xrobau Change-Id: I384691ce624eb55c80a125b9ca206d2d691c574c	5 years ago
Torrey Searle	bf4340f0ec	res_pjsip_sdp_rtp: implement hold state handling on moh_passthrough ... When moh_passthrough is used, asterisk is only generating invites of type sendonly and sendrecv instead of taking fully into account the on hold state of the local and remote parties ASTERISK-28738 #close Change-Id: Iaaad9fbc033cb14803d433b8a4071bc337047761	5 years ago
Joshua C. Colp	0f6ee98c3f	stasis: Use format specifier for size_t. ... Change-Id: Ic9b4afcc5398e7f46314419fc3c90433d818e35c	5 years ago
Kevin Harwell	3865b3fd6a	res_rtp_asterisk: bad audio (static) due to incomplete dtls/srtp setup ... There was a race condition between client initiated DTLS setup, and handling of server side ice completion that caused the underlying SSL object to get cleared during DTLS initialization. If this happened Asterisk would be left in a partial DTLS setup state. RTP packets were sent and received, but were not being encrypted and decrypted. This resulted in no audio, or static. Specifically, this occurred when '__rtp_recvfrom' was processing the handshake sequence from the client to the server, and then 'ast_rtp_on_ice_complete' gets called from another thread and clears the SSL object when calling the 'dtls_perform_setup' function. The timing had to be just right in the sense that from the external SSL library perspective SSL initialization completed (rtp recv), Asterisk clears/resets the SSL object (ice done), and then checks to see if SSL is intialized (rtp recv). Since it was cleared, Asterisk thinks it is not finished, thus not completing 'dtls_srtp_setup'. This patch removes calls to 'dtls_perform_setup', which clears the SSL object, in 'ast_rtp_on_ice_complete'. When ice completes, there is no reason to clear the underlying SSL object. If an ice candidate changes a full protocol level renegotiation occurs. Also, in the case of bundled ICE candidates are reused when a stream is added. So no real reason to have to clear, and reset in this instance. Also, this patch adds a bit of extra logging to aid in diagnosis of any future problems. ASTERISK-28742 #close Change-Id: I34c9e6bad5a39b087164646e2836e3e48fe6892f	5 years ago
Joshua Colp	519f21ecb2	Merge "res_pjsip_session: Fix off-nominal session refreshes."	5 years ago
Joshua Colp	4d671a2d14	Merge "res_musiconhold: Avoid spurious warning when 'format' is the empty string"	5 years ago
George Joseph	0d8275aa96	Merge "doc: Fix CHANGES entries to have .txt suffix and update READMEs"	5 years ago
Sean Bright	aeff1f2c53	res_musiconhold: Avoid spurious warning when 'format' is the empty string ... The change to res_config_odbc that allowed empty strings to be returned to realtime consumers¹ causes a warning to be emitted when loading MoH classes. So we need to treat an empty 'format' as if it was not specified to avoid the warning. ASTERISK-28735 #close Reported by: Ross Beer [1] https://gerrit.asterisk.org/c/asterisk/+/13722 Change-Id: I9a271d721e1a0973e80ebe7d75b46a0d8fa0e5a5	5 years ago
Sean Bright	1e037ebb97	func_odbc: Prevent snprintf() truncation warning ... For reasons that are not clear to me - this only appears for me when _not_ building in dev-mode. Change-Id: Ib45c54daaea8e0d571cb470cab1daaae2edba968	5 years ago
Joshua C. Colp	ac155decae	res_pjsip_session: Fix off-nominal session refreshes. ... Given a scenario where session refreshes occur close to each other while another is finishing it was possible for the session refreshes to occur out of order. It was also possible for session refreshes to be delayed for quite some time if a session refresh did not result in a topology change. For the out of order session refreshes the first session refresh would be queued due to a transaction in progress. This transaction would then finish. When finished a separate task to process the delayed requests queue would be queued for handling. A second refresh would be requested internally before this delayed request queued task was processed. As no transaction was in progress this session refresh would be immediately handled before the queued session refresh. The code will now check if any delayed requests exist before allowing a session refresh to immediately occur. If any exist then the session refresh is queued. For the delayed session refreshes if a session refresh did not result in a topology change the attempt would be immediately stopped and no other delayed requests would be processed. The code will now go through the entire delayed requests queue until a delayed request results in a request actually being sent. ASTERISK-28730 Change-Id: Ied640280133871f77d3f332be62265e754605088	5 years ago
George Joseph	a72caa041f	doc: Fix CHANGES entries to have .txt suffix and update READMEs ... Although the wiki page for the new CHANGES and UPGRADE scheme states that the files must have the ".txt" suffix, the READMEs didn't. Change-Id: I490306aa2cc24d6f014738e9ebbc78592efe0f05 (cherry picked from commit 7416703f04)	5 years ago
Joshua Colp	b2b6f28ac2	Merge "pjproject_bundled: Allow brackets in via parameters"	5 years ago
Friendly Automation	7c5a6efb44	Merge "install_prereq: Install aptitude non-interactively"	5 years ago
Joshua Colp	e5a53e50ba	Merge "chan_sip: Return 503 if we're out of RTP ports"	5 years ago
Sean Bright	9d9bde76a9	pjproject_bundled: Allow brackets in via parameters ... ASTERISK-26955 #close Reported by: Peter Sokolov Change-Id: Ib2803640905a77b65d0cee2d0ed2c7b310d470ac	5 years ago
Joshua Colp	67e4ec1a6c	Merge "chan_sip: Clarify in sample docs how directmediapermit/-acl should be used"	5 years ago
Joshua Colp	49809cb078	Merge "res_rtp_asterisk: Don't produce transport-cc if no packets."	5 years ago
Friendly Automation	dda7f986d0	Merge "res_config_odbc: Preserve empty strings returned by the database"	5 years ago
Friendly Automation	a41c971371	Merge "res_stasis_playback: Prevent media_index from going out of bounds"	5 years ago
Sylvain Afchain	0c02d0a450	install_prereq: Install aptitude non-interactively ... Currently aptitude is installed using interactive mode. This patch changes this to use the non-interactive mode as it can block automatic dependencies installation, ex: CI, Docker build. ASTERISK-28726 #close Change-Id: I271ee00d230513a6f044810351a32d83b2181133	5 years ago