5238 Commits (27283a9209c5fdf297989945d78afa1f67866258)

Author	SHA1	Message	Date
Naveen Albert	c4d9e950bd	app_voicemail: Disable ADSI if unavailable. ... If ADSI is available on a channel, app_voicemail will repeatedly try to use ADSI, even if there is no CPE that supports it. This leads to many unnecessary delays during the session. If ADSI is available but ADSI setup fails, we now disable it to prevent further attempts to use ADSI during the session. Resolves: #354	2 years ago
Jaco Kroon	60b529ea00	app_queue: periodic announcement configurable start time. ... This newly introduced periodic-announce-startdelay makes it possible to configure the initial start delay of the first periodic announcement after which periodic-announce-frequency takes over. UserNote: Introduce a new queue configuration option called 'periodic-announce-startdelay' which will vary the normal (historic) behavior of starting the periodic announcement cycle at periodic-announce-frequency seconds after entering the queue to start the periodic announcement cycle at period-announce-startdelay seconds after joining the queue. The default behavior if this config option is not set remains unchanged. Signed-off-by: Jaco Kroon <jaco@uls.co.za>	2 years ago
Naveen Albert	1ada3c0747	app_dial: Fix infinite loop when sending digits. ... If the called party hangs up while digits are being sent, -1 is returned to indicate so, but app_dial was not checking the return value, resulting in the hangup being lost and looping forever until the caller manually hangs up the channel. We now abort if digit sending fails. ASTERISK-29428 #close Resolves: #281	2 years ago
Mike Bradeen	62480fd91b	app_voicemail: Fix for loop declarations ... Resolve for loop initial declarations added in cli changes. Resolves: #275	2 years ago
zhengsh	a2353f4803	app_audiosocket: Fixed timeout with -1 to avoid busy loop. ... Resolves: asterisk#234	2 years ago
Matthew Fredrickson	ec4e0340ce	app_macro: Fix locking around datastore access ... app_macro sometimes would crash due to datastore list corruption on the channel because of lack of locking around find and create process for the macro datastore. This patch locks the channel lock prior to protect against this problem. Resolves: #265	2 years ago
Matthew Fredrickson	3f80f9ce0b	Revert "app_stack: Print proper exit location for PBXless channels." ... This reverts commit 617dad4cba. apps/app_stack.c: Revert buggy gosub patch This seems to break the case when a predial macro calls a gosub. When the gosub calls return, the Return function outputs: app_stack.c:423 return_exec: Return without Gosub: stack is empty This returns -1 to the calling macro, which returns to app_dial and causes the call to hangup instead of proceeding with the macro that invoked the gosub. Resolves: #253	2 years ago
Joshua C. Colp	71558e23d0	app_queue: Add support for applying caller priority change immediately. ... The app_queue module provides both an AMI action and a CLI command to change the priority of a caller in a queue. Up to now this change of priority has only been reflected to new callers into the queue. This change adds an "immediate" option to both the AMI action and CLI command which immediately applies the priority change respective to the other callers already in the queue. This can allow, for example, a caller to be placed at the head of the queue immediately if their priority is sufficient. Resolves: #202 UserNote: The 'queue priority caller' CLI command and 'QueueChangePriorityCaller' AMI action now have an 'immediate' argument which allows the caller priority change to be reflected immediately, causing the position of a caller to move within the queue depending on the priorities of the other callers.	2 years ago
Mike Bradeen	74f62dbfe9	Adds manager actions to allow move/remove/forward individual messages ... in a particular mailbox folder. The forward command can be used to copy a message within a mailbox or to another mailbox. Also adds a VoicemailBoxSummarry, required to retrieve message ID's. Resolves: #181 UserNote: The following manager actions have been added VoicemailBoxSummary - Generate message list for a given mailbox VoicemailRemove - Remove a message from a mailbox folder VoicemailMove - Move a message from one folder to another within a mailbox VoicemailForward - Copy a message from one folder in one mailbox to another folder in another or the same mailbox.	2 years ago
Mike Bradeen	6aff1c1065	app_voicemail: add CLI commands for message manipulation ... Adds CLI commands to allow move/remove/forward individual messages from a particular mailbox folder. The forward command can be used to copy a message within a mailbox or to another mailbox. Also adds a show mailbox, required to retrieve message ID's. Resolves: #170 UserNote: The following CLI commands have been added to app_voicemail voicemail show mailbox <mailbox> <context> Show contents of mailbox <mailbox>@<context> voicemail remove <mailbox> <context> <from_folder> <messageid> Remove message <messageid> from <from_folder> in mailbox <mailbox>@<context> voicemail move <mailbox> <context> <from_folder> <messageid> <to_folder> Move message <messageid> in mailbox <mailbox>&<context> from <from_folder> to <to_folder> voicemail forward <from_mailbox> <from_context> <from_folder> <messageid> <to_mailbox> <to_context> <to_folder> Forward message <messageid> in mailbox <mailbox>@<context> <from_folder> to mailbox <mailbox>@<context> <to_folder>	2 years ago
Mike Bradeen	5f01983abd	app_voicemail: fix imap compilation errors ... Fixes two compilation errors in app_voicemail_imap, one due to an unsed variable and one due to a new variable added in the incorrect location in _163. Resolves: #174	2 years ago
Olaf Titz	3b23ee4203	app_voicemail_imap: Fix message count when IMAP server is unavailable ... Some callers of __messagecount did not correctly handle error return, instead returning a -1 message count. This caused a notification with "Messages-Waiting: yes" and "Voice-Message: -1/0 (0/0)" if the IMAP server was unavailable. Fixes: #64	2 years ago
Nathan Bruning	c88a8aa8b0	app_queue: Add force_longest_waiting_caller option. ... This adds an option 'force_longest_waiting_caller' which changes the global behavior of the queue engine to prevent queue callers from 'jumping ahead' when an agent is in multiple queues. Resolves: #108 Also closes old asterisk issues: - ASTERISK-17732 - ASTERISK-17570 Change-Id: I0f84e27903fefbe2018d0afa2d67b23aa0b321ce	2 years ago
alex2grad	591351d4ad	app_followme: fix issue with enable_callee_prompt=no (#88) ... * app_followme: fix issue with enable_callee_prompt=no If the FollowMe option 'enable_callee_prompt' is set to 'no' then Asterisk incorrectly sets a winner channel to the channel from which any control frame was read. This fix sets the winner channel only to the answered channel. Resolves: #87 ASTERISK-30326	2 years ago
Niklas Larsson	12fb5d8589	app_queue: Preserve reason for realtime queues ... When Asterisk is restarted it does not preserve paused reason for members of realtime queues. This was fixed for non-realtime queues in ASTERISK_25732 Resolves: #66 UpgradeNote: Add a new column to the queue_member table: reason_paused VARCHAR(80) so the reason can be preserved. UserNote: Make paused reason in realtime queues persist an Asterisk restart. This was fixed for non-realtime queues in ASTERISK_25732.	2 years ago
Joshua Colp	a8ce41b7f7	Revert "app_queue: periodic announcement configurable start time." ... This reverts commit c405630810. Reason for revert: Causes segmentation fault. Change-Id: Ib0c8c592f8d4f0a5e3889aeadfe8bdcde800ba42	3 years ago
Naveen Albert	1ed147ffc1	app_queue: Fix minor xmldoc duplication and vagueness. ... The F option in the xmldocs for the Queue application was erroneously duplicated, causing it to display twice on the wiki. The two sections are now merged into one. Additionally, the description for the d option was quite vague. Some more details are added to provide context as to what this actually does. ASTERISK-30486 #close Change-Id: I6706cea708b5cc781f59f8652c2cb377e55aed7e	3 years ago
Mike Bradeen	b2e9419961	res_mixmonitor: MixMonitorMute by MixMonitor ID ... While it is possible to create multiple mixmonitor instances on a channel, it was not previously possible to mute individual instances. This change includes the ability to specify the MixMonitorID when calling the manager action: MixMonitorMute. This will allow an individual MixMonitor instance to be muted via id. This id can be stored as a channel variable using the 'i' MixMonitor option. As part of this change, if no MixMonitorID is specified in the manager action MixMonitorMute, Asterisk will set the mute flag on all MixMonitor spy-type audiohooks on the channel. This is done via the new audiohook function: ast_audiohook_set_mute_all. ASTERISK-30464 Change-Id: Ibba8c7e750577aa1595a24b23316ef445245be98	3 years ago
Jaco Kroon	c405630810	app_queue: periodic announcement configurable start time. ... This newly introduced periodic-announce-startdelay makes it possible to configure the initial start delay of the first periodic announcement after which periodic-announce-frequency takes over. ASTERISK-30437 #close Change-Id: Ia79984b6377ef78f167ad9ea2ac084bec29955d0 Signed-off-by: Jaco Kroon <jaco@uls.co.za>	3 years ago
Naveen Albert	48e3da5cdf	app_dial: Fix DTMF not relayed to caller on unanswered calls. ... DTMF frames are not handled in app_dial when sent towards the caller. This means that if DTMF is sent to the calling party and the call has not yet been answered, the DTMF is not audible. This is now fixed by relaying DTMF frames if only a single destination is being dialed. ASTERISK-29516 #close Change-Id: Iafd7430ac2915126d42dc48f0b73b262452ee027	3 years ago
Naveen Albert	0c8b42ede3	app_senddtmf: Add SendFlash AMI action. ... Adds an AMI action to send a flash event on a channel. ASTERISK-30440 #close Change-Id: I4707aeecb3cd8f3e63fd0c3fe009798943c369c9	3 years ago
Mike Bradeen	fc5b7ab459	app_read: Add an option to return terminator on empty digits. ... Adds 'e' option to allow Read() to return the terminator as the dialed digits in the case where only the terminator is entered. ie; if "#" is entered, return "#" if the 'e' option is set and "" if it is not. ASTERISK-30411 Change-Id: I49f3221824330a193a20c660f99da0f1fc2cbbc5	3 years ago
Mike Bradeen	3b75e6d45e	app_directory: Add a 'skip call' option. ... Adds 's' option to skip calling the extension and instead set the extension as DIRECTORY_EXTEN channel variable. ASTERISK-30405 Change-Id: Ib9d9db1ba5b7524594c640461b4aa8f752db8299	3 years ago
Mike Bradeen	f015d3e0cc	app_senddtmf: Add option to answer target channel. ... Adds a new option to SendDTMF() which will answer the specified channel if it is not already up. If no channel is specified, the current channel will be answered instead. ASTERISK-30422 Change-Id: Iddcbd501fcdf9fef0f453b7a8115a90b11f1d085	3 years ago
Sean Bright	603675f285	app_queue: Minor docs and logging fixes for UnpauseQueueMember. ... ASTERISK-30417 #close Change-Id: I7534e7a925bf92a7b5a5347f5f54225768c162fe	3 years ago
Sean Bright	7687c75cb6	app_queue: Reset all queue defaults before reload. ... Several queue fields were not being set to their default value during a reload. Additionally added some sample configuration options that were missing from queues.conf.sample. Change-Id: I3a88c7877af91752b1b46a0c087384f7eb9c47e4	3 years ago
Naveen Albert	d53c8fc4dc	app_signal: Add signaling applications ... Adds the Signal and WaitForSignal applications, which can be used for inter-channel signaling in the dialplan. Signal supports sending a signal to other channels listening for a signal of the same name, with an optional data payload. The signal is received by all channels waiting for that named signal. ASTERISK-29810 #close Change-Id: Ic34439de3d60f8609357666a465c354d81f5fef3	3 years ago
Sean Bright	41d3a57627	doxygen: Fix doxygen errors. ... Change-Id: Ic50e95b4fc10f74ab15416d908e8a87ee8ec2f85	3 years ago
Mike Bradeen	ef6901e137	app_directory: add ability to specify configuration file ... Adds option to app_directory to specify a filename from which to read configuration instead of voicemail.conf ie; same => n,Directory(,,c(directory.conf)) This configuration should contain a list of extensions using the voicemail.conf format, ie; 2020=2020,Dog Dog,,,,attach=no|saycid=no|envelope=no|delete=no ASTERISK-30404 Change-Id: Id58ccb1344ad1e563fa10db12f172fbd104a9d13	3 years ago
Sean Bright	07a850c6dd	app_playback.c: Fix PLAYBACKSTATUS regression. ... In Asterisk 11, if a channel was redirected away during Playback(), the PLAYBACKSTATUS variable would be set to SUCCESS. In Asterisk 12 (specifically commit 7d9871b394) that behavior was inadvertently changed and the same operation would result in the PLAYBACKSTATUS variable being set to FAILED. The Asterisk 11 behavior has been restored. Partial fix for ASTERISK~25661. Change-Id: I53f54e56b59b61c99403a481b6cb8d88b5a559ff	3 years ago
Naveen Albert	0dc3d8c655	app_broadcast: Add Broadcast application ... Adds a new application, Broadcast, which can be used for one-to-many transmission and many-to-one reception of channel audio in Asterisk. This is similar to ChanSpy, except it is designed for multiple channel targets instead of a single one. This can make certain kinds of audio manipulation more efficient and streamlined. New kinds of audio injection impossible with ChanSpy are also made possible. ASTERISK-30180 #close Change-Id: I7ba72f765dbab9b58deeae028baca3f4f8377726	3 years ago
Naveen Albert	1974ebe109	app_voicemail_odbc: Fix string overflow warning. ... Fixes a negative offset warning by initializing the buffer to empty. Additionally, although it doesn't currently complain about it, the size of a buffer is increased to accomodate the maximum size contents it could have. ASTERISK-30240 #close Change-Id: I8eecedf14d3f2a75864797f802277cac89a32877	3 years ago
Naveen Albert	462461870d	app_if: Fix format truncation errors. ... Fixes format truncation warnings in gcc 12.2.1. ASTERISK-30349 #close Change-Id: I42be4edf0284358b906e765d1966b6b9d66e1d3c	3 years ago
Naveen Albert	5a78ce5a1f	app_voicemail: Fix missing email in msg_create_from_file. ... msg_create_from_file currently does not dispatch emails, which means that applications using this function, such as MixMonitor, will not trigger notifications to users (only AMI events are sent our currently). This is inconsistent with other ways users can receive voicemail. This is fixed by adding an option that attempts to send an email and falling back to just the notifications as done now if that fails. The existing behavior remains the default. ASTERISK-30283 #close Change-Id: I597cbb9cf971a18d8776172b26ab187dc096a5c7	3 years ago
Naveen Albert	a7cd9ce26f	app_if: Adds conditional branch applications ... Adds the If, ElseIf, Else, ExitIf, and EndIf applications for conditional execution of a block of dialplan, similar to the While, EndWhile, and ExitWhile applications. The appropriate branch is executed at most once if available and may be broken out of while inside. ASTERISK-29497 Change-Id: I3aa3bd35a5add82465c6ee9bd86b64601f0e1f49	3 years ago
Naveen Albert	3cdc280cad	app_mixmonitor: Add option to use real Caller ID for voicemail. ... MixMonitor currently uses the Connected Line as the Caller ID for voicemails. This is due to the implementation being written this way for use with Digium phones. However, in general this is not correct for generic usage in the dialplan, and people may need the real Caller ID instead. This adds an option to do that. ASTERISK-30286 #close Change-Id: I3d0ce76dfe75e2a614e0f709ab27acbd2478267c	3 years ago
Naveen Albert	3c7dde3bf6	sla: Prevent deadlock and crash due to autoservicing. ... SLAStation currently autoservices the station channel before creating a thread to actually dial the trunk. This leads to duplicate servicing of the channel which causes assertions, deadlocks, crashes, and moreover not the correct behavior. Removing the autoservice prevents the crash, but if the station hangs up before the trunk answers, the call hangs since the hangup was never serviced on the channel. This is fixed by not autoservicing the channel, but instead servicing it in the thread dialing the trunk, since it is doing so synchronously to begin with. Instead of sleeping for 100ms in a loop, we simply use the channel for timing, and abort if it disappears. The same issue also occurs with SLATrunk when a call is answered, because ast_answer invokes ast_waitfor_nandfds. Thus, we use ast_raw_answer instead which does not cause any conflict and allows the call to be answered normally without thread blocking issues. ASTERISK-29998 #close Change-Id: Icc237d50354b5910000d2305901e86d2c87bb9d8	3 years ago
Naveen Albert	60232365ab	app_mixmonitor: Add option to delete files on exit. ... Adds an option that allows MixMonitor to delete its copy of any recording files before exiting. This can be handy in conjunction with options like m, which copy the file elsewhere, and the original files may no longer be needed. ASTERISK-30284 #close Change-Id: Ida093679c67e300efc154a97b6d8ec0f104e581e	3 years ago
Naveen Albert	617dad4cba	app_stack: Print proper exit location for PBXless channels. ... When gosub is executed on channels without a PBX, the context, extension, and priority are initialized to the channel driver's default location for that endpoint. As a result, the last Return will restore this location and the Gosub logs will print out bogus information about our exit point. To fix this, on channels that don't have a PBX, the execution location is left intact on the last return if there are no further stack frames left. This allows the correct location to be printed out to the user, rather than the bogus default context. ASTERISK-30076 #close Change-Id: I1d42a99c9aa9e3708d32718863175158a894e414 (cherry picked from commit 12d18b0a40)	3 years ago
Naveen Albert	062cef0a85	app_bridgewait: Add option to not answer channel. ... Adds the n option to not answer the channel when calling BridgeWait, so the application can be used without forcing answer supervision. ASTERISK-30216 #close Change-Id: I6b85ef300b1f7b5170f8537e2b10889cc2e6605a	3 years ago
Naveen Albert	fdac31f279	app_amd: Add option to play audio during AMD. ... Adds an option that will play an audio file to the party while AMD is running on the channel, so the called party does not just hear silence. ASTERISK-30179 #close Change-Id: I4af306274552b61b3d9f0883c33f698abd4699b6	3 years ago
Naveen Albert	8c6c06a340	app_confbridge: Add end_marked_any option. ... Adds the end_marked_any option, which can be used to kick a user from a conference if any marked user leaves. ASTERISK-30211 #close Change-Id: I9e8da7ccb892e522546c0f2b5476d172e022c2f5	3 years ago
Naveen Albert	9126f9bd2b	general: Very minor coding guideline fixes. ... Fixes a few coding guideline violations: * Use of C99 comments * Opening brace on same line as function prototype ASTERISK-30163 #close Change-Id: I07771c4c89facd41ce8d323859f022ddbddf6ca7	3 years ago
Naveen Albert	300a6150d5	app_confbridge: Fix memory leak on updated menu options. ... If the CONFBRIDGE function is used to dynamically set menu options, a memory leak occurs when a menu option that has been set is overridden, since the menu entry is not destroyed before being freed. This ensures that it is. Additionally, logic that duplicates the destroy function is removed in lieu of the destroy function itself. ASTERISK-28422 #close Change-Id: I71cfb5c24e636984d41086d1333a416dc12ff995	3 years ago
Naveen Albert	f459872430	app_meetme: Add missing AMI documentation. ... The MeetmeList and MeetmeListRooms AMI responses are currently completely undocumented. This adds documentation for these responses. ASTERISK-30018 #close Change-Id: Id93135b7edf01de6f8fba266e2122989dc8996b8	3 years ago
Naveen Albert	08afdcbd30	general: Improve logging levels of some log messages. ... Adjusts some logging levels to be more or less important, that is more prominent when actual problems occur and less prominent for less noteworthy things. ASTERISK-30153 #close Change-Id: Ifc8f7df427aa018627db462125ae744986d3261b	3 years ago
Naveen Albert	307b0fa767	general: Remove obsolete SVN references. ... There are a handful of files in the tree that reference an SVN link for the coding guidelines. This removes these because the links are dead and the vast majority of source files do not contain these links, so this is more consistent. app_skel still maintains an (up to date) link to the coding guidelines. ASTERISK-30159 #close Change-Id: I35bbb20f66982e98099cff3029ede20091ffdac7	3 years ago
Naveen Albert	38515df4da	app_confbridge: Add missing AMI documentation. ... Documents the ConfbridgeListRooms AMI response, which is currently not documented. ASTERISK-30020 #close Change-Id: Id6fff7a936244bae7b52686301eb740c1169cdea	3 years ago
Naveen Albert	a4266030ce	app_confbridge: Always set minimum video update interval. ... Currently, if multiple video-enabled ConfBridges are conferenced together, we immediately get into a scenario where an infinite sequence of video updates fills up the taskprocessor queue and causes memory consumption to climb unabated until Asterisk is killed. This is due to the core bridging mechanism that provides video updates (softmix_bridge_write_control in bridge_softmix.c) continously updating all the channels in the bridge with video updates. The logic to do so in the core is that the video updates should be provided if the video_update_discard property for the bridge is 0, or if enough time has elapsed since the last video update. Thus, we already have a safeguard built in to ensure the scenario described above does not happen. Currently, however, this safeguard is not being adequately ensured. In app_confbridge, the video_update_discard property defaults to 2000, which is a healthy value that should completely prevent this issue. However, this value is only set onto the bridge in the SFU video mode. This leaves video modes such as follow_talker completely vulnerable, since video_update_discard will actually be 0, since the default or set value was never applied. As a result, the core bridging mechanism will always try to provide video updates regardless of when the last one was sent. To prevent this issue from happening, we now always set the video_update_discard property on the bridge with the value from the bridge profile. The app_confbridge defaults will thus ensure that infinite video updates no longer happen in any video mode. ASTERISK-29907 #close Change-Id: I4accb2536ac62797950468e9930f12ef7dd486b2	3 years ago
Naveen Albert	0fe1a581e5	general: Fix various typos. ... ASTERISK-30089 #close Change-Id: I1f5db911fd05a3a211c522c13e990fa1d0e62275	3 years ago