28822 Commits (23db04ed93d6d8332881dc539b55a7c46d33b17c)

 

All Branches   

Search

Author	SHA1	Message	Date
Richard Mudgett	6208962b00	res_pjsip: Update artificial auth whenever default_realm changes. ... There was code attempting to update the artificial authentication object whenever the default_realm changed. However, once the artificial authentication object was created it would never get updated. The artificial authentication object would require a system restart for a change to the default_realm to take effect. ASTERISK-26799 Change-Id: Id59036e9529c2d3ed728af2ed904dc36e7094802	9 years ago
Richard Mudgett	9f11da85a2	res_pjsip: Update authentication realm documentation. ... Using the same auth section for inbound and outbound authentication is not recommended. There is a difference in meaning for an empty realm setting between inbound and outbound authentication uses. An empty inbound auth realm represents the global section's default_realm value when the authentication object is used to challenge an incoming request. An empty outgoing auth realm is treated as a don't care wildcard when the authentication object is used to respond to an incoming authentication challenge. ASTERISK-26799 Change-Id: Id3952f7cfa1b6683b9954f2c5d2352d2f11059ce	9 years ago
zuul	557ef67690	Merge "tcptls.c: Add some missing allocation failure checks." into 13	9 years ago
zuul	8287a012b6	Merge "app_voicemail: vm_authenticate accesses uninitialized memory" into 13	9 years ago
Richard Mudgett	473813311b	pjproject: Fixes to resolve DNS SRV crashes. ... * Re #1945 (misc): Don't trigger SRV complete callback when there is a parse error. * srv_resolver.c: Don't try to send query if already considered resolved. ** In resolve_hostnames() don't try to resolve a query that is already considered resolved. ** In resolve_hostnames() fix DNS typo in comments. ** In build_server_entries() move a common expression assigning to cnt earlier. * sip_transport.c: Fix tdata object name to actually contain the pointer. It helps if the logs referencing a tdata object buffer actually have a name that includes the correct pointer as part of the name. Also since the tdata has its own pool it helps if any logs referencing the pool have the same name as the tdata object. This change brings tdata logging in line with how tsx objects are named. ASTERISK-26669 #close ASTERISK-26738 #close Change-Id: I56af2ded25476b3e870ca586ee69ed6954ef75af	9 years ago
Richard Mudgett	d58fdae811	pjsip_distributor.c: Update some debug messages to get transaction name. ... * Removed overloaded unmatched response ignore. We obviously sent the request so we shouldn't ignore it because it isn't new work. ASTERISK-26669 ASTERISK-26738 Change-Id: I55fb5cadc83a8e6699b347c6dc7fa32c5a617d37	9 years ago
Richard Mudgett	eb9ae4f7cb	res_pjsip: Record the serializer earlier on the tdata. ... When PJPROJECT needs to do a DNS resolution and there is not a cached entry available, the SIP request message goes out on the PJSIP monitor thread instead of the original serializer thread. Thus when the response comes back it does not get processed by the original sending serializer. This patch records the serializer on tdata before passing a request message to PJPROJECT where it can in Asterisk code. There are several places in PJPROJECT for outbound registration and publishing support that would need to record the serializer. Unfortunately, without replacing the PJPROJECT DNS resolver as was done in v14 we cannot fix those without modifying PJPROJECT. Even if we backported the DNS resolver from v14, the outbound registration refresh timer does not go out on a serializer thread but the PJSIP monitor thread. Fortunately, Asterisk's outbound publish support doesn't use the auto refresh timer that would also not go out under the serializer thread. This patch is v13 only. ASTERISK-26669 ASTERISK-26738 Change-Id: I9997b9ed6dbcebd2c37d6a67dc6dcee9c78914a4	9 years ago
Richard Mudgett	57f19d6efb	pjproject: Increase SENDER_WIDTH column size for 64-bit system logs. ... ASTERISK-26669 ASTERISK-26738 Change-Id: Ibae6fc8cae69a1f04df0c577c4c11200499d6fe0	9 years ago
zuul	d7433aa796	Merge "pjproject cli: Add object count after object lists" into 13	9 years ago
zuul	d8ae2e053b	Merge "res_config_sqlite3: Properly create missing columns when necessary" into 13	9 years ago
Sean Bright	47daca8a2b	app_voicemail: vm_authenticate accesses uninitialized memory ... vm_authenticate doesn't always set the passed ast_vm_user argument, so we initialize to 0 before passing it in. ASTERISK-25893 #close Reported by: Filip Jenicek Change-Id: Ia3cc0128f93d352ed9add8d5c2f0f7232c2cbe4a	9 years ago
zuul	a6db9c480e	Merge "Revert "build: Execute ldconfig to build cache."" into 13	9 years ago
Joshua Colp	06214173a9	Revert "build: Execute ldconfig to build cache." ... This reverts commit e910dbab90. Change-Id: I242aa0a965a79738dc898299959c6d2e020c86bd	9 years ago
George Joseph	c9ea98f9bf	pjproject cli: Add object count after object lists ... When listing a container, we now print the number of objects in the container at the end of the list. Change-Id: I791cbc3ee9da9a2af9adc655164b5d32953df812	9 years ago
Sean Bright	d8972f50f4	res_config_ldap: Don't try to delete non-existent attributes ... OpenLDAP will raise an error when we try to delete an LDAP attribute that doesn't exist. We need to filter out LDAP_MOD_DELETE requests based on which attributes the current LDAP entry actually has. There is of course a small window of opportunity for this to still fail, but it is much less likely now. Change-Id: I3fe1b04472733e43151563aaf9f8b49980273e6b	9 years ago
Sean Bright	b980cae1f7	res_config_ldap: Remove extraneous line numbers from log messages ... Extraneous line numbers were being output in many log messages. These have been removed. Change-Id: Ice9efa3d252ee87f37fa8f5ea852fda482675431	9 years ago
Sean Bright	011b7be62a	res_config_ldap: Make memory allocation more consistent ... The code in update_ldap() and update2_ldap() was using both Asterisk's memory allocation routines as well as OpenLDAP's. I've changed it so that everything that is passed to OpenLDAP's functions are allocated with their routines. Change-Id: Iafec9c1fd8ea49ccc496d6316769a6a426daa804	9 years ago
Sean Bright	b2836dde7e	res_config_ldap: Fix configuration inheritance from _general ... The "_general" configuration section allows administrators to provide both general configuration options (host, port, url, etc.) as well as a global realtime-to-LDAP-attribute mapping that is a fallback if one of the later sections do not override it. This neglected to exclude the general configuration options from the mapping. As an example, during my testing, chan_sip requested 'port' from realtime, and because I did not have it defined, it pulled in the 'port' configuration option from "_general." We now filter those out explicitly. Change-Id: I1fc61560bf96b8ba623063cfb7e0a49c4690d778	9 years ago
Sean Bright	6d5e9993b2	res_config_ldap: Fix erroneous LDAP_MOD_REPLACE in LDAP modify ... We always treat the first change of our modification batch as a replacement when it sometimes is actually a delete. So we have to pass the correct arguments to the OpenLDAP library. ASTERISK-26580 #close Reported by: Nicholas John Koch Patches: res_config_ldap.c-11.24.1.patch (license #6833) patch uploaded by Nicholas John Koch Change-Id: I0741d25de07c9539f1edc6eff3696165dfb64fbe	9 years ago
zuul	919fe21155	Merge "res_config_sqlite3: Fix crash when loading with invalid config" into 13	9 years ago
Sean Bright	5b7c6678ae	res_config_sqlite3: Fix crash when loading with invalid config ... When ast_config_load() fails with CONFIG_STATUS_FILEINVALID, it has already destroyed the ast_config struct for us. Trying to do it again results in a crash. Change-Id: If6a5c0ca718ad428e01a1fb25beb209a9ac18bc6	9 years ago
Richard Mudgett	096496e13e	tcptls.c: Add some missing allocation failure checks. ... Change-Id: I0ddf01cd3c10d3b6666d7bf68d4e206a37f4fbdb	9 years ago
Sean Bright	047a1e7dcc	pjproject-bundled: Fix checksum verification when using cURL ... ASTERISK-26802 #close Reported by: Michael L. Young Change-Id: Iad293080f55d4d69ab615717a15211d916eed613	9 years ago
Joshua Colp	2b10ba8074	Merge "build: Execute ldconfig to build cache." into 13	9 years ago
Sean Bright	2cd75fe311	realtime: Fix LIKE escaping in SQL backends ... The realtime framework allows for components to look up values using a LIKE clause with similar syntax to SQL's. pbx_realtime uses this functionality to search for pattern matching extensions that start with an underscore (_). When passing an underscore to SQL's LIKE clause, it will be interpreted as a wildcard matching a single character and therefore needs to be escaped. It is (for better or for worse) the responsibility of the component that is querying realtime to escape it with a backslash before passing it in. Some RDBMs support escape characters by default, but the SQL92 standard explicitly says that there are no escape characters unless they are specified with an ESCAPE clause, e.g. SELECT * FROM table WHERE column LIKE '\_%' ESCAPE '\' This patch instructs 3 backends - res_config_mysql, res_config_pgsql, and res_config_sqlite3 - to use the ESCAPE clause where appropriate. Looking through documentation and source tarballs, I was able to determine that the ESCAPE clause is supported in: MySQL 5.0.15 (released 2005-10-22 - earliest version available from archives) PostgreSQL 7.1 (released 2001-04-13) SQLite 3.1.0 (released 2005-01-21) The versions of the relevant libraries that we depend on to access MySQL and PostgreSQL will not work on versions that old, and I've added an explicit check in res_config_sqlite3 to only use the ESCAPE clause when we have a sufficiently new version of SQLite3. res_config_odbc already handles the escape characters appropriately, so no changes were required there. ASTERISK-15858 #close Reported by: Humberto Figuera ASTERISK-26057 #close Reported by: Stepan Change-Id: I93117fbb874189ae819f4a31222df7c82cd20efa	9 years ago
zuul	73cbb915c1	Merge "chan_unistim: fix char type to have consistent behavior on ARM" into 13	9 years ago
Joshua Colp	e910dbab90	build: Execute ldconfig to build cache. ... On some platforms a multiarch approach is used for libraries. The build system does not take this into account and still places libraries into the lib directory if no --libdir is specified to configure. On initial startup this results in libasteriskssl.so not being found, as it is not in the multiarch lib directory. This change does the minimally invasive thing and executes ldconfig so that the libraries in the lib directory are found and their location cached. By doing so Asterisk starts up fine. ASTERISK-26705 Change-Id: I6d30b6427e9d5e69470e11327c7ff203fa7da519	9 years ago
Joshua Colp	24c2ef2418	Merge "http: Ensure capath is defined on all http creations" into 13	9 years ago
zuul	6b62ab7776	Merge "res_pjsip_pubsub: Correctly implement persisted subscriptions" into 13	9 years ago
zuul	ec0aefc822	Merge "pjsip_distributor.c: Fix off-nominal tdata ref leak." into 13	9 years ago
Sean Bright	9b02bbfa88	res_config_sqlite3: Properly create missing columns when necessary ... There were two specific issues resolved here: 1) The code that iterated over the required fields (via ast_realtime_require) was broken for the RQ_INTEGER1 field type. Iteration would stop when the first RQ_INTEGER1 (0) field was encountered. 2) sqlite3_changes() was used to try and count the number of rows returned by a SELECT statement. sqlite3_changes() only counts affected rows, so this was always returning the value from the most recent data modification statement. We now separate read-only queries from data modification queries and count rows appropriately in both cases. ASTERISK-23457 #close Reported by: Scott Griepentrog Change-Id: I91ed20494efc3fcfbc2a96ac7646999a49814884	9 years ago
Joshua Elson	0fc27fa364	http: Ensure capath is defined on all http creations ... ASTERISK-26794 #close Change-Id: I9cbc3b6b6a8aab590f5ccde9c262a98e4d5253a1	9 years ago
Igor Goncharovsky	7aa731c1c7	chan_unistim: fix char type to have consistent behavior on ARM ... There is difference exists in behaviour of char type on x86 and ARM. On x86 by default char variable type means signed char, but in ARM unsigned char used. This make binary calculations and negative values works wrong on ARM. This patch change type of char variables used for store negative values and binary calculations to signed char. ASTERISK-26714 Change-Id: Id78716dee9568a58419d4ef63c038affc3dfc7ab	9 years ago
George Joseph	be77b845d9	res_pjsip_pubsub: Correctly implement persisted subscriptions ... This patch fixes 2 original issues and more that those 2 exposed. * When we send a NOTIFY, and the client either doesn't respond or responds with a non OK, pjproject only calls our pubsub_on_evsub_state callback, no others. Since pubsub_on_evsub_state (which does the sub_tree cleanup) does not expect to be called back without the other callbacks being called first, it just returns leaving the sub_tree orphaned. Now pubsub_on_evsub_state checks the event for PJSIP_EVENT_TSX_STATE which is what pjproject will set to tell us that it was the transaction that timed out or failed and not the subscription itself timing our or being terminated by the client. If is TSX_STATE, pubsub_on_evsub_state now does the proper cleanup regardless of the state of the subscription. * When a client renews a subscription, we don't update the persisted subscription with the new expires timestamp. This causes subscription_persistence_recreate to prune the subscription if/when asterisk restarts. Now, pubsub_on_rx_refresh calls subscription_persistence_update to apply the new expires timestamp. This exposed other issues however... * When creating a dialog from rdata (which sub_persistence_recreate does from the packet buffer) there must NOT be a tag on the To header (which there will be when a client refreshes a subscription). If there is one, pjsip_dlg_create_uas will fail. To address this, subscription_persistence_update now accepts a flag that indicates that the original packet buffer must not be updated. New subscribes don't set the flag and renews do. This makes sure that when the rdata is recreated on asterisk startup, it's done from the original subscribe packet which won't have the tag on To. * When creating a dialog from rdata, we were setting the dialog's remote (SUBSCRIBE) cseq to be the same as the local (NOTIFY) cseq. When the client tried to resubscribe after a restart with the correct cseq, we'd reject the request with an Invalid CSeq error. * The acts of creating a dialog and evsub by themselves when recreating a subscription does NOT restart pjproject's subscription timer. The result was that even if we did correctly recreate the subscription, we never removed it if the client happened to go away or send a non-OK response to a NOTIFY. However, there is no pjproject function exposed to just set the timer on an evsub that wasn't created by an incoming subscribe request. To address this, we create our own timer using ast_sip_schedule_task. This timer is used only for re-establishing subscriptions after a restart. An earlier approach was to add support for setting pjproject's timer (via a pjproject patch) and while that patch is still included here, we don't use that call at the moment. While addressing these issues, additional debugging was added and some existing messages made more useful. A few formatting changes were also made to 'pjsip show scheduled tasks' to make displaying the subscription timers a little more friendly. ASTERISK-26696 ASTERISK-26756 Change-Id: I8c605fc1e3923f466a74db087d5ab6f90abce68e	9 years ago
Sean Bright	73133d5354	res_rtp_asterisk: Use PJ_ICE_MAX_CAND instead of hard-coding 16 ... pjsip limits the total number of ICE candidates to PJ_ICE_MAX_CAND, which is a compile-time constant. Instead of hard-coding 16 when we enumerate local interfaces, use PJ_ICE_MAX_CAND so that we can potentially collect more interfaces if the compile time options are changed. Tangentially related to ASTERISK~24464 Change-Id: I1b85509e39e33b1fed63c86261fc229ba14bbabd	9 years ago
zuul	c5b48fbe77	Merge "libasteriskssl: do nothing with OpenSSL >= 1.1" into 13	9 years ago
zuul	07163005ad	Merge "tcptls: use TLS_client_method with OpenSSL 1.1" into 13	9 years ago
zuul	258b808dce	Merge "openssl 1.1 support: use OPENSSL_VERSION_NUMBER" into 13	9 years ago
zuul	4551525fa9	Merge "app_voicemail: Allow 'Comedian Mail' branding to be overriden" into 13	9 years ago
zuul	730bc7e972	Merge "app_voicemail: VoiceMailPlayMsg did not play database stored messages" into 13	9 years ago
Tzafrir Cohen	99b40e72ae	libasteriskssl: do nothing with OpenSSL >= 1.1 ... OpenSSL 1.1 requires no explicit initialization. The hacks in the library are not needed. They also happen to fail running Asterisk. ASTERISK-26109 #close Change-Id: I3b3efd5d80234a4c45a8ee58dcfe25b15d9ad100	9 years ago
Sean Bright	4c31e03e80	app_voicemail: Allow 'Comedian Mail' branding to be overriden ... Original patch by John Covert, slight modifications by me. ASTERISK-17428 #close Reported by: John Covert Patches: app_voicemail.c.patch (license #5512) patch uploaded by John Covert Change-Id: Ic3361b0782e5a5397a19ab18eb8550923a9bd6a6	9 years ago
zuul	500b02cb82	Merge "app_record: Add option to prevent silence from being truncated" into 13	9 years ago
Tzafrir Cohen	e97e50b68b	tcptls: use TLS_client_method with OpenSSL 1.1 ... OpenSSL 1.1 introduced TLS_client_method() and deprecated the previous version-specific methods (such as TLSv1_client_method(). Other than being simpler to use and more correct (gain support for TLS newer that TLS1, in our case), the older ones produce a deprecation warning that fails the build in dev-mode. ASTERISK-26109 #close Change-Id: I257b1c8afd09dcb0d96cda3a41cb9f7a15d0ba07	9 years ago
Tzafrir Cohen	0d555f0d81	openssl 1.1 support: use OPENSSL_VERSION_NUMBER ... Use OPENSSL_VERSION_NUMBER instead of OPENSSL_API_COMPAT to detect the openssl 1.1 API. ASTERISK-26109 #close Change-Id: I4e448f55ef516aedf6ad154037c35577a421a458	9 years ago
zuul	0d6c99e715	Merge "cli: Fix various CLI documentation and completion issues" into 13	9 years ago
zuul	bc2104819c	Merge "channel: Protect flags in ast_waitfor_nandfds operation." into 13	9 years ago
rrittgarn	9d34df9a5e	app_voicemail: VoiceMailPlayMsg did not play database stored messages ... When attempting to use VoiceMailPlayMsg with a realtime data backend the message is located, but never retrieved. This patch adds the required RETRIEVE and DISPOSE calls that will fetch the message from the database (and IMAP storage as well for that matter). Also, removed extraneous make_file call. ASTERISK-26723 #close Change-Id: I1e122dd53c0f3d7faa10f3c2b7e7e76a47d51b8c	9 years ago
Sean Bright	f99e5f4de4	app_record: Add option to prevent silence from being truncated ... When using Record() with the silence detection feature, the stream is written out to the given file. However, if only 'silence' is detected, this file is then truncated to the first second of the recording. This patch adds the 'u' option to Record() to override that behavior. ASTERISK-18286 #close Reported by: var Patches: app_record-1.8.7.1.diff (license #6184) patch uploaded by var Change-Id: Ia1cd163483235efe2db05e52f39054288553b957	9 years ago
zuul	e0c52c5ec2	Merge "res_pjsip.c: Fix inconsistency between warning and action." into 13	9 years ago