asterisk

Commit Graph

Author	SHA1	Message	Date
Richard Mudgett	4ed91e3f7e	Add missing CEL logging fields to various CEL backends. Multiple revisions 350555,350571 ........ r350555 \| rmudgett \| 2012-01-13 11:12:51 -0600 (Fri, 13 Jan 2012) \| 12 lines Add missing CEL logging fields to various CEL backends. * Add missing eventextra to cel_psql.c and cel_odbc.c. * Add missing PeerAccount and EventExtra to cel_manager.c. * Add missing userdeftype support for cel_custom.conf.sample and cel_sqlite3_custom.conf.sample. (closes issue ASTERISK-17190) Reported by: Bryant Zimmerman ........ r350571 \| rmudgett \| 2012-01-13 11:23:57 -0600 (Fri, 13 Jan 2012) \| 8 lines Use compatible names for event extra data for various CEL backends. * Change eventextra to extra in cel_psql.c and cel_odbc.c. * Change EventExtra to Extra in cel_manager.c. (issue ASTERISK-17190) ........ Merged revisions 350555,350571 from http://svn.asterisk.org/svn/asterisk/branches/1.8 git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10@350585 65c4cc65-6c06-0410-ace0-fbb531ad65f3	14 years ago
Richard Mudgett	05e229b4e0	Remove extraneous BRIDGEPEER AMI VarSet event on a CEL dummy channel. (closes issue ASTERISK-19180) Reported by: Corey Farrell Patches: asterisk_cel_noevent_varset.diff (license #5909) patch uploaded by Corey Farrell ........ Merged revisions 350452 from http://svn.asterisk.org/svn/asterisk/branches/1.8 git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10@350453 65c4cc65-6c06-0410-ace0-fbb531ad65f3	14 years ago
Richard Mudgett	0764556d4f	Merged revisions 337973 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.8 ........ r337973 \| rmudgett \| 2011-09-26 14:30:39 -0500 (Mon, 26 Sep 2011) \| 30 lines Fix deadlock when using dummy channels. Dummy channels created by ast_dummy_channel_alloc() should be destoyed by ast_channel_unref(). Using ast_channel_release() needlessly grabs the channel container lock and can cause a deadlock as a result. * Analyzed use of ast_dummy_channel_alloc() and made use ast_channel_unref() when done with the dummy channel. (Primary reason for the reported deadlock.) * Made app_dial.c:dial_exec_full() not call ast_call() holding any channel locks. Chan_local could not perform deadlock avoidance correctly. (Potential deadlock exposed by this issue. Secondary reason for the reported deadlock since the held lock was part of the deadlock chain.) * Fixed some uses of ast_dummy_channel_alloc() not checking the returned channel pointer for failure. * Fixed some potential chan=NULL pointer usage in func_odbc.c. Protected by testing the bogus_chan value. * Fixed needlessly clearing a 1024 char auto array when setting the first char to zero is enough in manager.c:action_getvar(). (closes issue ASTERISK-18613) Reported by: Thomas Arimont Patches: jira_asterisk_18613_v1.8.patch (license #5621) patch uploaded by rmudgett Tested by: Thomas Arimont ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10@337974 65c4cc65-6c06-0410-ace0-fbb531ad65f3	15 years ago
Russell Bryant	019fbd57cf	Merged revisions 283230 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.8 ........ r283230 \| russell \| 2010-08-23 08:23:12 -0500 (Mon, 23 Aug 2010) \| 7 lines Make the AST_CEL_AMA enum match up with the AST_CDR_ ama flag values. Really, having 2 enums for this is silly and error prone, demonstrated by the crash that I hit because there was an assumption in the code that the values in each matched up. However, this is a quick fix to get them to match up so it will work. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@283232 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Russell Bryant	2cf6ac53ee	Merged revisions 283209 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.8 ........ r283209 \| russell \| 2010-08-23 08:06:57 -0500 (Mon, 23 Aug 2010) \| 2 lines Don't blow up on an invalid AMA flag. ........ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@283210 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Richard Mudgett	cf7bbcc4c6	Expand the caller ANI field to an ast_party_id Expand the ani field in ast_party_caller and ast_party_connected_line to an ast_party_id. This is an extension to the ast_callerid restructuring patch in review: https://reviewboard.asterisk.org/r/702/ Review: https://reviewboard.asterisk.org/r/744/ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@276393 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Richard Mudgett	ec37ffbdaf	ast_callerid restructuring The purpose of this patch is to eliminate struct ast_callerid since it has turned into a miscellaneous collection of various party information. Eliminate struct ast_callerid and replace it with the following struct organization: struct ast_party_name { char str; int char_set; int presentation; unsigned char valid; }; struct ast_party_number { char str; int plan; int presentation; unsigned char valid; }; struct ast_party_subaddress { char str; int type; unsigned char odd_even_indicator; unsigned char valid; }; struct ast_party_id { struct ast_party_name name; struct ast_party_number number; struct ast_party_subaddress subaddress; char tag; }; struct ast_party_dialed { struct { char str; int plan; } number; struct ast_party_subaddress subaddress; int transit_network_select; }; struct ast_party_caller { struct ast_party_id id; char ani; int ani2; }; The new organization adds some new information as well. * The party name and number now have their own presentation value that can be manipulated independently. ISDN supplies the presentation value for the name and number at different times with the possibility that they could be different. * The party name and number now have a valid flag. Before this change the name or number string could be empty if the presentation were restricted. Most channel drivers assume that the name or number is then simply not available instead of indicating that the name or number was restricted. * The party name now has a character set value. SIP and Q.SIG have the ability to indicate what character set a name string is using so it could be presented properly. * The dialed party now has a numbering plan value that could be useful to have available. The various channel drivers will need to be updated to support the new core features as needed. They have simply been converted to supply current functionality at this time. The following items of note were either corrected or enhanced: * The CONNECTEDLINE() and REDIRECTING() dialplan functions were consolidated into func_callerid.c to share party id handling code. * CALLERPRES() is now deprecated because the name and number have their own presentation values. * Fixed app_alarmreceiver.c write_metadata(). The workstring[] could contain garbage. It also can only contain the caller id number so using ast_callerid_parse() on it is silly. There was also a typo in the CALLERNAME if test. * Fixed app_rpt.c using ast_callerid_parse() on the channel's caller id number string. ast_callerid_parse() alters the given buffer which in this case is the channel's caller id number string. Then using ast_shrink_phone_number() could alter it even more. * Fixed caller ID name and number memory leak in chan_usbradio.c. * Fixed uninitialized char arrays cid_num[] and cid_name[] in sig_analog.c. * Protected access to a caller channel with lock in chan_sip.c. * Clarified intent of code in app_meetme.c sla_ring_station() and dial_trunk(). Also made save all caller ID data instead of just the name and number strings. * Simplified cdr.c set_one_cid(). It hand coded the ast_callerid_merge() function. * Corrected some weirdness with app_privacy.c's use of caller presentation. Review: https://reviewboard.asterisk.org/r/702/ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@276347 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Richard Mudgett	a5a0a5f867	Consolidate ast_channel.cid.cid_rdnis into ast_channel.redirecting.from.number. SWP-1229 ABE-2161 * Ensure chan_local.c:local_call() will not leak cid.cid_dnid when copying. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@256104 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Russell Bryant	3da9f8ed19	Resolve more compiler warnings on FreeBSD. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@253540 65c4cc65-6c06-0410-ace0-fbb531ad65f3	16 years ago
Mark Michelson	01181a27a0	Fix channel reference leak. ast_cel_report_event would geet a reference to the bridged channel. However, certain return paths, such as if CEL was not enabled, would result in a reference leak. All return paths now properly unref the channel. (closes issue #15991) Reported by: mmichelson git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@220995 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Russell Bryant	b7928de6ac	Resolve compiler warning on mac. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@208193 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Michiel van Baak	b31302d55d	make this compile again under devmode git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@205562 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago
Russell Bryant	0264eef115	Merge the new Channel Event Logging (CEL) subsystem. CEL is the new system for logging channel events. This was inspired after facing many problems trying to represent what is possible to happen to a call in Asterisk using CDR records. For more information on CEL, see the built in HTML or PDF documentation generated from the files in doc/tex/. Many thanks to Steve Murphy (murf) and Brian Degenhardt (bmd) for their hard work developing this code. Also, thanks to Matt Nicholson (mnicholson) and Sean Bright (seanbright) for their assistance in the final push to get this code ready for Asterisk trunk. Review: https://reviewboard.asterisk.org/r/239/ git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@203638 65c4cc65-6c06-0410-ace0-fbb531ad65f3	17 years ago

13 Commits (1cd169d034da59581c65d6a196a5b697b34affca)