32557 Commits (1b01a6abfd1f323c9043fc9c65f4ab038296f77c)

 

All Branches   

Search

Author	SHA1	Message	Date
Joshua Colp	0c486e7edf	res_rtp_asterisk: Always return provided DTLS packet length. ... OpenSSL can not tolerate if the packet sent out does not match the length that it provided to the sender. This change lies and says that each time the full packet was sent. If a problem does occur then a retransmission will occur as appropriate. ASTERISK-28576 Change-Id: Id42455b15c9dc4eb987c8c023ece6fbf3c22a449	6 years ago
Sean Bright	92bb381d5d	func_env: Prevent FILE() from reading garbage at end-of-file ... If the last line of a file does not have a terminating EOL sequence, we potentially add garbage to the value returned from the FILE() function. There is no overflow potential here as we are reading from a buffer of a known size, we are just reading too much of it. ASTERISK-26481 #close Change-Id: I50dd4fcf416fb3c83150040a1a79a59d9eb1ae01	6 years ago
Kevin Harwell	8b4610acfe	bridge_softmix: clear hold when joining a softmix bridge ... MOH continues to play to a channel if that channel was on hold prior to entering a softmix bridge. MOH will not stop even if the original "holder" attempts an unhold. For the most part a softmix bridge ignores holds, so a participating channel shouldn't join while on hold. This patch checks to see if the channel joining the softmix bridge is currently on hold. If so then it indicates an unhold. ASTERISK-28618 Change-Id: I66ccd4efc80f5b4c3dd68186b379eb442916392b	6 years ago
Kevin Harwell	8bc6fa0fbd	various files - fix some alerts raised by lgtm code analysis ... This patch fixes several issues reported by the lgtm code analysis tool: https://lgtm.com/projects/g/asterisk/asterisk Not all reported issues were addressed in this patch. This patch mostly fixes confirmed reported errors, potential problematic code points, and a few other "low hanging" warnings or recommendations found in core supported modules. These include, but are not limited to the following: * innapropriate stack allocation in loops * buffer overflows * variable declaration "hiding" another variable declaration * comparisons results that are always the same * ambiguously signed bit-field members * missing header guards Change-Id: Id4a881686605d26c94ab5409bc70fcc21efacc25	6 years ago
Martin Tomec	d579ec9cdf	func_curl.c: Support custom http headers ... When user wants to send json data, the default Content-Type header is incorect (application/x-www-form-urlencoded). This patch allows to set any custom headers so the Content-Type header can be overriden. User can set multiple headers by multiple calls of curlopt(). This approach is not consistent with other parameters, but is more readable in dialplan than one call with multiple headers. ASTERISK-28613 Change-Id: I4dd68c3f4e25362ef941d73a3861f58348dcfbf9	6 years ago
Joshua Colp	de433cdcaf	parking: Fix case where we can't get the parker. ... ASTERISK-28616 Change-Id: Iabe31ae38d01604284fcc5c2438d44e29a32ea4d	6 years ago
Joshua Colp	d638d9c6c6	parking: Use channel snapshot instead of channel. ... There exists a scenario where a thread can hold a lock on the channels container while trying to lock a bridge. At the same time another thread can hold the lock for said bridge while attempting to retrieve a channel. This causes a deadlock. This change fixes this scenario by retrieving a channel snapshot instead of a channel, as information present in the snapshot is all that is needed. ASTERISK-28616 Change-Id: I68ceb1d62c7378addcd286e21be08a660a7cecf2	6 years ago
Kevin Harwell	3084a6c617	Merge "res_pjsip_session: initialize pending's topology to endpoint's" into 17	6 years ago
Kevin Harwell	ea3daa94c8	res_pjsip_session: initialize pending's topology to endpoint's ... Found during some testing, there is a race condition between selecting an appropriate bridge type for a call versus the applying of media on the callee's session. In some instances a native bridge type would have been chosen, but due to the callee's media not yet being established at bridge compatibility check time the simple bridge type is picked instead. When using chan_pjsip this initiates a topology change event. The topologies are then compared for the two sessions. However, when the topology was created for the caller its streams are initialized to "inactive". This topology is then used as a base when creating the callee's topology, and streams. Soon after the caller's topology's stream(s) get updated based on the sdp (get set to sendrecv in the failing scenario). Now when the topology change event is raised, and the two topologies are compared, the comparison fails due to a stream state mismatch (sendrecv vs inactive). And since they differ a reinvite is sent out (to the caller in this case). This patch makes it such that when the caller's topology is initially created it gets created based on its configured endpoint's media topology. When the endpoint's topology is created its stream's state(s) are initialized to sendrecv instead of inactive. Subsequently, now when the callee's topology is created its topology streams are now initialized to sendrecv. Thus when the topology change event occurs due to the mentioned scenario the stream states match for the given sessions, and the reinvite is not sent unless due to some other valid mismatch. Note, this patch only changes one pending media state's creation point. It's possible other places *could* be changed, however for now it was deemed best to only alter what's here. Change-Id: I6ba3a6a75f64824a1b963044c37acbe951c389c7	6 years ago
George Joseph	7202624b3b	stasis: Don't hold app_registry and session locks unnecessarily ... resource_events:stasis_app_message_handler() was locking the session, then attempting to determine if the app had debug enabled which locked the app_registry container. res_stasis:__stasis_app_register was locking the app_registry container then calling app_update which caused app_handler (which locks the session) to run. The result was a deadlock. * Updated resource_events:stasis_app_message_handler() to determine if debug was set (which locks the app_registry) before obtaining the session lock. * Updated res_stasis:__stasis_app_register to release the app_registry container lock before calling app_update (which locks the sesison). ASTERISK-28423 Reported by Ross Beer Change-Id: I58c69d08cb372852a63933608e4d6c3e456247b4	6 years ago
George Joseph	36b28c98dd	Build: Fix compile issues with seldom used modules ... The following modules needed tweaks for API changes. addons/cdr_mysql.c addons/chan_ooh323.c apps/app_meetme.c ASTERISK-28604 Change-Id: Ib40e513ae55b5114be035cdc929abb6a8ce2d06d	6 years ago
Joshua Colp	eea2d499f4	res_pjsip_outbound_registration: Extend documentation for "max_retries". ... If the "max_retries" option is set to 0 then upon failure no further attemps are made, so explicitly document the behavior. ASTERISK-28602 Change-Id: I1e30daae9dd6c49ce18744164214d3def505acbf	6 years ago
Joshua Colp	43ea6e21db	Merge "res_calendar: Resolve memory leak on calendar destruction" into 17	6 years ago
Sean Bright	b3792e1288	res_calendar: Resolve memory leak on calendar destruction ... Calling ne_uri_parse allocates memory that needs to be freed with a corresponding call to ne_uri_free. ASTERISK-28572 #close Change-Id: I8a6834da27000a6807d89cb7a157b2a88fcb5e61	6 years ago
Joshua Colp	e37d546109	res_ari_events: Add module reference when a WebSocket is open. ... This change ensures that the module isn't unloaded when a WebSocket is open. Previously it was possible to unload the module manually or during shutdown which could cause a crash when any active WebSockets were terminated. ASTERISK-28585 Change-Id: I85c71ab112f99875b586419a34c08c8b34c14c5c	6 years ago
George Joseph	1b4502ec5d	Merge "ExternalMedia: Change return object from ExternalMedia to Channel" into 17	6 years ago
Friendly Automation	8b0661df75	Merge "utils.h: Set lower bound for thread stack size to PTHREAD_STACK_MIN" into 17	6 years ago
Joshua Colp	0cfe9186b0	Merge "app_voicemail.c: Support multiple file formats for forwarded messages." into 17	6 years ago
Friendly Automation	500e5f488f	Merge "Crash during "pjsip show channelstats" execution" into 17	6 years ago
Sean Bright	b3c56c7fa5	utils.h: Set lower bound for thread stack size to PTHREAD_STACK_MIN ... ASTERISK-28590 #close Change-Id: I51abce00c04d0a06550bda5205580705185b9c1c	6 years ago
Joshua Colp	4d67cd10ba	Merge "res_rtp_asterisk: Remove a log message that slipped in." into 17	6 years ago
George Joseph	2d665091a3	ExternalMedia: Change return object from ExternalMedia to Channel ... When we created the External Media addition to ARI we created an ExternalMedia object to be returned from the channels/externalMedia REST endpoint. This object contained the channel object that was created plus local_address and local_port attributes (which are also in the Channel variables). At the time, we thought that creating an ExternalMedia object would give us more flexibility in the future but as we created the sample speech to text application, we discovered that it doesn't work so well with ARI client libraries that a) don't have the ExternalMedia object defined and/or b) can't promote the embedded channel structure to a first-class Channel object. This change causes the channels/externalMedia REST endpoint to return a Channel object (like channels/create and channels/originate) instead of the ExternalMedia object. Change-Id: If280094debd35102cf21e0a31a5e0846fec14af9	6 years ago
Salah Ahmed	40acd7d198	Crash during "pjsip show channelstats" execution ... During execution "pjsip show channelstats" cli command by an external module asterisk crashed. It seems this is a separate thread running to fetch and print rtp stats. The crash happened on the ao2_lock method, just before it going to read the rtp stats on a rtp instance. According to gdb backtrace log, it seems the session media was already cleaned up at that moment. ASTERISK-28578 Change-Id: I3e05980dd4694577be6d39be2c21a5736bae3c6f	6 years ago
Joshua Colp	b8ae799ca9	res_rtp_asterisk: Remove a log message that slipped in. ... This was only supposed to be for testing, so now it can be removed. Change-Id: I3dfc2e776e70b3196aeed5688372ea80c0214b59	6 years ago
Sean Bright	4bc1c170cd	README-SERIOUSLY.bestpractices.md: Speling correetions. ... ASTERISK-28586 #close Change-Id: I43dc4e8bd9dc685b17695b215a5360314074734f	6 years ago
Joshua Colp	b590e8f23e	Merge "test_res_rtp: Enable FIR and REMB nominal tests." into 17	6 years ago
cmaj	aa0973f868	app_voicemail.c: Support multiple file formats for forwarded messages. ... If you specify multiple formats in voicemail.conf, eg. "format = gsm|wav" and are using realtime ODBC backend, only the first format gets stored in the database. So when you forward a message later on, there is a bug generating the email, related to the stored format (GSM) being different than the desired email format (WAV) specified for the user. Sox can handle this, but Asterisk needs to tell sox exactly what to do. ASTERISK-22192 Change-Id: I7321e7f7e7c58adbf41dd4fd7191c887b9b2eafd	6 years ago
George Joseph	3c712391c6	Merge "res_pjsip_mwi: potential double unref, and potential unwanted double link" into 17	6 years ago
Joshua Colp	ba688e6891	test_res_rtp: Enable FIR and REMB nominal tests. ... Now that both FIR and REMB are being sent in compound packets these tests can be enabled. This also extends the REMB nominal test to cover the REMB contents itself. Change-Id: Ibfee526ad780eefcce5dd787f53785382210024a	6 years ago
Friendly Automation	bbf995320e	Merge "pbx: deadlock when outgoing dialed channel hangs up too quickly" into 17	6 years ago
Friendly Automation	236ff0af7a	Merge "cdr_pgsql cel_pgsql res_config_pgsql: compatibility with PostgreSQL 12" into 17	6 years ago
Christoph Moench-Tegeder	79cc8ae3b8	cdr_pgsql cel_pgsql res_config_pgsql: compatibility with PostgreSQL 12 ... PostgreSQL 12 finally removed column adsrc from table pg_catalog.pg_attrdef (column default values), which has been deprecated since version 8.0. Since then, the official/correct/supported way to retrieve the column default value from the catalog is function pg_catalog.pg_get_expr(). This change breaks compatibility with pre-8.0 PostgreSQL servers, but has reached end-of-support more than a decade ago. cdr_pgsql and res_config_pgsql still have support for pre-7.3 servers, but cleaning that up is perhaps a topic for a major release, not this bugfix. ASTERISK-28571 Change-Id: I834cb3addf1937e19e87ede140bdd16cea531ebe	6 years ago
George Joseph	5b77f572e3	Merge "pjproject_bundled: Replace earlier reverts with official fixes." into 17	6 years ago
Kevin Harwell	45c0d99185	res_pjsip_mwi: potential double unref, and potential unwanted double link ... When creating an unsolicited MWI aggregate subscription it was possible for the subscription object to be double unref'ed. This patch removes the explicit unref as it is not needed since the RAII_VAR will handle it at function end. Less concerning there was also a bug that could potentially allow the aggregate subscription object to be added to the unsolicited container twice. This patch ensures it is added only once. ASTERISK-28575 Change-Id: I9ccfdb5ea788bc0c3618db183aae235e53c12763	6 years ago
csavinovich	c84135d2a3	test_taskprocessor.c: Fix test failure on Ubuntu ... Fixes a failure in /main/taskprocesor unit test, only occurring in Ubuntu. Newer versions of GCC require variable initialization. Change-Id: I2994d8aab9307a8c2c7330584f287a27144a580c	6 years ago
Friendly Automation	b25e529ad8	Merge "Revert "app_voicemail: Cleanup stale lock files on module load"" into 17	6 years ago
George Joseph	d869882697	Merge changes from topic "pjsip_shutdown" into 17 ... * changes: res_pjsip_mwi: use an ao2_global object for mwi containers res_pjsip/res_pjsip_mwi: use centralized serializer pools	6 years ago
George Joseph	82372fa816	Merge "serializer: move/add asterisk serializer pool functionality" into 17	6 years ago
Friendly Automation	804f5ddfeb	Merge "chan_pjsip: Prevent segfault when running PlayDTMF on hungup channel" into 17	6 years ago
George Joseph	2652bda3a0	pjproject_bundled: Replace earlier reverts with official fixes. ... Issues in pjproject 2.9 caused us to revert some of their changes as a work around. This introduced another issue where pjproject wouldn't build with older gcc versions such as that found on CentOS 6. This commit replaces the reverts with the official fixes for the original issues and allows pjproject to be built on CentOS 6 again. ASTERISK-28574 Reported-by: Niklas Larsson Change-Id: I06f8507bea553d1a01b0b8874197d35b9d47ec4c	6 years ago
Kevin Harwell	ae761c7473	pbx: deadlock when outgoing dialed channel hangs up too quickly ... Here's the basic scenario that occurred when executing an AMI fast originate while at the same time something else locks the channels container, and also wants a lock on the dialed channel: 1. pbx_outgoing_attempt obtains a lock on a dialed channel 2. concurrently another thread obtains a lock on the channels container, and subsequently requests a lock on the dialed channel. It waits on #1. For instance, "core show channel <dialed channel" 3. the outgoing call does not fail, but ends before the pbx_outgoing_attempt function exits 4. pbx_outgoing_attempt function exits, the outgoing structure destructs, and attempts to hang up the dialed channel 5. hang up tries to obtain the channels container lock, but can't due to #2. 6. Asterisk is deadlocked. The solution was to allow the pbx_outgoing_exec function to "steal" ownership of the dialed channel, and handle hanging it up. The channel now is either hung up prior to it being potentially locked by the initiating thread, or if locked the hang up takes place in a different thread, thus alleviating the deadlock. ASTERISK-28561 patches: iliketrains.diff submitted by Joshua Colp (license 5000) Change-Id: I51b42b92dde8f2215b69bb509e28667ee3a3853a	6 years ago
Friendly Automation	6bedd43b98	Merge "cdr_mysql: Don't clean up on unload unless we can unregister from CDRs" into 17	6 years ago
Sean Bright	b903994987	Revert "app_voicemail: Cleanup stale lock files on module load" ... This reverts commit fd2e8d0da7. Reason for revert: Problematic for users who store their voicemail on network storage devices, or share voicemail storage between multiple Asterisk instances. ASTERISK-28567 #close Change-Id: I3ff4ca983d8e753fe2971f3439bd154705693c41	6 years ago
lvl	71f86e78b6	chan_pjsip: Prevent segfault when running PlayDTMF on hungup channel ... ASTERISK-28086 #close Change-Id: Ib3baadc89b9f0477a6f25a63861433812368c5ea	6 years ago
Kevin Harwell	996fc40e2b	res_pjsip_mwi: use an ao2_global object for mwi containers ... On shutdown it's possible for the unsolicited mwi container to be freed before other dependent threads are done using it. This patch ensures this can no longer happen by wrapping the container in an ao2_global object. The solicited container was also changed too. ASTERISK-28552 Change-Id: I8f812286dc19a34916acacd71ce2ec26e1042047	6 years ago
Kevin Harwell	37ec88c4c8	serializer: move/add asterisk serializer pool functionality ... Serializer pools have previously existed in Asterisk. However, for the most part the code has been duplicated across modules. This patch abstracts the code into an 'ast_serializer_pool' object. As well the code is now centralized in serializer.c/h. In addition serializer pools can now optionally be monitored by a shutdown group. This will prevent the pool from being destroyed until all serializers have completed. Change-Id: Ib1e906144b90ffd4d5ed9826f0b719ca9c6d2971	6 years ago
Kevin Harwell	299ba78b09	res_pjsip/res_pjsip_mwi: use centralized serializer pools ... Both res_pjsip and res_pjsip_mwi made use of serializer pools. However, they both implemented their own serializer pool functionality that was pretty much identical in each of the source files. This patch removes the duplicated code, and uses the new 'ast_serializer_pool' object instead. Additionally res_pjsip_mwi enables a shutdown group on the pool since if the timing was right the module could be unloaded while taskprocessor threads still needed to execute, thus causing a crash. Change-Id: I959b0805ad024585bbb6276593118be34fbf6e1d	6 years ago
Friendly Automation	119a18ef08	Merge "channel/chan_pjsip: add dialplan function for music on hold" into 17	6 years ago
Sean Bright	1dc3451a34	cdr_mysql: Don't clean up on unload unless we can unregister from CDRs ... ASTERISK-28566 #close Change-Id: I6daa4e5128e9406d04d3aed670c3bae98d38d40c	6 years ago
Corey Farrell	25fbe79793	stasis_state: Create internal stasis_state_proxy object. ... This improves the way which stasis_state reference counting works. Since manager->states holds onto the proxy object instead of the real object this allows stasis_state objects to be freed when appropriate without use of a special state_remove function. Additionally each distinct eid associated with the state holds a reference to the state to prevent early release and potentially allow easier debug of leaks. Change-Id: I400e0db4b9afa3d5cb4ac7dad60907897e73f9a9	6 years ago