5952 Commits (18c8dda84310d149b489b03663e94de542f91157)

Author	SHA1	Message	Date
Corey Farrell	18c8dda843	CLI: Fix 'core set debug channel' completion bug. ... The completion generator is missing a return so typing "core set debug all off <tab>" causes the command to actually execute. Change-Id: Ibf6462088a74eee66967732b50445783ebefc20b	8 years ago
George Joseph	2fbf4554e4	Merge "loader: Use vector to build apha sorted module lists." into 15	8 years ago
George Joseph	fb6aad5301	Merge "loader: Replace priority heap with vector." into 15	8 years ago
Jenkins2	6b395dd3ed	Merge "cdr: Minor optimizations." into 15	8 years ago
Jenkins2	73404801a6	Merge "loader: Rework of load_dynamic_module." into 15	8 years ago
George Joseph	4ae244841c	Merge "loader: Minor fix to module registration." into 15	8 years ago
Corey Farrell	28517edba6	cdr: Minor optimizations. ... * bridge_candidate_process: remove SCOPED_AO2LOCK and return value. * handle_standard_bridge_enter_message: replace recursive call with goto statement. ASTERISK-24297 Change-Id: Id2eaa0822fb8dc799f63422bb3aa89de9d4ee2a2	8 years ago
Corey Farrell	dc236b13c5	loader: Use vector to build apha sorted module lists. ... Change-Id: I9c519f4dec3cda98b2f34d314255a31d49a6a467	8 years ago
Corey Farrell	77af356e30	loader: Replace priority heap with vector. ... This is needed for future changes which will require being able to process the load priority out of order. Change-Id: Ia23421197f09789940510b03ebbbf3bf24d51bea	8 years ago
Corey Farrell	5295c4685a	loader: Rework of load_dynamic_module. ... * Split off load_dlopen to perform actual dlopen, check results and log warnings when needed. * Use flags which minimize number of calls to dlopen required. First attempt always uses RTLD_GLOBAL when global_symbols_only is enabled, RTLD_LOCAL when it is not. This patch significantly reduces the number of dlopen's performed. With 299 modules my system ran dlopen 857 times before this patch, 655 times after this patch. Change-Id: Ib2c9903cfddcc01aed3e01c1e7fe4a3fb9af0f8b	8 years ago
Corey Farrell	69b82113fa	loader: Minor fix to module registration. ... This protects the module loader itself against crashing if dlopen is called on a module from outside loader.c. * Expand scope of lock inside ast_module_register to include reading of resource_being_loaded. * NULL check resource_being_loaded. * Set resource_being_loaded NULL as soon as dlopen returns. This fixes some error paths where it was not NULL'ed. * Create module_destroy function to deduplicate code from ast_module_unregister and modules_shutdown. * Resolve leak that occured if a module did not successfully register. * Simplify checking for successful registration. Change-Id: I40f07a315e55b92df4fc7faf525ed6d4f396e7d2	8 years ago
Richard Mudgett	39c8d566ad	res_rtp_asterisk.c: Disable packet flood detection for video streams. ... We should not do flood detection on video RTP streams. Video RTP streams are very bursty by nature. They send out a burst of packets to update the video frame then wait for the next video frame update. Really only audio streams can be checked for flooding. The others are either bursty or don't have a set rate. * Added code to selectively disable packet flood detection for video RTP streams. ASTERISK-27440 Change-Id: I78031491a6e75c2d4b1e9c2462dc498fe9880a70	8 years ago
Jenkins2	c1972ebbab	Merge "CLI: Fix 'core show sysinfo' function ordering." into 15	8 years ago
Corey Farrell	c6e137ee16	CLI: Fix 'core show sysinfo' function ordering. ... Handle CLI initialization before any processing occurs. Change-Id: I598b911d2e409214bbdfd0ba0882be1d602d221c	8 years ago
Richard Mudgett	0384e49a6e	stasis_channels.c: Don't set channel snapshot caller_dnid twice. ... Change-Id: Ib8d45bbdfbda81e65045f6dff874d189b74e5471	8 years ago
Jenkins2	5fb14aab28	Merge "astdb: Improve prefix searches in astdb" into 15	8 years ago
Jenkins2	910c6c260b	Merge "loader: Refactor resource_name_match." into 15	8 years ago
Sean Bright	d9843c84ef	astdb: Improve prefix searches in astdb ... Using the LIKE operator requires a full table scan of 'astdb', whereas a comparison operation is able to use the primary key index. This patch adds a new function to the AstDB API for quick prefix matches and updates res_sorcery_astdb to utilize it. This showed substantial performance improvement in my test environment. Related to ASTERISK~26806, but does not completely resolve it. Change-Id: I7d37f9ba2aea139dabf2ca72d31fbe34bd9b2fa1	8 years ago
Corey Farrell	bc20130683	loader: Refactor resource_name_match. ... Optimize resource_name_match. This change eliminates use of ast_strdupa, instead verifying that both basename's are the same length, then using strncasecmp. Change-Id: I477275c0e954c99d74be5abfc8bb6545b04e5a3d	8 years ago
Sean Bright	f9c6f69205	utils: Add convenience function for setting fd flags ... There are many places in the code base where we ignore the return value of fcntl() when getting/setting file descriptior flags. This patch introduces a convenience function that allows setting or clearing file descriptor flags and will also log an error on failure for later analysis. Change-Id: I8b81901e1b1bd537ca632567cdb408931c6eded7	8 years ago
Jenkins2	52de5a05f0	Merge "translate: Skip matrix_rebuild during shutdown." into 15	8 years ago
Joshua Colp	fead60166e	Merge "CLI: Fix remote console completion." into 15	8 years ago
Jenkins2	a51c82eb02	Merge "sounds_index: Avoid repeatedly reindexing." into 15	8 years ago
Jenkins2	c37093f2ff	Merge "media_index: Improve startup." into 15	8 years ago
Corey Farrell	b8a063f4bf	CLI: Fix remote console completion. ... Duplicate checking was done incorrectly when parsing completion options from a remote console causing all options to be ignored as duplicates. Once fixed I had to separate processing of the best match to ensure it was not identified as a duplicate when it is the only match. ASTERISK-27465 Change-Id: Ibbdb29f88211742071836c9b3f4d2aa1221cd0f9	8 years ago
Corey Farrell	14bb88a97a	translate: Skip matrix_rebuild during shutdown. ... Change-Id: I1e5eef4029cba56e33d786c5a5ade8091e531a1e	8 years ago
Corey Farrell	c35613d257	sounds_index: Avoid repeatedly reindexing. ... The sounds index is rebuilt each time a format is registered or unregistered. This causes the index to be repeatedly rebuilt during startup and shutdown. This patch significantly reduces the work done by delaying sound index initialization until after modules are loaded. This way a reindex only occurs if a format module is loaded after startup. We also skip reindexing when format modules are unloaded during shutdown. Change-Id: I585fd6ee04200612ab1490dc804f76805f89cf0a	8 years ago
Corey Farrell	48fce66bcf	media_index: Improve startup. ... This eliminates some wasteful operations in media_index startup. * Replace statically set string-fields with char[0]. * Eliminate pointless RAII_VAR's. * alloc_variant: Avoid pointless ao2_find on new info->variant. * Stop trying find_variant before alloc_variant. * process_media_file: replace ast_str with ast_asprintf. This avoids reallocation of file_id_str. Overall sounds_index.c is about 27% of Asterisk startup time when using sample configs. This patch reduces it to 20%. This is a half-fix. The real problem is that the media_index is regenerated repeatedly - 68 times in my test. Change-Id: Ia50b752f8efb356f852b05c4be495a6631af8652	8 years ago
Richard Mudgett	d5b5879157	bridge_basic.c: Update transfer diagnostic messages addendum. ... * Added start DTMF transfer verbose messages. * Made associated transfer messages use a similar message format. * Adjusted message verbose level as requested by initial reporter. ASTERISK-27449 Change-Id: I2045714586414b3c5ef1f3cc56c1c4af4b31f551	8 years ago
Niklas Larsson	14774a0377	bridge_basic.c: Update transfer diagnostic messages. ... * Add the channel name to diagnostic messages so you will know which channel failed to transfer. * Promoted some debug messages to verbose 4 messages. ASTERISK-27449 #close Change-Id: Idac66b7628c99379cc9269158377fd87dc97a880	8 years ago
Joshua Colp	cfc121128b	Merge "config: Speed up config template lookup" into 15	8 years ago
Sean Bright	ef26edd554	config: Speed up config template lookup ... ast_category_get() has an (undocumented) implementation detail where it tries to match the category name first by an explicit pointer comparison and if that fails falls back to a normal match. When initially building an ast_config during ast_config_load, this pointer comparison can never succeed, but we will end up iterating all categories twice. As the number of categories using a template increases, this dual looping becomes quite expensive. So we pass a flag to category_get_sep() indicating if a pointer match is even possible before trying to do so, saving us a full pass over the list of current categories. In my tests, loading a file with 3 template categories and 12000 additional categories that use those 3 templates (this file configures 4000 PJSIP endpoints with AOR & Auth) takes 1.2 seconds. After this change, that drops to 22ms. Change-Id: I59b95f288e11eb6bb34f31ce4cc772136b275e4a	8 years ago
Sean Bright	3af6c1b4bc	config: Speed up ACO & sorcery initialization ... When starting Asterisk in the foreground, there is a perceptible delay when loading modules that use the ACO and sorcery config frameworks. For example, a lightly configured res_pjsip took 853ms to load on my VM. I tracked down the slowness to the XPath queries used to associate the relevant documentation with the config options. One improvement was adding a call to xmlXPathOrderDocElems after loading an XML document. From the libxml2 docs: Call this routine to speed up XPath computation on static documents. The second change was to remove recursive descent and wildcard operators from the XPath queries. After these changes, res_pjsip takes 85ms to load on my VM and there is no longer a perceptible delay when starting Asterisk in the foreground. Change-Id: I45d457f1580e26bf5a2b0dab16e8e9ae46dcbd82	8 years ago
Jenkins2	b4bbe04898	Merge "translate: Transcode siren14, speex32, silk24, and silk12 via slin16." into 15	8 years ago
Jenkins2	a8b7447b61	Merge "translate: Show sample rate for silk, speex, and slin in translation table." into 15	8 years ago
Joshua Colp	546d93a6b6	Merge "CLI: Finish conversion of completion handling to vectors." into 15	8 years ago
Jenkins2	68c16d3c57	Merge "CLI: Refactor cli_complete." into 15	8 years ago
Jenkins2	a6fb67aa47	Merge "CLI: Rewrite ast_el_strtoarr to use vector's internally." into 15	8 years ago
Jenkins2	d817611374	Merge "CLI: Refactor ast_cli_display_match_list." into 15	8 years ago
George Joseph	d5eb530bdf	Merge "CLI: Create ast_cli_completion_add function." into 15	8 years ago
George Joseph	c34223c958	Merge "CLI: Remove calls to ast_cli_generator." into 15	8 years ago
Alexander Traud	a0654e40e3	translate: Transcode siren14, speex32, silk24, and silk12 via slin16. ... When a format has no pre-recorded sound files, Asterisk has to transcode between formats. For this, Asterisk has a fixed translation table. If the pre-recorded sound files are not available in the same sample rate, Asterisk has not only to transcode but also to resample. Asterisk has pre-recorded files for SLN (8000 kHz) and SLN16 (16000 kHz). However before this change, Asterisk did not take the sample rate into account, because the translation paths to SLN and SLN16 got the same score/weight in the table. Consequently, you might have got narrow-band audio with siren14, speex32, silk24, and silk12 although those are (ultra) wide-band audio codecs. With this change, the distance in sample-rates is taken into account. Now on the Command-Line interface (CLI) 'core show channels', you should see: (slin@16000)->(slin@32000)->(speex@32000). ASTERISK-23735 Reported by: Richard Kenner Change-Id: I9448295c1978be26f8633b6066395e7bbbe2e213	8 years ago
Alexander Traud	e2027b41e6	translate: Show sample rate for silk, speex, and slin in translation table. ... ASTERISK-24662 Change-Id: I3822956984292c99c48bca8e97807e498ccc0e88	8 years ago
Joshua Colp	3e62546511	Merge "aoc: Remove silly usage of RAII_VAR." into 15	8 years ago
Joshua Colp	1e2799f491	Merge "abstract_jb: Remove silly usage of RAII_VAR." into 15	8 years ago
Joshua Colp	48ec7e49e8	Merge "app: Remove silly usage of RAII_VAR." into 15	8 years ago
Corey Farrell	d643fbda49	CLI: Finish conversion of completion handling to vectors. ... Change-Id: Ib81318f4ee52a5e73b003316e13fe9be1dd897a1	8 years ago
Corey Farrell	7c9d73615c	CLI: Refactor cli_complete. ... * Stop using "_COMMAND NUMMATCHES" on remote consoles. Using this command had doubled the amount of work needed from the Asterisk daemon for each completion request. * Fix code formatting. * Remove static buffer used to send the command, use the same buffer that will receive the results. * Move sort from ast_cli_display_match_list. Change-Id: Ie2211b519a3d4bec45bf46e0095bdd01d384cb69	8 years ago
Corey Farrell	b8a735e9f4	CLI: Rewrite ast_el_strtoarr to use vector's internally. ... This rewrites ast_el_strtoarr to use vector's internally, but still return the original NULL terminated array of strings. Change-Id: Ibfe776cbe14f750effa9ca360930acaccc02e957	8 years ago
Corey Farrell	0ca507ba67	CLI: Refactor ast_cli_display_match_list. ... * Stop estimating line count, just print until we run out of matches. * Stop freeing entries, the caller does that anyways. * Stop calculating / returning numoutput, it was ignored. Change-Id: I7f92afa8bea92241a95227587367424c8c32a5cb	8 years ago