5821 Commits (0ae451ce05b6f50b281d07b6f5b4b1dce1b40bd7)

Author	SHA1	Message	Date
Joshua Colp	0ae451ce05	Merge "ast_bt_get_symbols: Prevent double-free." into 15	9 years ago
Joshua Colp	f218761169	Merge "tcptls: NULL-check the parameter of ast_ssl_teardown before accessing it." into 15	9 years ago
Jenkins2	49759a5782	Merge "cdr.c: Defer getting ao2_global_obj_ref() until needed." into 15	9 years ago
Jenkins2	f584e10d9d	Merge "cdr.c: Set stringfields only if they are different." into 15	9 years ago
Jenkins2	5e5383c47e	Merge "cdr.c: Fix setting dnid, callingsubaddr, and calledsubaddr" into 15	9 years ago
Corey Farrell	09301ddc4f	ast_bt_get_symbols: Prevent double-free. ... It's possible for bfdobj to be created but syms not created. If syms was not allocated in the current loop iteration but was allocated in the previous iteration it would crash. ASTERISK-27340 Change-Id: I5b110c609f6dfe91339f782a99a431bca5837363	9 years ago
Alexander Traud	5ef8377334	tcptls: NULL-check the parameter of ast_ssl_teardown before accessing it. ... This avoids a crash on stopping a chan_sip which failed to start its TLS server. ASTERISK-27339 #close Change-Id: I327fc70db68eaaca5b50a15c7fd687fde79263d5	9 years ago
Richard Mudgett	4cc4884144	cdr.c: Defer getting ao2_global_obj_ref() until needed. ... The CDR performance gets worse the further it gets behind in processing stasis messages. One of the reasons is we were getting the global config even if we didn't need it. * Most uses of the global config were only needed on off nominal code paths so it makes sense to not get it until absolutely needed. ASTERISK-27335 Change-Id: I00c63b7ec233e5bfffd5d976f05568613d3c2365	9 years ago
Richard Mudgett	6fdb992d12	cdr.c: Set stringfields only if they are different. ... The CDR performance gets worse the further it gets behind in processing stasis messages. One of the reasons is we were repeatedly setting string fields to potentially the same string in base_process_party_a(). Setting a string field involves allocating room for the new string out of a memory pool which may have to allocate even more memory. * Check to see if the string field is already set to the desired string. ASTERISK-27335 Change-Id: I3ccb7e23f1488417e08cafe477755033eed65a7c	9 years ago
Richard Mudgett	bd16bcb77c	cdr.c: Fix setting dnid, callingsubaddr, and calledsubaddr ... The string comparisons for setting these CDR variables was inverted. We were repeatedly setting these CDR variables only if the channel snapshots had the same value. ASTERISK-27335 Change-Id: I9482073524411e7ea6c03805b16de200cb1669ea	9 years ago
Thomas Sevestre	eadea6f55b	features, manager : Add CancelAtxfer AMI action ... Add action to cancel feature attended transfer with AMI interface ASTERISK-27215 #close Change-Id: Iab8a81362b5a1757e2608f70b014ef863200cb42	9 years ago
Jenkins2	59f732b675	Merge "sorcery: Use ao2_weakproxy to hold list of instances." into 15	9 years ago
Jenkins2	ae5ecbd739	Merge "named_locks: Use ao2_weakproxy_find." into 15	9 years ago
Joshua Colp	13c4c50252	Merge "astobj2: Add ao2_weakproxy_find function." into 15	9 years ago
Jenkins2	8e50cc9034	Merge "astobj2: Run weakproxy callbacks outside of lock." into 15	9 years ago
Richard Mudgett	f8da683a16	cdr.c: Defer misc checks. ... Try to defer some checks until needed in case there is an early exit. Change-Id: Ibc6b34c38a4f60ad4f9b67984b7d070a07257064	9 years ago
Corey Farrell	cd521f166f	sorcery: Use ao2_weakproxy to hold list of instances. ... Store weak proxy objects in instances container. Change-Id: I5a150a4e13cee319d46b5a4654f95a4623a978f8	9 years ago
Corey Farrell	d0a49d84ac	named_locks: Use ao2_weakproxy_find. ... Change-Id: I0ce8a1b7101b6caac6a19f83a89f00eaba1e9d9c	9 years ago
Corey Farrell	e54238388d	astobj2: Add ao2_weakproxy_find function. ... This function finds a weak proxy in an ao2_container and returns the real object associated with it. Change-Id: I9da822049747275f5961b5c0a7f14e87157d65d8	9 years ago
Corey Farrell	0727a8e524	astobj2: Run weakproxy callbacks outside of lock. ... Copy the list of weakproxy callbacks to temporary memory so they can be run without holding the weakproxy lock. Change-Id: Ib167622a8a0f873fd73938f7611b2a5914308047	9 years ago
Richard Mudgett	a22ac5eee1	cdr.c: Eliminated simple RAII_VAR usages. ... Change-Id: I150505db307249a962987e7b941bdd369bb91f35	9 years ago
Jenkins2	caad08d4ec	Merge "tcptls: Do not re-bind to wildcard on client creation." into 15	9 years ago
Jenkins2	9304e90657	Merge "cdr.c: Replace redundant check with an ast_assert()" into 15	9 years ago
Joshua Colp	ab43a7cc94	Merge "cdr.h: Fix doxygen comments." into 15	9 years ago
Jenkins2	a861cb9fe8	Merge "cdr.c: Use current ao2 flag names" into 15	9 years ago
Richard Mudgett	038759c320	cdr.c: Replace redundant check with an ast_assert() ... The only caller of cdr_object_fn_table.process_party_b() explicitly does the check before calling. Change-Id: Ib0c53cdf5048227842846e0df9d2c19117c45618	9 years ago
Richard Mudgett	b48eeff44c	cdr.c: Replace inlined code with ao2_t_replace() ... Change-Id: I9f424f5282ca7d833592f958d95f1b2bafb549b0	9 years ago
Richard Mudgett	58c898aa3f	cdr.c: Use current ao2 flag names ... Change-Id: Ib59d7d2f2a4a822754628f2c48a308d6791a6e6e	9 years ago
Richard Mudgett	4ad4c5679b	cdr.h: Fix doxygen comments. ... * Also some misc formatting in cdr.c. Change-Id: Ied89a28802a662c37c43326a1aafdce596e0df4a	9 years ago
Alexander Traud	3240ba9336	tcptls: Do not re-bind to wildcard on client creation. ... Since ASTERISK-26922, this issue affected only those chan_sip which were * enabled for dual-stack (bindaddr=::), and * enabled for TCP (tcpenable=yes) and/or TLS (tlsenable=yes), and * tried to register and/or invite a IPv4-only service, * via TCP and/or TLS. Now, ast_tcptls_client_create does not re-bind to [::] anymore. ASTERISK-27324 #close Change-Id: I4b242837bdeb1ec7130dc82505c6180a946fd9b5	9 years ago
Corey Farrell	622a1de0f0	main/strings: Fix uninitialized value. ... ast_strings_match uses sscanf and checks for non-zero return to verify a token was parsed. This is incorrect as sscanf returns EOF (-1) for errors. ASTERISK-27318 #close Change-Id: Ifcece92605f58116eff24c5a0a3b0ee08b3c87b1	9 years ago
Richard Mudgett	ade7253c9d	heap.c: No need to calloc heap pointer array. ... Change-Id: I5ae2f316229f336eb90d99c7af7ed07a33097e68	9 years ago
Richard Mudgett	1728e439e8	channel.c: Fix invalid reference in conditionaled out code. ... ASTERISK-27289 Change-Id: I7a415948116493050614d9f4fa91ffbe0c21ec4c	9 years ago
Joshua Colp	1fd68fb253	Merge "bridge: Change participant SFU streams when source streams change." into 15	9 years ago
Joshua Colp	00c625a858	Merge "res_pjsip_session: Check for removed stream state." into 15	9 years ago
Joshua Colp	693c06f8a3	bridge: Change participant SFU streams when source streams change. ... Some endpoints do not like a stream being reused for a new media stream. The frame/jitterbuffer can rely on underlying attributes of the media stream in order to order the packets. When a new stream takes its place without any notice the buffer can get confused and the media ends up getting dropped. This change uses the SSRC change to determine that a new source is reusing an existing stream and then bridge_softmix renegotiates each participant such that they see a new media stream. This causes the frame/jitterbuffer to start fresh and work as expected. ASTERISK-27277 Change-Id: I30ccbdba16ca073d7f31e0e59ab778c153afae07	9 years ago
Ben Ford	90b68dd54b	res_pjsip_session: Check for removed stream state. ... When a sip session is refreshed, the stream topology is looped through, checking each stream for compatible formats. This would cause a crash if the stream state was AST_STREAM_STATE_REMOVED, since the formats would never be set for this stream, causing a NULL value to be returned from ast_stream_get_formats. This commit adds a check for streams with removed states. Also removed a stray semicolon. Change-Id: Ic86f8b65a4a26a60885b28b8b1a0b22e1b471d42	9 years ago
Jean Aunis	47b41bd3ae	bridge : Fix one-way direct-media when early bridging with native_rtp ... When two channels were early bridged in a native_rtp bridge, the RTP description on one side was not updated when the other side answered. This patch forbids non-answered channels to enter a native_rtp bridge, and triggers a bridge reconfiguration when an ANSWER frame is received. ASTERISK-27257 Change-Id: If1aaee1b4ed9658a1aa91ab715ee0a6413b878df	9 years ago
Joshua Colp	ddae0bab23	Merge "tcptls: Change error message to debug." into 15	9 years ago
Joshua Colp	7fa11842d8	tcptls: Change error message to debug. ... The Websocket implementation will steal the underlying stream of TCP/TLS sessions. This results in an error message being output about a stream not being present when in reality this is actually fine. This change moves it to a debug message instead. Change-Id: I66cc639080b4b4599beadb4faa7d313f2721d094	9 years ago
George Joseph	752f0533dd	res_pjsip: Add handling for incoming unsolicited MWI NOTIFY ... A new endpoint parameter "incoming_mwi_mailbox" allows Asterisk to receive unsolicited MWI NOTIFY requests and make them available to other modules via the stasis message bus. res_pjsip_pubsub has a new handler "pubsub_on_rx_mwi_notify_request" that parses a simple-message-summary body and, if endpoint->incoming_mwi_account is set, calls ast_publish_mwi_state with the voice-message counts from the message. Change-Id: I08bae3d16e77af48fcccc2c936acce8fc0ef0f3c	9 years ago
George Joseph	a824fcc8e8	stasis/control: Fix possible deadlock with swap channel ... If an error occurs during a bridge impart it's possible that the "bridge_after" callback might try to run before control_swap_channel_in_bridge has been signalled to continue. Since control_swap_channel_in_bridge is holding the control lock and the callback needs it, a deadlock will occur. * control_swap_channel_in_bridge now only holds the control lock while it's actually modifying the control structure and releases it while the bridge impart is running. * bridge_after_cb is now tolerant of impart failures. Change-Id: Ifd239aa93955b3eb475521f61e284fcb0da2c3b3	9 years ago
Walter Doekes	329e111947	res/res_pjsip: Standardize/fix localnet checks across pjsip. ... In 2dee95cc (ASTERISK-27024) and 776ffd77 (ASTERISK-26879) there was confusion about whether the transport_state->localnet ACL has ALLOW or DENY semantics. For the record: the localnet has DENY semantics, meaning that "not in the list" means ALLOW, and the local nets are in the list. Therefore, checks like this look wrong, but are right: /* See if where we are sending this request is local or not, and if not that we can get a Contact URI to modify */ if (ast_apply_ha(transport_state->localnet, &addr) != AST_SENSE_ALLOW) { ast_debug(5, "Request is being sent to local address, " "skipping NAT manipulation\n"); (In the list == localnet == DENY == skip NAT manipulation.) And conversely, other checks that looked right, were wrong. This change adds two macro's to reduce the confusion and uses those instead: ast_sip_transport_is_nonlocal(transport_state, addr) ast_sip_transport_is_local(transport_state, addr) ASTERISK-27248 #close Change-Id: Ie7767519eb5a822c4848e531a53c0fd054fae934	9 years ago
Sean Bright	1d33757aa0	rtp_engine: Prevent possible double free with DTLS config ... ASTERISK-27225 #close Reported by: Richard Kenner Change-Id: I097b81734ef730f8603c0b972909d212a3a5cf89	9 years ago
Corey Farrell	0372157a48	AST-2017-006: Fix app_minivm application MinivmNotify command injection ... An admin can configure app_minivm with an externnotify program to be run when a voicemail is received. The app_minivm application MinivmNotify uses ast_safe_system() for this purpose which is vulnerable to command injection since the Caller-ID name and number values given to externnotify can come from an external untrusted source. * Add ast_safe_execvp() function. This gives modules the ability to run external commands with greater safety compared to ast_safe_system(). Specifically when some parameters are filled by untrusted sources the new function does not allow malicious input to break argument encoding. This may be of particular concern where CALLERID(name) or CALLERID(num) may be used as a parameter to a script run by ast_safe_system() which could potentially allow arbitrary command execution. * Changed app_minivm.c:run_externnotify() to use the new ast_safe_execvp() instead of ast_safe_system() to avoid command injection. * Document code injection potential from untrusted data sources for other shell commands that are under user control. ASTERISK-27103 Change-Id: I7552472247a84cde24e1358aaf64af160107aef1	9 years ago
Jenkins2	d05ab9e91a	Merge "core: Reduce video update queueing." into 15	9 years ago
Joshua Colp	6baf2c26f3	core: Reduce video update queueing. ... A video update frame is used to indicate that a channel with video negotiated should provide a full frame so the decoder decoding the stream is able to do so. In situations where a queue is used to store frames it makes no sense for the queue to contain multiple video update frames. One is sufficient to have a full frame be sent. ASTERISK-27222 Change-Id: Id3f40a6f51b740ae4704003a1800185c0c658ee7	9 years ago
Richard Mudgett	3e9cd53b5c	bridge_channel.c: Fix FRACK when mapping frames to the bridge. ... * Add protection checks when mapping streams to the bridge. The channel and bridge may be in the process of updating the stream mapping when a media frame comes in so we may not be able to map the frame at the time. * We need to map the streams to the bridge's stream numbers right before they are written into the bridge. That way we don't have to keep locking/unlocking the bridge and we won't have any synchronization problems before the frames actually go into the bridge. * Protect the deferred queue with the bridge_channel lock. ASTERISK-27212 Change-Id: Id6860dd61b594b90c8395f6e2c0150219094c21a	9 years ago
Richard Mudgett	efa6262814	bridge: Fix softmix bridge deadlock. ... * Fix deadlock in bridge_softmix.c:softmix_bridge_stream_topology_changed() between bridge_channel and channel locks. * The new bridge technology topology change callbacks must be called with the bridge locked. The callback references the bridge channel list, the bridge technology could change, and the bridge stream mapping is updated. ASTERISK-27212 Change-Id: Ide4360ab853607e738ad471721af3f561ddd83be	9 years ago
Richard Mudgett	6c555891eb	channel: Fix topology API locking. ... * ast_channel_request_stream_topology_change() must not be called with any channel locks held. * ast_channel_stream_topology_changed() must be called with only the passed channel lock held. ASTERISK-27212 Change-Id: I843de7956d9f1cc7cc02025aea3463d8fe19c691	9 years ago