From ed77b365ce36a018d3b0840db9c28108dec7456f Mon Sep 17 00:00:00 2001 From: Naveen Albert Date: Thu, 22 Dec 2022 01:01:01 +0000 Subject: [PATCH] manager: Fix appending variables. The if statement here is always false after the for loop finishes, so variables are never appended. This removes that to properly append to the end of the variable list. ASTERISK-30351 #close Reported by: Sebastian Gutierrez Change-Id: I1b7f8b85a8918f6a814cb933a479d4278cf16199 --- main/manager.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/main/manager.c b/main/manager.c index 8a198b38ac..c5a48fd4cb 100644 --- a/main/manager.c +++ b/main/manager.c @@ -6274,14 +6274,12 @@ static int action_originate(struct mansession *s, const struct message *m) old = vars; vars = NULL; - /* The variables in the AMI originate action are appended at the end of the list, to override any user variables that apply*/ + /* The variables in the AMI originate action are appended at the end of the list, to override any user variables that apply */ vars = ast_variables_dup(s->session->chanvars); if (old) { for (v = vars; v->next; v = v->next ); - if (v->next) { - v->next = old; /* Append originate variables at end of list */ - } + v->next = old; /* Append originate variables at end of list */ } }