From d6873875cc9156c36f8e3ed14ce7e84e628d7fbc Mon Sep 17 00:00:00 2001 From: "Kevin P. Fleming" Date: Tue, 23 May 2006 18:16:40 +0000 Subject: [PATCH] simplify/fix lock retry, and fix comment git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@29764 65c4cc65-6c06-0410-ace0-fbb531ad65f3 --- channels/chan_sip.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/channels/chan_sip.c b/channels/chan_sip.c index 72d95e2f57..61c55fa76b 100644 --- a/channels/chan_sip.c +++ b/channels/chan_sip.c @@ -11199,7 +11199,7 @@ static int sipsock_read(int *id, int fd, short events, void *ignore) int nounlock; int recount = 0; char iabuf[INET_ADDRSTRLEN]; - int lockretrycount = 0; + unsigned int lockretry = 100; len = sizeof(sin); memset(&req, 0, sizeof(req)); @@ -11252,13 +11252,12 @@ retrylock: ast_log(LOG_DEBUG, "Failed to grab lock, trying again...\n"); ast_mutex_unlock(&p->lock); ast_mutex_unlock(&netlock); - /* Sleep infintismly short amount of time */ + /* Sleep for a very short amount of time */ usleep(1); - lockretrycount++; - if (lockretrycount < 100) + if (--lockretry) goto retrylock; } - if (lockretrycount > 100) { + if (!lockretry) { ast_log(LOG_ERROR, "We could NOT get the channel lock for %s! \n", p->owner->name); ast_log(LOG_ERROR, "SIP MESSAGE JUST IGNORED: %s \n", req.data); ast_log(LOG_ERROR, "BAD! BAD! BAD!\n");