From bef49d90c1cc013aba248c757cd3db2436175c03 Mon Sep 17 00:00:00 2001 From: Richard Mudgett Date: Fri, 2 Feb 2018 15:43:34 -0600 Subject: [PATCH] res_sorcery_realtime.c: Fix ref leak if object failed to apply. Change-Id: I3c7106ff77009754725cee790eadf5da44154ab6 --- res/res_sorcery_realtime.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/res/res_sorcery_realtime.c b/res/res_sorcery_realtime.c index 29fbeb9683..101034009f 100644 --- a/res/res_sorcery_realtime.c +++ b/res/res_sorcery_realtime.c @@ -176,6 +176,7 @@ static void *sorcery_realtime_retrieve_fields(const struct ast_sorcery *sorcery, if (!id || !(object = ast_sorcery_alloc(sorcery, type, id->value)) || ast_sorcery_objectset_apply(sorcery, object, objectset)) { + ao2_cleanup(object); return NULL; } @@ -233,7 +234,9 @@ static void sorcery_realtime_retrieve_multiple(const struct ast_sorcery *sorcery objectset = sorcery_realtime_filter_objectset(objectset, &id, sorcery, type); - if (id && (object = ast_sorcery_alloc(sorcery, type, id->value)) && !ast_sorcery_objectset_apply(sorcery, object, objectset)) { + if (id + && (object = ast_sorcery_alloc(sorcery, type, id->value)) + && !ast_sorcery_objectset_apply(sorcery, object, objectset)) { ao2_link(objects, object); }