From a8393e64bcb15afe3c44c51bdbc84eec7cc5adce Mon Sep 17 00:00:00 2001 From: Kevin Harwell Date: Fri, 3 Jan 2014 18:27:25 +0000 Subject: [PATCH] app_meetme: compiler warning Fixed a compiler warning (errors in 'dev-mode') given by gcc version 4.8.1. The one in app_meetme involved the 'sizeof-pointer-memaccess' (see: http://gcc.gnu.org/gcc-4.8/porting_to.html) warning. Fixed so it would no longer issue a warning and can compile again in 'dev-mode'. Review: https://reviewboard.asterisk.org/r/3098/ ........ Merged revisions 404742 from http://svn.asterisk.org/svn/asterisk/branches/1.8 git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/11@404773 65c4cc65-6c06-0410-ace0-fbb531ad65f3 --- apps/app_meetme.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/apps/app_meetme.c b/apps/app_meetme.c index 6090358848..a9278ebdab 100644 --- a/apps/app_meetme.c +++ b/apps/app_meetme.c @@ -2631,7 +2631,8 @@ static void meetme_menu_admin(enum menu_modes *menu_mode, int *dtmf, struct ast_ * \param recordingtmp character buffer which may hold the name of the conference recording file * \param dahdic dahdi configuration info used by the main conference loop */ -static void meetme_menu_admin_extended(enum menu_modes *menu_mode, int *dtmf, struct ast_conference *conf, struct ast_flags64 *confflags, struct ast_channel *chan, struct ast_conf_user *user, char *recordingtmp, struct dahdi_confinfo *dahdic, struct ast_format_cap *cap_slin) + +static void meetme_menu_admin_extended(enum menu_modes *menu_mode, int *dtmf, struct ast_conference *conf, struct ast_flags64 *confflags, struct ast_channel *chan, struct ast_conf_user *user, char *recordingtmp, int recordingtmp_size, struct dahdi_confinfo *dahdic, struct ast_format_cap *cap_slin) { int keepplaying; int playednamerec; @@ -2752,7 +2753,7 @@ static void meetme_menu_admin_extended(enum menu_modes *menu_mode, int *dtmf, st } ast_channel_unlock(chan); if (!conf->recordingfilename) { - snprintf(recordingtmp, sizeof(recordingtmp), "meetme-conf-rec-%s-%s", conf->confno, ast_channel_uniqueid(chan)); + snprintf(recordingtmp, recordingtmp_size, "meetme-conf-rec-%s-%s", conf->confno, ast_channel_uniqueid(chan)); conf->recordingfilename = ast_strdup(recordingtmp); } if (!conf->recordingformat) { @@ -2815,7 +2816,7 @@ static void meetme_menu_admin_extended(enum menu_modes *menu_mode, int *dtmf, st * \param dahdic dahdi configuration info used by the main conference loop */ -static void meetme_menu(enum menu_modes *menu_mode, int *dtmf, struct ast_conference *conf, struct ast_flags64 *confflags, struct ast_channel *chan, struct ast_conf_user *user, char *recordingtmp, struct dahdi_confinfo *dahdic, struct ast_format_cap *cap_slin) +static void meetme_menu(enum menu_modes *menu_mode, int *dtmf, struct ast_conference *conf, struct ast_flags64 *confflags, struct ast_channel *chan, struct ast_conf_user *user, char *recordingtmp, int recordingtmp_size, struct dahdi_confinfo *dahdic, struct ast_format_cap *cap_slin) { switch (*menu_mode) { case MENU_DISABLED: @@ -2830,7 +2831,7 @@ static void meetme_menu(enum menu_modes *menu_mode, int *dtmf, struct ast_confer break; } case MENU_ADMIN_EXTENDED: - meetme_menu_admin_extended(menu_mode, dtmf, conf, confflags, chan, user, recordingtmp, dahdic, cap_slin); + meetme_menu_admin_extended(menu_mode, dtmf, conf, confflags, chan, user, recordingtmp, recordingtmp_size, dahdic, cap_slin); break; } } @@ -3973,7 +3974,7 @@ static int conf_run(struct ast_channel *chan, struct ast_conference *conf, struc } if (dtmf > 0) { - meetme_menu(&menu_mode, &dtmf, conf, confflags, chan, user, recordingtmp, &dahdic, cap_slin); + meetme_menu(&menu_mode, &dtmf, conf, confflags, chan, user, recordingtmp, sizeof(recordingtmp), &dahdic, cap_slin); } if (musiconhold && !menu_mode) {