From 9e2fcb82ed2450f41f83f59c8030db8dd90abaaa Mon Sep 17 00:00:00 2001
From: Sean Bright <sean.bright@gmail.com>
Date: Tue, 9 Jan 2018 17:23:54 -0500
Subject: [PATCH] cdr_syslog: Deprecate unmaintained module
There has been an open issue against cdr_syslog (ASTERISK~14441) about
a race condition for 7.5 years that has never been addressed. Because
this module is effectively unmaintained and currently broken, there is
no sense in keeping it around.
If logging CDRs to syslog is a desirable feature, it would probably be
better to write the logs directly to the syslog server via socket
instead of using the facilities provided by openlog/syslog/closelog.
Doing so would address the race condition referenced in the associated
issue.
Change-Id: Ic77b94cd97f355a9cf5b1d3f3444964a6e0ba5dc
---
CHANGES | 5 +++++
UPGRADE.txt | 4 ++++
cdr/cdr_syslog.c | 3 ++-
3 files changed, 11 insertions(+), 1 deletion(-)
diff --git a/CHANGES b/CHANGES
index 84344aa875..ec533e8313 100644
--- a/CHANGES
+++ b/CHANGES
@@ -51,6 +51,11 @@ res_pjsip
* A new AMI action, PJSIPShowAuths, has been added which displays information
about all configured PJSIP Auths.
+cdr_syslog
+------------------
+ * The cdr_syslog module is now deprecated and by default it is no longer
+ built.
+
------------------------------------------------------------------------------
--- Functionality changes from Asterisk 15.1.0 to Asterisk 15.2.0 ------------
------------------------------------------------------------------------------
diff --git a/UPGRADE.txt b/UPGRADE.txt
index dd37b259df..b2c75fbb54 100644
--- a/UPGRADE.txt
+++ b/UPGRADE.txt
@@ -40,6 +40,10 @@ ARI:
- The ContactInfo event's contact_status field is now set to "NonQualified"
when a contact exists but has not been qualified.
+cdr_syslog:
+ - The cdr_syslog module is now deprecated and by default it is no longer
+ built.
+
New in 15.0.0:
Build System:
diff --git a/cdr/cdr_syslog.c b/cdr/cdr_syslog.c
index bbe2652295..bbc44064f3 100644
--- a/cdr/cdr_syslog.c
+++ b/cdr/cdr_syslog.c
@@ -37,8 +37,9 @@
*/
/*** MODULEINFO
+ <defaultenabled>no</defaultenabled>
<depend>syslog</depend>
- <support_level>core</support_level>
+ <support_level>deprecated</support_level>
***/
#include "asterisk.h"