From 92b4eb8d40c27e7e88e000418bdc7994e983632c Mon Sep 17 00:00:00 2001 From: Tilghman Lesher Date: Thu, 9 Apr 2009 16:40:29 +0000 Subject: [PATCH] Merged revisions 187363 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r187363 | tilghman | 2009-04-09 11:39:43 -0500 (Thu, 09 Apr 2009) | 10 lines Merged revisions 187362 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r187362 | tilghman | 2009-04-09 11:38:37 -0500 (Thu, 09 Apr 2009) | 3 lines Permit zero-length text messages in SIP. (Related to an issue posted to the -users list, subject "AEL2, BASE64_DECODE and hexadecimal") ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@187364 65c4cc65-6c06-0410-ace0-fbb531ad65f3 --- apps/app_sendtext.c | 4 +++- channels/chan_sip.c | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/apps/app_sendtext.c b/apps/app_sendtext.c index e95ff6158c..f2822711de 100644 --- a/apps/app_sendtext.c +++ b/apps/app_sendtext.c @@ -60,7 +60,9 @@ static int sendtext_exec(struct ast_channel *chan, void *data) AST_APP_ARG(text); ); - if (ast_strlen_zero(data)) { + /* NOT ast_strlen_zero, because some protocols (e.g. SIP) MUST be able to + * send a zero-length message. */ + if (!data) { ast_log(LOG_WARNING, "SendText requires an argument (text)\n"); return -1; } else diff --git a/channels/chan_sip.c b/channels/chan_sip.c index e75d676248..6d19491909 100644 --- a/channels/chan_sip.c +++ b/channels/chan_sip.c @@ -3440,7 +3440,9 @@ static int sip_sendtext(struct ast_channel *ast, const char *text) ast_verbose("Sending text %s on %s\n", text, ast->name); if (!p) return -1; - if (ast_strlen_zero(text)) + /* NOT ast_strlen_zero, because a zero-length message is specifically + * allowed by RFC 3428 (See section 10, Examples) */ + if (!text) return 0; if (debug) ast_verbose("Really sending text %s on %s\n", text, ast->name);