From 5490889153baa8b756b4ff172ff57efb1e41d6a0 Mon Sep 17 00:00:00 2001 From: Luigi Rizzo Date: Mon, 10 Dec 2007 03:50:38 +0000 Subject: [PATCH] Put into Makefile.moddir_rules the common instructions used to generate loadable and embedded module lists. Individual Makefiles now are a lot simpler, possibly as simple as this: -include $(ASTTOPDIR)/menuselect.makeopts $(ASTTOPDIR)/menuselect.makedeps MODULE_PREFIX=cdr_ all: _all include $(ASTTOPDIR)/Makefile.moddir_rules and also more flexible because in a single directory we can combine various types of modules (app_, cdr_, func_, ... ) by simply listing them in the MODULE_PREFIX variable. The individual Makefiles can also create list of modules to be excluded by listing them in the variablel MODULE_EXCLUDE (see an example in channels/Makefile). With this change it becomes trivial to integrate a directory with locally created/modified sources into the main build. git-svn-id: https://origsvn.digium.com/svn/asterisk/trunk@92082 65c4cc65-6c06-0410-ace0-fbb531ad65f3 --- Makefile.moddir_rules | 35 +++++++++++++++++++++++++++++++++++ apps/Makefile | 12 +++--------- cdr/Makefile | 10 +--------- channels/Makefile | 16 ++++------------ codecs/Makefile | 10 +--------- formats/Makefile | 10 +--------- funcs/Makefile | 10 +--------- pbx/Makefile | 10 +--------- res/Makefile | 10 +--------- 9 files changed, 48 insertions(+), 75 deletions(-) diff --git a/Makefile.moddir_rules b/Makefile.moddir_rules index 8db597cb41..20fcde38a2 100644 --- a/Makefile.moddir_rules +++ b/Makefile.moddir_rules @@ -34,6 +34,41 @@ endif include $(ASTTOPDIR)/Makefile.rules +# If MODULE_PREFIX is defined, use it to run the standard functions to set +# C_MODS, CC_MODS, LOADABLE_MODS and EMBEDDED_MODS. +# Each word of MODULE_PREFIX is a prefix for filenames that we consider +# valid C or CC modules (eg. app_, func_ ...). +# Use MODULE_EXCLUDE to specify additional modules to exclude. + +ifneq ($(MODULE_PREFIX),) + # Compute the lowercase and uppercase directory name. The former + # is used as a key in MENUSELECT_EMBED, the latter is part of + # the name of the MENUSELECT_* variable containing the exclude list + # generated by menuselect. + A:=$(notdir $(CURDIR)) + B:=$(shell echo $A | tr "[a-z]" "[A-Z]") + # MENUSELECT_$(L) contains the list of modules excluded by menuselect. + # MODULE_EXCLUDE contains the locally generated exclude list + L:=$(MENUSELECT_$(B)) $(MODULE_EXCLUDE) + # construct the list of C and CC modules from the content of the directory + C_MODS:= + CC_MODS:= + C_MODS+=$(foreach pre,$(MODULE_PREFIX),$(filter-out $(L),$(patsubst %.c,%,$(wildcard $(pre)*.c)))) + CC_MODS+=$(foreach pre,$(MODULE_PREFIX),$(filter-out $(L),$(patsubst %.cc,%,$(wildcard $(pre)*.cc)))) + + # and store in the list of embedded or loadable modules + ifneq ($(findstring $(A),$(MENUSELECT_EMBED)),) + EMBEDDED_MODS:=$(C_MODS) $(CC_MODS) + else + LOADABLE_MODS:=$(C_MODS) $(CC_MODS) + endif +endif +# debugging +# x:=$(shell echo 'in $(B)' >&2) +# x:=$(shell echo 'filtered out $(L)' >&2) +# x:=$(shell echo 'C_MODS= $(C_MODS)' >&2) +# x:=$(shell sleep 2) + # Both C++ and C++ sources need their module name in AST_MODULE # We also pass whatever _INCLUDE list is generated by menuselect # (they are stored in file 'makeopts') diff --git a/apps/Makefile b/apps/Makefile index a04d31fadb..21bc0a90ad 100644 --- a/apps/Makefile +++ b/apps/Makefile @@ -11,16 +11,10 @@ -include $(ASTTOPDIR)/menuselect.makeopts $(ASTTOPDIR)/menuselect.makedeps -C_MODS:=$(filter-out $(MENUSELECT_APPS),$(patsubst %.c,%,$(wildcard app_*.c))) -CC_MODS:=$(filter-out $(MENUSELECT_APPS),$(patsubst %.cc,%,$(wildcard app_*.cc))) - -LOADABLE_MODS:=$(C_MODS) $(CC_MODS) - -ifneq ($(findstring apps,$(MENUSELECT_EMBED)),) - EMBEDDED_MODS:=$(LOADABLE_MODS) - LOADABLE_MODS:= -endif +#interesting files in this directory start with app_ +MODULE_PREFIX=app_ +# create extra MENUSELECT_DEPENDS entries. MENUSELECT_OPTS_app_directory:=$(MENUSELECT_OPTS_app_voicemail) ifneq ($(findstring ODBC_STORAGE,$(MENUSELECT_OPTS_app_voicemail)),) MENUSELECT_DEPENDS_app_voicemail+=$(MENUSELECT_DEPENDS_ODBC_STORAGE) diff --git a/cdr/Makefile b/cdr/Makefile index a1dd565b86..45e8b23d9b 100644 --- a/cdr/Makefile +++ b/cdr/Makefile @@ -11,15 +11,7 @@ -include $(ASTTOPDIR)/menuselect.makeopts $(ASTTOPDIR)/menuselect.makedeps -C_MODS:=$(filter-out $(MENUSELECT_CDR),$(patsubst %.c,%,$(wildcard cdr_*.c))) -CC_MODS:=$(filter-out $(MENUSELECT_CDR),$(patsubst %.cc,%,$(wildcard cdr_*.cc))) - -LOADABLE_MODS:=$(C_MODS) $(CC_MODS) - -ifneq ($(findstring cdr,$(MENUSELECT_EMBED)),) - EMBEDDED_MODS:=$(LOADABLE_MODS) - LOADABLE_MODS:= -endif +MODULE_PREFIX=cdr_ all: _all diff --git a/channels/Makefile b/channels/Makefile index 06f45f8dc0..1bf461e0f6 100644 --- a/channels/Makefile +++ b/channels/Makefile @@ -11,8 +11,7 @@ -include $(ASTTOPDIR)/menuselect.makeopts $(ASTTOPDIR)/menuselect.makedeps -C_MODS:=$(filter-out $(MENUSELECT_CHANNELS),$(patsubst %.c,%,$(wildcard chan_*.c))) -CC_MODS:=$(filter-out $(MENUSELECT_CHANNELS),$(patsubst %.cc,%,$(wildcard chan_*.cc))) +MODULE_PREFIX=chan_ ifeq ($(OSARCH),OpenBSD) PTLIB=-lpt_OpenBSD_x86_r @@ -36,13 +35,13 @@ ifeq ($(OSARCH),NetBSD) H323LIB=-lh323_NetBSD_x86_r endif +MODULE_EXCLUDE:= ifneq ($(findstring $(OSARCH), mingw32 cygwin ),) - C_MODS:=$(filter-out chan_oss,$(C_MODS)) - C_MODS:=$(filter-out chan_unistim,$(C_MODS)) + MODULE_EXCLUDE+= chan_oss chan_unistim endif ifeq ($(wildcard h323/libchanh323.a),) - CC_MODS:=$(filter-out chan_h323,$(CC_MODS)) + MODULE_EXCLUDE += chan_h323 endif ifndef OPENH323DIR @@ -53,13 +52,6 @@ ifndef PWLIBDIR PWLIBDIR=$(HOME)/pwlib endif -LOADABLE_MODS:=$(C_MODS) $(CC_MODS) - -ifneq ($(findstring channels,$(MENUSELECT_EMBED)),) - EMBEDDED_MODS:=$(LOADABLE_MODS) - LOADABLE_MODS:= -endif - all: _all include $(ASTTOPDIR)/Makefile.moddir_rules diff --git a/codecs/Makefile b/codecs/Makefile index d4402d3c3d..99a3b4edd1 100644 --- a/codecs/Makefile +++ b/codecs/Makefile @@ -13,15 +13,7 @@ -include $(ASTTOPDIR)/menuselect.makeopts $(ASTTOPDIR)/menuselect.makedeps -C_MODS:=$(filter-out $(MENUSELECT_CODECS),$(patsubst %.c,%,$(wildcard codec_*.c))) -CC_MODS:=$(filter-out $(MENUSELECT_CODECS),$(patsubst %.cc,%,$(wildcard codec_*.cc))) - -LOADABLE_MODS:=$(C_MODS) $(CC_MODS) - -ifneq ($(findstring codecs,$(MENUSELECT_EMBED)),) - EMBEDDED_MODS:=$(LOADABLE_MODS) - LOADABLE_MODS:= -endif +MODULE_PREFIX=codec_ LIBILBC:=ilbc/libilbc.a LIBLPC10:=lpc10/liblpc10.a diff --git a/formats/Makefile b/formats/Makefile index b003a2d513..ef76ec2500 100644 --- a/formats/Makefile +++ b/formats/Makefile @@ -11,15 +11,7 @@ -include $(ASTTOPDIR)/menuselect.makeopts $(ASTTOPDIR)/menuselect.makedeps -C_MODS:=$(filter-out $(MENUSELECT_FORMATS),$(patsubst %.c,%,$(wildcard format_*.c))) -CC_MODS:=$(filter-out $(MENUSELECT_FORMATS),$(patsubst %.cc,%,$(wildcard format_*.cc))) - -LOADABLE_MODS:=$(C_MODS) $(CC_MODS) - -ifneq ($(findstring formats,$(MENUSELECT_EMBED)),) - EMBEDDED_MODS:=$(LOADABLE_MODS) - LOADABLE_MODS:= -endif +MODULE_PREFIX=format_ all: _all diff --git a/funcs/Makefile b/funcs/Makefile index 160200035f..7d33d4867d 100644 --- a/funcs/Makefile +++ b/funcs/Makefile @@ -11,15 +11,7 @@ -include $(ASTTOPDIR)/menuselect.makeopts $(ASTTOPDIR)/menuselect.makedeps -C_MODS:=$(filter-out $(MENUSELECT_FUNCS),$(patsubst %.c,%,$(wildcard func_*.c))) -CC_MODS:=$(filter-out $(MENUSELECT_FUNCS),$(patsubst %.cc,%,$(wildcard func_*.cc))) - -LOADABLE_MODS:=$(C_MODS) $(CC_MODS) - -ifneq ($(findstring funcs,$(MENUSELECT_EMBED)),) - EMBEDDED_MODS:=$(LOADABLE_MODS) - LOADABLE_MODS:= -endif +MODULE_PREFIX=func_ all: _all diff --git a/pbx/Makefile b/pbx/Makefile index c443b56fca..bc3d164ac6 100644 --- a/pbx/Makefile +++ b/pbx/Makefile @@ -11,15 +11,7 @@ -include $(ASTTOPDIR)/menuselect.makeopts $(ASTTOPDIR)/menuselect.makedeps -C_MODS:=$(filter-out $(MENUSELECT_PBX),$(patsubst %.c,%,$(wildcard pbx_*.c))) -CC_MODS:=$(filter-out $(MENUSELECT_PBX),$(patsubst %.cc,%,$(wildcard pbx_*.cc))) - -LOADABLE_MODS:=$(C_MODS) $(CC_MODS) - -ifneq ($(findstring pbx,$(MENUSELECT_EMBED)),) - EMBEDDED_MODS:=$(LOADABLE_MODS) - LOADABLE_MODS:= -endif +MODULE_PREFIX=pbx_ all: _all diff --git a/res/Makefile b/res/Makefile index fe9f83106c..7dc1b97ac5 100644 --- a/res/Makefile +++ b/res/Makefile @@ -11,15 +11,7 @@ -include $(ASTTOPDIR)/menuselect.makeopts $(ASTTOPDIR)/menuselect.makedeps -C_MODS:=$(filter-out $(MENUSELECT_RES),$(patsubst %.c,%,$(wildcard res_*.c))) -CC_MODS:=$(filter-out $(MENUSELECT_RES),$(patsubst %.cc,%,$(wildcard res_*.cc))) - -LOADABLE_MODS:=$(C_MODS) $(CC_MODS) - -ifneq ($(findstring res,$(MENUSELECT_EMBED)),) - EMBEDDED_MODS:=$(LOADABLE_MODS) - LOADABLE_MODS:= -endif +MODULE_PREFIX=res_ all: _all