From 4736407e8d7fc14180c60eda8289df53fd5942cc Mon Sep 17 00:00:00 2001 From: Mark Michelson Date: Fri, 9 Jan 2009 21:57:46 +0000 Subject: [PATCH] Merged revisions 168193 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r168193 | mmichelson | 2009-01-09 15:53:26 -0600 (Fri, 09 Jan 2009) | 21 lines Merged revisions 168128 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r168128 | mmichelson | 2009-01-09 14:08:04 -0600 (Fri, 09 Jan 2009) | 13 lines Add check_via calls to more request handlers INFO, NOTIFY, OPTIONS, REFER, and MESSAGE requests were not checking the topmost Via to determine where to send the response. Adding check_via calls to those request handlers solves this. (closes issue #13071) Reported by: baron Patches: check_via.patch uploaded by baron (license 531) Tested by: baron ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@168196 65c4cc65-6c06-0410-ace0-fbb531ad65f3 --- channels/chan_sip.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/channels/chan_sip.c b/channels/chan_sip.c index 60fa698abe..085405d421 100644 --- a/channels/chan_sip.c +++ b/channels/chan_sip.c @@ -14421,6 +14421,7 @@ static void handle_request_info(struct sip_pvt *p, struct sip_request *req) unsigned int event; const char *c = get_header(req, "Content-Type"); + check_via(p, req); /* Need to check the media/type */ if (!strcasecmp(c, "application/dtmf-relay") || !strcasecmp(c, "application/vnd.nortelnetworks.digits")) { @@ -16799,6 +16800,7 @@ static int handle_request_notify(struct sip_pvt *p, struct sip_request *req, str char *eventid = NULL; char *sep; + check_via(p, req); if( (sep = strchr(event, ';')) ) { /* XXX bug here - overwriting string ? */ *sep++ = '\0'; eventid = sep; @@ -16937,6 +16939,7 @@ static int handle_request_options(struct sip_pvt *p, struct sip_request *req) (this needs to be fixed in 1.4 as well) */ + check_via(p, req); if (p->lastinvite) { /* if this is a request in an active dialog, just confirm that the dialog exists. */ transmit_response_with_allow(p, "200 OK", req, 0); @@ -18242,6 +18245,7 @@ static int handle_request_refer(struct sip_pvt *p, struct sip_request *req, int int res = 0; + check_via(p, req); if (req->debug) ast_verbose("Call %s got a SIP call transfer from %s: (REFER)!\n", p->callid, ast_test_flag(&p->flags[0], SIP_OUTGOING) ? "callee" : "caller"); @@ -18781,6 +18785,7 @@ static int handle_request_bye(struct sip_pvt *p, struct sip_request *req) static int handle_request_message(struct sip_pvt *p, struct sip_request *req) { if (!req->ignore) { + check_via(p, req); if (req->debug) ast_verbose("Receiving message!\n"); receive_message(p, req);