From d8063c1cf9b0fe1a2192e437f33d4eb223f76a59 Mon Sep 17 00:00:00 2001 From: Walter Doekes Date: Wed, 4 Dec 2019 10:33:44 +0100 Subject: [PATCH] app_queue: Fix old confusing comment about when the members are called ASTERISK-28644 Change-Id: I2771a931d00a8fc2b9f9a4d1a33ea8f1ad24e06b --- apps/app_queue.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/apps/app_queue.c b/apps/app_queue.c index 53ae2ba1c5..d67dbcf09c 100644 --- a/apps/app_queue.c +++ b/apps/app_queue.c @@ -4707,7 +4707,7 @@ static void rna(int rnatime, struct queue_ent *qe, struct ast_channel *peer, cha ast_verb(3, "Auto-Pausing Queue Member %s in all queues since they failed to answer on queue %s.\n", interface, qe->parent->name); } else { - ast_verb(3, "Failed to pause Queue Member %s in all queues!\n", interface); + ast_verb(3, "Failed to pause Queue Member %s in all queues!\n", interface); } } } @@ -6631,8 +6631,7 @@ static int try_calling(struct queue_ent *qe, struct ast_flags opts, char **opt_a tmp->lastcall = cur->lastcall; tmp->lastqueue = cur->lastqueue; ast_copy_string(tmp->interface, cur->interface, sizeof(tmp->interface)); - /* Special case: If we ring everyone, go ahead and ring them, otherwise - just calculate their metric for the appropriate strategy */ + /* Calculate the metric for the appropriate strategy. */ if (!calc_metric(qe->parent, cur, x++, qe, tmp)) { /* Put them in the list of outgoing thingies... We're ready now. XXX If we're forcibly removed, these outgoing calls won't get @@ -6668,6 +6667,7 @@ static int try_calling(struct queue_ent *qe, struct ast_flags opts, char **opt_a orig = to; ++qe->pending; ao2_unlock(qe->parent); + /* Call the queue members with the best metric now. */ ring_one(qe, outgoing, &numbusies); lpeer = wait_for_answer(qe, outgoing, &to, &digit, numbusies, ast_test_flag(&(bridge_config.features_caller), AST_FEATURE_DISCONNECT),