From 2e95f4713a71a1f3090197c68ba6056afbe7b211 Mon Sep 17 00:00:00 2001 From: Sean Bright Date: Mon, 27 Feb 2023 16:35:57 -0500 Subject: [PATCH] =?UTF-8?q?test=5Fcrypto.c:=20Fix=20getcwd(=E2=80=A6)=20bu?= =?UTF-8?q?ild=20error.?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit `getcwd(…)` is decorated with the `warn_unused_result` attribute and therefore needs its return value checked. Change-Id: Idcccb20a0abf293202c28633d0e9ee0f6a9dbe93 --- tests/test_crypto.c | 32 ++++++++++++++++++++++++++++---- 1 file changed, 28 insertions(+), 4 deletions(-) diff --git a/tests/test_crypto.c b/tests/test_crypto.c index 848a562b36..8b52c9df38 100644 --- a/tests/test_crypto.c +++ b/tests/test_crypto.c @@ -110,10 +110,16 @@ AST_TEST_DEFINE(crypto_rsa_encrypt) if (!ast_check_command_in_path(command)) { ast_test_status_update(test, "couldn't find %s\n", command); + ast_test_capture_free(&cap); + return res; + } + + if (getcwd(wd, sizeof(wd)) == NULL) { + ast_test_status_update(test, "Could not determine current working directory\n"); + ast_test_capture_free(&cap); return res; } - getcwd(wd, sizeof(wd)); snprintf(key_dir, sizeof(key_dir), "%s/%s", wd, "tests/keys"); push_key_dir((const char *)key_dir); snprintf(priv, sizeof(priv), "%s/%s.key", key_dir, keypair1); @@ -200,10 +206,16 @@ AST_TEST_DEFINE(crypto_rsa_decrypt) if (!ast_check_command_in_path(command)) { ast_test_status_update(test, "couldn't find %s\n", command); + ast_test_capture_free(&cap); + return res; + } + + if (getcwd(wd, sizeof(wd)) == NULL) { + ast_test_status_update(test, "Could not determine current working directory\n"); + ast_test_capture_free(&cap); return res; } - getcwd(wd, sizeof(wd)); snprintf(key_dir, sizeof(key_dir), "%s/%s", wd, "tests/keys"); push_key_dir((const char *)key_dir); snprintf(pub, sizeof(pub), "%s/%s.pub", key_dir, keypair1); @@ -297,10 +309,16 @@ AST_TEST_DEFINE(crypto_sign) if (!ast_check_command_in_path(command)) { ast_test_status_update(test, "couldn't find %s\n", command); + ast_test_capture_free(&cap); + return res; + } + + if (getcwd(wd, sizeof(wd)) == NULL) { + ast_test_status_update(test, "Could not determine current working directory\n"); + ast_test_capture_free(&cap); return res; } - getcwd(wd, sizeof(wd)); snprintf(key_dir, sizeof(key_dir), "%s/%s", wd, "tests/keys"); push_key_dir((const char *)key_dir); snprintf(pub, sizeof(pub), "%s/%s.pub", key_dir, keypair1); @@ -410,10 +428,16 @@ AST_TEST_DEFINE(crypto_verify) if (!ast_check_command_in_path(command)) { ast_test_status_update(test, "couldn't find %s\n", command); + ast_test_capture_free(&cap); + return res; + } + + if (getcwd(wd, sizeof(wd)) == NULL) { + ast_test_status_update(test, "Could not determine current working directory\n"); + ast_test_capture_free(&cap); return res; } - getcwd(wd, sizeof(wd)); snprintf(key_dir, sizeof(key_dir), "%s/%s", wd, "tests/keys"); push_key_dir((const char *)key_dir); snprintf(priv, sizeof(priv), "%s/%s.key", key_dir, keypair1);