diff --git a/res/ari/ari_websockets.c b/res/ari/ari_websockets.c index 1d2eacd5bd..39c6dcac90 100644 --- a/res/ari/ari_websockets.c +++ b/res/ari/ari_websockets.c @@ -174,7 +174,7 @@ int ast_ari_websocket_session_write(struct ast_ari_websocket_session *session, return -1; } - ast_debug(3, "Examining ARI event: \n%s\n", str); + ast_debug(3, "Examining ARI event (length %zu): \n%s\n", strlen(str), str); if (ast_websocket_write_string(session->ws_session, str)) { ast_log(LOG_NOTICE, "Problem occurred during websocket write, websocket closed\n"); return -1; diff --git a/res/res_http_websocket.c b/res/res_http_websocket.c index bad8337051..db9c50a28d 100644 --- a/res/res_http_websocket.c +++ b/res/res_http_websocket.c @@ -298,6 +298,24 @@ int AST_OPTIONAL_API_NAME(ast_websocket_close)(struct ast_websocket *session, ui return res; } +static const char *opcode_map[] = { + [AST_WEBSOCKET_OPCODE_CONTINUATION] = "continuation", + [AST_WEBSOCKET_OPCODE_TEXT] = "text", + [AST_WEBSOCKET_OPCODE_BINARY] = "binary", + [AST_WEBSOCKET_OPCODE_CLOSE] = "close", + [AST_WEBSOCKET_OPCODE_PING] = "ping", + [AST_WEBSOCKET_OPCODE_PONG] = "pong", +}; + +static const char *websocket_opcode2str(enum ast_websocket_opcode opcode) +{ + if (opcode < AST_WEBSOCKET_OPCODE_CONTINUATION || + opcode > AST_WEBSOCKET_OPCODE_PONG) { + return ""; + } else { + return opcode_map[opcode]; + } +} /*! \brief Write function for websocket traffic */ int AST_OPTIONAL_API_NAME(ast_websocket_write)(struct ast_websocket *session, enum ast_websocket_opcode opcode, char *payload, uint64_t actual_length) @@ -306,6 +324,9 @@ int AST_OPTIONAL_API_NAME(ast_websocket_write)(struct ast_websocket *session, en char *frame; uint64_t length; + ast_debug(3, "Writing websocket %s frame, length %" PRIu64 "\n", + websocket_opcode2str(opcode), actual_length); + if (actual_length < 126) { length = actual_length; } else if (actual_length < (1 << 16)) { @@ -1356,6 +1377,8 @@ int AST_OPTIONAL_API_NAME(ast_websocket_write_string) { uint64_t len = strlen(buf); + ast_debug(3, "Writing websocket string of length %" PRIu64 "\n", len); + /* We do not pass strlen(buf) to ast_websocket_write() directly because the * size_t returned by strlen() may not require the same storage size * as the uint64_t that ast_websocket_write() uses. This normally