From 13e940b985e514957ba16db34aeba17a67641cde Mon Sep 17 00:00:00 2001 From: Joshua Colp Date: Tue, 19 Sep 2017 11:08:19 -0500 Subject: [PATCH] Update for certified/11.6-cert18 --- .version | 2 +- ChangeLog | 50 +++++++ asterisk-certified-11.6-cert17-summary.html | 39 ----- asterisk-certified-11.6-cert17-summary.txt | 151 -------------------- asterisk-certified-11.6-cert18-summary.html | 16 +++ asterisk-certified-11.6-cert18-summary.txt | 88 ++++++++++++ 6 files changed, 155 insertions(+), 191 deletions(-) delete mode 100644 asterisk-certified-11.6-cert17-summary.html delete mode 100644 asterisk-certified-11.6-cert17-summary.txt create mode 100644 asterisk-certified-11.6-cert18-summary.html create mode 100644 asterisk-certified-11.6-cert18-summary.txt diff --git a/.version b/.version index 1265036ed6..d9fc7de747 100644 --- a/.version +++ b/.version @@ -1 +1 @@ -certified/11.6-cert17 \ No newline at end of file +certified/11.6-cert18 \ No newline at end of file diff --git a/ChangeLog b/ChangeLog index bea77cc1cd..224a418011 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,53 @@ +2017-09-19 16:08 +0000 Asterisk Development Team + + * asterisk certified/11.6-cert18 Released. + +2017-09-13 12:07 +0000 [52d06e95b5] Richard Mudgett + + * AST-2017-008: Improve RTP and RTCP packet processing. + + Validate RTCP packets before processing them. + + * Validate that the received packet is of a minimum length and apply the + RFC3550 RTCP packet validation checks. + + * Fixed potentially reading garbage beyond the received RTCP record data. + + * Fixed rtp->themssrc only being set once when the remote could change + the SSRC. We would effectively stop handling the RTCP statistic records. + + * Fixed rtp->themssrc to not treat a zero value as special by adding + rtp->themssrc_valid to indicate if rtp->themssrc is available. + + ASTERISK-27274 + + Make strict RTP learning more flexible. + + Direct media can cause strict RTP to attempt to learn a remote address + again before it has had a chance to learn the remote address the first + time. Because of the rapid relearn requests, strict RTP could latch onto + the first remote address and fail to latch onto the direct media remote + address. As a result, you have one way audio until the call is placed on + and off hold. + + The new algorithm learns remote addresses for a set time (1.5 seconds) + before locking the remote address. In addition, we must see a configured + number of remote packets from the same address in a row before switching. + + * Fixed strict RTP learning from always accepting the first new address + packet as the new stream. + + * Fixed strict RTP to initialize the expected sequence number with the + last received sequence number instead of the last transmitted sequence + number. + + * Fixed the predicted next sequence number calculation in + rtp_learning_rtp_seq_update() to handle overflow. + + ASTERISK-27252 + + Change-Id: Ia2d3aa6e0f22906c25971e74f10027d96525f31c + 2017-08-31 15:32 +0000 Asterisk Development Team * asterisk certified/11.6-cert17 Released. diff --git a/asterisk-certified-11.6-cert17-summary.html b/asterisk-certified-11.6-cert17-summary.html deleted file mode 100644 index a134677873..0000000000 --- a/asterisk-certified-11.6-cert17-summary.html +++ /dev/null @@ -1,39 +0,0 @@ -Release Summary - asterisk-certified/11.6-cert17

Release Summary

asterisk-certified/11.6-cert17

Date: 2017-08-31

<asteriskteam@digium.com>

Table of Contents

    -
  1. Summary
    2. -
  2. Contributors
    3. -
  3. Closed Issues
    4. -
  4. Diffstat
    5. -

Summary

[Back to Top]

This release has been made to address one or more security vulnerabilities that have been identified. A security advisory document has been published for each vulnerability that includes additional information. Users of versions of Asterisk that are affected are strongly encouraged to review the advisories and determine what action they should take to protect their systems from these issues.

Security Advisories:

The data in this summary reflects changes that have been made since the previous release, asterisk-certified/11.6-cert16.

Contributors

[Back to Top]

This table lists the people who have submitted code, those that have tested patches, as well as those that reported issues on the issue tracker that were resolved in this release. For coders, the number is how many of their patches (of any size) were committed into this release. For testers, the number is the number of times their name was listed as assisting with testing a patch. Finally, for reporters, the number is the number of issues that they reported that were affected by commits that went into this release.

- - -
CodersTestersReporters
1 Corey Farrell
1 Joshua Colp
1 Joshua Colp
1 Corey Farrell

Closed Issues

[Back to Top]

This is a list of all issues from the issue tracker that were closed by changes that went into this release.

Bug

Category: Applications/app_minivm

ASTERISK-27103: core: ast_safe_system command injection possible.
Reported by: Corey Farrell
    -
  • [4c4e7303a8] Corey Farrell -- AST-2017-006: Fix app_minivm application MinivmNotify command injection
    • -

Category: Applications/app_mixmonitor

ASTERISK-27103: core: ast_safe_system command injection possible.
Reported by: Corey Farrell
    -
  • [4c4e7303a8] Corey Farrell -- AST-2017-006: Fix app_minivm application MinivmNotify command injection
    • -

Category: Applications/app_system

ASTERISK-27103: core: ast_safe_system command injection possible.
Reported by: Corey Farrell
    -
  • [4c4e7303a8] Corey Farrell -- AST-2017-006: Fix app_minivm application MinivmNotify command injection
    • -

Category: Applications/app_voicemail

ASTERISK-27103: core: ast_safe_system command injection possible.
Reported by: Corey Farrell
    -
  • [4c4e7303a8] Corey Farrell -- AST-2017-006: Fix app_minivm application MinivmNotify command injection
    • -

Category: Channels/chan_dahdi

ASTERISK-27103: core: ast_safe_system command injection possible.
Reported by: Corey Farrell
    -
  • [4c4e7303a8] Corey Farrell -- AST-2017-006: Fix app_minivm application MinivmNotify command injection
    • -

Category: Core/General

ASTERISK-27103: core: ast_safe_system command injection possible.
Reported by: Corey Farrell
    -
  • [4c4e7303a8] Corey Farrell -- AST-2017-006: Fix app_minivm application MinivmNotify command injection
    • -

Category: Functions/func_shell

ASTERISK-27103: core: ast_safe_system command injection possible.
Reported by: Corey Farrell
    -
  • [4c4e7303a8] Corey Farrell -- AST-2017-006: Fix app_minivm application MinivmNotify command injection
    • -

Category: Resources/res_monitor

ASTERISK-27103: core: ast_safe_system command injection possible.
Reported by: Corey Farrell
    -
  • [4c4e7303a8] Corey Farrell -- AST-2017-006: Fix app_minivm application MinivmNotify command injection
    • -

Category: Resources/res_rtp_asterisk

ASTERISK-27013: res_rtp_asterisk: Media can be hijacked even with strict RTP enabled
Reported by: Joshua Colp
    -
  • [04c45758ca] Joshua Colp -- res_rtp_asterisk: Only learn a new source in learn state.
    • -

Diffstat Results

[Back to Top]

This is a summary of the changes to the source code that went into this release that was generated using the diffstat utility.

README-SERIOUSLY.bestpractices.txt |    7 ++
-apps/app_minivm.c                  |   36 +++++++++-----
-apps/app_mixmonitor.c              |   10 +++
-apps/app_system.c                  |   10 +++
-configs/minivm.conf.sample         |    2
-funcs/func_shell.c                 |    5 +
-include/asterisk/app.h             |   31 +++++++++++-
-main/asterisk.c                    |   93 +++++++++++++++++++++++++++++++------
-res/res_monitor.c                  |   13 +++--
-res/res_rtp_asterisk.c             |   70 +++++++++++++++------------
-10 files changed, 213 insertions(+), 64 deletions(-)

\ No newline at end of file diff --git a/asterisk-certified-11.6-cert17-summary.txt b/asterisk-certified-11.6-cert17-summary.txt deleted file mode 100644 index c8501d584e..0000000000 --- a/asterisk-certified-11.6-cert17-summary.txt +++ /dev/null @@ -1,151 +0,0 @@ - Release Summary - - asterisk-certified/11.6-cert17 - - Date: 2017-08-31 - - - - ---------------------------------------------------------------------- - - Table of Contents - - 1. Summary - 2. Contributors - 3. Closed Issues - 4. Diffstat - - ---------------------------------------------------------------------- - - Summary - - [Back to Top] - - This release has been made to address one or more security vulnerabilities - that have been identified. A security advisory document has been published - for each vulnerability that includes additional information. Users of - versions of Asterisk that are affected are strongly encouraged to review - the advisories and determine what action they should take to protect their - systems from these issues. - - Security Advisories: - - * AST-2017-005,AST-2017-006 - - The data in this summary reflects changes that have been made since the - previous release, asterisk-certified/11.6-cert16. - - ---------------------------------------------------------------------- - - Contributors - - [Back to Top] - - This table lists the people who have submitted code, those that have - tested patches, as well as those that reported issues on the issue tracker - that were resolved in this release. For coders, the number is how many of - their patches (of any size) were committed into this release. For testers, - the number is the number of times their name was listed as assisting with - testing a patch. Finally, for reporters, the number is the number of - issues that they reported that were affected by commits that went into - this release. - - Coders Testers Reporters - 1 Corey Farrell 1 Joshua Colp - 1 Joshua Colp 1 Corey Farrell - - ---------------------------------------------------------------------- - - Closed Issues - - [Back to Top] - - This is a list of all issues from the issue tracker that were closed by - changes that went into this release. - - Bug - - Category: Applications/app_minivm - - ASTERISK-27103: core: ast_safe_system command injection possible. - Reported by: Corey Farrell - * [4c4e7303a8] Corey Farrell -- AST-2017-006: Fix app_minivm application - MinivmNotify command injection - - Category: Applications/app_mixmonitor - - ASTERISK-27103: core: ast_safe_system command injection possible. - Reported by: Corey Farrell - * [4c4e7303a8] Corey Farrell -- AST-2017-006: Fix app_minivm application - MinivmNotify command injection - - Category: Applications/app_system - - ASTERISK-27103: core: ast_safe_system command injection possible. - Reported by: Corey Farrell - * [4c4e7303a8] Corey Farrell -- AST-2017-006: Fix app_minivm application - MinivmNotify command injection - - Category: Applications/app_voicemail - - ASTERISK-27103: core: ast_safe_system command injection possible. - Reported by: Corey Farrell - * [4c4e7303a8] Corey Farrell -- AST-2017-006: Fix app_minivm application - MinivmNotify command injection - - Category: Channels/chan_dahdi - - ASTERISK-27103: core: ast_safe_system command injection possible. - Reported by: Corey Farrell - * [4c4e7303a8] Corey Farrell -- AST-2017-006: Fix app_minivm application - MinivmNotify command injection - - Category: Core/General - - ASTERISK-27103: core: ast_safe_system command injection possible. - Reported by: Corey Farrell - * [4c4e7303a8] Corey Farrell -- AST-2017-006: Fix app_minivm application - MinivmNotify command injection - - Category: Functions/func_shell - - ASTERISK-27103: core: ast_safe_system command injection possible. - Reported by: Corey Farrell - * [4c4e7303a8] Corey Farrell -- AST-2017-006: Fix app_minivm application - MinivmNotify command injection - - Category: Resources/res_monitor - - ASTERISK-27103: core: ast_safe_system command injection possible. - Reported by: Corey Farrell - * [4c4e7303a8] Corey Farrell -- AST-2017-006: Fix app_minivm application - MinivmNotify command injection - - Category: Resources/res_rtp_asterisk - - ASTERISK-27013: res_rtp_asterisk: Media can be hijacked even with strict - RTP enabled - Reported by: Joshua Colp - * [04c45758ca] Joshua Colp -- res_rtp_asterisk: Only learn a new source - in learn state. - - ---------------------------------------------------------------------- - - Diffstat Results - - [Back to Top] - - This is a summary of the changes to the source code that went into this - release that was generated using the diffstat utility. - - README-SERIOUSLY.bestpractices.txt | 7 ++ - apps/app_minivm.c | 36 +++++++++----- - apps/app_mixmonitor.c | 10 +++ - apps/app_system.c | 10 +++ - configs/minivm.conf.sample | 2 - funcs/func_shell.c | 5 + - include/asterisk/app.h | 31 +++++++++++- - main/asterisk.c | 93 +++++++++++++++++++++++++++++++------ - res/res_monitor.c | 13 +++-- - res/res_rtp_asterisk.c | 70 +++++++++++++++------------ - 10 files changed, 213 insertions(+), 64 deletions(-) diff --git a/asterisk-certified-11.6-cert18-summary.html b/asterisk-certified-11.6-cert18-summary.html new file mode 100644 index 0000000000..329203fee9 --- /dev/null +++ b/asterisk-certified-11.6-cert18-summary.html @@ -0,0 +1,16 @@ +Release Summary - asterisk-certified/11.6-cert18

Release Summary

asterisk-certified/11.6-cert18

Date: 2017-09-19

<asteriskteam@digium.com>

Table of Contents

    +
  1. Summary
    2. +
  2. Contributors
    3. +
  3. Closed Issues
    4. +
  4. Diffstat
    5. +

Summary

[Back to Top]

This release has been made to address one or more security vulnerabilities that have been identified. A security advisory document has been published for each vulnerability that includes additional information. Users of versions of Asterisk that are affected are strongly encouraged to review the advisories and determine what action they should take to protect their systems from these issues.

Security Advisories:

The data in this summary reflects changes that have been made since the previous release, asterisk-certified/11.6-cert17.

Contributors

[Back to Top]

This table lists the people who have submitted code, those that have tested patches, as well as those that reported issues on the issue tracker that were resolved in this release. For coders, the number is how many of their patches (of any size) were committed into this release. For testers, the number is the number of times their name was listed as assisting with testing a patch. Finally, for reporters, the number is the number of issues that they reported that were affected by commits that went into this release.

+ + +
CodersTestersReporters
1 Richard Mudgett
1 Richard Mudgett

Closed Issues

[Back to Top]

This is a list of all issues from the issue tracker that were closed by changes that went into this release.

Bug

Category: Resources/res_rtp_asterisk

ASTERISK-27274: RTCP needs better packet validation to resist port scans.
Reported by: Richard Mudgett
    +
  • [52d06e95b5] Richard Mudgett -- AST-2017-008: Improve RTP and RTCP packet processing.
    • +
ASTERISK-27252: RTP: One way audio with direct media and strictrtp=yes.
Reported by: Richard Mudgett
    +
  • [52d06e95b5] Richard Mudgett -- AST-2017-008: Improve RTP and RTCP packet processing.
    • +

Diffstat Results

[Back to Top]

This is a summary of the changes to the source code that went into this release that was generated using the diffstat utility.

res_rtp_asterisk.c |  481 ++++++++++++++++++++++++++++++++++++++++++++---------
+1 file changed, 401 insertions(+), 80 deletions(-)

\ No newline at end of file diff --git a/asterisk-certified-11.6-cert18-summary.txt b/asterisk-certified-11.6-cert18-summary.txt new file mode 100644 index 0000000000..c6111d9a4f --- /dev/null +++ b/asterisk-certified-11.6-cert18-summary.txt @@ -0,0 +1,88 @@ + Release Summary + + asterisk-certified/11.6-cert18 + + Date: 2017-09-19 + + + + ---------------------------------------------------------------------- + + Table of Contents + + 1. Summary + 2. Contributors + 3. Closed Issues + 4. Diffstat + + ---------------------------------------------------------------------- + + Summary + + [Back to Top] + + This release has been made to address one or more security vulnerabilities + that have been identified. A security advisory document has been published + for each vulnerability that includes additional information. Users of + versions of Asterisk that are affected are strongly encouraged to review + the advisories and determine what action they should take to protect their + systems from these issues. + + Security Advisories: + + * AST-2017-008 + + The data in this summary reflects changes that have been made since the + previous release, asterisk-certified/11.6-cert17. + + ---------------------------------------------------------------------- + + Contributors + + [Back to Top] + + This table lists the people who have submitted code, those that have + tested patches, as well as those that reported issues on the issue tracker + that were resolved in this release. For coders, the number is how many of + their patches (of any size) were committed into this release. For testers, + the number is the number of times their name was listed as assisting with + testing a patch. Finally, for reporters, the number is the number of + issues that they reported that were affected by commits that went into + this release. + + Coders Testers Reporters + 1 Richard Mudgett 1 Richard Mudgett + + ---------------------------------------------------------------------- + + Closed Issues + + [Back to Top] + + This is a list of all issues from the issue tracker that were closed by + changes that went into this release. + + Bug + + Category: Resources/res_rtp_asterisk + + ASTERISK-27274: RTCP needs better packet validation to resist port scans. + Reported by: Richard Mudgett + * [52d06e95b5] Richard Mudgett -- AST-2017-008: Improve RTP and RTCP + packet processing. + ASTERISK-27252: RTP: One way audio with direct media and strictrtp=yes. + Reported by: Richard Mudgett + * [52d06e95b5] Richard Mudgett -- AST-2017-008: Improve RTP and RTCP + packet processing. + + ---------------------------------------------------------------------- + + Diffstat Results + + [Back to Top] + + This is a summary of the changes to the source code that went into this + release that was generated using the diffstat utility. + + res_rtp_asterisk.c | 481 ++++++++++++++++++++++++++++++++++++++++++++--------- + 1 file changed, 401 insertions(+), 80 deletions(-)