From 020dce48e9ff878cf1a464a93756d152dd6eec5a Mon Sep 17 00:00:00 2001 From: Russell Bryant Date: Tue, 17 Jun 2008 15:52:36 +0000 Subject: [PATCH] Merged revisions 123272 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r123272 | russell | 2008-06-17 10:52:13 -0500 (Tue, 17 Jun 2008) | 12 lines Merged revisions 123271 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r123271 | russell | 2008-06-17 10:48:31 -0500 (Tue, 17 Jun 2008) | 4 lines Fix a memory leak in astobj2 that was pointed out by seanbright. When a container got destroyed, the underlying bucket list entry for each object that was in the container at that time did not get free'd. ........ ................ git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.0@123273 65c4cc65-6c06-0410-ace0-fbb531ad65f3 --- main/astobj2.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/main/astobj2.c b/main/astobj2.c index 8c783955b4..dd48ae924a 100644 --- a/main/astobj2.c +++ b/main/astobj2.c @@ -588,9 +588,18 @@ static int cd_cb(void *obj, void *arg, int flag) static void container_destruct(void *_c) { struct ao2_container *c = _c; + int i; ao2_callback(c, OBJ_UNLINK, cd_cb, NULL); + for (i = 0; i < c->n_buckets; i++) { + struct bucket_list *cur; + + while ((cur = AST_LIST_REMOVE_HEAD(&c->buckets[i], entry))) { + ast_free(cur); + } + } + #ifdef AO2_DEBUG ast_atomic_fetchadd_int(&ao2.total_containers, -1); #endif